167468 2017-01-26 15:09:36 -0800 Web Inspector: iOS: Memory timeline shows impossible values for Page size (underflowed) 2017-01-26 16:58:08 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck barraclough bfulgham commit-queue ggaren inspector-bugzilla-changes joepeck kling webkit-bug-importer oldest_to_newest 1270366 0 joepeck 2017-01-26 15:09:36 -0800 Summary: iOS: Memory timeline shows impossible values for Page size (underflowed) Steps to Reproduce: 1. Inspect iOS 10 device 2. Enable Memory Timeline 3. Start and stop timeline recording => Page memory values are impossible Notes: - vmPageSize() is returning 0 on iOS (sandbox violation prevents accessing sysctlbyname) 1270367 1 joepeck 2017-01-26 15:10:38 -0800 <rdar://problem/30099051> 1270369 2 joepeck 2017-01-26 15:14:07 -0800 This developer forum post seems to offer the most accurate information: https://forums.developer.apple.com/thread/47532 Namely: These should all match: - getpagesize - sysconf(_SC_PAGESIZE) - vm_page_size As: • 16 KiB on 64-bit ARM platforms • 4 KiB on everything else However, "various low-level Mach APIs (which we are using here) continue to work in terms of 4 KiB pages." You can get that value using vm_kernel_page_size. --- So this ends up matching bmalloc's vmPageSizePhysical(): > inline size_t vmPageSizePhysical() > { > #if (BPLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000) > return vm_kernel_page_size; > #else > static size_t cached; > if (!cached) > cached = sysconf(_SC_PAGESIZE); > return cached; > #endif > } 1270372 3 299862 joepeck 2017-01-26 15:16:24 -0800 Created attachment 299862 [PATCH] Proposed Fix 1270374 4 299862 kling 2017-01-26 15:19:44 -0800 Comment on attachment 299862 [PATCH] Proposed Fix r=me! 1270444 5 299862 commit-queue 2017-01-26 16:58:04 -0800 Comment on attachment 299862 [PATCH] Proposed Fix Clearing flags on attachment: 299862 Committed r211241: <http://trac.webkit.org/changeset/211241> 1270445 6 commit-queue 2017-01-26 16:58:08 -0800 All reviewed patches have been landed. Closing bug. 299862 2017-01-26 15:16:24 -0800 2017-01-26 16:58:04 -0800 [PATCH] Proposed Fix vm-page-size-1.patch text/plain 1899 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjM2QzNzU4MDVmNS4uYmU4N2QwN2JiYjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wMS0yNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGlPUzogTWVtb3J5IHRpbWVsaW5lIHNob3dz IGltcG9zc2libGUgdmFsdWVzIGZvciBQYWdlIHNpemUgKHVuZGVyZmxvd2VkKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NDY4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zMDA5OTA1MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBhZ2UvY29jb2EvUmVzb3VyY2VVc2FnZVRocmVhZENvY29hLm1t OgorICAgICAgICAoV2ViQ29yZTo6dm1QYWdlU2l6ZSk6CisgICAgICAgIFRoaXMgdmFsdWUgbWF0 Y2hlcyB0aGUgc3lzY3RsIHZhbHVlIHdlIHdlcmUgYXR0ZW1wdGluZyB0byBhY2Nlc3MsIGFuZCBp cworICAgICAgICB0aGUgbW9zdCBhcHByb3ByaWF0ZSB3aGVuIGRlYWxpbmcgd2l0aCBtYWNoIEFQ SXMsIGFzIHdlIGFyZSB1c2luZyBoZXJlLgorCiAyMDE3LTAxLTIzICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW51cCBXRUJfVElNSU5HIGNvZGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvY29jb2EvUmVzb3VyY2VVc2FnZVRocmVh ZENvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGFnZS9jb2NvYS9SZXNvdXJjZVVzYWdlVGhyZWFk Q29jb2EubW0KaW5kZXggNmFiYTA5Y2Q3MmEuLjY5MTM2YWRmNGY3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2NvY29hL1Jlc291cmNlVXNhZ2VUaHJlYWRDb2NvYS5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL2NvY29hL1Jlc291cmNlVXNhZ2VUaHJlYWRDb2NvYS5tbQpAQCAt MzQsMjEgKzM0LDE3IEBACiAjaW5jbHVkZSA8bWFjaC9tYWNoLmg+CiAjaW5jbHVkZSA8bWFjaC92 bV9zdGF0aXN0aWNzLmg+CiAjaW5jbHVkZSA8cnVudGltZS9WTS5oPgotI2luY2x1ZGUgPHN5cy9z eXNjdGwuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0aWMgc2l6ZV90IHZtUGFnZVNp emUoKQogewotICAgIHN0YXRpYyBzaXplX3QgcGFnZVNpemU7Ci0gICAgc3RhdGljIHN0ZDo6b25j ZV9mbGFnIG9uY2VGbGFnOwotICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2VGbGFnLCBbJl0gewotICAg ICAgICBzaXplX3Qgb3V0cHV0U2l6ZSA9IHNpemVvZihwYWdlU2l6ZSk7Ci0gICAgICAgIGludCBz dGF0dXMgPSBzeXNjdGxieW5hbWUoInZtLnBhZ2VzaXplIiwgJnBhZ2VTaXplLCAmb3V0cHV0U2l6 ZSwgbnVsbHB0ciwgMCk7Ci0gICAgICAgIEFTU0VSVF9VTlVTRUQoc3RhdHVzLCBzdGF0dXMgIT0g LTEpOwotICAgICAgICBBU1NFUlQocGFnZVNpemUpOwotICAgIH0pOwotICAgIHJldHVybiBwYWdl U2l6ZTsKKyNpZiBQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJ UkVEID49IDEwMDAwMAorICAgIHJldHVybiB2bV9rZXJuZWxfcGFnZV9zaXplOworI2Vsc2UKKyAg ICBzdGF0aWMgc2l6ZV90IGNhY2hlZCA9IHN5c2NvbmYoX1NDX1BBR0VTSVpFKTsKKyAgICByZXR1 cm4gY2FjaGVkOworI2VuZGlmCiB9CiAKIHZvaWQgbG9nRm9vdHByaW50Q29tcGFyaXNvbihjb25z dCBzdGQ6OmFycmF5PFRhZ0luZm8sIDI1Nj4mIGJlZm9yZSwgY29uc3Qgc3RkOjphcnJheTxUYWdJ bmZvLCAyNTY+JiBhZnRlcikK