167467 2017-01-26 14:03:06 -0800 QueueStatusServer should have an explicit timeout for _fetch_url 2017-01-30 15:23:26 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167210 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue glenn lforschler ryanhaddad oldest_to_newest 1270333 0 aakash_jain 2017-01-26 14:03:06 -0800 see rdar://problem/24792814 1270338 1 299848 aakash_jain 2017-01-26 14:08:06 -0800 Created attachment 299848 Proposed patch 1270759 2 299848 ap 2017-01-27 13:52:52 -0800 Comment on attachment 299848 Proposed patch How long does this usually take? 15 seconds sounds short generally speaking, so I'd like to understand it better. 1271393 3 aakash_jain 2017-01-30 13:43:46 -0800 In the last hang, i noticed it took about 18s (from 22:10:31 to 22:10:49). We have only one data point right now (after the last time we added more logs). I can increase this timeout to 60s or 120s, my concern is that we should have explicit timeout, in order to avoid possibility of timeout being infinite. 1271414 4 ap 2017-01-30 14:41:50 -0800 If this is just to avoid infinite timeout, would making it 5 minutes makes sense? 1271417 5 300146 aakash_jain 2017-01-30 14:50:05 -0800 Created attachment 300146 Updated patch Yes, 5 minutes makes sense. Updated the patch. 1271436 6 300146 commit-queue 2017-01-30 15:23:21 -0800 Comment on attachment 300146 Updated patch Clearing flags on attachment: 300146 Committed r211389: <http://trac.webkit.org/changeset/211389> 1271437 7 commit-queue 2017-01-30 15:23:26 -0800 All reviewed patches have been landed. Closing bug. 299848 2017-01-26 14:08:06 -0800 2017-01-30 14:50:05 -0800 Proposed patch patch_statusserver_timeout text/plain 1298 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMTIzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTAxLTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBRdWV1ZVN0YXR1c1NlcnZlciBzaG91bGQgaGF2ZSBhbiBleHBsaWNpdCB0 aW1lb3V0IGZvciBfZmV0Y2hfdXJsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjc0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2ZXIu cHk6CisgICAgICAgIChTdGF0dXNTZXJ2ZXIuX2ZldGNoX3VybCk6IEFkZCBhbiBleHBsaWNpdCB0 aW1lb3V0IG9mIDE1cy4KKwogMjAxNy0wMS0yNiAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBsZS5j b20+CiAKICAgICAgICAgTm90aWZ5IGNsaWVudHMgd2hlbiB0aGUgdXNlciBwbGF5cyBtZWRpYSBv dGhlcndpc2UgcHJldmVudGVkIGZyb20gYXV0b3BsYXlpbmcKSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2ZXIucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3N0YXR1c3NlcnZlci5weQkocmV2aXNpb24gMjEx MjMwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3N0YXR1c3NlcnZlci5w eQkod29ya2luZyBjb3B5KQpAQCAtMTY2LDcgKzE2Niw3IEBAIGNsYXNzIFN0YXR1c1NlcnZlcjoK ICAgICBkZWYgX2ZldGNoX3VybChzZWxmLCB1cmwpOgogICAgICAgICAjIEZJWE1FOiBUaGlzIHNo b3VsZCB1c2UgTmV0d29ya1RyYW5zYWN0aW9uJ3MgNDA0IGhhbmRsaW5nIGluc3RlYWQuCiAgICAg ICAgIHRyeToKLSAgICAgICAgICAgIHJldHVybiB1cmxsaWIyLnVybG9wZW4odXJsKS5yZWFkKCkK KyAgICAgICAgICAgIHJldHVybiB1cmxsaWIyLnVybG9wZW4odXJsLCB0aW1lb3V0PTE1KS5yZWFk KCkKICAgICAgICAgZXhjZXB0IHVybGxpYjIuSFRUUEVycm9yLCBlOgogICAgICAgICAgICAgaWYg ZS5jb2RlID09IDQwNDoKICAgICAgICAgICAgICAgICByZXR1cm4gTm9uZQo= 300146 2017-01-30 14:50:05 -0800 2017-01-30 15:23:21 -0800 Updated patch patch_statusserver_timeout_v2 text/plain 1300 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMTIzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTAxLTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBRdWV1ZVN0YXR1c1NlcnZlciBzaG91bGQgaGF2ZSBhbiBleHBsaWNpdCB0 aW1lb3V0IGZvciBfZmV0Y2hfdXJsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjc0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2ZXIu cHk6CisgICAgICAgIChTdGF0dXNTZXJ2ZXIuX2ZldGNoX3VybCk6IEFkZCBhbiBleHBsaWNpdCB0 aW1lb3V0IG9mIDMwMHMuCisKIDIwMTctMDEtMjYgIE1hdHQgUmFqY2EgIDxtcmFqY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIE5vdGlmeSBjbGllbnRzIHdoZW4gdGhlIHVzZXIgcGxheXMgbWVkaWEg b3RoZXJ3aXNlIHByZXZlbnRlZCBmcm9tIGF1dG9wbGF5aW5nCkluZGV4OiBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9uZXQvc3RhdHVzc2VydmVyLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2ZXIucHkJKHJldmlzaW9uIDIx MTIzMCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2ZXIu cHkJKHdvcmtpbmcgY29weSkKQEAgLTE2Niw3ICsxNjYsNyBAQCBjbGFzcyBTdGF0dXNTZXJ2ZXI6 CiAgICAgZGVmIF9mZXRjaF91cmwoc2VsZiwgdXJsKToKICAgICAgICAgIyBGSVhNRTogVGhpcyBz aG91bGQgdXNlIE5ldHdvcmtUcmFuc2FjdGlvbidzIDQwNCBoYW5kbGluZyBpbnN0ZWFkLgogICAg ICAgICB0cnk6Ci0gICAgICAgICAgICByZXR1cm4gdXJsbGliMi51cmxvcGVuKHVybCkucmVhZCgp CisgICAgICAgICAgICByZXR1cm4gdXJsbGliMi51cmxvcGVuKHVybCwgdGltZW91dD0zMDApLnJl YWQoKQogICAgICAgICBleGNlcHQgdXJsbGliMi5IVFRQRXJyb3IsIGU6CiAgICAgICAgICAgICBp ZiBlLmNvZGUgPT0gNDA0OgogICAgICAgICAgICAgICAgIHJldHVybiBOb25lCg==