167449 2017-01-25 21:58:03 -0800 Remote Inspector: Listing should be updated when a target gains or loses a debugger session 2017-01-28 16:41:10 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck achristensen commit-queue inspector-bugzilla-changes keith_miller mark.lam msaboff saam timothy webkit-bug-importer oldest_to_newest 1270139 0 joepeck 2017-01-25 21:58:03 -0800 Summary: Listing should be updated when a target gains or loses a debugger session This controls whether or not we prevent device idle behavior or not. So we should update the listing whenever a debugger session starts or ends. Steps to Reproduce: 1. Remotely inspect a page in iOS Safari 2. Wait 2 minutes => device falls asleep, expected it to stay awake. Notes: Debuggers will want to track this state so different debuggers don't try to debug a target already being debugged. 1270140 1 299793 joepeck 2017-01-25 22:08:02 -0800 Created attachment 299793 [PATCH] Proposed Fix 1270141 2 webkit-bug-importer 2017-01-25 22:22:14 -0800 <rdar://problem/30203156> 1270847 3 299793 mattbaker 2017-01-27 16:54:50 -0800 Comment on attachment 299793 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:622 > + auto target = m_targetMap.get(targetIdentifier); I think we're preferring the more explicit auto* and auto& for pointer and reference types (per recent discussions with Darin). 1271053 4 299793 bburg 2017-01-28 14:07:11 -0800 Comment on attachment 299793 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review r=me > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:619 > + This means caller must hold the listings lock before calling these, right? 1271067 5 299793 joepeck 2017-01-28 16:16:04 -0800 Comment on attachment 299793 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review >> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:619 >> + > > This means caller must hold the listings lock before calling these, right? Yes 1271070 6 299793 commit-queue 2017-01-28 16:41:06 -0800 Comment on attachment 299793 [PATCH] Proposed Fix Clearing flags on attachment: 299793 Committed r211344: <http://trac.webkit.org/changeset/211344> 1271071 7 commit-queue 2017-01-28 16:41:10 -0800 All reviewed patches have been landed. Closing bug. 299793 2017-01-25 22:08:02 -0800 2017-01-28 16:41:06 -0800 [PATCH] Proposed Fix listing-1.patch text/plain 4948 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk5NjgxYzUyOWQ0Li42ZDdlNjQ3NmFjZiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTctMDEtMjUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdGUgSW5zcGVj dG9yOiBMaXN0aW5nIHNob3VsZCBiZSB1cGRhdGVkIHdoZW4gYSB0YXJnZXQgZ2FpbnMgb3IgbG9z ZXMgYSBkZWJ1Z2dlciBzZXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjc0NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGluc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmg6CisgICAg ICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IubW06CisgICAgICAgIChJbnNw ZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6c2V0dXBGYWlsZWQpOgorICAgICAgICAoSW5zcGVjdG9y OjpSZW1vdGVJbnNwZWN0b3I6OnVwZGF0ZVRhcmdldExpc3RpbmcpOgorICAgICAgICAoSW5zcGVj dG9yOjpSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkU2V0dXBNZXNzYWdlKToKKyAgICAgICAgKElu c3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yOjpyZWNlaXZlZERpZENsb3NlTWVzc2FnZSk6CisgICAg ICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6cmVjZWl2ZWRDb25uZWN0aW9uRGllZE1l c3NhZ2UpOgorICAgICAgICBXaGVuZXZlciB3ZSBhZGQvcmVtb3ZlIGEgY29ubmVjdGlvbiB3ZSBz aG91bGQgdXBkYXRlIHRoZSBsaXN0aW5nIHByb3BlcnRpZXMKKyAgICAgICAgZm9yIHRoYXQgdGFy Z2V0IHRoYXQgY29ycmVzcG9uZGVkIHRvIHRoYXQgY29ubmVjdGlvbi4gSW4gdGhpcyB3YXkgZ3Jv dXAKKyAgICAgICAgdXBkYXRpbmcgYWN0aXZlIHNlc3Npb25zLCB0aGUgdGFyZ2V0LCBhbmQgcHVz aGluZyBsaXN0aW5nIHRvZ2V0aGVyLgorCiAyMDE3LTAxLTIzICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEludGxPYmplY3QgdXNlcyBKU0FycmF5Ojp0cnlD cmVhdGVVbmluaXRpYWxpemVkIGluIGFuIHVuc2FmZSB3YXkKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXgg OTNmZDFhN2Q3YzAuLjdjMjFjNmRjZGQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuaApAQCAtMTAyLDYgKzEw Miw5IEBAIHByaXZhdGU6CiAgICAgdm9pZCBwdXNoTGlzdGluZ3NOb3coKTsKICAgICB2b2lkIHB1 c2hMaXN0aW5nc1Nvb24oKTsKIAorICAgIHZvaWQgdXBkYXRlVGFyZ2V0TGlzdGluZyh1bnNpZ25l ZCB0YXJnZXRJZGVudGlmaWVyKTsKKyAgICB2b2lkIHVwZGF0ZVRhcmdldExpc3RpbmcoY29uc3Qg UmVtb3RlQ29udHJvbGxhYmxlVGFyZ2V0Jik7CisKICAgICB2b2lkIHVwZGF0ZUhhc0FjdGl2ZURl YnVnU2Vzc2lvbigpOwogICAgIHZvaWQgdXBkYXRlQ2xpZW50Q2FwYWJpbGl0aWVzKCk7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUlu c3BlY3Rvci5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90 ZUluc3BlY3Rvci5tbQppbmRleCAyMWNiMjMyZDhjNC4uMTI2ZTZjYzM0YzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5t bQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNw ZWN0b3IubW0KQEAgLTMxOSwxMSArMzE5LDExIEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpzZXR1 cEZhaWxlZCh1bnNpZ25lZCB0YXJnZXRJZGVudGlmaWVyKQogCiAgICAgbV90YXJnZXRDb25uZWN0 aW9uTWFwLnJlbW92ZSh0YXJnZXRJZGVudGlmaWVyKTsKIAotICAgIHVwZGF0ZUhhc0FjdGl2ZURl YnVnU2Vzc2lvbigpOwotCiAgICAgaWYgKHRhcmdldElkZW50aWZpZXIgPT0gbV9hdXRvbWF0aWNJ bnNwZWN0aW9uQ2FuZGlkYXRlVGFyZ2V0SWRlbnRpZmllcikKICAgICAgICAgbV9hdXRvbWF0aWNJ bnNwZWN0aW9uUGF1c2VkID0gZmFsc2U7CiAKKyAgICB1cGRhdGVIYXNBY3RpdmVEZWJ1Z1Nlc3Np b24oKTsKKyAgICB1cGRhdGVUYXJnZXRMaXN0aW5nKHRhcmdldElkZW50aWZpZXIpOwogICAgIHB1 c2hMaXN0aW5nc1Nvb24oKTsKIH0KIApAQCAtNjE1LDYgKzYxNSwyNiBAQCB2b2lkIFJlbW90ZUlu c3BlY3Rvcjo6cHVzaExpc3RpbmdzU29vbigpCiAgICAgfSk7CiB9CiAKKyNwcmFnbWEgbWFyayAt IFVwZGF0ZSBMaXN0aW5nIHdpdGggbG9jaworCit2b2lkIFJlbW90ZUluc3BlY3Rvcjo6dXBkYXRl VGFyZ2V0TGlzdGluZyh1bnNpZ25lZCB0YXJnZXRJZGVudGlmaWVyKQoreworICAgIGF1dG8gdGFy Z2V0ID0gbV90YXJnZXRNYXAuZ2V0KHRhcmdldElkZW50aWZpZXIpOworICAgIGlmICghdGFyZ2V0 KQorICAgICAgICByZXR1cm47CisKKyAgICB1cGRhdGVUYXJnZXRMaXN0aW5nKCp0YXJnZXQpOwor fQorCit2b2lkIFJlbW90ZUluc3BlY3Rvcjo6dXBkYXRlVGFyZ2V0TGlzdGluZyhjb25zdCBSZW1v dGVDb250cm9sbGFibGVUYXJnZXQmIHRhcmdldCkKK3sKKyAgICBSZXRhaW5QdHI8TlNEaWN0aW9u YXJ5PiB0YXJnZXRMaXN0aW5nID0gbGlzdGluZ0ZvclRhcmdldCh0YXJnZXQpOworICAgIGlmICgh dGFyZ2V0TGlzdGluZykKKyAgICAgICAgcmV0dXJuOworCisgICAgbV90YXJnZXRMaXN0aW5nTWFw LnNldCh0YXJnZXQudGFyZ2V0SWRlbnRpZmllcigpLCB0YXJnZXRMaXN0aW5nKTsKK30KKwogI3By YWdtYSBtYXJrIC0gQWN0aXZlIERlYnVnZ2VyIFNlc3Npb25zCiAKIHZvaWQgUmVtb3RlSW5zcGVj dG9yOjp1cGRhdGVIYXNBY3RpdmVEZWJ1Z1Nlc3Npb24oKQpAQCAtNjI5LDcgKzY0OSw2IEBAIHZv aWQgUmVtb3RlSW5zcGVjdG9yOjp1cGRhdGVIYXNBY3RpdmVEZWJ1Z1Nlc3Npb24oKQogICAgIC8v IExlZ2FjeSBpT1MgV2ViS2l0IDEgaGFkIGEgbm90aWZpY2F0aW9uLiBUaGlzIHdpbGwgbmVlZCB0 byBiZSBzbWFydGVyIHdpdGggV2ViS2l0Mi4KIH0KIAotCiAjcHJhZ21hIG1hcmsgLSBSZWNlaXZl ZCBYUEMgTWVzc2FnZXMKIAogdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkU2V0dXBNZXNz YWdlKE5TRGljdGlvbmFyeSAqdXNlckluZm8pCkBAIC02NjYsMTcgKzY4NSwxNyBAQCB2b2lkIFJl bW90ZUluc3BlY3Rvcjo6cmVjZWl2ZWRTZXR1cE1lc3NhZ2UoTlNEaWN0aW9uYXJ5ICp1c2VySW5m bykKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogICAgICAgICBtX3RhcmdldENvbm5l Y3Rpb25NYXAuc2V0KHRhcmdldElkZW50aWZpZXIsIFdURk1vdmUoY29ubmVjdGlvblRvVGFyZ2V0 KSk7Ci0gICAgICAgIHVwZGF0ZUhhc0FjdGl2ZURlYnVnU2Vzc2lvbigpOwogICAgIH0gZWxzZSBp ZiAoaXM8UmVtb3RlQXV0b21hdGlvblRhcmdldD4odGFyZ2V0KSkgewogICAgICAgICBpZiAoIWNv bm5lY3Rpb25Ub1RhcmdldC0+c2V0dXAoKSkgewogICAgICAgICAgICAgY29ubmVjdGlvblRvVGFy Z2V0LT5jbG9zZSgpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAgIG1f dGFyZ2V0Q29ubmVjdGlvbk1hcC5zZXQodGFyZ2V0SWRlbnRpZmllciwgV1RGTW92ZShjb25uZWN0 aW9uVG9UYXJnZXQpKTsKLSAgICAgICAgdXBkYXRlSGFzQWN0aXZlRGVidWdTZXNzaW9uKCk7CiAg ICAgfSBlbHNlCiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogCisgICAgdXBkYXRlSGFz QWN0aXZlRGVidWdTZXNzaW9uKCk7CisgICAgdXBkYXRlVGFyZ2V0TGlzdGluZygqdGFyZ2V0KTsK ICAgICBwdXNoTGlzdGluZ3NTb29uKCk7CiB9CiAKQEAgLTcxNiw3ICs3MzUsNyBAQCB2b2lkIFJl bW90ZUluc3BlY3Rvcjo6cmVjZWl2ZWREaWRDbG9zZU1lc3NhZ2UoTlNEaWN0aW9uYXJ5ICp1c2Vy SW5mbykKICAgICBtX3RhcmdldENvbm5lY3Rpb25NYXAucmVtb3ZlKHRhcmdldElkZW50aWZpZXIp OwogCiAgICAgdXBkYXRlSGFzQWN0aXZlRGVidWdTZXNzaW9uKCk7Ci0KKyAgICB1cGRhdGVUYXJn ZXRMaXN0aW5nKHRhcmdldElkZW50aWZpZXIpOwogICAgIHB1c2hMaXN0aW5nc1Nvb24oKTsKIH0K IApAQCAtNzkyLDEwICs4MTEsMTMgQEAgdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkQ29u bmVjdGlvbkRpZWRNZXNzYWdlKE5TRGljdGlvbmFyeSAqdXNlckluZm8pCiAgICAgICAgIHJldHVy bjsKIAogICAgIGF1dG8gY29ubmVjdGlvbiA9IGl0LT52YWx1ZTsKKyAgICB1bnNpZ25lZCB0YXJn ZXRJZGVudGlmaWVyID0gY29ubmVjdGlvbi0+dGFyZ2V0SWRlbnRpZmllcigpLnZhbHVlX29yKDAp OwogICAgIGNvbm5lY3Rpb24tPmNsb3NlKCk7CiAgICAgbV90YXJnZXRDb25uZWN0aW9uTWFwLnJl bW92ZShpdCk7CiAKICAgICB1cGRhdGVIYXNBY3RpdmVEZWJ1Z1Nlc3Npb24oKTsKKyAgICB1cGRh dGVUYXJnZXRMaXN0aW5nKHRhcmdldElkZW50aWZpZXIpOworICAgIHB1c2hMaXN0aW5nc1Nvb24o KTsKIH0KIAogdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkQXV0b21hdGljSW5zcGVjdGlv bkNvbmZpZ3VyYXRpb25NZXNzYWdlKE5TRGljdGlvbmFyeSAqdXNlckluZm8pCg==