167422 2017-01-25 09:43:11 -0800 Commit queue fails to look at real name aliases for the reviewer 2017-01-30 17:21:51 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser ap ap commit-queue glenn joepeck lforschler mcatanzaro oldest_to_newest 1269854 0 simon.fraser 2017-01-25 09:43:11 -0800 https://bugs.webkit.org/show_bug.cgi?id=167223#c6 cq failed to find "Myles Maxfield" as an alias for "Myles C. Maxfield" even though that's in contributors.json: "Myles C. Maxfield" : { "aliases" : [ "Myles Maxfield" ], 1271411 1 300143 ap 2017-01-30 14:34:50 -0800 Created attachment 300143 proposed fix 1271430 2 300143 joepeck 2017-01-30 15:11:52 -0800 Comment on attachment 300143 proposed fix r=me 1271496 3 300143 commit-queue 2017-01-30 17:21:47 -0800 Comment on attachment 300143 proposed fix Clearing flags on attachment: 300143 Committed r211397: <http://trac.webkit.org/changeset/211397> 1271497 4 commit-queue 2017-01-30 17:21:51 -0800 All reviewed patches have been landed. Closing bug. 300143 2017-01-30 14:34:50 -0800 2017-01-30 17:21:47 -0800 proposed fix AliasNames.txt text/plain 4065 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMTM4NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDE3LTAxLTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIENvbW1pdCBxdWV1ZSBmYWlscyB0byBsb29rIGF0IHJlYWwgbmFtZSBhbGlh c2VzIGZvciB0aGUgcmV2aWV3ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NzQyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9n X3VuaXR0ZXN0LnB5OgorICAgICAgICAodGVzdF9oYXNfdmFsaWRfcmV2aWV3ZXIpOiBBZGRlZCB0 ZXN0cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0 ZXJzLnB5OgorICAgICAgICAoQ29tbWl0dGVyTGlzdC5fbmFtZV90b19jb250cmlidXRvcl9tYXAp OgorICAgICAgICBNYWRlIF9uYW1lX3RvX2NvbnRyaWJ1dG9yX21hcCBpbmNsdWRlIGFsaWFzIG5h bWVzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnNfdW5pdHRlc3QucHk6CisgICAgICAgIChDb21taXR0ZXJzVGVzdC50ZXN0X2NvbnRyaWJ1dG9y c19ieV9mdXp6eV9tYXRjaCk6CisgICAgICAgIFJlbW92ZWQgc3VidGVzdHMgdGhhdCBhcmUgbm93 IG9ic29sZXRlLCBhcyB0aGVzZSBtYXRjaGVzIGFyZSBzdHJpY3QuIEl0IGlzIG5vdAorICAgICAg ICBvYnZpb3VzIGlmIGRpc3RhbmNlIGJhc2VkIGZ1enp5IG1hdGNoaW5nIGZvciBuYW1lcyBpcyB1 c2VmdWwgYXQgYWxsLCBidXQgd2UgY2FuCisgICAgICAgIGxvb2sgaW50byB0aGF0IHNvbWUgb3Ro ZXIgdGltZS4KKwogMjAxNy0wMS0zMCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBw bGUuY29tPgogCiAgICAgICAgIENvcnJlY3Qgc3BhY2luZyByZWdyZXNzaW9uIG9uIGludGVyLWVs ZW1lbnQgY29tcGxleCBwYXRoIHNoYXBpbmcgb24gc29tZSBmb250cwpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxv Z191bml0dGVzdC5weQkocmV2aXNpb24gMjExMjg5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBA IC00NzksNiArNDc5LDggQEAgY2xhc3MgQ2hhbmdlTG9nVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6 CiAgICAgICAgIHNlbGYuX2Fzc2VydF9oYXNfdmFsaWRfcmV2aWV3ZXIoIlJ1YmJlciBzdGFtcGVk IGJ5IEVyaWMgU2VpZGVsLiIsIFRydWUpCiAgICAgICAgIHNlbGYuX2Fzc2VydF9oYXNfdmFsaWRf cmV2aWV3ZXIoIlVucmV2aWV3ZWQgYnVpbGQgZml4LiIsIFRydWUpCiAgICAgICAgIHNlbGYuX2Fz c2VydF9oYXNfdmFsaWRfcmV2aWV3ZXIoIlJldmlld2VkIGJ5IEdhYm9yIFJhcGNzYW55aS4iLCBG YWxzZSkKKyAgICAgICAgc2VsZi5fYXNzZXJ0X2hhc192YWxpZF9yZXZpZXdlcigiUmV2aWV3ZWQg YnkgTXlsZXMgTWF4ZmllbGQiLCBUcnVlKQorICAgICAgICBzZWxmLl9hc3NlcnRfaGFzX3ZhbGlk X3Jldmlld2VyKCJSZXZpZXdlZCBieSBNeWxlcyBDLiBNYXhmaWVsZCIsIFRydWUpCiAKICAgICBk ZWYgdGVzdF9pc190b3VjaGVkX2ZpbGVzX3RleHRfY2xlYW4oc2VsZik6CiAgICAgICAgIHRlc3Rz ID0gWwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmln L2NvbW1pdHRlcnMucHkJKHJldmlzaW9uIDIxMTI4OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNTksOSAr MjU5LDE0IEBAIGNsYXNzIENvbW1pdHRlckxpc3Qob2JqZWN0KToKICAgICBkZWYgX25hbWVfdG9f Y29udHJpYnV0b3JfbWFwKHNlbGYpOgogICAgICAgICBpZiBub3QgbGVuKHNlbGYuX2NvbnRyaWJ1 dG9yc19ieV9uYW1lKToKICAgICAgICAgICAgIGZvciBjb250cmlidXRvciBpbiBzZWxmLl9jb250 cmlidXRvcnM6Ci0gICAgICAgICAgICAgICAgYXNzZXJ0KGNvbnRyaWJ1dG9yLmZ1bGxfbmFtZSkK LSAgICAgICAgICAgICAgICBhc3NlcnQoY29udHJpYnV0b3IuZnVsbF9uYW1lLmxvd2VyKCkgbm90 IGluIHNlbGYuX2NvbnRyaWJ1dG9yc19ieV9uYW1lKSAgIyBXZSBzaG91bGQgbmV2ZXIgaGF2ZSBk dXBsaWNhdGUgbmFtZXMuCisgICAgICAgICAgICAgICAgYXNzZXJ0IGNvbnRyaWJ1dG9yLmZ1bGxf bmFtZQorICAgICAgICAgICAgICAgIGFzc2VydCBjb250cmlidXRvci5mdWxsX25hbWUubG93ZXIo KSBub3QgaW4gc2VsZi5fY29udHJpYnV0b3JzX2J5X25hbWUgICMgV2Ugc2hvdWxkIG5ldmVyIGhh dmUgZHVwbGljYXRlIG5hbWVzLgogICAgICAgICAgICAgICAgIHNlbGYuX2NvbnRyaWJ1dG9yc19i eV9uYW1lW2NvbnRyaWJ1dG9yLmZ1bGxfbmFtZS5sb3dlcigpXSA9IGNvbnRyaWJ1dG9yCisgICAg ICAgICAgICAgICAgaWYgY29udHJpYnV0b3IuYWxpYXNlcyBpcyBOb25lOgorICAgICAgICAgICAg ICAgICAgICBjb250aW51ZQorICAgICAgICAgICAgICAgIGZvciBhbGlhcyBpbiBjb250cmlidXRv ci5hbGlhc2VzOgorICAgICAgICAgICAgICAgICAgICBhc3NlcnQgYWxpYXMubG93ZXIoKSBub3Qg aW4gc2VsZi5fY29udHJpYnV0b3JzX2J5X25hbWUKKyAgICAgICAgICAgICAgICAgICAgc2VsZi5f Y29udHJpYnV0b3JzX2J5X25hbWVbYWxpYXMubG93ZXIoKV0gPSBjb250cmlidXRvcgogICAgICAg ICByZXR1cm4gc2VsZi5fY29udHJpYnV0b3JzX2J5X25hbWUKIAogICAgIGRlZiBfZW1haWxfdG9f YWNjb3VudF9tYXAoc2VsZik6CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvY29tbWl0dGVyc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVyc191bml0dGVzdC5weQkocmV2aXNpb24g MjExMjg5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTEwOSw4ICsxMDksNyBAQCBjbGFzcyBD b21taXR0ZXJzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICAjIEJhc2ljIHRlc3Rpbmcg b2YgdGhlIGVkaXQgZGlzdGFuY2UgbWF0Y2hpbmcgLi4uCiAgICAgZGVmIHRlc3RfY29udHJpYnV0 b3JzX2J5X2Z1enp5X21hdGNoKHNlbGYpOgotICAgICAgICBzZWxmLl9hc3NlcnRfZnV6el9tYXRj aCgnR2VvZmYgR2FyZW4nLCAnR2VvZmZyZXkgR2FyZW4nLCAzKQotICAgICAgICBzZWxmLl9hc3Nl cnRfZnV6el9tYXRjaCgnS2VubmV0aCBDaHJpc3RpYW5zZW4nLCAnS2VubmV0aCBSb2hkZSBDaHJp c3RpYW5zZW4nLCA2KQorICAgICAgICBzZWxmLl9hc3NlcnRfZnV6el9tYXRjaCgnR2VvZiBHYXJl bicsICdHZW9mZnJleSBHYXJlbicsIDQpCiAgICAgICAgIHNlbGYuX2Fzc2VydF9mdXp6X21hdGNo KCdTYW0nLCAnU2FtIFdlaW5pZycsIDApCiAgICAgICAgIHNlbGYuX2Fzc2VydF9mdXp6X21hdGNo KCdtZScsIE5vbmUsIDIpCiAK