167389 2017-01-24 15:03:31 -0800 WKR should not confuse Miguel Gomez with Andres Gomez 2022-02-28 03:36:52 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC All RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro agomez bugs-noreply commit-queue glenn jonlee lforschler magomez mcatanzaro oldest_to_newest 1269573 0 mcatanzaro 2017-01-24 15:03:31 -0800 Andres's email is a substring of Miguel's, which is causing WKR to get very confused. I think we might have more scripts with this problem; if anyone knows of one, please say so. 1269574 1 299636 mcatanzaro 2017-01-24 15:06:35 -0800 Created attachment 299636 Patch 1269576 2 299636 mcatanzaro 2017-01-24 15:13:33 -0800 Comment on attachment 299636 Patch Whoops, the unit test is in the wrong place. 1269578 3 299638 mcatanzaro 2017-01-24 15:17:13 -0800 Created attachment 299638 Patch 1269629 4 299638 commit-queue 2017-01-24 16:56:27 -0800 Comment on attachment 299638 Patch Clearing flags on attachment: 299638 Committed r211123: <http://trac.webkit.org/changeset/211123> 1269630 5 commit-queue 2017-01-24 16:56:32 -0800 All reviewed patches have been landed. Closing bug. 1269735 6 ap 2017-01-24 23:16:04 -0800 Nice! 299636 2017-01-24 15:06:35 -0800 2022-02-28 03:36:52 -0800 Patch bug-167389-20170124170435.patch text/plain 3580 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMTEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGY3YThhMDQwNzgwNDQyYWI3MWMyYzc0NWVlZDEwNDhj OTA2YTU1Ni4uNzJiZjlkMzkzY2YwOWE1YjcxZmVjMGM0Yjc3NjBhZGNhMTI2YjJjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTAxLTI0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBXS1Igc2hvdWxkIG5vdCBjb25mdXNlIE1pZ3VlbCBHb21leiB3aXRoIEFu ZHJlcyBHb21legorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY3Mzg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQW5kcmVzJ3MgZW1haWwgaXMgYSBzdWJzdHJpbmcgb2YgTWlndWVsJ3MsIGNhdXNpbmcgV0tS IHRvIGNyZWRpdCBNaWd1ZWwncyBjb21taXRzIHRvCisgICAgICAgICJtQW5kcmVzIEdvbWV6Ii4g Rml4IHRoaXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3 Y29tbWl0Ym90LnB5OgorICAgICAgICAoTmV3Q29tbWl0Qm90Ll9zdW1tYXJpemVfY29tbWl0X2xv Zyk6IEJlIHN0cmljdGVyIGFib3V0IG1hdGNoaW5nIGVtYWlscy4gU1ZOIGxvZ3MgaW5jbHVkZSBh CisgICAgICAgIHNwYWNlIG9uIGVhY2ggc2lkZSBvZiB0aGUgZW1haWwgYWRkcmVzcywgc28gZXhw ZWN0IGJvdGggc3BhY2VzIHRvIGJlIHRoZXJlIGJlZm9yZQorICAgICAgICBjb25zaWRlcmluZyB0 aGUgZW1haWwgZm9yIHJlcGxhY2VtZW50LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9uZXdjb21taXRib3RfdW5pdHRlc3QucHk6IEFkZCBhIHRlc3QuCisKIDIwMTct MDEtMjQgIE1hdHQgUmFqY2EgIDxtcmFqY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFBhc3MgZG93 biB3ZWJzaXRlIGF1dG9wbGF5IHBvbGljaWVzIHRvIG1lZGlhIGVsZW1lbnRzCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weQppbmRl eCAxYWZlNjljNTFjZGIyNWI0NzllZWU1NjYxZjA1MDkxOTFhY2M0OWZiLi40MGM2MjE3ZGNlYTIy MjQ2YzQ4Nzc3NGU4YjU0MDI4MjU2NjJhYTJmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkKQEAgLTEzNCw3ICsxMzQsNyBA QCBjbGFzcyBOZXdDb21taXRCb3QoQWJzdHJhY3RRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5k bGVyKToKICAgICAgICAgICAgICAgICAgICAgY29tbWl0X2xvZyA9IGNvbW1pdF9sb2cucmVwbGFj ZSgnIDwnICsgZW1haWwgKyAnPicsICcnKQogICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAg ICAgICBmb3IgZW1haWwgaW4gY29udHJpYnV0b3IuZW1haWxzOgotICAgICAgICAgICAgICAgICAg ICBjb21taXRfbG9nID0gY29tbWl0X2xvZy5yZXBsYWNlKGVtYWlsLCBuYW1lX3dpdGhfbmljaykK KyAgICAgICAgICAgICAgICAgICAgY29tbWl0X2xvZyA9IGNvbW1pdF9sb2cucmVwbGFjZSgnICVz ICcgJSBlbWFpbCwgJyAlcyAnICUgbmFtZV93aXRoX25pY2spCiAKICAgICAgICAgbGluZXMgPSBj b21taXRfbG9nLnNwbGl0KCdcbicpWzE6LTJdICAjIElnbm9yZSBsaW5lcyB3aXRoIC0tLS0tLS0t LS0uCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9u ZXdjb21taXRib3RfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvbmV3Y29tbWl0Ym90X3VuaXR0ZXN0LnB5CmluZGV4IGYyMWU1ZDkyNzkxNDNhNjRkYzA2 ZTBjYjIzM2ZhMDNmMTllZTEzZWIuLmI0YWFiYTQ2OTFkMDZmYTcyNGIwNTc3Njg5MjlhYjRjMDVk MWI1ZGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9u ZXdjb21taXRib3RfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL25ld2NvbW1pdGJvdF91bml0dGVzdC5weQpAQCAtMTI3LDMgKzEyNywyMyBAQCBQ YXRjaCBieSBTaGVyaWZmIEJvdCA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPiBvbiAyMDEy LTExLTIyCiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0iIiIpLAogICAgICAgICAgICAgIlZzZXZvbG9kIFZsYXNv diAodnNldmlrKSByb2xsZWQgb3V0IHIxMzQ5MjcgYW5kIHIxMzQ5NDQgaW4gaHR0cHM6Ly90cmFj LndlYmtpdC5vcmcvcjEzNTQ4NyA6IgogICAgICAgICAgICAgIiBSZXZlcnRpbmcgdGhlIHJldmVy dHMgYWZ0ZXIgbWVyZ2luZy4iKQorCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoTmV3Q29tbWl0 Qm90Ll9zdW1tYXJpemVfY29tbWl0X2xvZygiIiItLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK3IyMTEwODQgfCBt YWdvbWV6QGlnYWxpYS5jb20gfCAyMDE3LTAxLTI0IDEwOjI1OjMxIC0wNjAwIChUdWUsIDI0IEph biAyMDE3KSB8IDEzIGxpbmVzCisKK1tHVEtdIERvIG5vdCBwYWludCBub24gY29tcG9zaXRlZCBj b250ZW50IGludG8gdGhlIHdpbmRvdyB3aGVuIHVzaW5nIHRoZSB0aHJlYWRlZCBjb21wb3NpdG9y CitodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MzY3CisKK1Jldmll d2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zLgorCitXaGVuIHVzaW5nIHRoZSB0aHJlYWRlZCBj b21wb3NpdG9yIHdlIG5lZWQgdG8gc2VuZCB0aGUgbm9uIGNvbXBvc2l0ZWQgY29udGVudCBmb3Ig Y29tcG9zaXRpbmcgYXMgd2VsbCwKK25vdCBwYWludGluZyBpdCBkaXJlY3RseSBpbnRvIHRoZSB3 aW5kb3cuCisKK05vIG5ldyB0ZXN0cy4KKworKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5n LmNwcDoKKyhXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50c0ludG9XaW5kb3cpOgor CistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0iIiIpLAorICAgICAgICAgICAgImh0dHBzOi8vdHJhYy53ZWJraXQu b3JnL3IyMTEwODQgYnkgTWlndWVsIEdvbWV6IChtYWdvbWV6KSBbR1RLXSBEbyBub3QgcGFpbnQg bm9uIGNvbXBvc2l0ZWQgY29udGVudCBpbnRvIHRoZSB3aW5kb3cgd2hlbiB1c2luZyB0aGUgdGhy ZWFkZWQgY29tcG9zaXRvciIKKyAgICAgICAgICAgICIgaHR0cHM6Ly93ZWJraXQub3JnL2IvMTY3 MzY3IFJldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zIChLYUwpLiIpCg== 299638 2017-01-24 15:17:13 -0800 2017-01-24 16:56:27 -0800 Patch bug-167389-20170124171513.patch text/plain 3715 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMTEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGY3YThhMDQwNzgwNDQyYWI3MWMyYzc0NWVlZDEwNDhj OTA2YTU1Ni4uNzJiZjlkMzkzY2YwOWE1YjcxZmVjMGM0Yjc3NjBhZGNhMTI2YjJjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTAxLTI0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBXS1Igc2hvdWxkIG5vdCBjb25mdXNlIE1pZ3VlbCBHb21leiB3aXRoIEFu ZHJlcyBHb21legorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY3Mzg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQW5kcmVzJ3MgZW1haWwgaXMgYSBzdWJzdHJpbmcgb2YgTWlndWVsJ3MsIGNhdXNpbmcgV0tS IHRvIGNyZWRpdCBNaWd1ZWwncyBjb21taXRzIHRvCisgICAgICAgICJtQW5kcmVzIEdvbWV6Ii4g Rml4IHRoaXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3 Y29tbWl0Ym90LnB5OgorICAgICAgICAoTmV3Q29tbWl0Qm90Ll9zdW1tYXJpemVfY29tbWl0X2xv Zyk6IEJlIHN0cmljdGVyIGFib3V0IG1hdGNoaW5nIGVtYWlscy4gU1ZOIGxvZ3MgaW5jbHVkZSBh CisgICAgICAgIHNwYWNlIG9uIGVhY2ggc2lkZSBvZiB0aGUgZW1haWwgYWRkcmVzcywgc28gZXhw ZWN0IGJvdGggc3BhY2VzIHRvIGJlIHRoZXJlIGJlZm9yZQorICAgICAgICBjb25zaWRlcmluZyB0 aGUgZW1haWwgZm9yIHJlcGxhY2VtZW50LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9uZXdjb21taXRib3RfdW5pdHRlc3QucHk6IEFkZCBhIHRlc3QuCisKIDIwMTct MDEtMjQgIE1hdHQgUmFqY2EgIDxtcmFqY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFBhc3MgZG93 biB3ZWJzaXRlIGF1dG9wbGF5IHBvbGljaWVzIHRvIG1lZGlhIGVsZW1lbnRzCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weQppbmRl eCAxYWZlNjljNTFjZGIyNWI0NzllZWU1NjYxZjA1MDkxOTFhY2M0OWZiLi40MGM2MjE3ZGNlYTIy MjQ2YzQ4Nzc3NGU4YjU0MDI4MjU2NjJhYTJmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkKQEAgLTEzNCw3ICsxMzQsNyBA QCBjbGFzcyBOZXdDb21taXRCb3QoQWJzdHJhY3RRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5k bGVyKToKICAgICAgICAgICAgICAgICAgICAgY29tbWl0X2xvZyA9IGNvbW1pdF9sb2cucmVwbGFj ZSgnIDwnICsgZW1haWwgKyAnPicsICcnKQogICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAg ICAgICBmb3IgZW1haWwgaW4gY29udHJpYnV0b3IuZW1haWxzOgotICAgICAgICAgICAgICAgICAg ICBjb21taXRfbG9nID0gY29tbWl0X2xvZy5yZXBsYWNlKGVtYWlsLCBuYW1lX3dpdGhfbmljaykK KyAgICAgICAgICAgICAgICAgICAgY29tbWl0X2xvZyA9IGNvbW1pdF9sb2cucmVwbGFjZSgnICVz ICcgJSBlbWFpbCwgJyAlcyAnICUgbmFtZV93aXRoX25pY2spCiAKICAgICAgICAgbGluZXMgPSBj b21taXRfbG9nLnNwbGl0KCdcbicpWzE6LTJdICAjIElnbm9yZSBsaW5lcyB3aXRoIC0tLS0tLS0t LS0uCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9u ZXdjb21taXRib3RfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvbmV3Y29tbWl0Ym90X3VuaXR0ZXN0LnB5CmluZGV4IGYyMWU1ZDkyNzkxNDNhNjRkYzA2 ZTBjYjIzM2ZhMDNmMTllZTEzZWIuLjdkM2EzODNjNTRlYmYxNzA0ODI5NTQwOGZjMDgzNjNkYzdj NDg4NDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9u ZXdjb21taXRib3RfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL25ld2NvbW1pdGJvdF91bml0dGVzdC5weQpAQCAtMTI3LDMgKzEyNywyNSBAQCBQ YXRjaCBieSBTaGVyaWZmIEJvdCA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPiBvbiAyMDEy LTExLTIyCiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0iIiIpLAogICAgICAgICAgICAgIlZzZXZvbG9kIFZsYXNv diAodnNldmlrKSByb2xsZWQgb3V0IHIxMzQ5MjcgYW5kIHIxMzQ5NDQgaW4gaHR0cHM6Ly90cmFj LndlYmtpdC5vcmcvcjEzNTQ4NyA6IgogICAgICAgICAgICAgIiBSZXZlcnRpbmcgdGhlIHJldmVy dHMgYWZ0ZXIgbWVyZ2luZy4iKQorCisgICAgIyBNaWd1ZWwgPG1hZ29tZXpAaWdhbGlhLmNvbT4g aXMgbm90IHRvIGJlIGNvbmZ1c2VkIHdpdGggQW5kcmVzIDxhZ29tZXpAaWdhbGlhLmNvbT4uCisg ICAgZGVmIHRlc3RfZW1haWxfc3Vic3RyaW5nX3Byb2JsZW0oc2VsZik6CisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoTmV3Q29tbWl0Qm90Ll9zdW1tYXJpemVfY29tbWl0X2xvZygiIiItLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KK3IyMTEwODQgfCBtYWdvbWV6QGlnYWxpYS5jb20gfCAyMDE3LTAxLTI0IDEwOjI1 OjMxIC0wNjAwIChUdWUsIDI0IEphbiAyMDE3KSB8IDEzIGxpbmVzCisKK1tHVEtdIERvIG5vdCBw YWludCBub24gY29tcG9zaXRlZCBjb250ZW50IGludG8gdGhlIHdpbmRvdyB3aGVuIHVzaW5nIHRo ZSB0aHJlYWRlZCBjb21wb3NpdG9yCitodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY3MzY3CisKK1Jldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zLgorCitXaGVu IHVzaW5nIHRoZSB0aHJlYWRlZCBjb21wb3NpdG9yIHdlIG5lZWQgdG8gc2VuZCB0aGUgbm9uIGNv bXBvc2l0ZWQgY29udGVudCBmb3IgY29tcG9zaXRpbmcgYXMgd2VsbCwKK25vdCBwYWludGluZyBp dCBkaXJlY3RseSBpbnRvIHRoZSB3aW5kb3cuCisKK05vIG5ldyB0ZXN0cy4KKworKiByZW5kZXJp bmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyhXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6 OnBhaW50c0ludG9XaW5kb3cpOgorCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0iIiIpLAorICAgICAgICAgICAg Imh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3IyMTEwODQgYnkgTWlndWVsIEdvbWV6IChtYWdvbWV6 KSBbR1RLXSBEbyBub3QgcGFpbnQgbm9uIGNvbXBvc2l0ZWQgY29udGVudCBpbnRvIHRoZSB3aW5k b3cgd2hlbiB1c2luZyB0aGUgdGhyZWFkZWQgY29tcG9zaXRvciIKKyAgICAgICAgICAgICIgaHR0 cHM6Ly93ZWJraXQub3JnL2IvMTY3MzY3IFJldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9z IChLYUwpLiIpCg==