167388 2017-01-24 14:56:58 -0800 WKR does not include my nick when commit-queue lands my patch 2017-01-24 20:27:12 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue glenn lforschler rniwa oldest_to_newest 1269569 0 joepeck 2017-01-24 14:56:58 -0800 Summary: WKR does not include my nick when commit-queue lands my patch If my name appears in the commit message landed by commit queue it shows as "Patch by <Full Name>". This doesn't get replaced to "<Full Name> (Nick)" as expected in summarization, because the patch_by is grabbed before nickname insertion. 1269571 1 299635 joepeck 2017-01-24 14:59:41 -0800 Created attachment 299635 [PATCH] Proposed Fix 1269706 2 299635 commit-queue 2017-01-24 20:27:08 -0800 Comment on attachment 299635 [PATCH] Proposed Fix Clearing flags on attachment: 299635 Committed r211134: <http://trac.webkit.org/changeset/211134> 1269707 3 commit-queue 2017-01-24 20:27:12 -0800 All reviewed patches have been landed. Closing bug. 299635 2017-01-24 14:59:41 -0800 2017-01-24 20:27:08 -0800 [PATCH] Proposed Fix nick-1.patch text/plain 4698 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkNDZh NWVkOTE2OC4uZmIxNmE1NmUwZGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNy0wMS0yNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdLUiBkb2VzIG5vdCBpbmNsdWRl IG15IG5pY2sgd2hlbiBjb21taXQtcXVldWUgbGFuZHMgbXkgcGF0Y2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzM4OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weToKKyAgICAgICAgKE5ld0NvbW1pdEJvdC5fc3VtbWFy aXplX2NvbW1pdF9sb2cpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9uZXdjb21taXRib3RfdW5pdHRlc3QucHk6CisgICAgICAgIFBlcmZvcm0gbmlja25hbWUgaW5z ZXJ0aW9uIGJlZm9yZSBncmFiYmluZyAiUGF0Y2ggYnkiIGRldGFpbHMuCisgICAgICAgIFRoaXMg d2F5IHdlIGNhbiBpbmNsdWRlIHRoZSBuaWNrbmFtZSB3aXRoIHRoZSBmdWxsIG5hbWUuCisKIDIw MTctMDEtMjQgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFN0 cmluZ1ZpZXcuc3BsaXQoKSBzaG91bGQgdXNlIGFuIGl0ZXJhdG9yIGRlc2lnbiBwYXR0ZXJuIGlu c3RlYWQgb2YgYWxsb2NhdGluZyBhIFZlY3RvcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkKaW5kZXggMWFmZTY5YzUxY2QuLjUz NTM1NDI1NGQ2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvbmV3Y29tbWl0Ym90LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9uZXdjb21taXRib3QucHkKQEAgLTExMywxNyArMTEzLDYgQEAgY2xhc3MgTmV3Q29tbWl0 Qm90KEFic3RyYWN0UXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcik6CiAKICAgICBAY2xh c3NtZXRob2QKICAgICBkZWYgX3N1bW1hcml6ZV9jb21taXRfbG9nKHNlbGYsIGNvbW1pdF9sb2cs IGNvbW1pdHRlcl9saXN0PUNvbW1pdHRlckxpc3QoKSk6Ci0gICAgICAgIHBhdGNoX2J5ID0gc2Vs Zi5fcGF0Y2hfYnlfcmVnZXguc2VhcmNoKGNvbW1pdF9sb2cpCi0gICAgICAgIGNvbW1pdF9sb2cg PSBzZWxmLl9wYXRjaF9ieV9yZWdleC5zdWIoJycsIGNvbW1pdF9sb2csIGNvdW50PTEpCi0KLSAg ICAgICAgcm9sbG91dCA9IHNlbGYuX3JvbGxvdXRfcmVnZXguc2VhcmNoKGNvbW1pdF9sb2cpCi0g ICAgICAgIGNvbW1pdF9sb2cgPSBzZWxmLl9yb2xsb3V0X3JlZ2V4LnN1YignJywgY29tbWl0X2xv ZywgY291bnQ9MSkKLQotICAgICAgICByZXF1ZXN0ZWRfYnkgPSBzZWxmLl9yZXF1ZXN0ZWRfYnlf cmVnZXguc2VhcmNoKGNvbW1pdF9sb2cpCi0KLSAgICAgICAgY29tbWl0X2xvZyA9IHNlbGYuX2J1 Z3ppbGxhX3VybF9yZWdleC5zdWIocidodHRwczovL3dlYmtpdC5vcmcvYi9cZzxpZD4nLCBjb21t aXRfbG9nKQotICAgICAgICBjb21taXRfbG9nID0gc2VsZi5fdHJhY191cmxfcmVnZXguc3ViKHIn aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvclxnPHJldmlzaW9uPicsIGNvbW1pdF9sb2cpCi0KICAg ICAgICAgZm9yIGNvbnRyaWJ1dG9yIGluIGNvbW1pdHRlcl9saXN0LmNvbnRyaWJ1dG9ycygpOgog ICAgICAgICAgICAgaWYgbm90IGNvbnRyaWJ1dG9yLmlyY19uaWNrbmFtZXM6CiAgICAgICAgICAg ICAgICAgY29udGludWUKQEAgLTEzNiwxMCArMTI1LDIyIEBAIGNsYXNzIE5ld0NvbW1pdEJvdChB YnN0cmFjdFF1ZXVlLCBTdGVwU2VxdWVuY2VFcnJvckhhbmRsZXIpOgogICAgICAgICAgICAgICAg IGZvciBlbWFpbCBpbiBjb250cmlidXRvci5lbWFpbHM6CiAgICAgICAgICAgICAgICAgICAgIGNv bW1pdF9sb2cgPSBjb21taXRfbG9nLnJlcGxhY2UoZW1haWwsIG5hbWVfd2l0aF9uaWNrKQogCisg ICAgICAgIHBhdGNoX2J5ID0gc2VsZi5fcGF0Y2hfYnlfcmVnZXguc2VhcmNoKGNvbW1pdF9sb2cp CisgICAgICAgIGNvbW1pdF9sb2cgPSBzZWxmLl9wYXRjaF9ieV9yZWdleC5zdWIoJycsIGNvbW1p dF9sb2csIGNvdW50PTEpCisKKyAgICAgICAgcm9sbG91dCA9IHNlbGYuX3JvbGxvdXRfcmVnZXgu c2VhcmNoKGNvbW1pdF9sb2cpCisgICAgICAgIGNvbW1pdF9sb2cgPSBzZWxmLl9yb2xsb3V0X3Jl Z2V4LnN1YignJywgY29tbWl0X2xvZywgY291bnQ9MSkKKworICAgICAgICByZXF1ZXN0ZWRfYnkg PSBzZWxmLl9yZXF1ZXN0ZWRfYnlfcmVnZXguc2VhcmNoKGNvbW1pdF9sb2cpCisKKyAgICAgICAg Y29tbWl0X2xvZyA9IHNlbGYuX2J1Z3ppbGxhX3VybF9yZWdleC5zdWIocidodHRwczovL3dlYmtp dC5vcmcvYi9cZzxpZD4nLCBjb21taXRfbG9nKQorICAgICAgICBjb21taXRfbG9nID0gc2VsZi5f dHJhY191cmxfcmVnZXguc3ViKHInaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvclxnPHJldmlzaW9u PicsIGNvbW1pdF9sb2cpCisKICAgICAgICAgbGluZXMgPSBjb21taXRfbG9nLnNwbGl0KCdcbicp WzE6LTJdICAjIElnbm9yZSBsaW5lcyB3aXRoIC0tLS0tLS0tLS0uCiAKICAgICAgICAgZmlyc3Rs aW5lID0gcmUubWF0Y2gocideKD9QPHJldmlzaW9uPnJcZCspIFx8ICg/UDxlbWFpbD5bXlx8XSsp IFx8ICg/UDx0aW1lc3RhbXA+W158XSspIFx8IFteXG5dKycsIGxpbmVzWzBdKQogICAgICAgICBh c3NlcnQgZmlyc3RsaW5lCisKICAgICAgICAgYXV0aG9yID0gZmlyc3RsaW5lLmdyb3VwKCdlbWFp bCcpCiAgICAgICAgIGlmIHBhdGNoX2J5OgogICAgICAgICAgICAgYXV0aG9yID0gcGF0Y2hfYnku Z3JvdXAoJ2F1dGhvcicpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv Y29tbWFuZHMvbmV3Y29tbWl0Ym90X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdF91bml0dGVzdC5weQppbmRleCBmMjFlNWQ5Mjc5 MS4uMTZlZWJlNmVlYzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9uZXdjb21taXRib3RfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdF91bml0dGVzdC5weQpAQCAtNjcsNiArNjcs MjIgQEAgaW5zdGVhZCBvZiAiZmFsc2UiLgogICAgICAgICAgICAgImh0dHBzOi8vdHJhYy53ZWJr aXQub3JnL3IxNDAwNjYgYnkgU2ltb24gRnJhc2VyIChzbWZyKSIKICAgICAgICAgICAgICIgQWxs b3cgUGFpbnRJbmZvIHRvIGNhcnJ5IGFsbCBQYWludEJlaGF2aW9yIGZsYWdzIGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzEwNjk4MCBSZXZpZXdlZCBieSBCZXRoIERha2luIChkZXRoYmFraW4pLiIpCiAK KyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChOZXdDb21taXRCb3QuX3N1bW1hcml6ZV9jb21taXRf bG9nKCIiIi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorcjIxMTA4NSB8IGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn IHwgMjAxNy0wMS0yNCAwOTowMTo0NCAtMDgwMCAoVHVlLCAyNCBKYW4gMjAxNykgfCA5IGxpbmVz CisKK1JlbW92ZSBhbHdheXMgdHJ1ZSBvcGVuR0xNdWx0aXNhbXBsaW5nRW5hYmxlZCBzZXR0aW5n CitodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MzY0CisKK1BhdGNo IGJ5IEpvc2VwaCBQZWNvcmFybyA8cGVjb3Jhcm9AYXBwbGUuY29tPiBvbiAyMDE3LTAxLTI0CitS ZXZpZXdlZCBieSBTYW0gV2VpbmlnLgorCisqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u dGV4dEJhc2UuY3BwOgorKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OmNyZWF0 ZSk6CisqIHBhZ2UvU2V0dGluZ3MuaW46CistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0iIiIpLAorICAgICAgICAg ICAgImh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3IyMTEwODUgYnkgSm9zZXBoIFBlY29yYXJvIChK b2VQZWNrKSIKKyAgICAgICAgICAgICIgUmVtb3ZlIGFsd2F5cyB0cnVlIG9wZW5HTE11bHRpc2Ft cGxpbmdFbmFibGVkIHNldHRpbmcgaHR0cHM6Ly93ZWJraXQub3JnL2IvMTY3MzY0IFJldmlld2Vk IGJ5IFNhbSBXZWluaWcgKHdlaW5pZykuIikKKwogICAgIGRlZiB0ZXN0X3N1bW1hcml6ZV9jb21t aXRfbG9nX3JvbGxvdXQoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoTmV3Q29tbWl0 Qm90Ll9zdW1tYXJpemVfY29tbWl0X2xvZygiIiItLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIHIxNDMxMDQgfCBj b21taXQtcXVldWVAd2Via2l0Lm9yZyB8IDIwMTMtMDItMTYgMDk6MDk6MDEgLTA4MDAgKFNhdCwg MTYgRmViIDIwMTMpIHwgMjcgbGluZXMK