167386 2017-01-24 14:48:14 -0800 -0 is a valid array index and AtomicsObject should know this 2017-01-24 15:26:08 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1269562 0 fpizlo 2017-01-24 14:48:14 -0800 Patch forthcoming. 1269563 1 webkit-bug-importer 2017-01-24 14:50:23 -0800 <rdar://problem/30174692> 1269564 2 299633 fpizlo 2017-01-24 14:52:31 -0800 Created attachment 299633 the patch 1269565 3 commit-queue 2017-01-24 14:54:02 -0800 Attachment 299633 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/AtomicsObject.cpp:113: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1269572 4 299633 mark.lam 2017-01-24 15:00:37 -0800 Comment on attachment 299633 the patch r=me 1269583 5 fpizlo 2017-01-24 15:26:08 -0800 Landed in https://trac.webkit.org/changeset/211113 299633 2017-01-24 14:52:31 -0800 2017-01-24 15:00:37 -0800 the patch blah.patch text/plain 2768 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTExMTIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE3LTAxLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgLTAgaXMgYSB2YWxpZCBhcnJheSBpbmRleCBhbmQgQXRvbWljc09iamVj dCBzaG91bGQga25vdyB0aGlzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjczODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHN0cmVzcy9hdG9taWNzLW5lZy16ZXJvLmpzOiBBZGRlZC4KKwogMjAxNy0w MS0yMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MjQ3CkluZGV4OiBKU1Rlc3RzL3N0 cmVzcy9hdG9taWNzLW5lZy16ZXJvLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2F0 b21pY3MtbmVnLXplcm8uanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvYXRvbWlj cy1uZWctemVyby5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMgQEAKK3ZhciBzYWIgPSBu ZXcgU2hhcmVkQXJyYXlCdWZmZXIoNCk7Cit2YXIgYSA9IG5ldyBJbnQzMkFycmF5KHNhYik7CitB dG9taWNzLmFkZChhLCAtMCwgMSk7IC8vIFRoaXMgc2hvdWxkIG5vdCB0aHJvdy4KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjExMTExKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAx LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgLTAgaXMgYSB2 YWxpZCBhcnJheSBpbmRleCBhbmQgQXRvbWljc09iamVjdCBzaG91bGQga25vdyB0aGlzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjczODYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvQXRv bWljc09iamVjdC5jcHA6IFRoZSBidWcgdGl0bGUgcmVhbGx5IHNheXMgaXQgYWxsLgorCiAyMDE3 LTAxLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxl IHRoZSBzdG9jaGFzdGljIHNwYWNlLXRpbWUgc2NoZWR1bGVyIG9uIHRoZSBsYXJnZXIgbXVsdGlj b3JlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXRvbWljc09iamVjdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXRvbWljc09i amVjdC5jcHAJKHJldmlzaW9uIDIxMTExMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0F0b21pY3NPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDgsMTEgKzEwOCwxNiBA QCB1bnNpZ25lZCB2YWxpZGF0ZWRBY2Nlc3NJbmRleChWTSYgdm0sIEV4CiAgICAgYXV0byBzY29w ZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogICAgIEpTVmFsdWUgYWNjZXNzSW5kZXhWYWx1 ZSA9IGV4ZWMtPmFyZ3VtZW50KDEpOwogICAgIGlmIChVTkxJS0VMWSghYWNjZXNzSW5kZXhWYWx1 ZS5pc0ludDMyKCkpKSB7Ci0gICAgICAgIGFjY2Vzc0luZGV4VmFsdWUgPSBqc051bWJlcihhY2Nl c3NJbmRleFZhbHVlLnRvTnVtYmVyKGV4ZWMpKTsKKyAgICAgICAgZG91YmxlIGFjY2Vzc0luZGV4 RG91YmxlID0gYWNjZXNzSW5kZXhWYWx1ZS50b051bWJlcihleGVjKTsKICAgICAgICAgUkVUVVJO X0lGX0VYQ0VQVElPTihzY29wZSwgMCk7Ci0gICAgICAgIGlmICghYWNjZXNzSW5kZXhWYWx1ZS5p c0ludDMyKCkpIHsKLSAgICAgICAgICAgIHRocm93UmFuZ2VFcnJvcihleGVjLCBzY29wZSwgQVND SUlMaXRlcmFsKCJBY2Nlc3MgaW5kZXggaXMgbm90IGFuIGludGVnZXIuIikpOwotICAgICAgICAg ICAgcmV0dXJuIDA7CisgICAgICAgIGlmIChhY2Nlc3NJbmRleERvdWJsZSA9PSAwKQorICAgICAg ICAgICAgYWNjZXNzSW5kZXhWYWx1ZSA9IGpzTnVtYmVyKDApOworICAgICAgICBlbHNlIHsKKyAg ICAgICAgICAgIGFjY2Vzc0luZGV4VmFsdWUgPSBqc051bWJlcihhY2Nlc3NJbmRleERvdWJsZSk7 CisgICAgICAgICAgICBpZiAoIWFjY2Vzc0luZGV4VmFsdWUuaXNJbnQzMigpKSB7CisgICAgICAg ICAgICAgICAgdGhyb3dSYW5nZUVycm9yKGV4ZWMsIHNjb3BlLCBBU0NJSUxpdGVyYWwoIkFjY2Vz cyBpbmRleCBpcyBub3QgYW4gaW50ZWdlci4iKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuIDA7 CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAgICAgaW50MzJfdCBhY2Nlc3NJbmRl eCA9IGFjY2Vzc0luZGV4VmFsdWUuYXNJbnQzMigpOwo=