167385 2017-01-24 14:40:08 -0800 [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out 2017-01-25 15:44:23 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified iOS 10 RESOLVED FIXED P2 Normal --- 1 ryanhaddad webkit-unassigned ap commit-queue jer.noble mrajca oldest_to_newest 1269557 0 ryanhaddad 2017-01-24 14:40:08 -0800 [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/2891 1269558 1 ryanhaddad 2017-01-24 14:40:44 -0800 The test was added with https://trac.webkit.org/changeset/211097 1269592 2 mrajca 2017-01-24 15:47:40 -0800 The JS used timeouts in the HTML test files might just have to be increased from 100 ms. Is there a way to test this without making a commit? I don't think EWS runs API tests. 1269598 3 ryanhaddad 2017-01-24 15:52:52 -0800 (In reply to comment #2) > The JS used timeouts in the HTML test files might just have to be increased > from 100 ms. Is there a way to test this without making a commit? I don't > think EWS runs API tests. If you have a build for the simulator, you can run API tests locally with: ./Tools/Scripts/run-api-tests --verbose --ios-simulator 1269600 4 ryanhaddad 2017-01-24 15:56:02 -0800 > If you have a build for the simulator, you can run API tests locally with: > > ./Tools/Scripts/run-api-tests --verbose --ios-simulator Actually, make that: ./Tools/Scripts/run-api-tests --no-build --verbose --ios-simulator WebKit2.WebsitePoliciesAutoplayEnabled 1269736 5 ap 2017-01-24 23:21:00 -0800 This test expects "did-no-play" three times, so increasing the timeout would have quite cost. Isn't there a better way to detect the condition? Her would know for sure. 1269737 6 ap 2017-01-24 23:21:27 -0800 *Jer*! 1269841 7 jer.noble 2017-01-25 09:08:20 -0800 (In reply to comment #6) > *Jer*! Calling video.play() will now return a Promise, which will reject if playback is not allowed. Seems like the test could use that rather than waiting to see if playback doesn't start. 1269988 8 299753 mrajca 2017-01-25 15:10:29 -0800 Created attachment 299753 Patch 1270002 9 299753 commit-queue 2017-01-25 15:44:19 -0800 Comment on attachment 299753 Patch Clearing flags on attachment: 299753 Committed r211174: <http://trac.webkit.org/changeset/211174> 1270003 10 commit-queue 2017-01-25 15:44:23 -0800 All reviewed patches have been landed. Closing bug. 299753 2017-01-25 15:10:29 -0800 2017-01-25 15:44:19 -0800 Patch bug-167385-20170125150828.patch text/plain 4759 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMTIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjMxNTIwYzhiMmM3NzFkNzZjNzg5Mzc4NjY2ZjYxMGFh N2NmMzA5NC4uOTVlOGI4MmM2MjMwYzAyMmNkMTM3YzQ2YmVhMGY1YjEzZDBhNTUwYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTAxLTI1ICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAg ICBbaW9zLXNpbXVsYXRvcl0gQVBJIHRlc3QgV2ViS2l0Mi5XZWJzaXRlUG9saWNpZXNBdXRvcGxh eUVuYWJsZWQgdGltaW5nIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY3Mzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvYXV0b3BsYXktY2hlY2su aHRtbDogQXZvaWQgYXJiaXRyYXJ5IHRpbWVvdXRzIGluIGZhdm9yIG9mIHByb21pc2VzLgorICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9hdXRvcGxheS1uby1hdWRpby1jaGVj ay5odG1sOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dlYnNp dGVQb2xpY2llcy5tbToKKyAgICAgICAgKFRFU1QpOiBBbGxvdyBpbmxpbmUgKHJhdGhlciB0aGFu IGZ1bGwgc2NyZWVuKSBtZWRpYSBwbGF5YmFjayBvbiBpT1MuCisKIDIwMTctMDEtMjQgIE1hdHQg UmFqY2EgIDxtcmFqY2FAYXBwbGUuY29tPgogCiAgICAgICAgIE5vdGlmeSBjbGllbnRzIHdoZW4g dGhlIHVzZXIgcGxheXMgbWVkaWEgb3RoZXJ3aXNlIHByZXZlbnRlZCBmcm9tIGF1dG9wbGF5aW5n CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvYXV0b3BsYXkt Y2hlY2suaHRtbCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9hdXRvcGxheS1j aGVjay5odG1sCmluZGV4IDFhY2FmOWMxZjNhYzc2ODhjZjQxM2Q1YThkZGZlMmNkMGQ2NjMzZmEu LmVjYzNjODg0ZThkZThmN2Q4YjNmYzA1YTU4YTY1N2JiNGQ0YzZmMWUgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9hdXRvcGxheS1jaGVjay5odG1sCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9hdXRvcGxheS1jaGVjay5odG1sCkBA IC0yLDIxICsyLDE5IEBACiAgICAgPGhlYWQ+CiAgICAgICAgIDxzY3JpcHQ+CiAgICAgICAgICAg ICBmdW5jdGlvbiBwYWdlTG9hZGVkKCkgewotICAgICAgICAgICAgICAgIHNldFRpbWVvdXQoZnVu Y3Rpb24oKSB7CisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInZpZGVv IikucGxheSgpLnRoZW4oZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgICAgIHRyeSB7Cisg ICAgICAgICAgICAgICAgICAgICAgICB3aW5kb3cud2Via2l0Lm1lc3NhZ2VIYW5kbGVycy50ZXN0 SGFuZGxlci5wb3N0TWVzc2FnZSgiYXV0b3BsYXllZCIpOworICAgICAgICAgICAgICAgICAgICB9 IGNhdGNoKGUpIHsgfQorICAgICAgICAgICAgICAgIH0pLmNhdGNoKGZ1bmN0aW9uKCkgewogICAg ICAgICAgICAgICAgICAgICB0cnkgewogICAgICAgICAgICAgICAgICAgICAgICAgd2luZG93Lndl YmtpdC5tZXNzYWdlSGFuZGxlcnMudGVzdEhhbmRsZXIucG9zdE1lc3NhZ2UoImRpZC1ub3QtcGxh eSIpOwogICAgICAgICAgICAgICAgICAgICB9IGNhdGNoKGUpIHsgfQotICAgICAgICAgICAgICAg IH0sIDEwMCk7Ci0gICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgIGZ1bmN0aW9uIGJlZ2FuUGxh eWluZygpIHsKLSAgICAgICAgICAgICAgICB0cnkgewotICAgICAgICAgICAgICAgICAgICB3aW5k b3cud2Via2l0Lm1lc3NhZ2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0TWVzc2FnZSgiYXV0b3Bs YXllZCIpOwotICAgICAgICAgICAgICAgIH0gY2F0Y2goZSkgeyB9CisgICAgICAgICAgICAgICAg fSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIDwvc2NyaXB0PgogICAgIDwvaGVhZD4KICAgICA8 Ym9keSBvbmxvYWQ9InBhZ2VMb2FkZWQoKSI+Ci0gICAgICAgIDx2aWRlbyBpZD0idmlkZW8iIGF1 dG9wbGF5IG9ucGxheWluZz1iZWdhblBsYXlpbmcoKSBzcmM9InRlc3QubXA0IiAvPgorICAgICAg ICA8dmlkZW8gaWQ9InZpZGVvIiBwbGF5c2lubGluZSBzcmM9InRlc3QubXA0IiAvPgogICAgIDwv Ym9keT4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Mi9hdXRvcGxheS1uby1hdWRpby1jaGVjay5odG1sIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQyL2F1dG9wbGF5LW5vLWF1ZGlvLWNoZWNrLmh0bWwKaW5kZXggOTNiNzNlNWQ5 NmJjNTI2ZDY4YjY0YTgzNjI5MTZiZWQ5NWFkOWI0NS4uZGMxY2M3MzI1ZTQ5NmE3NTUxNzYwNjM3 Y2IyOTYxN2M3N2U1ZDM1YiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXQyL2F1dG9wbGF5LW5vLWF1ZGlvLWNoZWNrLmh0bWwKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXQyL2F1dG9wbGF5LW5vLWF1ZGlvLWNoZWNrLmh0bWwKQEAgLTIsMjEg KzIsMTkgQEAKICAgICA8aGVhZD4KICAgICAgICAgPHNjcmlwdD4KICAgICAgICAgICAgIGZ1bmN0 aW9uIHBhZ2VMb2FkZWQoKSB7Ci0gICAgICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigp IHsKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidmlkZW8iKS5wbGF5 KCkudGhlbihmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICAgICAgdHJ5IHsKKyAgICAgICAg ICAgICAgICAgICAgICAgIHdpbmRvdy53ZWJraXQubWVzc2FnZUhhbmRsZXJzLnRlc3RIYW5kbGVy LnBvc3RNZXNzYWdlKCJhdXRvcGxheWVkIik7CisgICAgICAgICAgICAgICAgICAgIH0gY2F0Y2go ZSkgeyB9CisgICAgICAgICAgICAgICAgfSkuY2F0Y2goZnVuY3Rpb24oKSB7CiAgICAgICAgICAg ICAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICAgICAgICAgICAgICB3aW5kb3cud2Via2l0Lm1l c3NhZ2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0TWVzc2FnZSgiZGlkLW5vdC1wbGF5Iik7CiAg ICAgICAgICAgICAgICAgICAgIH0gY2F0Y2goZSkgeyB9Ci0gICAgICAgICAgICAgICAgfSwgMTAw KTsKLSAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgZnVuY3Rpb24gYmVnYW5QbGF5aW5nKCkg ewotICAgICAgICAgICAgICAgIHRyeSB7Ci0gICAgICAgICAgICAgICAgICAgIHdpbmRvdy53ZWJr aXQubWVzc2FnZUhhbmRsZXJzLnRlc3RIYW5kbGVyLnBvc3RNZXNzYWdlKCJhdXRvcGxheWVkIik7 Ci0gICAgICAgICAgICAgICAgfSBjYXRjaChlKSB7IH0KKyAgICAgICAgICAgICAgICB9KTsKICAg ICAgICAgICAgIH0KICAgICAgICAgPC9zY3JpcHQ+CiAgICAgPC9oZWFkPgogICAgIDxib2R5IG9u bG9hZD0icGFnZUxvYWRlZCgpIj4KLSAgICAgICAgPHZpZGVvIGlkPSJ2aWRlbyIgYXV0b3BsYXkg b25wbGF5aW5nPWJlZ2FuUGxheWluZygpIHNyYz0idGVzdC13aXRob3V0LWF1ZGlvLXRyYWNrLm1w NCIgLz4KKyAgICAgICAgPHZpZGVvIGlkPSJ2aWRlbyIgcGxheXNpbmxpbmUgc3JjPSJ0ZXN0LXdp dGhvdXQtYXVkaW8tdHJhY2subXA0IiAvPgogICAgIDwvYm9keT4KIDwvaHRtbD4KZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dlYnNpdGVQb2xpY2ll cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dlYnNpdGVQb2xp Y2llcy5tbQppbmRleCA4YjA0Y2IxZTU4MjgxYmJlZjkwYTU5OGVjZjdhYjYzODRkZGEzYjY5Li5k NzgxMWYwYjk1ZmUyZDJjYTJlNGVhNTI1MmVlNDJiZTg4ODRjZDNiIDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9XZWJzaXRlUG9saWNpZXMubW0KKysr IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvV2Vic2l0ZVBvbGljaWVz Lm1tCkBAIC0zMyw2ICszMywxMCBAQAogI2ltcG9ydCA8V2ViS2l0L19XS1dlYnNpdGVQb2xpY2ll cy5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCisjaWYgUExBVEZPUk0oSU9TKQorI2lt cG9ydCA8V2ViS2l0L1dLV2ViVmlld0NvbmZpZ3VyYXRpb25Qcml2YXRlLmg+CisjZW5kaWYKKwog I2lmIFdLX0FQSV9FTkFCTEVECiAKIEBpbnRlcmZhY2UgV0tXZWJWaWV3ICgpCkBAIC0xNzgsNiAr MTgyLDExIEBAIEBlbmQKIFRFU1QoV2ViS2l0MiwgV2Vic2l0ZVBvbGljaWVzQXV0b3BsYXlFbmFi bGVkKQogewogICAgIGF1dG8gY29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25m aWd1cmF0aW9uIGFsbG9jXSBpbml0XSk7CisKKyNpZiBQTEFURk9STShJT1MpCisgICAgW2NvbmZp Z3VyYXRpb24gc2V0QWxsb3dzSW5saW5lTWVkaWFQbGF5YmFjazpZRVNdOworI2VuZGlmCisKICAg ICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhG cmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRp b24uZ2V0KCldKTsKIAogICAgIGF1dG8gZGVsZWdhdGUgPSBhZG9wdE5TKFtbQXV0b3BsYXlQb2xp Y2llc0RlbGVnYXRlIGFsbG9jXSBpbml0XSk7Cg==