167384 2017-01-24 14:38:37 -0800 REGRESSION(r211091): introduces a subtle bug in InferredTypeTable, huge Octane/deltablue regression (Requested by pizlo on #webkit). 2017-01-24 14:42:03 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 167344 1 commit-queue commit-queue fpizlo msaboff webkit-bug-importer oldest_to_newest 1269553 0 commit-queue 2017-01-24 14:38:37 -0800 http://trac.webkit.org/changeset/211091 broke the build: introduces a subtle bug in InferredTypeTable, huge Octane/deltablue regression (Requested by pizlo on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1269555 1 299632 commit-queue 2017-01-24 14:38:49 -0800 Created attachment 299632 ROLLOUT of r211091 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1269556 2 webkit-bug-importer 2017-01-24 14:39:34 -0800 <rdar://problem/30174408> 1269559 3 299632 commit-queue 2017-01-24 14:41:58 -0800 Comment on attachment 299632 ROLLOUT of r211091 Clearing flags on attachment: 299632 Committed r211112: <http://trac.webkit.org/changeset/211112> 1269560 4 commit-queue 2017-01-24 14:42:03 -0800 All reviewed patches have been landed. Closing bug. 299632 2017-01-24 14:38:49 -0800 2017-01-24 14:41:58 -0800 ROLLOUT of r211091 bug-167384-20170124173649.patch text/plain 4611 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZGRjN2I4YmEzMTcxMWMzNjhhOWZlYTI2YzVjMjk0ODk1ZWRmOGRhLi4xOWVhMTZlZDhkN2RmYTM1 ODM2NThhYWJlOWZiYjdhOTUwMWNhZGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMS0yNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMTA5MS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzM4NAorCisgICAg ICAgIGludHJvZHVjZXMgYSBzdWJ0bGUgYnVnIGluIEluZmVycmVkVHlwZVRhYmxlLCBodWdlCisg ICAgICAgIE9jdGFuZS9kZWx0YWJsdWUgcmVncmVzc2lvbiAoUmVxdWVzdGVkIGJ5IHBpemxvIG9u ICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAgICAiSW5m ZXJyZWRUeXBlVGFibGUgZW50cnkgbWFuaXB1bGF0aW9uIGlzIG5vdCBUT0NUT1UgcmFjZSBzYWZl IgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MzQ0 CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzIxMTA5MQorCiAyMDE3 LTAxLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxl IHRoZSBzdG9jaGFzdGljIHNwYWNlLXRpbWUgc2NoZWR1bGVyIG9uIHRoZSBsYXJnZXIgbXVsdGlj b3JlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW5mZXJyZWRU eXBlVGFibGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW5mZXJyZWRUeXBl VGFibGUuY3BwCmluZGV4IGY5YTFiOGQwY2FhNzQ2MmExODEyODVmMjUxOWQ4ZTk3YTI4NzE1YTcu Ljc4Mjc4ZThlYmY2MzY2ZTAyZjdmMDRmZGQ4MzVjZjg1ODE1OWQzOGUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0luZmVycmVkVHlwZVRhYmxlLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbmZlcnJlZFR5cGVUYWJsZS5jcHAKQEAgLTU3 LDEyICs1NywxMCBAQCB2b2lkIEluZmVycmVkVHlwZVRhYmxlOjp2aXNpdENoaWxkcmVuKEpTQ2Vs bCogY2VsbCwgU2xvdFZpc2l0b3ImIHZpc2l0b3IpCiAgICAgQ29uY3VycmVudEpTTG9ja2VyIGxv Y2tlcihpbmZlcnJlZFR5cGVUYWJsZS0+bV9sb2NrKTsKICAgICAKICAgICBmb3IgKGF1dG8mIGVu dHJ5IDogaW5mZXJyZWRUeXBlVGFibGUtPm1fdGFibGUpIHsKLSAgICAgICAgYXV0byBlbnRyeVZh bHVlID0gZW50cnkudmFsdWU7Ci0KLSAgICAgICAgaWYgKCFlbnRyeVZhbHVlKQorICAgICAgICBp ZiAoIWVudHJ5LnZhbHVlKQogICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGlmIChlbnRy eVZhbHVlLT5pc1JlbGV2YW50KCkpCi0gICAgICAgICAgICB2aXNpdG9yLmFwcGVuZChlbnRyeVZh bHVlKTsKKyAgICAgICAgaWYgKGVudHJ5LnZhbHVlLT5pc1JlbGV2YW50KCkpCisgICAgICAgICAg ICB2aXNpdG9yLmFwcGVuZChlbnRyeS52YWx1ZSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAg IGVudHJ5LnZhbHVlLmNsZWFyKCk7CiAgICAgfQpAQCAtNzEsMjAgKzY5LDE2IEBAIHZvaWQgSW5m ZXJyZWRUeXBlVGFibGU6OnZpc2l0Q2hpbGRyZW4oSlNDZWxsKiBjZWxsLCBTbG90VmlzaXRvciYg dmlzaXRvcikKIEluZmVycmVkVHlwZSogSW5mZXJyZWRUeXBlVGFibGU6OmdldChjb25zdCBDb25j dXJyZW50SlNMb2NrZXImLCBVbmlxdWVkU3RyaW5nSW1wbCogdWlkKQogewogICAgIGF1dG8gaXRl ciA9IG1fdGFibGUuZmluZCh1aWQpOwotICAgIGlmIChpdGVyID09IG1fdGFibGUuZW5kKCkpCi0g ICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgYXV0byBlbnRyeVZhbHVlID0gaXRlci0+dmFs dWU7Ci0gICAgaWYgKCFlbnRyeVZhbHVlKQorICAgIGlmIChpdGVyID09IG1fdGFibGUuZW5kKCkg fHwgIWl0ZXItPnZhbHVlKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIC8vIFRha2Ug dGhpcyBvcHBvcnR1bml0eSB0byBwcnVuZSBpbnZhbGlkYXRlZCB0eXBlcy4KLSAgICBpZiAoIWVu dHJ5VmFsdWUtPmlzUmVsZXZhbnQoKSkgeworICAgIGlmICghaXRlci0+dmFsdWUtPmlzUmVsZXZh bnQoKSkgewogICAgICAgICBpdGVyLT52YWx1ZS5jbGVhcigpOwogICAgICAgICByZXR1cm4gbnVs bHB0cjsKICAgICB9CiAKLSAgICByZXR1cm4gZW50cnlWYWx1ZS5nZXQoKTsKKyAgICByZXR1cm4g aXRlci0+dmFsdWUuZ2V0KCk7CiB9CiAKIEluZmVycmVkVHlwZSogSW5mZXJyZWRUeXBlVGFibGU6 OmdldChVbmlxdWVkU3RyaW5nSW1wbCogdWlkKQpAQCAtMTA1LDE0ICs5OSwxMCBAQCBib29sIElu ZmVycmVkVHlwZVRhYmxlOjp3aWxsU3RvcmVWYWx1ZSgKICAgICAKICAgICBpZiAoYWdlID09IE9s ZFByb3BlcnR5KSB7CiAgICAgICAgIFRhYmxlVHlwZTo6aXRlcmF0b3IgaXRlciA9IG1fdGFibGUu ZmluZChwcm9wZXJ0eU5hbWUudWlkKCkpOwotICAgICAgICBpZiAoaXRlciA9PSBtX3RhYmxlLmVu ZCgpKQorICAgICAgICBpZiAoaXRlciA9PSBtX3RhYmxlLmVuZCgpIHx8ICFpdGVyLT52YWx1ZSkK ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsgLy8gQWJzZW5jZSBvbiByZXBsYWNlID0+IHRvcC4K LQotICAgICAgICBhdXRvIGVudHJ5VmFsdWUgPSBpdGVyLT52YWx1ZTsKLSAgICAgICAgaWYgKCFl bnRyeVZhbHVlKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAKLSAgICAgICAg aWYgKGVudHJ5VmFsdWUtPndpbGxTdG9yZVZhbHVlKHZtLCBwcm9wZXJ0eU5hbWUsIHZhbHVlKSkK KyAgICAgICAgaWYgKGl0ZXItPnZhbHVlLT53aWxsU3RvcmVWYWx1ZSh2bSwgcHJvcGVydHlOYW1l LCB2YWx1ZSkpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgCiAgICAgICAgIGl0 ZXItPnZhbHVlLmNsZWFyKCk7CkBAIC0xMjQsMTYgKzExNCwxNCBAQCBib29sIEluZmVycmVkVHlw ZVRhYmxlOjp3aWxsU3RvcmVWYWx1ZSgKICAgICAgICAgQ29uY3VycmVudEpTTG9ja2VyIGxvY2tl cihtX2xvY2spOwogICAgICAgICByZXN1bHQgPSBtX3RhYmxlLmFkZChwcm9wZXJ0eU5hbWUudWlk KCksIFdyaXRlQmFycmllcjxJbmZlcnJlZFR5cGU+KCkpOwogICAgIH0KLSAgICBhdXRvIGVudHJ5 VmFsdWUgPSByZXN1bHQuaXRlcmF0b3ItPnZhbHVlOwotCiAgICAgaWYgKHJlc3VsdC5pc05ld0Vu dHJ5KSB7CiAgICAgICAgIEluZmVycmVkVHlwZSogaW5mZXJyZWRUeXBlID0gSW5mZXJyZWRUeXBl OjpjcmVhdGUodm0pOwogICAgICAgICBXVEY6OnN0b3JlU3RvcmVGZW5jZSgpOwotICAgICAgICBl bnRyeVZhbHVlLnNldCh2bSwgdGhpcywgaW5mZXJyZWRUeXBlKTsKLSAgICB9IGVsc2UgaWYgKCFl bnRyeVZhbHVlKQorICAgICAgICByZXN1bHQuaXRlcmF0b3ItPnZhbHVlLnNldCh2bSwgdGhpcywg aW5mZXJyZWRUeXBlKTsKKyAgICB9IGVsc2UgaWYgKCFyZXN1bHQuaXRlcmF0b3ItPnZhbHVlKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCi0gICAgaWYgKGVudHJ5VmFsdWUtPndpbGxTdG9y ZVZhbHVlKHZtLCBwcm9wZXJ0eU5hbWUsIHZhbHVlKSkKKyAgICBpZiAocmVzdWx0Lml0ZXJhdG9y LT52YWx1ZS0+d2lsbFN0b3JlVmFsdWUodm0sIHByb3BlcnR5TmFtZSwgdmFsdWUpKQogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICAKICAgICByZXN1bHQuaXRlcmF0b3ItPnZhbHVlLmNsZWFyKCk7 CkBAIC0xNDUsMTUgKzEzMywxMCBAQCB2b2lkIEluZmVycmVkVHlwZVRhYmxlOjptYWtlVG9wKFZN JiB2bSwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgU3RvcmVkUHJvcGVydAogICAgIC8vIFRo ZSBhbGdvcml0aG0gaGVyZSByZWxpZXMgb24gdGhlIGZhY3QgdGhhdCBvbmx5IG9uZSB0aHJlYWQg bW9kaWZpZXMgdGhlIGhhc2ggbWFwLgogICAgIGlmIChhZ2UgPT0gT2xkUHJvcGVydHkpIHsKICAg ICAgICAgVGFibGVUeXBlOjppdGVyYXRvciBpdGVyID0gbV90YWJsZS5maW5kKHByb3BlcnR5TmFt ZS51aWQoKSk7Ci0gICAgICAgIGlmIChpdGVyID09IG1fdGFibGUuZW5kKCkpCisgICAgICAgIGlm IChpdGVyID09IG1fdGFibGUuZW5kKCkgfHwgIWl0ZXItPnZhbHVlKQogICAgICAgICAgICAgcmV0 dXJuOyAvLyBBYnNlbmNlIG9uIHJlcGxhY2UgPT4gdG9wLgogCi0gICAgICAgIGF1dG8gZW50cnlW YWx1ZSA9IGl0ZXItPnZhbHVlOwotCi0gICAgICAgIGlmICghZW50cnlWYWx1ZSkKLSAgICAgICAg ICAgIHJldHVybjsKLQotICAgICAgICBlbnRyeVZhbHVlLT5tYWtlVG9wKHZtLCBwcm9wZXJ0eU5h bWUpOworICAgICAgICBpdGVyLT52YWx1ZS0+bWFrZVRvcCh2bSwgcHJvcGVydHlOYW1lKTsKICAg ICAgICAgaXRlci0+dmFsdWUuY2xlYXIoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K