167381 2017-01-24 13:49:29 -0800 Work around a crash when running media/modern-media-controls/pip-support/pip-support-enabled.html 2017-01-24 18:58:01 -0800 1 1 1 Unclassified WebKit Media Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=164336 P2 Normal --- 1 graouts graouts commit-queue oldest_to_newest 1269533 0 graouts 2017-01-24 13:49:29 -0800 As found while diagnosing https://bugs.webkit.org/show_bug.cgi?id=164336, we hit the assertion in WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm timeToString() when running the tests media/modern-media-controls/pip-support/pip-support-click.html and media/modern-media-controls/pip-support/pip-support-enabled.html in succession. Exiting PiP in the first test before moving on to the next one works around the issue. 1269535 1 299627 graouts 2017-01-24 13:52:03 -0800 Created attachment 299627 Patch 1269662 2 299627 commit-queue 2017-01-24 18:57:58 -0800 Comment on attachment 299627 Patch Clearing flags on attachment: 299627 Committed r211130: <http://trac.webkit.org/changeset/211130> 1269663 3 commit-queue 2017-01-24 18:58:01 -0800 All reviewed patches have been landed. Closing bug. 299627 2017-01-24 13:52:03 -0800 2017-01-24 18:57:58 -0800 Patch bug-167381-20170124225002.patch text/plain 3353 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDg3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGI5MjIwY2QxNzYzMzg0NjFmOTgy OGZkOWQyOTcyMTljZTQ5ZWM3Ny4uNDUzNjc2MGJiZWNkOTE5MWE1MjdjOWJlYjU4ZWU0ZTA4YTlh M2U5OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTI0ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgV29yayBhcm91bmQgYSBjcmFzaCB3aGVuIHJ1 bm5pbmcgbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BpcC1zdXBwb3J0L3BpcC1zdXBwb3J0 LWVuYWJsZWQuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY3MzgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIHRlc3QgYXQgbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BpcC1zdXBwb3J0 L3BpcC1zdXBwb3J0LWVuYWJsZWQuaHRtbCB3b3VsZCBjcmFzaCBiZWNhdXNlIHRoZSB0ZXN0IHRo YXQKKyAgICAgICAgcHJlY2VkZWQgaXQsIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9waXAt c3VwcG9ydC9waXAtc3VwcG9ydC1jbGljay5odG1sLCB3b3VsZCBub3QgZXhpdCB0aGUgUGlQIHBy ZXNlbnRhdGlvbiBtb2RlCisgICAgICAgIGJlZm9yZSBleGl0aW5nIHRoZSB0ZXN0LiBXZSBub3cg ZXhpdCBQaVAgYmVmb3JlIHByb2NlZWRpbmcgdG8gdGhlIG5leHQgdGVzdCB3aGljaCBhdm9pZCBo aXR0aW5nIHRoZSBhc3NlcnRpb24KKyAgICAgICAgYW5kIHRoZSBjcmFzaCBpbiBEZWJ1ZyBidWls ZHMuCisKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGlwLXN1cHBvcnQv cGlwLXN1cHBvcnQtY2xpY2suaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2sxL1Rlc3RF eHBlY3RhdGlvbnM6CisKIDIwMTctMDEtMjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgYWx3YXlzIHRydWUgc3luY1hIUkluRG9jdW1lbnRz RW5hYmxlZCBzZXR0aW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVk aWEtY29udHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1cHBvcnQtY2xpY2suaHRtbCBiL0xheW91dFRl c3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9waXAtc3VwcG9ydC9waXAtc3VwcG9ydC1j bGljay5odG1sCmluZGV4IGY2OTMzOGU1OWYyZDgyNTdhMzQ0MDExNmI4Y2NlYmExMDgyYmFiMmEu LjI1OTg0NzBmNTI3YzQxYzlmOTVlZWZmZGNmZTYwOTIyYzYyOTJhMTcgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9waXAtc3VwcG9ydC9waXAtc3Vw cG9ydC1jbGljay5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250 cm9scy9waXAtc3VwcG9ydC9waXAtc3VwcG9ydC1jbGljay5odG1sCkBAIC0yNCw4ICsyNCw2IEBA IHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIAogZGVzY3JpcHRpb24oIlRlc3RpbmcgdGhl IDxjb2RlPlBpUFN1cHBvcnQ8L2NvZGU+IGJlaGF2aW9yIHdoZW4gY2xpY2tpbmcgdGhlIFBpUCBi dXR0b24uIik7CiAKLWljb25TZXJ2aWNlLmRpcmVjdG9yeVBhdGggPSAiLi4vLi4vLi4vLi4vU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvaW1hZ2VzIjsKLQogaWYg KHdpbmRvdy5pbnRlcm5hbHMpCiAgICAgd2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRBbGxv d3NQaWN0dXJlSW5QaWN0dXJlTWVkaWFQbGF5YmFjayh0cnVlKTsKIApAQCAtNDgsNiArNDYsMTEg QEAgc2NoZWR1bGVyLmZyYW1lRGlkRmlyZSA9IGZ1bmN0aW9uKCkgewogCiBtZWRpYS5hZGRFdmVu dExpc3RlbmVyKCJ3ZWJraXRwcmVzZW50YXRpb25tb2RlY2hhbmdlZCIsICgpID0+IHsKICAgICBz aG91bGRCZUVxdWFsVG9TdHJpbmcoIm1lZGlhLndlYmtpdFByZXNlbnRhdGlvbk1vZGUiLCAicGlj dHVyZS1pbi1waWN0dXJlIik7CisKKyAgICAvLyBGSVhNRTogV2UgZXhpdCBQaVAgc28gd2UgbGVh dmUgdGhpbmdzIGluIGEgY2xlYW4gc3RhdGUsIG90aGVyd2lzZSB0aGUgZm9sbG93aW5nCisgICAg Ly8gdGVzdCBwaXAtc3VwcG9ydC1lbmFibGVkLmh0bWwgbWF5IGNyYXNoLCBzZWUgd2Via2l0Lm9y Zy9iLzE2NDMzNi4KKyAgICBtZWRpYS53ZWJraXRTZXRQcmVzZW50YXRpb25Nb2RlKCJpbmxpbmUi KTsKKwogICAgIGNvbnRhaW5lci5yZW1vdmUoKTsKICAgICBtZWRpYS5yZW1vdmUoKTsKICAgICBm aW5pc2hNZWRpYUNvbnRyb2xzVGVzdCgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdr MS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDAzNThiMWVkYmRmZmZiOTkzYjhhOTc3NGY3Y2NkZTY2 NmUxNzA2ZjguLjkyYjhhZGU3MjRlNWM4N2EzOWVjYTljNzkyMjk4ZGQ5MGM2MjhmN2UgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTMwMSw4 ICszMDEsNiBAQCBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXN1cHBvcnQvdHJh Y2tzLXN1cHBvcnQtY2xpY2stdHJhY2staW4tcGFuZWwuaAogCiB3ZWJraXQub3JnL2IvMTY3MjUz IG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tYWNvcy1mdWxsc2NyZWVuLW1lZGlhLWNvbnRy b2xzL21hY29zLWZ1bGxzY3JlZW4tbWVkaWEtY29udHJvbHMtYnV0dG9ucy1jb250YWluZXJzLXN0 eWxlcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE2NDMzNiBbIFNpZXJy YSBEZWJ1ZyBdIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9waXAtc3VwcG9ydC9waXAtc3Vw cG9ydC1lbmFibGVkLmh0bWwgWyBDcmFzaCBdCi0KIHdlYmtpdC5vcmcvYi8xNjczMjAgWyBTaWVy cmEgUmVsZWFzZSBdIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9wbGFjYXJkLXN1cHBvcnQv cGxhY2FyZC1zdXBwb3J0LXBpcC5odG1sIFsgUGFzcyBDcmFzaCBdCiAKIHdlYmtpdC5vcmcvYi8x NjczNTIgWyBFbENhcGl0YW4gRGVidWcgXSBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcmV3 aW5kLWJ1dHRvbi9yZXdpbmQtYnV0dG9uLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQo=