16738 2008-01-04 23:23:26 -0800 Collector block offset could be stored as an cell offset instead of a byte offset 2008-01-05 00:26:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 hmason webkit-unassigned oldest_to_newest 66257 0 hmason 2008-01-04 23:23:26 -0800 Contrary to comments in the code to the contrary, storing the "next" field as a byte offset rather than a cell offset seems to be hurting performance. Both shark and timing tests with SunSpider show a small performance gain by switching to cell offsets. As an added bonus, using cell offsets eliminates a lot of somewhat ugly casting. 66259 1 18284 hmason 2008-01-04 23:27:15 -0800 Created attachment 18284 Cell offset usage 66260 2 18284 mjs 2008-01-04 23:28:16 -0800 Comment on attachment 18284 Cell offset usage r=me 66261 3 mjs 2008-01-04 23:36:04 -0800 Henry requests that anyone landing this patch should verify that it is a speedup since it is a little mysterious why. 66264 4 mrowe 2008-01-05 00:26:28 -0800 Landed in r29195. My testing showed this was a 0.4% speedup. 18284 2008-01-04 23:27:15 -0800 2008-01-04 23:28:16 -0800 Cell offset usage bug16738.diff text/plain 2545 hmason SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MTkzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDEtMDQgIEhlbnJ5IE1h c29uICA8aG1hc29uQG1hYy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgICAgICAgIAorICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjczOAorICAgICAgICAKKyAgICAgICAgMC4yJSBTdW5TcGlkZXIgYm9vc3QgYW5kIHBy ZXR0aWVyIGNvZGUuCisKKyAgICAgICAgKiBranMvY29sbGVjdG9yLmNwcDogU3dpdGNoZWQgdG8g Y2VsbCBvZmZzZXRzIGZyb20gYnl0ZSBvZmZzZXRzCisgICAgICAgIChLSlM6OkNvbGxlY3Rvcjo6 aGVhcEFsbG9jYXRlKToKKyAgICAgICAgKEtKUzo6Q29sbGVjdG9yOjpzd2VlcCk6CisKIDIwMDgt MDEtMDQgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgogCiAgICAgICAgIEdUSysgYXV0b3Rv b2xzIGJ1aWxkIGZpeC4gVGVybWluYXRlIGVtcHR5IHJ1bGVzLgpJbmRleDogSmF2YVNjcmlwdENv cmUva2pzL2NvbGxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL2Nv bGxlY3Rvci5jcHAJKHJldmlzaW9uIDI5MTkzKQorKysgSmF2YVNjcmlwdENvcmUva2pzL2NvbGxl Y3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4Nyw5ICsyODcsOCBAQCBjb2xsZWN0OgogICAv LyBmaW5kIGEgZnJlZSBzcG90IGluIHRoZSBibG9jayBhbmQgZGV0YWNoIGl0IGZyb20gdGhlIGZy ZWUgbGlzdAogICBDZWxsICpuZXdDZWxsID0gdGFyZ2V0QmxvY2stPmZyZWVMaXN0OwogICAKLSAg Ly8gIm5leHQiIGZpZWxkIGlzIGEgYnl0ZSBvZmZzZXQgLS0gMCBtZWFucyBuZXh0IGNlbGwsIHNv IGEgemVyb2VkIGJsb2NrIGlzIGFscmVhZHkgaW5pdGlhbGl6ZWQKLSAgLy8gY291bGQgYXZvaWQg dGhlIGNhc3RzIGJ5IHVzaW5nIGEgY2VsbCBvZmZzZXQsIGJ1dCB0aGlzIGF2b2lkcyBhIHJlbGF0 aXZlbHktc2xvdyBtdWx0aXBseQotICB0YXJnZXRCbG9jay0+ZnJlZUxpc3QgPSByZWludGVycHJl dF9jYXN0PENlbGwqPihyZWludGVycHJldF9jYXN0PGNoYXIqPihuZXdDZWxsICsgMSkgKyBuZXdD ZWxsLT51LmZyZWVDZWxsLm5leHQpOworICAvLyAibmV4dCIgZmllbGQgaXMgYSBjZWxsIG9mZnNl dCAtLSAwIG1lYW5zIG5leHQgY2VsbCwgc28gYSB6ZXJvZWQgYmxvY2sgaXMgYWxyZWFkeSBpbml0 aWFsaXplZAorICB0YXJnZXRCbG9jay0+ZnJlZUxpc3QgPSAobmV3Q2VsbCArIDEpICsgbmV3Q2Vs bC0+dS5mcmVlQ2VsbC5uZXh0OwogCiAgIHRhcmdldEJsb2NrLT51c2VkQ2VsbHMgPSBzdGF0aWNf Y2FzdDx1aW50MzJfdD4odGFyZ2V0QmxvY2tVc2VkQ2VsbHMgKyAxKTsKICAgaGVhcC5udW1MaXZl T2JqZWN0cyA9IG51bUxpdmVPYmplY3RzICsgMTsKQEAgLTg1Myw3ICs4NTIsNyBAQCB0ZW1wbGF0 ZSA8Q29sbGVjdG9yOjpIZWFwVHlwZSBoZWFwVHlwZT4gCiAgICAgICAgICAgICAgICAgICAgIAog ICAgICAgICAgICAgICAgICAgICAvLyBwdXQgY2VsbCBvbiB0aGUgZnJlZSBsaXN0CiAgICAgICAg ICAgICAgICAgICAgIGNlbGwtPnUuZnJlZUNlbGwuemVyb0lmRnJlZSA9IDA7Ci0gICAgICAgICAg ICAgICAgICAgIGNlbGwtPnUuZnJlZUNlbGwubmV4dCA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+ KGZyZWVMaXN0KSAtIHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGNlbGwgKyAxKTsKKyAgICAgICAg ICAgICAgICAgICAgY2VsbC0+dS5mcmVlQ2VsbC5uZXh0ID0gZnJlZUxpc3QgLSAoY2VsbCArIDEp OwogICAgICAgICAgICAgICAgICAgICBmcmVlTGlzdCA9IGNlbGw7CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgfQpAQCAtODc5LDcgKzg3OCw3IEBAIHRlbXBsYXRlIDxDb2xsZWN0b3I6 OkhlYXBUeXBlIGhlYXBUeXBlPiAKICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAg ICAgICAgICAgICAgICAgLy8gcHV0IGNlbGwgb24gdGhlIGZyZWUgbGlzdAogICAgICAgICAgICAg ICAgICAgICAgICAgY2VsbC0+dS5mcmVlQ2VsbC56ZXJvSWZGcmVlID0gMDsKLSAgICAgICAgICAg ICAgICAgICAgICAgIGNlbGwtPnUuZnJlZUNlbGwubmV4dCA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hh cio+KGZyZWVMaXN0KSAtIHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGNlbGwgKyAxKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgIGNlbGwtPnUuZnJlZUNlbGwubmV4dCA9IGZyZWVMaXN0IC0gKGNl bGwgKyAxKTsgCiAgICAgICAgICAgICAgICAgICAgICAgICBmcmVlTGlzdCA9IGNlbGw7CiAgICAg ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9Cg==