167368 2017-01-24 02:38:57 -0800 VS2015 supports ref qualifiers 2017-01-24 11:57:06 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen benjamin cdumez cmarcelo commit-queue dbates oldest_to_newest 1269389 0 annulen 2017-01-24 02:38:57 -0800 WTF_COMPILER_SUPPORTS_CXX_REFERENCE_QUALIFIED_FUNCTIONS should be defined for VS2015 1269390 1 299591 annulen 2017-01-24 02:41:34 -0800 Created attachment 299591 Patch 1269450 2 299591 commit-queue 2017-01-24 10:16:28 -0800 Comment on attachment 299591 Patch Clearing flags on attachment: 299591 Committed r211088: <http://trac.webkit.org/changeset/211088> 1269453 3 commit-queue 2017-01-24 10:16:33 -0800 All reviewed patches have been landed. Closing bug. 1269476 4 299591 achristensen 2017-01-24 11:54:24 -0800 Comment on attachment 299591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299591&action=review > Source/WTF/wtf/Compiler.h:124 > +#if _MSC_VER >= 1900 We don't support Visual Studio versions older than CS2015. This shouldn't be necessary. > Source/WTF/wtf/Compiler.h:130 > #if defined(_MSC_VER) && _MSC_VER < 1800 This should be updated instead. 1269478 5 299591 annulen 2017-01-24 11:57:06 -0800 Comment on attachment 299591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299591&action=review >> Source/WTF/wtf/Compiler.h:124 >> +#if _MSC_VER >= 1900 > > We don't support Visual Studio versions older than CS2015. This shouldn't be necessary. OK, I thought you may be using this file in some internal project >> Source/WTF/wtf/Compiler.h:130 >> #if defined(_MSC_VER) && _MSC_VER < 1800 > > This should be updated instead. Will do 299591 2017-01-24 02:41:34 -0800 2017-01-24 10:16:28 -0800 Patch bug-167368-20170124133934.patch text/plain 1117 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRiNjU5MmY1ZDhlMzY5M2MzNjBiYzJl ODM1NTM0Y2I0MzkyOTg3OGYuLmM0MDBiY2IyYzlhMjU5ZjljMzc4NjBlOTI3N2VlZmU3M2Y5OWJj NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDEtMjQgIEtvbnN0YW50aW4gVG9rYXJldiAg PGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIFZTMjAxNSBzdXBwb3J0cyByZWYgcXVhbGlm aWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3 MzY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvQ29tcGlsZXIuaDogRW5hYmxlCisgICAgICAgIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhf UkVGRVJFTkNFX1FVQUxJRklFRF9GVU5DVElPTlMgZm9yIFZTMjAxNQorCiAyMDE3LTAxLTIwICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG91 dGRhdGVkIEVOQUJMRShDU1BfTkVYVCkgYnVpbGQgZmxhZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dU Ri93dGYvQ29tcGlsZXIuaCBiL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKaW5kZXggNjJkZTA0 MjgxNmM3NjU4ZDI2YTkxMGZiZjNhZDQwYzMxYjUxZGQzMy4uM2MwY2Y3MjE2ZGQ1ZjA0ODU3YjA5 OGNlZTBkZmZjNGZhMDE0Y2JjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCkBAIC0xMjAsNiArMTIwLDExIEBACiAK ICNpZiBkZWZpbmVkKF9NU0NfVkVSKQogI2RlZmluZSBXVEZfQ09NUElMRVJfTVNWQyAxCisKKyNp ZiBfTVNDX1ZFUiA+PSAxOTAwCisjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfUkVG RVJFTkNFX1FVQUxJRklFRF9GVU5DVElPTlMgMQorI2VuZGlmCisKICNlbmRpZgogCiAjaWYgZGVm aW5lZChfTVNDX1ZFUikgJiYgX01TQ19WRVIgPCAxODAwCg==