167367 2017-01-24 01:59:27 -0800 [GTK] Do not paint non composited content into the window when using the threaded compositor 2017-01-24 08:39:20 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply commit-queue esprehn+autocc glenn kondapallykalyan mcatanzaro simon.fraser oldest_to_newest 1269381 0 magomez 2017-01-24 01:59:27 -0800 When using the threaded compositor we need to send the non composited content for compositing as well, not painting it directly into the window. 1269386 1 299590 magomez 2017-01-24 02:05:53 -0800 Created attachment 299590 Patch 1269392 2 299590 cgarcia 2017-01-24 02:48:33 -0800 Comment on attachment 299590 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299590&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2223 > +#if USE(COORDINATED_GRAPHICS_THREADED) > + return false; > +#endif The function already returns false when !m_owningLayer.isRootLayer(), I think we can move this #ifdef outside the if, and make it an early return of the function like if (m_usingTiledCacheLayer) 1269396 3 299594 magomez 2017-01-24 03:43:13 -0800 Created attachment 299594 Patch 1269403 4 commit-queue 2017-01-24 04:36:33 -0800 The commit-queue encountered the following flaky tests while processing attachment 299594: The commit-queue is continuing to process your patch. 1269421 5 299594 commit-queue 2017-01-24 08:26:48 -0800 Comment on attachment 299594 Patch Clearing flags on attachment: 299594 Committed r211084: <http://trac.webkit.org/changeset/211084> 1269422 6 commit-queue 2017-01-24 08:26:52 -0800 All reviewed patches have been landed. Closing bug. 1269425 7 mcatanzaro 2017-01-24 08:39:20 -0800 The indentation is wrong; too many spaces before the return. Also, the rest of the code should not be compiled at all; isn't it going to give unreachable code warnings? 299590 2017-01-24 02:05:53 -0800 2017-01-24 03:43:06 -0800 Patch bug-167367-20170124110353.patch text/plain 1568 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU2MmJkMzcyODA0YThj YWQwYzg1NmE1ODc1N2IzYTAzOTIzMjkwYi4uYTM1MjFiNWViYjE1NTE0ZjQ2MGIwMDU5ODZkYWVj MzA5MmMyZDNhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTI0ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRG8gbm90IHBh aW50IG5vbiBjb21wb3NpdGVkIGNvbnRlbnQgaW50byB0aGUgd2luZG93IHdoZW4gdXNpbmcgdGhl IHRocmVhZGVkIGNvbXBvc2l0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NzM2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gdXNpbmcgdGhlIHRocmVhZGVkIGNvbXBvc2l0b3Igd2UgbmVlZCB0 byBzZW5kIHRoZSBub24gY29tcG9zaXRlZCBjb250ZW50IGZvciBjb21wb3NpdGluZyBhcyB3ZWxs LAorICAgICAgICBub3QgcGFpbnRpbmcgaXQgZGlyZWN0bHkgaW50byB0aGUgd2luZG93LgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJh Y2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludHNJ bnRvV2luZG93KToKKwogMjAxNy0wMS0xNSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdt YWlsLmNvbT4KIAogICAgICAgICBBZGQgdGhlIHN1cHBvcnQgZm9yIG5vbW9kdWxlIGF0dHJpYnV0 ZSBvbiBzY3JpcHQgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcAppbmRleCA2MWNhYWJmNmFmYThlODcwMjY4NjFiNGZlODA5N2NjMDk2 MzUzZWU5Li5iOWJkZmNhMmEwZjczMzlhNTRlOTZkNjJiZDJhM2QxODgzNzY5NDYzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtMjIx OCw2ICsyMjE4LDkgQEAgYm9vbCBSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50c0ludG9XaW5kb3co KSBjb25zdAogCiAgICAgaWYgKG1fb3duaW5nTGF5ZXIuaXNSb290TGF5ZXIoKSkgewogI2lmIFBM QVRGT1JNKElPUykgfHwgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQorI2lmIFVTRShDT09SRElO QVRFRF9HUkFQSElDU19USFJFQURFRCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCiAg ICAgICAgIGlmIChjb21wb3NpdG9yKCkuaW5Gb3JjZWRDb21wb3NpdGluZ01vZGUoKSkKICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgo= 299594 2017-01-24 03:43:13 -0800 2017-01-24 08:26:48 -0800 Patch bug-167367-20170124124113.patch text/plain 1521 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzE3MTJiOTdmMWEwYzRk ZjE2YThhODQwYTk5NTUwN2ZkOTE5Njg1OS4uZmY0YzA5YWI3NTIxZDYzNTI2MDIwOTg0ZjVkNDFk MWNhN2YxOGMzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTI0ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRG8gbm90IHBh aW50IG5vbiBjb21wb3NpdGVkIGNvbnRlbnQgaW50byB0aGUgd2luZG93IHdoZW4gdXNpbmcgdGhl IHRocmVhZGVkIGNvbXBvc2l0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NzM2NworCisgICAgICAgIFJldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEg Q2FtcG9zLgorCisgICAgICAgIFdoZW4gdXNpbmcgdGhlIHRocmVhZGVkIGNvbXBvc2l0b3Igd2Ug bmVlZCB0byBzZW5kIHRoZSBub24gY29tcG9zaXRlZCBjb250ZW50IGZvciBjb21wb3NpdGluZyBh cyB3ZWxsLAorICAgICAgICBub3QgcGFpbnRpbmcgaXQgZGlyZWN0bHkgaW50byB0aGUgd2luZG93 LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJM YXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpw YWludHNJbnRvV2luZG93KToKKwogMjAxNy0wMS0yNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBhbHdheXMgdHJ1ZSBzeW5jWEhSSW5Eb2N1 bWVudHNFbmFibGVkIHNldHRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQmFja2luZy5jcHAKaW5kZXggNjFjYWFiZjZhZmE4ZTg3MDI2ODYxYjRmZTgwOTdjYzA5 NjM1M2VlOS4uY2QyMGQ0NDE3MDYyZjFhNWNmY2ZhZmRiMjgzMTNhN2MzZDZjNzg5NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTIy MTMsNiArMjIxMywxMCBAQCBHcmFwaGljc0xheWVyKiBSZW5kZXJMYXllckJhY2tpbmc6OmNoaWxk Rm9yU3VwZXJsYXllcnMoKSBjb25zdAogCiBib29sIFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRz SW50b1dpbmRvdygpIGNvbnN0CiB7CisjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTX1RIUkVB REVEKQorICAgICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKKwogICAgIGlmIChtX3VzaW5nVGls ZWRDYWNoZUxheWVyKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK