<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>167366</bug_id>
          
          <creation_ts>2017-01-24 01:57:45 -0800</creation_ts>
          <short_desc>Add invalid value tests to Link header handling.</short_desc>
          <delta_ts>2017-01-29 07:15:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yoav Weiss">yoav</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>rniwa</cc>
    
    <cc>yoav</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1269379</commentid>
    <comment_count>0</comment_count>
    <who name="Yoav Weiss">yoav</who>
    <bug_when>2017-01-24 01:57:45 -0800</bug_when>
    <thetext>Add invalid value tests to Link header handling.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1269380</commentid>
    <comment_count>1</comment_count>
      <attachid>299589</attachid>
    <who name="Yoav Weiss">yoav</who>
    <bug_when>2017-01-24 01:59:18 -0800</bug_when>
    <thetext>Created attachment 299589
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1269755</commentid>
    <comment_count>2</comment_count>
      <attachid>299589</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2017-01-25 00:34:56 -0800</bug_when>
    <thetext>Comment on attachment 299589
Patch

Cool
Let&apos;s also add one with &quot;as=script; as=style&quot; in the same header just to verify that we don&apos;t accidentally change behavior when there are duplicates.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1269762</commentid>
    <comment_count>3</comment_count>
    <who name="Yoav Weiss">yoav</who>
    <bug_when>2017-01-25 00:49:48 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; Comment on attachment 299589 [details]
&gt; Patch
&gt; 
&gt; Cool
&gt; Let&apos;s also add one with &quot;as=script; as=style&quot; in the same header just to
&gt; verify that we don&apos;t accidentally change behavior when there are duplicates.

Adding that test here won&apos;t really tell us which attribute is used.
In order to make that test meaningful, I want to first land https://bugs.webkit.org/show_bug.cgi?id=159678 and then duplicate the test there for headers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271123</commentid>
    <comment_count>4</comment_count>
    <who name="Yoav Weiss">yoav</who>
    <bug_when>2017-01-29 06:49:38 -0800</bug_when>
    <thetext>Added https://bugs.webkit.org/show_bug.cgi?id=167560
Landing this in the mean time</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271124</commentid>
    <comment_count>5</comment_count>
      <attachid>299589</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-01-29 07:15:06 -0800</bug_when>
    <thetext>Comment on attachment 299589
Patch

Clearing flags on attachment: 299589

Committed r211352: &lt;http://trac.webkit.org/changeset/211352&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271125</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-01-29 07:15:12 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>299589</attachid>
            <date>2017-01-24 01:59:18 -0800</date>
            <delta_ts>2017-01-29 07:15:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-167366-20170124105718.patch</filename>
            <type>text/plain</type>
            <size>4318</size>
            <attacher name="Yoav Weiss">yoav</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDc4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGJlOTZlNGEzZjYzZjhmMDlhNTg1
MjU3NTBkOTBhYjQ4MzMwMWZhMy4uMTlmZmNlZDM4ZjgzM2M1NTY3ZDkxNzBhMWM3ZDVlZDA0MmEy
ZDhhMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAxLTI0ICBZb2F2IFdlaXNzICA8eW9h
dkB5b2F2LndzPgorCisgICAgICAgIEFkZCBpbnZhbGlkIHZhbHVlIHRlc3RzIHRvIExpbmsgaGVh
ZGVyIGhhbmRsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTY3MzY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBodHRwL3Rlc3RzL3ByZWxvYWQvZG93bmxvYWRfcmVzb3VyY2VzX2Zyb21faW52YWxp
ZF9oZWFkZXJzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3ByZWxvYWQvcmVz
b3VyY2VzL2Rvd25sb2FkX3Jlc291cmNlc19mcm9tX2hlYWRlci5waHA6CisgICAgICAgICogaHR0
cC90ZXN0cy9wcmVsb2FkL3Jlc291cmNlcy9pbnZhbGlkX3Jlc291cmNlc19mcm9tX2hlYWRlci5w
aHA6CisKIDIwMTctMDEtMTUgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+
CiAKICAgICAgICAgQWRkIHRoZSBzdXBwb3J0IGZvciBub21vZHVsZSBhdHRyaWJ1dGUgb24gc2Ny
aXB0IGVsZW1lbnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJlbG9hZC9k
b3dubG9hZF9yZXNvdXJjZXNfZnJvbV9pbnZhbGlkX2hlYWRlcnMtZXhwZWN0ZWQudHh0IGIvTGF5
b3V0VGVzdHMvaHR0cC90ZXN0cy9wcmVsb2FkL2Rvd25sb2FkX3Jlc291cmNlc19mcm9tX2ludmFs
aWRfaGVhZGVycy1leHBlY3RlZC50eHQKaW5kZXggMmZlM2U4YzQwNzhmOTljOTRmOTZmOTY0YTI4
M2QyNTc1NDhmMjRiNC4uMGVhYjI3N2E5N2IzNDU4OTFhOWEwM2MwNGE2ODExMzAxNTIxZThkOSAx
MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9wcmVsb2FkL2Rvd25sb2FkX3Jlc291
cmNlc19mcm9tX2ludmFsaWRfaGVhZGVycy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv
aHR0cC90ZXN0cy9wcmVsb2FkL2Rvd25sb2FkX3Jlc291cmNlc19mcm9tX2ludmFsaWRfaGVhZGVy
cy1leHBlY3RlZC50eHQKQEAgLTEsNCArMSw1IEBACiBDT05TT0xFIE1FU1NBR0U6IFJlZnVzZWQg
dG8gbG9hZCBodHRwOi8vbG9jYWxob3N0OjgwMDAvcHJlbG9hZC9yZXNvdXJjZXMvc3F1YXJlLnBu
ZyBiZWNhdXNlIGl0IGRvZXMgbm90IGFwcGVhciBpbiB0aGUgaW1nLXNyYyBkaXJlY3RpdmUgb2Yg
dGhlIENvbnRlbnQgU2VjdXJpdHkgUG9saWN5LgorQ09OU09MRSBNRVNTQUdFOiA8bGluayByZWw9
cHJlbG9hZD4gbXVzdCBoYXZlIGEgdmFsaWQgYGFzYCB2YWx1ZQogCiAKIC0tLS0tLS0tCkBAIC0x
OSw2ICsyMCw3IEBAIFBBU1MgaW50ZXJuYWxzLmlzUHJlbG9hZGVkKCdodHRwOi8vbG9jYWxob3N0
OjgwMDAvcHJlbG9hZC9yZXNvdXJjZXMvc3F1YXJlLnBuZycpCiBQQVNTIGludGVybmFscy5pc1By
ZWxvYWRlZCgnaHR0cDovL2xvY2FsaG9zdDo1My9wcmVsb2FkL3Jlc291cmNlcy9kdW1teS5qcycp
OyBpcyB0cnVlCiBQQVNTIGludGVybmFscy5pc1ByZWxvYWRlZCgnI2Zvb2JhcicpOyBpcyBmYWxz
ZQogUEFTUyBpbnRlcm5hbHMuaXNQcmVsb2FkZWQoJy4uL3Jlc291cmNlcy9BaGVtLnR0ZicpOyBp
cyBmYWxzZQorUEFTUyBpbnRlcm5hbHMuaXNQcmVsb2FkZWQoJy4uL3Jlc291cmNlcy9kdW1teS5q
cz9pbnZhbGlkJyk7IGlzIGZhbHNlCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAK
IFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJlbG9h
ZC9yZXNvdXJjZXMvZG93bmxvYWRfcmVzb3VyY2VzX2Zyb21faGVhZGVyLnBocCBiL0xheW91dFRl
c3RzL2h0dHAvdGVzdHMvcHJlbG9hZC9yZXNvdXJjZXMvZG93bmxvYWRfcmVzb3VyY2VzX2Zyb21f
aGVhZGVyLnBocAppbmRleCAxOTE4Yjg1ZGU3YTAyMGRhMGU0MjBmMTk4NjUzODM1MmVkMTUyYzA2
Li45NTRhYzJkMTY4M2Q4YTUxMzU1ZjZkMzdkYWMxNWMwNDNmYzAzNjMzIDEwMDY0NAotLS0gYS9M
YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ByZWxvYWQvcmVzb3VyY2VzL2Rvd25sb2FkX3Jlc291cmNl
c19mcm9tX2hlYWRlci5waHAKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9wcmVsb2FkL3Jl
c291cmNlcy9kb3dubG9hZF9yZXNvdXJjZXNfZnJvbV9oZWFkZXIucGhwCkBAIC0xLDYgKzEsNiBA
QAogPD9waHAKIGhlYWRlcigiTGluazogPC4uL3Jlc291cmNlcy9kdW1teS5qcz47IHJlbD1wcmVs
b2FkOyBhcz1zY3JpcHQiLCBmYWxzZSk7Ci1oZWFkZXIoIkxpbms6PC4uL3Jlc291cmNlcy9kdW1t
eS5jc3M+OyByZWw9cHJlbG9hZDsgYXM9c3R5bGUiLCBmYWxzZSk7CitoZWFkZXIoIkxpTms6PC4u
L3Jlc291cmNlcy9kdW1teS5jc3M+OyByZWw9cHJlbG9hZDsgYXM9c3R5bGUiLCBmYWxzZSk7CiBo
ZWFkZXIoIkxpbms6IDwuLi9yZXNvdXJjZXMvc3F1YXJlLnBuZz47cmVsPXByZWxvYWQ7YXM9aW1h
Z2UiLCBmYWxzZSk7CiBoZWFkZXIoIkxpbms6IDwuLi9yZXNvdXJjZXMvQWhlbS50dGY+OyByZWw9
cHJlbG9hZDsgYXM9Zm9udDsgY3Jvc3NvcmlnaW4iLCBmYWxzZSk7CiBoZWFkZXIoIkxpbms6IDwu
Li9yZXNvdXJjZXMvdGVzdC5tcDQ+OyByZWw9cHJlbG9hZDsgYXM9bWVkaWEiLCBmYWxzZSk7CmRp
ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ByZWxvYWQvcmVzb3VyY2VzL2ludmFs
aWRfcmVzb3VyY2VzX2Zyb21faGVhZGVyLnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJl
bG9hZC9yZXNvdXJjZXMvaW52YWxpZF9yZXNvdXJjZXNfZnJvbV9oZWFkZXIucGhwCmluZGV4IDBm
ZGM3ZjdmZDNiNjNjOGEwMjk5NmY5YTA4NzhkOTg5NGIxMWI2ZTcuLmJiZjAyYzJiZDgwNDg0MDQ3
ZjhjZDAwMzNmNmVlOWE5NmYxN2Q1YmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz
dHMvcHJlbG9hZC9yZXNvdXJjZXMvaW52YWxpZF9yZXNvdXJjZXNfZnJvbV9oZWFkZXIucGhwCisr
KyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJlbG9hZC9yZXNvdXJjZXMvaW52YWxpZF9yZXNv
dXJjZXNfZnJvbV9oZWFkZXIucGhwCkBAIC0xOCw2ICsxOCw5IEBAIGhlYWRlcigiTGluazogPDsg
cmVsPXByZWxvYWQ7IGFzPXN0eWxlIiwgZmFsc2UpOwogaGVhZGVyKCJMaW5rOiA7IHJlbD1wcmVs
b2FkOyBhcz1zdHlsZSIsIGZhbHNlKTsKIGhlYWRlcigiTGluayA8Li4vcmVzb3VyY2VzL0FoZW0u
dHRmPjsgcmVsPXByZWxvYWQ7IGFzPWZvbnQ7IGNyb3Nzb3JpZ2luIiwgZmFsc2UpOwogaGVhZGVy
KCJMaW5rOiA8ICAgLi4vcmVzb3VyY2VzL2R1bW15LmpzP2Zvb2JhciA+OyByZWw9cHJlbG9hZDsg
YXM9JyIsIGZhbHNlKTsKK2hlYWRlcigiTGluazogPDwuLi9yZXNvdXJjZXMvZHVtbXkuanM/aW52
YWxpZD4+OyByZWw9cHJlbG9hZDsgYXM9c2NyaXB0IiwgZmFsc2UpOworaGVhZGVyKCJMaW5rOiA8
Li4vcmVzb3VyY2VzL2R1bW15LmpzP2ludmFsaWQ+PjsgcmVsPXByZWxvYWQ7IGFzPXNjcmlwdCIs
IGZhbHNlKTsKK2hlYWRlcigiTGluazogPDwuLi9yZXNvdXJjZXMvZHVtbXkuanM/aW52YWxpZD47
IHJlbD1wcmVsb2FkOyBhcz1zY3JpcHQiLCBmYWxzZSk7CiA/PgogPCFET0NUWVBFIGh0bWw+CiA8
c2NyaXB0IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgpAQCAt
MzksNiArNDIsNyBAQCBoZWFkZXIoIkxpbms6IDwgICAuLi9yZXNvdXJjZXMvZHVtbXkuanM/Zm9v
YmFyID47IHJlbD1wcmVsb2FkOyBhcz0nIiwgZmFsc2UpOwogICAgIHNob3VsZEJlVHJ1ZSgiaW50
ZXJuYWxzLmlzUHJlbG9hZGVkKCdodHRwOi8vbG9jYWxob3N0OjUzL3ByZWxvYWQvcmVzb3VyY2Vz
L2R1bW15LmpzJyk7Iik7CiAgICAgc2hvdWxkQmVGYWxzZSgiaW50ZXJuYWxzLmlzUHJlbG9hZGVk
KCcjZm9vYmFyJyk7Iik7CiAgICAgc2hvdWxkQmVGYWxzZSgiaW50ZXJuYWxzLmlzUHJlbG9hZGVk
KCcuLi9yZXNvdXJjZXMvQWhlbS50dGYnKTsiKTsKKyAgICBzaG91bGRCZUZhbHNlKCJpbnRlcm5h
bHMuaXNQcmVsb2FkZWQoJy4uL3Jlc291cmNlcy9kdW1teS5qcz9pbnZhbGlkJyk7Iik7CiA8L3Nj
cmlwdD4KIDxzY3JpcHQ+CiAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>