167365 2017-01-24 01:47:42 -0800 [Coordinated Graphics] Ensure that we're in AC mode before trying to create GraphicsLayers 2017-01-24 06:12:03 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cgarcia commit-queue oldest_to_newest 1269377 0 magomez 2017-01-24 01:47:42 -0800 When entering AC on demand, the RenderLayerCompositor wants to create the root GraphicsLayer before the AcceleratedDrawingArea is in AC mode. This means there's no LayerTreeHost to request the GraphicsLayerFactory, so no layers are created. 1269378 1 299588 magomez 2017-01-24 01:53:35 -0800 Created attachment 299588 Patch 1269391 2 299588 cgarcia 2017-01-24 02:45:16 -0800 Comment on attachment 299588 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299588&action=review > Source/WebKit2/ChangeLog:3 > + [GTK] Ensure that we're in AC mode before trying to create GraphicsLayers Please, update the title before landing to match the bug 1269394 3 299592 magomez 2017-01-24 03:23:52 -0800 Created attachment 299592 Patch 1269409 4 299592 commit-queue 2017-01-24 06:11:59 -0800 Comment on attachment 299592 Patch Clearing flags on attachment: 299592 Committed r211083: <http://trac.webkit.org/changeset/211083> 1269410 5 commit-queue 2017-01-24 06:12:03 -0800 All reviewed patches have been landed. Closing bug. 299588 2017-01-24 01:53:35 -0800 2017-01-24 03:23:46 -0800 Patch bug-167365-20170124105135.patch text/plain 1826 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjJjM2IwZmUzNTNlZTRi NDI3OWM5NTEwOGJkYmNjNDdjN2JlNWUyZC4uMDQ1ZTk0MzFkNzkwODA4ZGVhYjZhMjkwMThjYTIw N2Q0NGY0YWQzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTI0ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRW5zdXJlIHRo YXQgd2UncmUgaW4gQUMgbW9kZSBiZWZvcmUgdHJ5aW5nIHRvIGNyZWF0ZSBHcmFwaGljc0xheWVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MzY1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBl bnRlcmluZyBBQyBvbiBkZW1hbmQsIHRoZSBSZW5kZXJMYXllckNvbXBvc2l0b3Igd2FudHMgdG8g Y3JlYXRlIHRoZSByb290IEdyYXBoaWNzTGF5ZXIgYmVmb3JlIHRoZQorICAgICAgICBBY2NlbGVy YXRlZERyYXdpbmdBcmVhIGlzIGluIEFDIG1vZGUuIFRoaXMgbWVhbnMgdGhlcmUncyBubyBMYXll clRyZWVIb3N0IHRvIHJlcXVlc3QgdGhlIEdyYXBoaWNzTGF5ZXJGYWN0b3J5LAorICAgICAgICBz byBubyBsYXllcnMgYXJlIGNyZWF0ZWQuIEVuc3VyZSB0aGF0IHdlIGFyZSBpbiBBQyBtb2RlIGJl Zm9yZSByZXF1ZXN0aW5nIHRoZSBHcmFwaGljc0xheWVyRmFjdG9yeS4KKworICAgICAgICBObyBi ZWhhdmlvdXIgY2hhbmdlLCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YlBhZ2UvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFjY2Vs ZXJhdGVkRHJhd2luZ0FyZWE6OmdyYXBoaWNzTGF5ZXJGYWN0b3J5KToKKwogMjAxNy0wMS0yMyAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gQWRkIEFQSSB0byBXZWJLaXRXZWJzaXRlRGF0YU1hbmFnZXIgdG8gaGFuZGxlIHdlYnNpdGUg ZGF0YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0FjY2Vs ZXJhdGVkRHJhd2luZ0FyZWEuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0FjY2VsZXJhdGVkRHJhd2luZ0FyZWEuY3BwCmluZGV4IGI4NzhmYmM5ODQyZTNlYmFkNjdmNmZm OThkNzk5MGM5Y2E2MzA1ZTUuLjAyNDdjYTVhNjFiYmU4NjY1OWIwN2VjODEzNTI2ODVhYjA0ODU3 ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9BY2NlbGVy YXRlZERyYXdpbmdBcmVhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYS5jcHAKQEAgLTE3NCw2ICsxNzQsOCBAQCB2b2lkIEFj Y2VsZXJhdGVkRHJhd2luZ0FyZWE6OmxheWVySG9zdERpZEZsdXNoTGF5ZXJzKCkKIAogR3JhcGhp Y3NMYXllckZhY3RvcnkqIEFjY2VsZXJhdGVkRHJhd2luZ0FyZWE6OmdyYXBoaWNzTGF5ZXJGYWN0 b3J5KCkKIHsKKyAgICBpZiAoIW1fbGF5ZXJUcmVlSG9zdCkKKyAgICAgICAgZW50ZXJBY2NlbGVy YXRlZENvbXBvc2l0aW5nTW9kZShudWxscHRyKTsKICAgICByZXR1cm4gbV9sYXllclRyZWVIb3N0 ID8gbV9sYXllclRyZWVIb3N0LT5ncmFwaGljc0xheWVyRmFjdG9yeSgpIDogbnVsbHB0cjsKIH0K IAo= 299592 2017-01-24 03:23:52 -0800 2017-01-24 06:11:59 -0800 Patch bug-167365-20170124122153.patch text/plain 1849 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjJjM2IwZmUzNTNlZTRi NDI3OWM5NTEwOGJkYmNjNDdjN2JlNWUyZC4uMGU3YmRjZWI5ZTc3MTcwZmJhZjBkNmQwYjYxZDZl Y2JjOGQ4ODdmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTI0ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0Nvb3JkaW5hdGVkIEdy YXBoaWNzXSBFbnN1cmUgdGhhdCB3ZSdyZSBpbiBBQyBtb2RlIGJlZm9yZSB0cnlpbmcgdG8gY3Jl YXRlIEdyYXBoaWNzTGF5ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjczNjUKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENh bXBvcy4KKworICAgICAgICBXaGVuIGVudGVyaW5nIEFDIG9uIGRlbWFuZCwgdGhlIFJlbmRlckxh eWVyQ29tcG9zaXRvciB3YW50cyB0byBjcmVhdGUgdGhlIHJvb3QgR3JhcGhpY3NMYXllciBiZWZv cmUgdGhlCisgICAgICAgIEFjY2VsZXJhdGVkRHJhd2luZ0FyZWEgaXMgaW4gQUMgbW9kZS4gVGhp cyBtZWFucyB0aGVyZSdzIG5vIExheWVyVHJlZUhvc3QgdG8gcmVxdWVzdCB0aGUgR3JhcGhpY3NM YXllckZhY3RvcnksCisgICAgICAgIHNvIG5vIGxheWVycyBhcmUgY3JlYXRlZC4gRW5zdXJlIHRo YXQgd2UgYXJlIGluIEFDIG1vZGUgYmVmb3JlIHJlcXVlc3RpbmcgdGhlIEdyYXBoaWNzTGF5ZXJG YWN0b3J5LgorCisgICAgICAgIE5vIGJlaGF2aW91ciBjaGFuZ2UsIG5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVhLmNwcDoK KyAgICAgICAgKFdlYktpdDo6QWNjZWxlcmF0ZWREcmF3aW5nQXJlYTo6Z3JhcGhpY3NMYXllckZh Y3RvcnkpOgorCiAyMDE3LTAxLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgQVBJIHRvIFdlYktpdFdlYnNpdGVEYXRhTWFu YWdlciB0byBoYW5kbGUgd2Vic2l0ZSBkYXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYS5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYS5jcHAKaW5kZXgg Yjg3OGZiYzk4NDJlM2ViYWQ2N2Y2ZmY5OGQ3OTkwYzljYTYzMDVlNS4uMDI0N2NhNWE2MWJiZTg2 NjU5YjA3ZWM4MTM1MjY4NWFiMDQ4NTdlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL0FjY2VsZXJhdGVkRHJhd2luZ0FyZWEuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVhLmNwcApAQCAt MTc0LDYgKzE3NCw4IEBAIHZvaWQgQWNjZWxlcmF0ZWREcmF3aW5nQXJlYTo6bGF5ZXJIb3N0RGlk Rmx1c2hMYXllcnMoKQogCiBHcmFwaGljc0xheWVyRmFjdG9yeSogQWNjZWxlcmF0ZWREcmF3aW5n QXJlYTo6Z3JhcGhpY3NMYXllckZhY3RvcnkoKQogeworICAgIGlmICghbV9sYXllclRyZWVIb3N0 KQorICAgICAgICBlbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKG51bGxwdHIpOwogICAg IHJldHVybiBtX2xheWVyVHJlZUhvc3QgPyBtX2xheWVyVHJlZUhvc3QtPmdyYXBoaWNzTGF5ZXJG YWN0b3J5KCkgOiBudWxscHRyOwogfQogCg==