167330 2017-01-23 15:16:16 -0800 URLParser should fail to parse percent-encoded invalid UTF-8 sequences 2017-02-02 11:06:54 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen zcorpan oldest_to_newest 1269214 0 achristensen 2017-01-23 15:16:16 -0800 URLParser should fail to parse percent-encoded invalid UTF-8 sequences 1269224 1 299547 achristensen 2017-01-23 15:21:52 -0800 Created attachment 299547 Patch 1269227 2 achristensen 2017-01-23 15:28:22 -0800 http://trac.webkit.org/r211067 1269297 3 299547 darin 2017-01-23 18:00:47 -0800 Comment on attachment 299547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299547&action=review > Source/WebCore/platform/URLParser.cpp:2465 > ALWAYS_INLINE static bool containsOnlyASCII(const String& string) Why does URLParser have its own version of this function? Shouldn’t we put this into WTF? > Source/WebCore/platform/URLParser.cpp:2467 > + ASSERT(!string.isNull()); Why? 1269299 4 299547 achristensen 2017-01-23 18:03:27 -0800 Comment on attachment 299547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299547&action=review >> Source/WebCore/platform/URLParser.cpp:2465 >> ALWAYS_INLINE static bool containsOnlyASCII(const String& string) > > Why does URLParser have its own version of this function? Shouldn’t we put this into WTF? probably. >> Source/WebCore/platform/URLParser.cpp:2467 >> + ASSERT(!string.isNull()); > > Why? I just made it so that the one caller of this function can't call it with a null String. If we put this in WTF, that won't necessarily be true. 1272541 5 ap 2017-02-02 11:06:54 -0800 *** Bug 167730 has been marked as a duplicate of this bug. *** 299547 2017-01-23 15:21:52 -0800 2017-01-23 15:26:08 -0800 Patch bug-167330-20170123151955.patch text/plain 3858 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTA1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTIzICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVVJMUGFyc2Vy IHNob3VsZCBmYWlsIHRvIHBhcnNlIHBlcmNlbnQtZW5jb2RlZCBpbnZhbGlkIFVURi04IHNlcXVl bmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3 MzMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTMxOTk2Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IG5ldyBBUEkgdGVzdHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9VUkxQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Y29udGFpbnNPbmx5QVNDSUkpOgorICAgICAgICAoV2ViQ29yZTo6VVJMUGFyc2VyOjpwYXJzZUhv c3RBbmRQb3J0KToKKyAgICAgICAgSWYgVVRGLTggZGVjb2RpbmcgZmFpbHMgYWZ0ZXIgcGVyY2Vu dC1kZWNvZGluZyB0aGUgaG9zdCwgZmFpbCB0byBwYXJzZS4KKyAgICAgICAgVGhpcyBtYXRjaGVz IENocm9tZSBhbmQgRmlyZWZveCwgYW5kIGl0IHdhcyBwcm9wb3NlZCB0byB0aGUgc3BlYyBpbiBo dHRwczovL2dpdGh1Yi5jb20vd2hhdHdnL3VybC9pc3N1ZXMvMjE1CisKIDIwMTctMDEtMjMgIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNYWtl IFVSTHMgd2l0aCBub24tc3BlY2lhbCBzY2hlbWVzIGFuZCBhIHF1ZXJ5IG9yIGZyYWdtZW50IGJ1 dCBubyBzbGFzaCBhZnRlciB0aGUgaG9zdCBtb3JlIGNvbXBhdGlibGUKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkocmV2aXNpb24gMjExMDU4KQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ2NCw2ICsy NDY0LDcgQEAgVmVjdG9yPExDaGFyLCBVUkxQYXJzZXI6OmRlZmF1bHRJbmxpbmVCdQogCiBBTFdB WVNfSU5MSU5FIHN0YXRpYyBib29sIGNvbnRhaW5zT25seUFTQ0lJKGNvbnN0IFN0cmluZyYgc3Ry aW5nKQogeworICAgIEFTU0VSVCghc3RyaW5nLmlzTnVsbCgpKTsKICAgICBpZiAoc3RyaW5nLmlz OEJpdCgpKQogICAgICAgICByZXR1cm4gY2hhcmFjdGVyc0FyZUFsbEFTQ0lJKHN0cmluZy5jaGFy YWN0ZXJzOCgpLCBzdHJpbmcubGVuZ3RoKCkpOwogICAgIHJldHVybiBjaGFyYWN0ZXJzQXJlQWxs QVNDSUkoc3RyaW5nLmNoYXJhY3RlcnMxNigpLCBzdHJpbmcubGVuZ3RoKCkpOwpAQCAtMjY4MSw2 ICsyNjgyLDggQEAgYm9vbCBVUkxQYXJzZXI6OnBhcnNlSG9zdEFuZFBvcnQoQ29kZVBvaQogICAg IH0KICAgICBWZWN0b3I8TENoYXIsIGRlZmF1bHRJbmxpbmVCdWZmZXJTaXplPiBwZXJjZW50RGVj b2RlZCA9IHBlcmNlbnREZWNvZGUodXRmOEVuY29kZWQuZGF0YSgpLCB1dGY4RW5jb2RlZC5zaXpl KCksIGhvc3RCZWdpbik7CiAgICAgU3RyaW5nIGRvbWFpbiA9IFN0cmluZzo6ZnJvbVVURjgocGVy Y2VudERlY29kZWQuZGF0YSgpLCBwZXJjZW50RGVjb2RlZC5zaXplKCkpOworICAgIGlmIChkb21h aW4uaXNOdWxsKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoZG9tYWluICE9IFN0 cmluZ1ZpZXcocGVyY2VudERlY29kZWQuZGF0YSgpLCBwZXJjZW50RGVjb2RlZC5zaXplKCkpKQog ICAgICAgICBzeW50YXhWaW9sYXRpb24oaG9zdEJlZ2luKTsKICAgICBhdXRvIGFzY2lpRG9tYWlu ID0gZG9tYWluVG9BU0NJSShkb21haW4sIGhvc3RCZWdpbik7CkluZGV4OiBUb29scy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTEwNjUpCisrKyBU b29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wMS0y MyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAg IFVSTFBhcnNlciBzaG91bGQgZmFpbCB0byBwYXJzZSBwZXJjZW50LWVuY29kZWQgaW52YWxpZCBV VEYtOCBzZXF1ZW5jZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2NzMzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHA6CisgICAg ICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDE3LTAxLTIzICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSBVUkxzIHdpdGgg bm9uLXNwZWNpYWwgc2NoZW1lcyBhbmQgYSBxdWVyeSBvciBmcmFnbWVudCBidXQgbm8gc2xhc2gg YWZ0ZXIgdGhlIGhvc3QgbW9yZSBjb21wYXRpYmxlCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcAkocmV2aXNpb24gMjExMDU4KQorKysg VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTc4Nyw3ICs3ODcsMTIgQEAgVEVTVF9GKFVSTFBhcnNlclRlc3QsIFBhcnNlckRp ZmZlcmVuY2VzKQogICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImZpbGU6cEF0SC8iLAogICAgICAg ICB7ImZpbGUiLCAiIiwgIiIsICIiLCAwLCAiL3BBdEgvIiwgIiIsICIiLCAiZmlsZTovLy9wQXRI LyJ9LAogICAgICAgICB7ImZpbGUiLCAiIiwgIiIsICIiLCAwLCAicEF0SC8iLCAiIiwgIiIsICJm aWxlOi8vcEF0SC8ifSk7Ci0gICAgCisgICAgY2hlY2tVUkxEaWZmZXJlbmNlcygiaHR0cDovL2V4 YW1wbGUuY29tJUEwIiwKKyAgICAgICAgeyIiLCAiIiwgIiIsICIiLCAwLCAiIiwgIiIsICIiLCAi aHR0cDovL2V4YW1wbGUuY29tJUEwIn0sCisgICAgICAgIHsiaHR0cCIsICIiLCAiIiwgImV4YW1w bGUuY29tJWEwIiwgMCwgIi8iLCAiIiwgIiIsICJodHRwOi8vZXhhbXBsZS5jb20lYTAvIn0pOwor ICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImh0dHA6Ly8lRTIlOTglODMiLAorICAgICAgICB7Imh0 dHAiLCAiIiwgIiIsICJ4bi0tbjNoIiwgMCwgIi8iLCAiIiwgIiIsICJodHRwOi8veG4tLW4zaC8i fSwKKyAgICAgICAgeyJodHRwIiwgIiIsICIiLCAiJWUyJTk4JTgzIiwgMCwgIi8iLCAiIiwgIiIs ICJodHRwOi8vJWUyJTk4JTgzLyJ9KTsKICAgICBjaGVja1VSTERpZmZlcmVuY2VzKCJodHRwOi8v aG9zdCU3MyIsCiAgICAgICAgIHsiaHR0cCIsICIiLCAiIiwgImhvc3RzIiwgMCwgIi8iLCAiIiwg IiIsICJodHRwOi8vaG9zdHMvIn0sCiAgICAgICAgIHsiaHR0cCIsICIiLCAiIiwgImhvc3QlNzMi LCAwLCAiLyIsICIiLCAiIiwgImh0dHA6Ly9ob3N0JTczLyJ9KTsK