167316 2017-01-23 12:16:49 -0800 Web Inspector: Asserts seen opening and closing Remote Web Inspector windows 2017-01-23 13:09:22 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck ap commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1269130 0 joepeck 2017-01-23 12:16:49 -0800 Summary: Asserts seen opening and closing Remote Web Inspector windows Assert when opening: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x00000001113cde44 WTFCrash + 36 1 com.apple.JavaScriptCore 0x00000001113cde59 WTFCrashWithSecurityImplication + 9 2 com.apple.WebKit 0x0000000114abb354 WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle(WebCore::URL const&, WebKit::SandboxExtension::Handle&) + 164 3 com.apple.WebKit 0x0000000114abb5d0 WebKit::WebPageProxy::loadRequest(WebCore::ResourceRequest const&, WebCore::ShouldOpenExternalURLsPolicy, API::Object*) + 560 4 com.apple.WebKit 0x00000001147631ae WebKit::RemoteWebInspectorProxy::load(WTF::String const&, WTF::String const&) + 318 5 com.apple.WebKit 0x00000001142cfd5f -[_WKRemoteWebInspectorViewController loadForDebuggableType:backendCommandsURL:] + 127 ... Assert when closing: (newly added) Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010a533894 WTFCrash + 36 (Assertions.cpp:323) 1 com.apple.WebCore 0x000000010dd17ff1 WebCore::InspectorController::disconnectAllFrontends() + 113 (InspectorController.cpp:305) 2 com.apple.WebKit 0x0000000102e1a12b WebKit::WebPage::close() + 395 (WebPage.cpp:1063) 3 com.apple.WebKit 0x000000010302e52a WebKit::WebProcess::didClose(IPC::Connection&) + 138 (WebProcess.cpp:648) 4 com.apple.WebKit 0x00000001027233d2 IPC::Connection::connectionDidClose()::$_13::operator()() + 242 (Connection.cpp:802) 5 com.apple.WebKit 0x0000000102723259 WTF::Function<void ()>::CallableWrapper<IPC::Connection::connectionDidClose()::$_13>::call() + 25 (Function.h:89) 6 com.apple.JavaScriptCore 0x000000010a5601ae WTF::Function<void ()>::operator()() const + 94 (Function.h:50) 7 com.apple.JavaScriptCore 0x000000010a57ba43 WTF::RunLoop::performWork() + 211 (RunLoop.cpp:106) 8 com.apple.JavaScriptCore 0x000000010a57d264 WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38) ... Both of these are due to patterns RemoteWebInspectorProxy/UI are not following from WebInspectorProxy/UI. 1269131 1 joepeck 2017-01-23 12:17:05 -0800 <rdar://problem/28891161> 1269133 2 299531 joepeck 2017-01-23 12:18:38 -0800 Created attachment 299531 [PATCH] Proposed Fix 1269152 3 299531 commit-queue 2017-01-23 13:09:18 -0800 Comment on attachment 299531 [PATCH] Proposed Fix Clearing flags on attachment: 299531 Committed r211054: <http://trac.webkit.org/changeset/211054> 1269153 4 commit-queue 2017-01-23 13:09:22 -0800 All reviewed patches have been landed. Closing bug. 299531 2017-01-23 12:18:38 -0800 2017-01-23 13:09:18 -0800 [PATCH] Proposed Fix asserts-1.patch text/plain 2343 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4NDExMjNmLi44MjcxMWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTctMDEtMjMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBBc3NlcnRzIHNlZW4gb3BlbmluZyBhbmQgY2xvc2luZyBS ZW1vdGUgV2ViIEluc3BlY3RvciB3aW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjczMTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4ODkx MTYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL1JlbW90ZVdlYkluc3BlY3RvclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 UmVtb3RlV2ViSW5zcGVjdG9yUHJveHk6OmNyZWF0ZUZyb250ZW5kUGFnZUFuZFdpbmRvdyk6Cisg ICAgICAgIEFzc3VtZSByZWFkIGFjY2VzcywgbGlrZSB0aGUgbG9jYWwgd2ViIGluc3BlY3Rvciwg dG8gV2ViIEluc3BlY3RvciByZXNvdXJjZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvUmVtb3RlV2ViSW5zcGVjdG9yVUkuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVXZWJJ bnNwZWN0b3JVSTo6Y2xvc2VXaW5kb3cpOgorICAgICAgICBDbGVhciBvdXJzZWx2ZXMgYXMgdGhl IGluc3BlY3RvciBmcm9udGVuZCBjbGllbnQgd2hlbiBjbG9zaW5nLgorCiAyMDE3LTAxLTIzICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIx MTAzMyk6IEFTU0VSVElPTiBGQUlMRUQ6IG1fcHRyIGluIGNvbS5hcHBsZS5XZWJDb3JlOiBXVEY6 OlJlZlB0cjxXZWJDb3JlOjpFbGVtZW50Pjo6b3BlcmF0b3IqIGNvbnN0ICsgNzAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUmVtb3RlV2ViSW5zcGVjdG9yUHJveHkuY3BwCmlu ZGV4IDZkY2JlYzcuLjIyMjhiMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1JlbW90ZVdlYkluc3BlY3RvclByb3h5LmNwcApAQCAtMTI5LDYgKzEyOSw3IEBAIHZvaWQg UmVtb3RlV2ViSW5zcGVjdG9yUHJveHk6OmNyZWF0ZUZyb250ZW5kUGFnZUFuZFdpbmRvdygpCiAg ICAgdHJhY2tJbnNwZWN0b3JQYWdlKG1faW5zcGVjdG9yUGFnZSk7CiAKICAgICBtX2luc3BlY3Rv clBhZ2UtPnByb2Nlc3MoKS5hZGRNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlJlbW90ZVdlYklu c3BlY3RvclByb3h5OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1faW5zcGVjdG9yUGFnZS0+cGFn ZUlEKCksICp0aGlzKTsKKyAgICBtX2luc3BlY3RvclBhZ2UtPnByb2Nlc3MoKS5hc3N1bWVSZWFk QWNjZXNzVG9CYXNlVVJMKFdlYkluc3BlY3RvclByb3h5OjppbnNwZWN0b3JCYXNlVVJMKCkpOwog fQogCiB2b2lkIFJlbW90ZVdlYkluc3BlY3RvclByb3h5OjpjbG9zZUZyb250ZW5kUGFnZUFuZFdp bmRvdygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUmVt b3RlV2ViSW5zcGVjdG9yVUkuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L1JlbW90ZVdlYkluc3BlY3RvclVJLmNwcAppbmRleCA1Y2JmMmEyLi4zYmVkZTk5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUmVtb3RlV2ViSW5zcGVjdG9y VUkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9SZW1vdGVXZWJJ bnNwZWN0b3JVSS5jcHAKQEAgLTExOSw2ICsxMTksOCBAQCB2b2lkIFJlbW90ZVdlYkluc3BlY3Rv clVJOjpicmluZ1RvRnJvbnQoKQogCiB2b2lkIFJlbW90ZVdlYkluc3BlY3RvclVJOjpjbG9zZVdp bmRvdygpCiB7CisgICAgbV9wYWdlLmNvcmVQYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIoKS5z ZXRJbnNwZWN0b3JGcm9udGVuZENsaWVudChudWxscHRyKTsKKwogICAgIFdlYlByb2Nlc3M6OnNp bmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6OlJlbW90 ZVdlYkluc3BlY3RvclByb3h5OjpGcm9udGVuZERpZENsb3NlKCksIG1fcGFnZS5wYWdlSUQoKSk7 CiB9CiAK