167314 2017-01-23 11:11:00 -0800 Use priorities in speculative revalidation 2017-02-01 06:04:11 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned beidson cdumez cgarcia commit-queue webkit-bug-importer oldest_to_newest 1269108 0 koivisto 2017-01-23 11:11:00 -0800 We currently do all speculative cache operations with 'Medium' priority and network operations with 'Low'. We should use the actual request priorities instead. 1269124 1 299530 koivisto 2017-01-23 12:09:52 -0800 Created attachment 299530 patch 1269127 2 299530 cdumez 2017-01-23 12:14:36 -0800 Comment on attachment 299530 patch View in context: https://bugs.webkit.org/attachment.cgi?id=299530&action=review r=me > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:492 > + spacing issue. > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:536 > + m_storage.retrieve(subresourcesStorageKey, static_cast<unsigned>(WebCore::ResourceLoadPriority::High), [completionHandler = WTFMove(completionHandler)](auto record) { Why the extra WebCore:: ? The priority change might be risky as I used that value based on PLT results. 1269134 3 koivisto 2017-01-23 12:23:27 -0800 https://trac.webkit.org/r211049 1272122 4 webkit-bug-importer 2017-02-01 06:04:11 -0800 <rdar://problem/30306336> 299530 2017-01-23 12:09:52 -0800 2017-01-23 12:14:36 -0800 patch cache-speculative-priorities.patch text/plain 7522 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTA0NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM4IEBACisyMDE3LTAxLTIzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgcHJpb3JpdGllcyBpbiBz cGVjdWxhdGl2ZSByZXZhbGlkYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NzMxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRseSBkbyBhbGwgc3BlY3VsYXRpdmUgY2FjaGUgb3Bl cmF0aW9ucyB3aXRoICdNZWRpdW0nIHByaW9yaXR5CisgICAgICAgIGFuZCBuZXR3b3JrIG9wZXJh dGlvbnMgd2l0aCAnTG93Jy4gV2Ugc2hvdWxkIHVzZSB0aGUgYWN0dWFsIHJlcXVlc3QgcHJpb3Jp dGllcyBpbnN0ZWFkLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtD YWNoZTo6Y29uc3RydWN0UmV2YWxpZGF0aW9uUmVxdWVzdCk6CisKKyAgICAgICAgICAgIFVzZSBw cmlvcml0eSB3aGVuIGNvbnN0cnVjdGluZyB2YWxpZGF0aW9uIHJlcXVlc3QuCisKKyAgICAgICAg KFdlYktpdDo6TmV0d29ya0NhY2hlOjpTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjpyZXRyaWV2ZUVu dHJ5RnJvbVN0b3JhZ2UpOgorCisgICAgICAgICAgICBVc2UgcHJpb3JpdHkgd2hlbiByZXRyaWV2 aW5nIGZyb20gY2FjaGUuCisKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpTcGVjdWxh dGl2ZUxvYWRNYW5hZ2VyOjpwcmVsb2FkRW50cnkpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3Jr Q2FjaGU6OlNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnJldHJpZXZlU3VicmVzb3VyY2VzRW50cnkp OgorCisgICAgICAgICAgICBVc2UgSGlnaCBwcmlvcml0eSB3aGVuIHJldHJpZXZpbmcgdGhlIGxp c3Qgb2Ygc3VicmVzb3VyY2VzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5oOgorICAgICAgICAqIE5ldHdvcmtQcm9j ZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN1YnJlc291cmNlc0VudHJ5LmNwcDoKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya0NhY2hlOjpTdWJyZXNvdXJjZUluZm86OmVuY29kZSk6CisgICAgICAgIChX ZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6U3VicmVzb3VyY2VJbmZvOjpkZWNvZGUpOgorCisgICAgICAg ICAgICBTYXZlIGFuZCByZXN0b3JlIHRoZSBwcmlvcml0eS4KKworICAgICAgICAqIE5ldHdvcmtQ cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN1YnJlc291cmNlc0VudHJ5Lmg6CisgICAgICAgIChX ZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6U3VicmVzb3VyY2VJbmZvOjpTdWJyZXNvdXJjZUluZm8pOgor ICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlN1YnJlc291cmNlSW5mbzo6cHJpb3JpdHkp OgorCiAyMDE3LTAxLTIzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFZpZGVvIGRldGFpbHMgZG9lcyBub3QgYXBlYXIgYW5kIG1pc3Npbmcgc2NydWJiZXIgaW4g Q29udHJvbCBDZW50ZXIKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZl TG9hZE1hbmFnZXIuY3BwCShyZXZpc2lvbiAyMTA5NDUpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTAzLDYgKzEwMyw4IEBAIHN0YXRpYyBpbmxpbmUgUmVzb3VyY2VS ZXF1ZXN0IGNvbnN0cnVjdFIKICAgICBTdHJpbmcgbGFzdE1vZGlmaWVkID0gZW50cnkucmVzcG9u c2UoKS5odHRwSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6Okxhc3RNb2RpZmllZCk7CiAgICAg aWYgKCFsYXN0TW9kaWZpZWQuaXNFbXB0eSgpKQogICAgICAgICByZXZhbGlkYXRpb25SZXF1ZXN0 LnNldEhUVFBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6SWZNb2RpZmllZFNpbmNlLCBsYXN0 TW9kaWZpZWQpOworICAgIAorICAgIHJldmFsaWRhdGlvblJlcXVlc3Quc2V0UHJpb3JpdHkoc3Vi UmVzb3VyY2VJbmZvLnByaW9yaXR5KCkpOwogCiAgICAgcmV0dXJuIHJldmFsaWRhdGlvblJlcXVl c3Q7CiB9CkBAIC00MDQsOSArNDA2LDkgQEAgdm9pZCBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjph ZGRQcmVsb2FkZQogICAgIH0pKTsKIH0KIAotdm9pZCBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjpy ZXRyaWV2ZUVudHJ5RnJvbVN0b3JhZ2UoY29uc3QgS2V5JiBrZXksIFJldHJpZXZlQ29tcGxldGlv bkhhbmRsZXImJiBjb21wbGV0aW9uSGFuZGxlcikKK3ZvaWQgU3BlY3VsYXRpdmVMb2FkTWFuYWdl cjo6cmV0cmlldmVFbnRyeUZyb21TdG9yYWdlKGNvbnN0IEtleSYga2V5LCBXZWJDb3JlOjpSZXNv dXJjZUxvYWRQcmlvcml0eSBwcmlvcml0eSwgUmV0cmlldmVDb21wbGV0aW9uSGFuZGxlciYmIGNv bXBsZXRpb25IYW5kbGVyKQogewotICAgIG1fc3RvcmFnZS5yZXRyaWV2ZShrZXksIHN0YXRpY19j YXN0PHVuc2lnbmVkPihSZXNvdXJjZUxvYWRQcmlvcml0eTo6TWVkaXVtKSwgW2NvbXBsZXRpb25I YW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildKGF1dG8gcmVjb3JkKSB7CisgICAg bV9zdG9yYWdlLnJldHJpZXZlKGtleSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHByaW9yaXR5KSwg W2NvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildKGF1dG8gcmVj b3JkKSB7CiAgICAgICAgIGlmICghcmVjb3JkKSB7CiAgICAgICAgICAgICBjb21wbGV0aW9uSGFu ZGxlcihudWxscHRyKTsKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTQ4Nyw5ICs0ODks OSBAQCB2b2lkIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnByZWxvYWRFbnRyCiB7CiAgICAgaWYg KG1fcGVuZGluZ1ByZWxvYWRzLmNvbnRhaW5zKGtleSkpCiAgICAgICAgIHJldHVybjsKLQorICAg IAogICAgIG1fcGVuZGluZ1ByZWxvYWRzLmFkZChrZXksIG51bGxwdHIpOwotICAgIHJldHJpZXZl RW50cnlGcm9tU3RvcmFnZShrZXksIFt0aGlzLCBrZXksIHN1YlJlc291cmNlSW5mbywgZnJhbWVJ RF0oc3RkOjp1bmlxdWVfcHRyPEVudHJ5PiBlbnRyeSkgeworICAgIHJldHJpZXZlRW50cnlGcm9t U3RvcmFnZShrZXksIHN1YlJlc291cmNlSW5mby5wcmlvcml0eSgpLCBbdGhpcywga2V5LCBzdWJS ZXNvdXJjZUluZm8sIGZyYW1lSURdKHN0ZDo6dW5pcXVlX3B0cjxFbnRyeT4gZW50cnkpIHsKICAg ICAgICAgQVNTRVJUKCFtX3BlbmRpbmdQcmVsb2Fkcy5nZXQoa2V5KSk7CiAgICAgICAgIGJvb2wg cmVtb3ZlZCA9IG1fcGVuZGluZ1ByZWxvYWRzLnJlbW92ZShrZXkpOwogICAgICAgICBBU1NFUlRf VU5VU0VEKHJlbW92ZWQsIHJlbW92ZWQpOwpAQCAtNTMxLDcgKzUzMyw3IEBAIHZvaWQgU3BlY3Vs YXRpdmVMb2FkTWFuYWdlcjo6cmV0cmlldmVTdWIKIHsKICAgICBBU1NFUlQoc3RvcmFnZUtleS50 eXBlKCkgPT0gIlJlc291cmNlIik7CiAgICAgYXV0byBzdWJyZXNvdXJjZXNTdG9yYWdlS2V5ID0g bWFrZVN1YnJlc291cmNlc0tleShzdG9yYWdlS2V5LCBtX3N0b3JhZ2Uuc2FsdCgpKTsKLSAgICBt X3N0b3JhZ2UucmV0cmlldmUoc3VicmVzb3VyY2VzU3RvcmFnZUtleSwgc3RhdGljX2Nhc3Q8dW5z aWduZWQ+KFJlc291cmNlTG9hZFByaW9yaXR5OjpNZWRpdW0pLCBbY29tcGxldGlvbkhhbmRsZXIg PSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0oYXV0byByZWNvcmQpIHsKKyAgICBtX3N0b3Jh Z2UucmV0cmlldmUoc3VicmVzb3VyY2VzU3RvcmFnZUtleSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KFdlYkNvcmU6OlJlc291cmNlTG9hZFByaW9yaXR5OjpIaWdoKSwgW2NvbXBsZXRpb25IYW5kbGVy ID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildKGF1dG8gcmVjb3JkKSB7CiAgICAgICAgIGlm ICghcmVjb3JkKSB7CiAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihudWxscHRyKTsKICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVj dWxhdGl2ZUxvYWRNYW5hZ2VyLmgJKHJldmlzaW9uIDIxMDk0NSkKKysrIFNvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIu aAkod29ya2luZyBjb3B5KQpAQCAtNjEsNyArNjEsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBh ZGRQcmVsb2FkZWRFbnRyeShzdGQ6OnVuaXF1ZV9wdHI8RW50cnk+LCBjb25zdCBHbG9iYWxGcmFt ZUlEJiwgc3RkOjpvcHRpb25hbDxXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q+JiYgcmV2YWxpZGF0 aW9uUmVxdWVzdCA9IHN0ZDo6bnVsbG9wdCk7CiAgICAgdm9pZCBwcmVsb2FkRW50cnkoY29uc3Qg S2V5JiwgY29uc3QgU3VicmVzb3VyY2VJbmZvJiwgY29uc3QgR2xvYmFsRnJhbWVJRCYpOwotICAg IHZvaWQgcmV0cmlldmVFbnRyeUZyb21TdG9yYWdlKGNvbnN0IEtleSYsIFJldHJpZXZlQ29tcGxl dGlvbkhhbmRsZXImJik7CisgICAgdm9pZCByZXRyaWV2ZUVudHJ5RnJvbVN0b3JhZ2UoY29uc3Qg S2V5JiwgV2ViQ29yZTo6UmVzb3VyY2VMb2FkUHJpb3JpdHksIFJldHJpZXZlQ29tcGxldGlvbkhh bmRsZXImJik7CiAgICAgdm9pZCByZXZhbGlkYXRlRW50cnkoc3RkOjp1bmlxdWVfcHRyPEVudHJ5 PiwgY29uc3QgU3VicmVzb3VyY2VJbmZvJiwgY29uc3QgR2xvYmFsRnJhbWVJRCYpOwogICAgIGJv b2wgc2F0aXNmeVBlbmRpbmdSZXF1ZXN0cyhjb25zdCBLZXkmLCBFbnRyeSopOwogICAgIHZvaWQg cmV0cmlldmVTdWJyZXNvdXJjZXNFbnRyeShjb25zdCBLZXkmIHN0b3JhZ2VLZXksIHN0ZDo6ZnVu Y3Rpb248dm9pZCAoc3RkOjp1bmlxdWVfcHRyPFN1YnJlc291cmNlc0VudHJ5Pik+JiYpOwpJbmRl eDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3VicmVz b3VyY2VzRW50cnkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN1YnJlc291cmNlc0VudHJ5LmNwcAkocmV2aXNpb24gMjEw OTQ1KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hl U3VicmVzb3VyY2VzRW50cnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw3IEBAIHZv aWQgU3VicmVzb3VyY2VJbmZvOjplbmNvZGUoV1RGOjpQZXJzaXMKIAogICAgIGVuY29kZXIgPDwg bV9maXJzdFBhcnR5Rm9yQ29va2llczsKICAgICBlbmNvZGVyIDw8IG1fcmVxdWVzdEhlYWRlcnM7 CisgICAgZW5jb2Rlci5lbmNvZGVFbnVtKG1fcHJpb3JpdHkpOwogfQogCiBib29sIFN1YnJlc291 cmNlSW5mbzo6ZGVjb2RlKFdURjo6UGVyc2lzdGVuY2U6OkRlY29kZXImIGRlY29kZXIsIFN1YnJl c291cmNlSW5mbyYgaW5mbykKQEAgLTYwLDYgKzYxLDkgQEAgYm9vbCBTdWJyZXNvdXJjZUluZm86 OmRlY29kZShXVEY6OlBlcnNpcwogICAgIGlmICghZGVjb2Rlci5kZWNvZGUoaW5mby5tX3JlcXVl c3RIZWFkZXJzKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKCFkZWNvZGVyLmRl Y29kZUVudW0oaW5mby5tX3ByaW9yaXR5KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAog ICAgIHJldHVybiB0cnVlOwogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9jYWNoZS9OZXR3b3JrQ2FjaGVTdWJyZXNvdXJjZXNFbnRyeS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN1YnJlc291cmNl c0VudHJ5LmgJKHJldmlzaW9uIDIxMDk0NSkKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN1YnJlc291cmNlc0VudHJ5LmgJKHdvcmtpbmcgY29weSkK QEAgLTQ3LDE3ICs0NywyMCBAQCBwdWJsaWM6CiAgICAgICAgIDogbV9pc1RyYW5zaWVudChpc1Ry YW5zaWVudCkKICAgICAgICAgLCBtX2ZpcnN0UGFydHlGb3JDb29raWVzKGlzVHJhbnNpZW50ID8g V2ViQ29yZTo6VVJMKCkgOiByZXF1ZXN0LmZpcnN0UGFydHlGb3JDb29raWVzKCkpCiAgICAgICAg ICwgbV9yZXF1ZXN0SGVhZGVycyhpc1RyYW5zaWVudCA/IFdlYkNvcmU6OkhUVFBIZWFkZXJNYXAo KSA6IHJlcXVlc3QuaHR0cEhlYWRlckZpZWxkcygpKQorICAgICAgICAsIG1fcHJpb3JpdHkocmVx dWVzdC5wcmlvcml0eSgpKQogICAgIHsKICAgICB9CiAKICAgICBib29sIGlzVHJhbnNpZW50KCkg Y29uc3QgeyByZXR1cm4gbV9pc1RyYW5zaWVudDsgfQogICAgIGNvbnN0IFdlYkNvcmU6OlVSTCYg Zmlyc3RQYXJ0eUZvckNvb2tpZXMoKSBjb25zdCB7IEFTU0VSVCghbV9pc1RyYW5zaWVudCk7IHJl dHVybiBtX2ZpcnN0UGFydHlGb3JDb29raWVzOyB9CiAgICAgY29uc3QgV2ViQ29yZTo6SFRUUEhl YWRlck1hcCYgcmVxdWVzdEhlYWRlcnMoKSBjb25zdCB7IEFTU0VSVCghbV9pc1RyYW5zaWVudCk7 IHJldHVybiBtX3JlcXVlc3RIZWFkZXJzOyB9CisgICAgV2ViQ29yZTo6UmVzb3VyY2VMb2FkUHJp b3JpdHkgcHJpb3JpdHkoKSBjb25zdCB7IEFTU0VSVCghbV9pc1RyYW5zaWVudCk7IHJldHVybiBt X3ByaW9yaXR5OyB9CiAKIHByaXZhdGU6CiAgICAgYm9vbCBtX2lzVHJhbnNpZW50IHsgdHJ1ZSB9 OwogICAgIFdlYkNvcmU6OlVSTCBtX2ZpcnN0UGFydHlGb3JDb29raWVzOwogICAgIFdlYkNvcmU6 OkhUVFBIZWFkZXJNYXAgbV9yZXF1ZXN0SGVhZGVyczsKKyAgICBXZWJDb3JlOjpSZXNvdXJjZUxv YWRQcmlvcml0eSBtX3ByaW9yaXR5OwogfTsKIAogc3RydWN0IFN1YnJlc291cmNlTG9hZCB7Cg==