167313 2017-01-23 09:38:54 -0800 gtest fails to link on Linux due to missing -lpthread 2017-01-23 13:39:28 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 timothy timothy achristensen cdumez commit-queue lforschler mcatanzaro oldest_to_newest 1269074 0 timothy 2017-01-23 09:38:54 -0800 Building gtest is failing for me because CMAKE_USE_PTHREADS_INIT is not defined and GTEST_HAS_PTHREAD will be assumed true if it is undefined. 1269083 1 299521 timothy 2017-01-23 09:58:02 -0800 Created attachment 299521 Patch 1269084 2 commit-queue 2017-01-23 10:00:42 -0800 Attachment 299521 did not pass style-queue: ERROR: Source/ThirdParty/gtest/CMakeLists.txt:53: One space between command "else" and its parentheses, should be "else (" [whitespace/parentheses] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1269086 3 299522 timothy 2017-01-23 10:10:36 -0800 Created attachment 299522 Patch 1269100 4 299522 commit-queue 2017-01-23 10:47:07 -0800 Comment on attachment 299522 Patch Clearing flags on attachment: 299522 Committed r211044: <http://trac.webkit.org/changeset/211044> 1269101 5 commit-queue 2017-01-23 10:47:13 -0800 All reviewed patches have been landed. Closing bug. 1269136 6 299522 timothy 2017-01-23 12:27:39 -0800 Comment on attachment 299522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299522&action=review > Source/ThirdParty/gtest/CMakeLists.txt:48 > +find_package(Threads) Turns out this isn't needed, it is assumed to happen in the platform make options file. I'll remove this. 1269172 7 timothy 2017-01-23 13:39:28 -0800 Follow up. https://trac.webkit.org/changeset/211050 299521 2017-01-23 09:58:02 -0800 2017-01-23 10:10:36 -0800 Patch 167313.patch text/plain 1402 timothy ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZyBiL1NvdXJjZS9UaGlyZFBh cnR5L0NoYW5nZUxvZwppbmRleCA4NWE3YjY3Zi4uMTdlNzk5YyAxMDA2NDQKLS0tIGEvU291cmNl L1RoaXJkUGFydHkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTIzICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGhh dGNoZXIubmFtZT4KKworICAgICAgICBndGVzdCBmYWlscyB0byBsaW5rIG9uIExpbnV4IGR1ZSB0 byBtaXNzaW5nIC1scHRocmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY3MzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBndGVzdC9DTWFrZUxpc3RzLnR4dDogQWRkIGNhbGwgdG8gZmluZF9wYWNr YWdlKFRocmVhZHMpIGJlZm9yZSB0ZXN0aW5nIENNQUtFX1VTRV9QVEhSRUFEU19JTklULgorICAg ICAgICBXaXRob3V0IHRoZSBmaW5kX3BhY2thZ2UgY2FsbCwgQ01BS0VfVVNFX1BUSFJFQURTX0lO SVQgd2FzIGFsd2F5cyBmYWxzZSBmb3IgbWUuIEFsc28gZXhwbGljaXRseQorICAgICAgICBkZWZp bmUgR1RFU1RfSEFTX1BUSFJFQUQgdG8gMCB3aGVuIENNQUtFX1VTRV9QVEhSRUFEU19JTklUIGlz IGZhbHNlIHRvIHByZXZlbnQgZ3Rlc3QtcG9ydC5oIGZyb20KKyAgICAgICAgc2V0dGluZyBHVEVT VF9IQVNfUFRIUkVBRCBiYXNlZCBvbiB0aGUgcGxhdGZvcm0uCisKIDIwMTctMDEtMjAgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJSVENdIEFkZCBsaWJ3 ZWJydGMgYnVpbGQgaW5mcmFzdHJ1Y3R1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L2d0ZXN0L0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01ha2VMaXN0 cy50eHQKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCAwNTU3ODFmLi42OWU0 YWE0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CkBAIC00NSw3ICs0NSwxMSBAQCB0 YXJnZXRfbGlua19saWJyYXJpZXMoZ3Rlc3QKICAgICBXVEYKICkKIAorZmluZF9wYWNrYWdlKFRo cmVhZHMpCisKIGlmIChDTUFLRV9VU0VfUFRIUkVBRFNfSU5JVCkKICAgICB0YXJnZXRfbGlua19s aWJyYXJpZXMoZ3Rlc3QgJHtDTUFLRV9USFJFQURfTElCU19JTklUfSkKICAgICBhZGRfZGVmaW5p dGlvbnMoLURHVEVTVF9IQVNfUFRIUkVBRD0xKQorZWxzZSgpCisgICAgYWRkX2RlZmluaXRpb25z KC1ER1RFU1RfSEFTX1BUSFJFQUQ9MCkKIGVuZGlmICgpCg== 299522 2017-01-23 10:10:36 -0800 2017-01-23 10:47:07 -0800 Patch 167313.patch text/plain 1405 timothy ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZyBiL1NvdXJjZS9UaGlyZFBh cnR5L0NoYW5nZUxvZwppbmRleCA4NWE3YjY3Zi4uZDRjNjliOCAxMDA2NDQKLS0tIGEvU291cmNl L1RoaXJkUGFydHkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTIzICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGhh dGNoZXIubmFtZT4KKworICAgICAgICBndGVzdCBmYWlscyB0byBsaW5rIG9uIExpbnV4IGR1ZSB0 byBtaXNzaW5nIC1scHRocmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY3MzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNl bi4KKworICAgICAgICAqIGd0ZXN0L0NNYWtlTGlzdHMudHh0OiBBZGQgY2FsbCB0byBmaW5kX3Bh Y2thZ2UoVGhyZWFkcykgYmVmb3JlIHRlc3RpbmcgQ01BS0VfVVNFX1BUSFJFQURTX0lOSVQuCisg ICAgICAgIFdpdGhvdXQgdGhlIGZpbmRfcGFja2FnZSBjYWxsLCBDTUFLRV9VU0VfUFRIUkVBRFNf SU5JVCB3YXMgYWx3YXlzIGZhbHNlIGZvciBtZS4gQWxzbyBleHBsaWNpdGx5CisgICAgICAgIGRl ZmluZSBHVEVTVF9IQVNfUFRIUkVBRCB0byAwIHdoZW4gQ01BS0VfVVNFX1BUSFJFQURTX0lOSVQg aXMgZmFsc2UgdG8gcHJldmVudCBndGVzdC1wb3J0LmggZnJvbQorICAgICAgICBzZXR0aW5nIEdU RVNUX0hBU19QVEhSRUFEIGJhc2VkIG9uIHRoZSBwbGF0Zm9ybS4KKwogMjAxNy0wMS0yMCAgWW91 ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYlJUQ10gQWRkIGxp YndlYnJ0YyBidWlsZCBpbmZyYXN0cnVjdHVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFy dHkvZ3Rlc3QvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC9DTWFrZUxp c3RzLnR4dApvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IDA1NTc4MWYuLmI1 NTVjMzYKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01ha2VMaXN0cy50eHQKKysrIGIv U291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01ha2VMaXN0cy50eHQKQEAgLTQ1LDcgKzQ1LDExIEBA IHRhcmdldF9saW5rX2xpYnJhcmllcyhndGVzdAogICAgIFdURgogKQogCitmaW5kX3BhY2thZ2Uo VGhyZWFkcykKKwogaWYgKENNQUtFX1VTRV9QVEhSRUFEU19JTklUKQogICAgIHRhcmdldF9saW5r X2xpYnJhcmllcyhndGVzdCAke0NNQUtFX1RIUkVBRF9MSUJTX0lOSVR9KQogICAgIGFkZF9kZWZp bml0aW9ucygtREdURVNUX0hBU19QVEhSRUFEPTEpCitlbHNlICgpCisgICAgYWRkX2RlZmluaXRp b25zKC1ER1RFU1RfSEFTX1BUSFJFQUQ9MCkKIGVuZGlmICgpCg==