167311 2017-01-23 09:28:51 -0800 LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout 2017-01-24 19:00:31 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad graouts commit-queue graouts oldest_to_newest 1269066 0 ryanhaddad 2017-01-23 09:28:51 -0800 LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r211038%20(2629)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Ftracks-panel%2Ftracks-panel-hide.html 1269166 1 ryanhaddad 2017-01-23 13:29:53 -0800 This appears to be limited to macOS debug. 1269168 2 ryanhaddad 2017-01-23 13:32:59 -0800 Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211059 1269543 3 graouts 2017-01-24 14:06:34 -0800 The timeout is caused by the "transitionend" event not being fired. 1269545 4 graouts 2017-01-24 14:11:55 -0800 This looks like a bug in the TracksPanel class where we register for the "transitionend" event at the same time we apply the "fade-out" class that triggers the transition. But in case the value we're animating from is already 0, we won't have a chance to transition and there will be no event. So we need to register for the event first and delay the transition until the next frame. 1269549 5 299631 graouts 2017-01-24 14:19:04 -0800 Created attachment 299631 Patch 1269665 6 299631 commit-queue 2017-01-24 19:00:28 -0800 Comment on attachment 299631 Patch Clearing flags on attachment: 299631 Committed r211131: <http://trac.webkit.org/changeset/211131> 1269666 7 commit-queue 2017-01-24 19:00:31 -0800 All reviewed patches have been landed. Closing bug. 299631 2017-01-24 14:19:04 -0800 2017-01-24 19:00:28 -0800 Patch bug-167311-20170124231704.patch text/plain 3342 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E5YTE4MDUxYzgzNWRi ZTllZjM4MWZjMGQ3YTBmNjg0YmU1ZGFlOC4uZWM4NjdhNGQ4ZjZlOTkxMDUzZTA3YjU4NTFmZTkx ZTk3Y2E4M2NmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAxLTI0ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBtZWRp YS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXBhbmVsL3RyYWNrcy1wYW5lbC1oaWRlLmh0 bWwgaXMgYSBmbGFreSB0aW1lb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjczMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFbnN1cmUgd2UgaGF2ZSBhIGNoYW5jZSB0byBzdGFydCB0aGUgdHJhbnNp dGlvbiAob24gdGhlIG5leHQgZnJhbWUpIGJlZm9yZSByZWdpc3RlcmluZyBmb3IgYW4gZXZlbnQK KyAgICAgICAgdHJhY2tpbmcgaXRzIGNvbXBsZXRpb24uCisKKyAgICAgICAgKiBNb2R1bGVzL21v ZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy90cmFja3MtcGFuZWwuanM6CisgICAgICAgIChU cmFja3NQYW5lbC5wcm90b3R5cGUuaGlkZSk6CisKIDIwMTctMDEtMjQgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFN0cmluZ1ZpZXcuc3BsaXQoKSBzaG91bGQg dXNlIGFuIGl0ZXJhdG9yIGRlc2lnbiBwYXR0ZXJuIGluc3RlYWQgb2YgYWxsb2NhdGluZyBhIFZl Y3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29u dHJvbHMvY29udHJvbHMvdHJhY2tzLXBhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t b2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvdHJhY2tzLXBhbmVsLmpzCmluZGV4IGM4NjM5 ZWEyZWJlMWEzNjg4ODU0YjAwYjk3ZDE5MzllMmJiODZkZTQuLjQwMTFkMjllNTk0ZmYyOGEyNGE2 NzUxNzA0YzI3YTY5MmU2ODdhZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL3RyYWNrcy1wYW5lbC5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy90cmFja3Mt cGFuZWwuanMKQEAgLTQzLDcgKzQzLDkgQEAgY2xhc3MgVHJhY2tzUGFuZWwgZXh0ZW5kcyBMYXlv dXROb2RlCiAgICAgICAgIHdpbmRvdy5yZW1vdmVFdmVudExpc3RlbmVyKCJrZXlkb3duIiwgdGhp cywgdHJ1ZSk7CiAKICAgICAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoInRyYW5z aXRpb25lbmQiLCB0aGlzKTsKLSAgICAgICAgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC5hZGQoImZh ZGUtb3V0Iik7CisKKyAgICAgICAgLy8gRW5zdXJlIGEgdHJhbnNpdGlvbiB3aWxsIGluZGVlZCBo YXBwZW4gYnkgc3RhcnRpbmcgaXQgb25seSBvbiB0aGUgbmV4dCBmcmFtZS4KKyAgICAgICAgd2lu ZG93LnJlcXVlc3RBbmltYXRpb25GcmFtZSgoKSA9PiB7IHRoaXMuZWxlbWVudC5jbGFzc0xpc3Qu YWRkKCJmYWRlLW91dCIpIH0pOwogICAgIH0KIAogICAgIGdldCBib3R0b21ZKCkKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4 YjkyMjBjZDE3NjMzODQ2MWY5ODI4ZmQ5ZDI5NzIxOWNlNDllYzc3Li41ZTVmNTViNjNhZDk2YzQ1 NmUzYWUyNmY4ODM3M2Q3ZTkzMjMxOGU0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDEt MjQgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXRU ZXN0IG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy90cmFja3MtcGFuZWwvdHJhY2tzLXBhbmVs LWhpZGUuaHRtbCBpcyBhIGZsYWt5IHRpbWVvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzMxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdGVzdCBzaG91bGQgbm8gbG9uZ2VyIGJlIGZsYWt5 LCBzbyBsZXQncyBubyBtYXJrIGl0IGFzIHN1Y2ggYW55bW9yZS4KKworICAgICAgICAqIHBsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3LTAxLTI0ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGFsd2F5cyB0cnVlIHN5bmNY SFJJbkRvY3VtZW50c0VuYWJsZWQgc2V0dGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVz dEV4cGVjdGF0aW9ucwppbmRleCBmYTIwMTYyMWY3YWYxZmFiMGQ3NDMwY2U2MmZlZDY2MTc5YzZl MjBiLi5mNmU5YmQ0MDhlYzcxYWNiYjEzYWViYjA4YTgxNTY5YjgyOTUwZjA0IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ5Myw4ICsxNDkzLDYgQEAg d2Via2l0Lm9yZy9iLzE2NzI2MyBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29u dHJvbGxlci9tZWRpYS1jb250cm9sbGUKIAogd2Via2l0Lm9yZy9iLzE2NzI3NSBtZWRpYS9tb2Rl cm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXN1cHBvcnQvdHJhY2tzLXN1cHBvcnQtc2hvdy1wYW5l bC1hZnRlci1kcmFnZ2luZy1jb250cm9scy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0 Lm9yZy9iLzE2NzMxMSBbIERlYnVnIF0gbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3RyYWNr cy1wYW5lbC90cmFja3MtcGFuZWwtaGlkZS5odG1sIFsgUGFzcyBUaW1lb3V0IF0KLQogd2Via2l0 Lm9yZy9iLzE2NzM0NyBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxl ci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS1tb3VzZS1lbnRlci1hbmQtbW91c2UtbGVhdmUu aHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNjU4NzQgWyBEZWJ1ZyBdIHN0 cmVhbXMvcGlwZS10by5odG1sIFsgUGFzcyBGYWlsdXJlIF0K