167298 2017-01-22 20:57:21 -0800 Add pdr to the rendering watchlist 2017-03-07 09:39:58 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr commit-queue glenn lforschler rego oldest_to_newest 1268972 0 pdr 2017-01-22 20:57:21 -0800 I'd like to do a better job at keeping blink and webkit compatible in both directions. 1268973 1 299497 pdr 2017-01-22 21:04:42 -0800 Created attachment 299497 Add pdr to the rendering watchlist 1268974 2 commit-queue 2017-01-22 21:07:18 -0800 Attachment 299497 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1269336 3 pdr 2017-01-23 21:32:32 -0800 Thanks Andreas. I no longer have the svn cred to land this without the commit queue (per the security clause in https://webkit.org/commit-and-review-policy/#inactive-committer-or-reviewer-status). Would you be willing to webkit-patch land this on my behalf? 1284275 4 rego 2017-03-07 05:16:31 -0800 Committed r213512: <http://trac.webkit.org/changeset/213512> 1284276 5 rego 2017-03-07 05:17:19 -0800 @pdr I've landed this for you. PS: I found this just by chance, looking for issues related to the watchlist as it seems to be failing for me in some cases. :-) 1284366 6 pdr 2017-03-07 09:39:58 -0800 Thank you! 299497 2017-01-22 21:04:42 -0800 2017-01-22 21:37:28 -0800 Add pdr to the rendering watchlist bug-167298-20170122210245.patch text/plain 2845 pdr SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMTAyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTAxLTIyICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisK KyAgICAgICAgQWRkIHBkciB0byB0aGUgcmVuZGVyaW5nIHdhdGNobGlzdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3Mjk4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb246IFN3aXRjaCB0byBwZHIrYXV0b2NjQGNocm9t aXVtLm9yZworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxp c3Q6IEFkZCBwZHIgdG8gdGhlIHJlbmRlcmluZyB3YXRjaGxpc3QuCisKIDIwMTctMDEtMjEgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuIEJyaW5nIGJhY2sgZ3RrLWRvYyBlcnJvciBtZXNzYWdlcyBhZnRlciByMjA5OTgxLgpJ bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5q c29uCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9j b250cmlidXRvcnMuanNvbgkocmV2aXNpb24gMjExMDI5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uCSh3b3JraW5nIGNvcHkpCkBAIC00 NDUzLDcgKzQ0NTMsOCBAQAogICAgIlBoaWxpcCBSb2dlcnMiIDogewogICAgICAgImVtYWlscyIg OiBbCiAgICAgICAgICAicGRyQGdvb2dsZS5jb20iLAotICAgICAgICAgInBkckBjaHJvbWl1bS5v cmciCisgICAgICAgICAicGRyQGNocm9taXVtLm9yZyIsCisgICAgICAgICAicGRyK2F1dG9jY0Bj aHJvbWl1bS5vcmciCiAgICAgICBdLAogICAgICAgImV4cGVydGlzZSIgOiAiU1ZHIChTY2FsYWJs ZSBWZWN0b3IgR3JhcGhpY3MpIiwKICAgICAgICJuaWNrcyIgOiBbCkBAIC01ODIyLDQgKzU4MjMs NCBAQAogICAgICAgXSwKICAgICAgICJzdGF0dXMiIDogInJldmlld2VyIgogICAgfQotfQorfQpc IE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy93YXRjaGxpc3QKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdAkocmV2aXNpb24gMjExMDI5KQorKysgVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdAkod29ya2luZyBjb3B5KQpA QCAtMzg5LDkgKzM4OSw5IEBACiAgICAgICAgICJPcGVuR0wiIDogWyAibm9hbUB3ZWJraXQub3Jn IiwgImRpbm9AYXBwbGUuY29tIiwgImtvbmRhcGFsbHlrYWx5YW5AZ21haWwuY29tIiBdLAogICAg ICAgICAiUGVyZm9ybWFuY2VUZXN0cyI6IFsgInJuaXdhQHdlYmtpdC5vcmciLCAiY2R1bWV6QGFw cGxlLmNvbSIgXSwKICAgICAgICAgIlJlZ2lvbnNEZXZlbG9wbWVudHxSZWdpb25zRXhwZWN0YXRp b25zTW9yZXxSZWdpb25zRXhwZWN0YXRpb25zTGVzc3xSZWdpb25zVXNhZ2UiOiBbICJXZWJraXRC dWdUcmFja2VyQGFkb2JlLmNvbSIgXSwKLSAgICAgICAgIlJlbmRlcmluZyI6IFsgImVzcHJlaG4r YXV0b2NjQGNocm9taXVtLm9yZyIsICJnbGVubkBza3luYXYuY29tIiwgImtvbmRhcGFsbHlrYWx5 YW5AZ21haWwuY29tIiBdLAorICAgICAgICAiUmVuZGVyaW5nIjogWyAiZXNwcmVobithdXRvY2NA Y2hyb21pdW0ub3JnIiwgImdsZW5uQHNreW5hdi5jb20iLCAia29uZGFwYWxseWthbHlhbkBnbWFp bC5jb20iLCAicGRyK2F1dG9jY0BjaHJvbWl1bS5vcmciIF0sCiAgICAgICAgICJSZW5kZXJMYXll cnMiIDogWyAic2ltb24uZnJhc2VyQGFwcGxlLmNvbSIsICJrb25kYXBhbGx5a2FseWFuQGdtYWls LmNvbSIgXSwKLSAgICAgICAgIlNWRyI6IFsic2NoZW5uZXlAY2hyb21pdW0ub3JnIiwgInBkckBn b29nbGUuY29tIiwgImZtYWxpdGFAY2hyb21pdW0ub3JnIiwgImd5dXlvdW5nLmtpbUB3ZWJraXQu b3JnIiwgInNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmciLCAic2Fib3VoYWxsYXdhQGFwcGxl LmNvbSIsICJkaW5vQGFwcGxlLmNvbSIgXSwKKyAgICAgICAgIlNWRyI6IFsic2NoZW5uZXlAY2hy b21pdW0ub3JnIiwgInBkcithdXRvY2NAY2hyb21pdW0ub3JnIiwgImZtYWxpdGFAY2hyb21pdW0u b3JnIiwgImd5dXlvdW5nLmtpbUB3ZWJraXQub3JnIiwgInNlcmdpby5jb3JyZWlhQG9wZW5ib3Nz YS5vcmciLCAic2Fib3VoYWxsYXdhQGFwcGxlLmNvbSIsICJkaW5vQGFwcGxlLmNvbSIgXSwKICAg ICAgICAgIlNWTlNjcmlwdHMiOiBbICJkYmF0ZXNAd2Via2l0Lm9yZyIgXSwKICAgICAgICAgIlNj cm9sbGluZ0Nvb3JkaW5hdG9yIjogWyAiamFtZXNyQGNocm9taXVtLm9yZyIsICJ0b25pa2l0b29A d2Via2l0Lm9yZyIsICJjbWFyY2Vsb0B3ZWJraXQub3JnIiwgImx1aXpAd2Via2l0Lm9yZyIgXSwK ICAgICAgICAgIlNlbGVjdG9ycyI6IFsgImFsbGFuLmplbnNlbkBkaWdpYS5jb20iIF0sCg==