167282 2017-01-21 02:05:41 -0800 JavaScriptCore has a weak external symbol in it 2017-01-23 02:43:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hszhsh webkit-unassigned ap commit-queue joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1268743 0 hszhsh 2017-01-21 02:05:41 -0800 ERROR: JavaScriptCore has a weak external symbol in it (/Users/hoolai/Library/Developer/Xcode/DerivedData/WebKit-ehpvmnqmihxdvndqudiokzoxdfuu/Build/Products/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol automatically hidden __ZTVN3JSC8Debugger15ProfilingClientE 1268845 1 ap 2017-01-21 23:29:17 -0800 I don't think that we've seen this particular error. What version of Xcode are you building with? 1268846 2 hszhsh 2017-01-21 23:32:26 -0800 I'm using Xcode Version 8.2.1 (8C1002) 1268850 3 ap 2017-01-21 23:52:10 -0800 Our bots have version 8.2, which is unlikely to be different in this regard. What command do you build with? 1268868 4 hszhsh 2017-01-22 00:14:51 -0800 I just open the workspace file with Xcode, and select the JavaScriptCore target. I have changed the Mach-O Type to static library to run on iOS with my own app. Error was reported for debug build. I can make the release build successfully. 1268949 5 joepeck 2017-01-22 18:41:47 -0800 This seems like an issue that I used to see in the past that was solved by newer compilers. In any case, it sounds like we can just make the destructor: virtual ~ProfilingClient() { } Not be inlined to solve this. I'll try to reproduce myself tonight, but I'll just throw up a patch anyways. 1268982 6 joepeck 2017-01-22 22:14:00 -0800 With: $ xcrun clang++ -v Apple LLVM version 8.1.0 (clang-802.0.21.2) I only see these weak externals: $ nm -m $build/Release/JavaScriptCore.framework/JavaScriptCore | grep 'weak external' (undefined) weak external __ZdaPv (from libc++) (undefined) weak external __ZdlPv (from libc++) (undefined) weak external __Znam (from libc++) (undefined) weak external __Znwm (from libc++) So I guess I can go ahead speculatively here, seems harmless. 1268983 7 299500 joepeck 2017-01-22 22:16:29 -0800 Created attachment 299500 [PATCH] Proposed Fix 1268984 8 joepeck 2017-01-22 22:17:03 -0800 Shuan, since I can't reproduce but you can, would you be willing to try the attached patch (very basic) and see if it solves the problem for you? 1268986 9 hszhsh 2017-01-22 22:20:19 -0800 Ok, I'll try it and report my result later. 1269011 10 hszhsh 2017-01-22 23:35:47 -0800 The patch solved my problem. Thanks for you work. 1269021 11 299500 ysuzuki 2017-01-23 02:18:28 -0800 Comment on attachment 299500 [PATCH] Proposed Fix ok, r=me 1269022 12 299500 commit-queue 2017-01-23 02:42:58 -0800 Comment on attachment 299500 [PATCH] Proposed Fix Clearing flags on attachment: 299500 Committed r211037: <http://trac.webkit.org/changeset/211037> 1269023 13 commit-queue 2017-01-23 02:43:02 -0800 All reviewed patches have been landed. Closing bug. 299500 2017-01-22 22:16:29 -0800 2017-01-23 02:42:58 -0800 [PATCH] Proposed Fix weak-1.patch text/plain 1757 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVlZmJiMWZlM2EzLi4yMjJhYTcxNmJlOCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDEtMjIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBKYXZhU2NyaXB0Q29y ZSBoYXMgYSB3ZWFrIGV4dGVybmFsIHN5bWJvbCBpbiBpdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZWJ1Z2dlci9EZWJ1Z2dlci5jcHA6CisgICAg ICAgIChKU0M6OkRlYnVnZ2VyOjpQcm9maWxpbmdDbGllbnQ6On5Qcm9maWxpbmdDbGllbnQpOgor ICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmg6CisgICAgICAgIEF2b2lkIHBvc3NpYmxlIHdl YWsgZXh0ZXJuYWwgc3ltYm9sLgorCiAyMDE3LTAxLTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgSmF2YVNjcmlwdCBmb3Itb2YgZG9lcyBub3Qgd29yayBvbiBh IGxvdCBvZiBjb2xsZWN0aW9uIHR5cGVzIChlLmcuIEhUTUxDb2xsZWN0aW9uKQpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAKaW5kZXggYjgwNDkyYzE1MzcuLjgy YjRkNTRmOWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVi dWdnZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5j cHAKQEAgLTExOCw2ICsxMTgsMTEgQEAgcHJpdmF0ZToKICAgICBEZWJ1Z2dlciYgbV9kZWJ1Z2dl cjsKIH07CiAKKworRGVidWdnZXI6OlByb2ZpbGluZ0NsaWVudDo6flByb2ZpbGluZ0NsaWVudCgp Cit7Cit9CisKIERlYnVnZ2VyOjpEZWJ1Z2dlcihWTSYgdm0pCiAgICAgOiBtX3ZtKHZtKQogICAg ICwgbV9wYXVzZU9uRXhjZXB0aW9uc1N0YXRlKERvbnRQYXVzZU9uRXhjZXB0aW9ucykKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmgKaW5kZXggNzIyMDBhOGZhYWIuLmZh NmQzMWVhMWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVi dWdnZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuaApA QCAtMTM4LDcgKzEzOCw3IEBAIHB1YmxpYzoKIAogICAgIGNsYXNzIFByb2ZpbGluZ0NsaWVudCB7 CiAgICAgcHVibGljOgotICAgICAgICB2aXJ0dWFsIH5Qcm9maWxpbmdDbGllbnQoKSB7IH0KKyAg ICAgICAgdmlydHVhbCB+UHJvZmlsaW5nQ2xpZW50KCk7CiAgICAgICAgIHZpcnR1YWwgYm9vbCBp c0FscmVhZHlQcm9maWxpbmcoKSBjb25zdCA9IDA7CiAgICAgICAgIHZpcnR1YWwgZG91YmxlIHdp bGxFdmFsdWF0ZVNjcmlwdCgpID0gMDsKICAgICAgICAgdmlydHVhbCB2b2lkIGRpZEV2YWx1YXRl U2NyaXB0KGRvdWJsZSBzdGFydFRpbWUsIFByb2ZpbGluZ1JlYXNvbikgPSAwOwo=