<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>167263</bug_id>
          
          <creation_ts>2017-01-20 15:54:02 -0800</creation_ts>
          <short_desc>LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky</short_desc>
          <delta_ts>2017-03-02 18:04:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Haddad">ryanhaddad</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>graouts</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1268626</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-01-20 15:54:02 -0800</bug_when>
    <thetext>LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r210986%20(10966)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&amp;tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-auto-hide.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-actual.txt
@@ -7,7 +7,7 @@
 PASS controlsBar.classList.contains(&apos;faded&apos;) is false
 
 Auto-hide timer has been going for 200ms, controls bar should still be visible.
-PASS controlsBar.classList.contains(&apos;faded&apos;) is false
+FAIL controlsBar.classList.contains(&apos;faded&apos;) should be false. Was true.
 
 Auto-hide timer has elapsed, controls bar should be faded.
 PASS controlsBar.classList.contains(&apos;faded&apos;) is true</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1268634</commentid>
    <comment_count>1</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-01-20 16:02:37 -0800</bug_when>
    <thetext>Marked as flaky in https://trac.webkit.org/changeset/210994</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1269788</commentid>
    <comment_count>2</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-01-25 05:38:25 -0800</bug_when>
    <thetext>This is tricky because this test, and a host of others, is timing-sensitive by design since it&apos;s testing the auto-hide timer. The test checks as close as possible to the auto-hide delay that the controls are still visible, and then again as soon as possible after the auto-hide delay has elapsed to check that the controls are no longer visible. So in certain cases, probably where the system is under pressure and timers run late, we get in cases where the check prior to the timer firing fails because we&apos;ve actually run past auto-hide delay. We&apos;re going to have to find a different way to test this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1272895</commentid>
    <comment_count>3</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-02-03 06:08:36 -0800</bug_when>
    <thetext>OK, I think I understand what makes this test flaky.

First, the test makes the assumption that the auto-hide timer can only be started as a result of the &quot;play&quot; event firing… but it turns out that when &quot;loadedmetadata&quot; fires, media.paused can be set to &quot;false&quot;, and ControlsVisibilitySupport which governs when the controls bar is set to have fadesWhileIdle = true, uses both &quot;loadedmetadata&quot; and &quot;play&quot; as triggers provided media.paused = &quot;false&quot;. So that&apos;s the first issue, since we could potentially wait enough time until we&apos;d assume the auto-hide timer started to make our 200ms and 300ms timers off-base enough.

Second, while the system is under stress (in my case I have a full WK build and running the test with GuardMalloc), there might be a significant delta between the moment the same event is handled within the media controls code and when it&apos;s handled in the test. Locally, I can see something around 85ms as the delay. This would cause another significant delay to make the 200ms and 300ms timers off-base.

So this test is definitely flaky by nature, and all of the other auto-hide tests, many of which are showing flakiness, suffer from the same design flaw. I&apos;ll need to think of a better, more robust way to write those tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1282989</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-03-02 17:08:40 -0800</bug_when>
    <thetext>&lt;rdar://problem/30821398&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1282991</commentid>
    <comment_count>5</comment_count>
      <attachid>303270</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-03-02 17:14:07 -0800</bug_when>
    <thetext>Created attachment 303270
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1283010</commentid>
    <comment_count>6</comment_count>
      <attachid>303275</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-03-02 17:50:26 -0800</bug_when>
    <thetext>Created attachment 303275
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1283016</commentid>
    <comment_count>7</comment_count>
      <attachid>303275</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-02 18:04:27 -0800</bug_when>
    <thetext>Comment on attachment 303275
Patch for landing

Clearing flags on attachment: 303275

Committed r213337: &lt;http://trac.webkit.org/changeset/213337&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1283017</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-02 18:04:31 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>303270</attachid>
            <date>2017-03-02 17:14:07 -0800</date>
            <delta_ts>2017-03-02 17:50:23 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-167263-20170302171406.patch</filename>
            <type>text/plain</type>
            <size>5752</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjY1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2U3ZjVlYjI3MTUyMTg2YTQxNWQ1
NDBjYzVhYTFkMTkzZDNmMzRmZS4uMDJjZWM5ZTMwZWIyNTU4NzE2MWRmMTkwYjVkNWUzMjJhODlj
NjQ4OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAzLTAyICBBbnRvaW5lIFF1aW50ICA8
Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBtZWRpYS9tb2Rlcm4tbWVk
aWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS5o
dG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xNjcyNjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMwODIxMzk4PgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHRpbWluZyBpcyBo
YXJkIHRvIHRlc3QgYWNjdXJhdGVseSwgc2ltcGxpZnkgdGhlIHRlc3QgdG8gb25seSBjaGVjayB0
aGF0IHdlJ3JlIHRyYW5zaXRpb25pbmcKKyAgICAgICAgZnJvbSBvbmUgc3RhdGUgdG8gYW5vdGhl
ciBhbmQgdXNlIHRoZSBhc3luY2hyb25vdXMsIHBvbGxpbmctYmFzZWQgYXNzZXJ0aW9ucyB0byBj
aGVjayB0aGF0IHdlIHdpbGwKKyAgICAgICAgYmUgdHJhbnNpdGlvbmluZyBiZXR3ZWVuIHRob3Nl
IHR3byBzdGF0ZXMgKHZpc2libGUgYW5kIGZhZGVkKS4KKworICAgICAgICAqIG1lZGlhL21vZGVy
bi1tZWRpYS1jb250cm9scy9tZWRpYS1jb250cm9sbGVyL21lZGlhLWNvbnRyb2xsZXItYXV0by1o
aWRlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMv
bWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS5odG1sOgorICAgICAg
ICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3LTAzLTAxICBBbnRvaW5l
IFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0VGVzdCBtZWRpYS9t
b2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLXJl
c2l6ZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk
aWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxl
ci1hdXRvLWhpZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlh
LWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxlci1hdXRvLWhpZGUtZXhw
ZWN0ZWQudHh0CmluZGV4IDkwODBmNzkxOTc4NGY3OWE2N2Y0YjY1OGM2OTcxNWU1MDMyNjgxZDUu
LmYxZTQ1OGEzY2U5YWEwMTFiNDYwNjgwOWFkYWU4YTBlMGM1YTNhMWEgMTAwNjQ0Ci0tLSBhL0xh
eW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS1jb250cm9sbGVyL21l
ZGlhLWNvbnRyb2xsZXItYXV0by1oaWRlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9t
ZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9s
bGVyLWF1dG8taGlkZS1leHBlY3RlZC50eHQKQEAgLTMsMTQgKzMsOSBAQCBUZXN0aW5nIHRoZSBj
b250cm9scyBiYXIgZmFkZXMgb3V0IGFzIGV4cGVjdGVkIGFmdGVyIHRoZSBhdXRvLWhpZGUgZGVs
YXkgZXhwaXJlcwogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt
ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVZpZGVvIHN0YXJ0ZWQg
cGxheWluZywgY29udHJvbHMgYmFyIGlzIHZpc2libGUgYnkgZGVmYXVsdC4KLVBBU1MgY29udHJv
bHNCYXIuY2xhc3NMaXN0LmNvbnRhaW5zKCdmYWRlZCcpIGlzIGZhbHNlCi0KLUF1dG8taGlkZSB0
aW1lciBoYXMgYmVlbiBnb2luZyBmb3IgMjAwbXMsIGNvbnRyb2xzIGJhciBzaG91bGQgc3RpbGwg
YmUgdmlzaWJsZS4KLVBBU1MgY29udHJvbHNCYXIuY2xhc3NMaXN0LmNvbnRhaW5zKCdmYWRlZCcp
IGlzIGZhbHNlCi0KLUF1dG8taGlkZSB0aW1lciBoYXMgZWxhcHNlZCwgY29udHJvbHMgYmFyIHNo
b3VsZCBiZSBmYWRlZC4KLVBBU1MgY29udHJvbHNCYXIuY2xhc3NMaXN0LmNvbnRhaW5zKCdmYWRl
ZCcpIGlzIHRydWUKK1BBU1MgISFzaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJy5jb250cm9scy1i
YXInKSBiZWNhbWUgdHJ1ZQorUEFTUyBzaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJy5jb250cm9s
cy1iYXInKS5jbGFzc0xpc3QuY29udGFpbnMoJ2ZhZGVkJykgYmVjYW1lIGZhbHNlCitQQVNTIHNo
YWRvd1Jvb3QucXVlcnlTZWxlY3RvcignLmNvbnRyb2xzLWJhcicpLmNsYXNzTGlzdC5jb250YWlu
cygnZmFkZWQnKSBiZWNhbWUgdHJ1ZQogCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVl
CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9t
ZWRpYS1jb250cm9sbGVyL21lZGlhLWNvbnRyb2xsZXItYXV0by1oaWRlLmh0bWwgYi9MYXlvdXRU
ZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1j
b250cm9sbGVyLWF1dG8taGlkZS5odG1sCmluZGV4IGQ0Njc5NGRhZmE4ZDY2OTZmZTk3YjgwMDA3
M2Y5ODIzZDVlMTkwNTMuLjYyMGQwZmUwOGIwOTdkOWE2YTcxM2FiNTdlZjZlMGVlNDE3YTFhNjkg
MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRp
YS1jb250cm9sbGVyL21lZGlhLWNvbnRyb2xsZXItYXV0by1oaWRlLmh0bWwKKysrIGIvTGF5b3V0
VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEt
Y29udHJvbGxlci1hdXRvLWhpZGUuaHRtbApAQCAtOCwzMyArOCwxOSBAQCB3aW5kb3cuanNUZXN0
SXNBc3luYyA9IHRydWU7CiAKIGRlc2NyaXB0aW9uKCJUZXN0aW5nIHRoZSBjb250cm9scyBiYXIg
ZmFkZXMgb3V0IGFzIGV4cGVjdGVkIGFmdGVyIHRoZSBhdXRvLWhpZGUgZGVsYXkgZXhwaXJlcyB1
cG9uIGZpcnN0IHBsYXkuIik7CiAKLWxldCBjb250cm9sc0JhcjsKLQotZG9jdW1lbnQucXVlcnlT
ZWxlY3RvcigidmlkZW8iKS5hZGRFdmVudExpc3RlbmVyKCJwbGF5IiwgKGV2ZW50KSA9PiB7Ci0g
ICAgY29uc3QgbWVkaWEgPSBldmVudC50YXJnZXQ7Ci0KLSAgICB3aW5kb3cucmVxdWVzdEFuaW1h
dGlvbkZyYW1lKCgpID0+IHsKLSAgICAgICAgY29udHJvbHNCYXIgPSB3aW5kb3cuaW50ZXJuYWxz
LnNoYWRvd1Jvb3QobWVkaWEpLnF1ZXJ5U2VsZWN0b3IoIi5jb250cm9scy1iYXIiKTsKLQotICAg
ICAgICBkZWJ1ZygiVmlkZW8gc3RhcnRlZCBwbGF5aW5nLCBjb250cm9scyBiYXIgaXMgdmlzaWJs
ZSBieSBkZWZhdWx0LiIpOwotICAgICAgICBzaG91bGRCZUZhbHNlKCJjb250cm9sc0Jhci5jbGFz
c0xpc3QuY29udGFpbnMoJ2ZhZGVkJykiKTsKK2NvbnN0IG1lZGlhID0gZG9jdW1lbnQucXVlcnlT
ZWxlY3RvcigidmlkZW8iKTsKK2NvbnN0IHNoYWRvd1Jvb3QgPSB3aW5kb3cuaW50ZXJuYWxzLnNo
YWRvd1Jvb3QobWVkaWEpOworCittZWRpYS5hZGRFdmVudExpc3RlbmVyKCJwbGF5IiwgKGV2ZW50
KSA9PiB7CisgICAgc2hvdWxkQmVjb21lRXF1YWwoIiEhc2hhZG93Um9vdC5xdWVyeVNlbGVjdG9y
KCcuY29udHJvbHMtYmFyJykiLCAidHJ1ZSIsICgpID0+IHsKKyAgICAgICAgc2hvdWxkQmVjb21l
RXF1YWwoInNoYWRvd1Jvb3QucXVlcnlTZWxlY3RvcignLmNvbnRyb2xzLWJhcicpLmNsYXNzTGlz
dC5jb250YWlucygnZmFkZWQnKSIsICJmYWxzZSIsICgpID0+IHsKKyAgICAgICAgICAgIHNob3Vs
ZEJlY29tZUVxdWFsKCJzaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJy5jb250cm9scy1iYXInKS5j
bGFzc0xpc3QuY29udGFpbnMoJ2ZhZGVkJykiLCAidHJ1ZSIsICgpID0+IHsKKyAgICAgICAgICAg
ICAgICBkZWJ1ZygiIik7CisgICAgICAgICAgICAgICAgbWVkaWEucmVtb3ZlKCk7CisgICAgICAg
ICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfSk7CiAg
ICAgfSk7Ci0KLSAgICBzZXRUaW1lb3V0KCgpID0+IHsKLSAgICAgICAgZGVidWcoIiIpOwotICAg
ICAgICBkZWJ1ZygiQXV0by1oaWRlIHRpbWVyIGhhcyBiZWVuIGdvaW5nIGZvciAyMDBtcywgY29u
dHJvbHMgYmFyIHNob3VsZCBzdGlsbCBiZSB2aXNpYmxlLiIpOwotICAgICAgICBzaG91bGRCZUZh
bHNlKCJjb250cm9sc0Jhci5jbGFzc0xpc3QuY29udGFpbnMoJ2ZhZGVkJykiKTsKLSAgICB9LCAy
MDApOwotCi0gICAgc2V0VGltZW91dCgoKSA9PiB7Ci0gICAgICAgIGRlYnVnKCIiKTsKLSAgICAg
ICAgZGVidWcoIkF1dG8taGlkZSB0aW1lciBoYXMgZWxhcHNlZCwgY29udHJvbHMgYmFyIHNob3Vs
ZCBiZSBmYWRlZC4iKTsKLSAgICAgICAgc2hvdWxkQmVUcnVlKCJjb250cm9sc0Jhci5jbGFzc0xp
c3QuY29udGFpbnMoJ2ZhZGVkJykiKTsKLQotICAgICAgICBkZWJ1ZygiIik7Ci0gICAgICAgIG1l
ZGlhLnJlbW92ZSgpOwotICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKLSAgICB9LCAzMDApOwogfSk7
CiAKIDwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RF
eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpp
bmRleCBkYzJlNjgxOGEzNTk4NGYzODBlYTgxZDRlNDM4NDRkOTJlYWQ1N2VkLi5mM2Q3ZGU0ZTg1
ZTkzZTgwZWIxOTc2NzEzZjVlYTE1NTE0YTJhZWUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w
bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t
YWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ3OSw4ICsxNDc5LDYgQEAgbWVkaWEvbW9kZXJuLW1l
ZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxlci1pb3Mtb25seS1l
bmFibGUtdGEKIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS1jb250cm9sbGVyL21l
ZGlhLWNvbnRyb2xsZXItaW9zLWRvLW5vdC1oaWRlLWNvbnRyb2xzLXdoZW4tdGFwcGluZy1idXR0
b24uaHRtbCBbIFNraXAgXQogbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRy
b2xsZXIvbWVkaWEtY29udHJvbGxlci10aWdodC1wYWRkaW5nLmh0bWwgWyBTa2lwIF0KIAotd2Vi
a2l0Lm9yZy9iLzE2NzI2MyBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJv
bGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQog
d2Via2l0Lm9yZy9iLzE2NzI3NSBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXN1
cHBvcnQvdHJhY2tzLXN1cHBvcnQtc2hvdy1wYW5lbC1hZnRlci1kcmFnZ2luZy1jb250cm9scy5o
dG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2NzM0NyBtZWRpYS9tb2Rlcm4t
bWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlk
ZS1tb3VzZS1lbnRlci1hbmQtbW91c2UtbGVhdmUuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>303275</attachid>
            <date>2017-03-02 17:50:26 -0800</date>
            <delta_ts>2017-03-02 18:04:27 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-167263-20170302175025.patch</filename>
            <type>text/plain</type>
            <size>6178</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjY1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2U3ZjVlYjI3MTUyMTg2YTQxNWQ1
NDBjYzVhYTFkMTkzZDNmMzRmZS4uNTJkMThkNTcwNTgyODkzMWE1NDg1OTk4N2NlZjNkNjYyN2Ix
MDJkZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAzLTAyICBBbnRvaW5lIFF1aW50ICA8
Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBtZWRpYS9tb2Rlcm4tbWVk
aWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS5o
dG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xNjcyNjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMwODIxMzk4PgorCisgICAgICAg
IFJldmlld2VkIGJ5IE15bGVzIEMuIE1heGZpZWxkLgorCisgICAgICAgIFNpbmNlIHRpbWluZyBp
cyBoYXJkIHRvIHRlc3QgYWNjdXJhdGVseSwgc2ltcGxpZnkgdGhlIHRlc3QgdG8gb25seSBjaGVj
ayB0aGF0IHdlJ3JlIHRyYW5zaXRpb25pbmcKKyAgICAgICAgZnJvbSBvbmUgc3RhdGUgdG8gYW5v
dGhlciBhbmQgdXNlIHRoZSBhc3luY2hyb25vdXMsIHBvbGxpbmctYmFzZWQgYXNzZXJ0aW9ucyB0
byBjaGVjayB0aGF0IHdlIHdpbGwKKyAgICAgICAgYmUgdHJhbnNpdGlvbmluZyBiZXR3ZWVuIHRo
b3NlIHR3byBzdGF0ZXMgKHZpc2libGUgYW5kIGZhZGVkKS4KKworICAgICAgICAqIG1lZGlhL21v
ZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS1jb250cm9sbGVyL21lZGlhLWNvbnRyb2xsZXItYXV0
by1oaWRlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv
bHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS5odG1sOgorICAg
ICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3LTAzLTAxICBBbnRv
aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0VGVzdCBtZWRp
YS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVy
LXJlc2l6ZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv
bWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJv
bGxlci1hdXRvLWhpZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1l
ZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxlci1hdXRvLWhpZGUt
ZXhwZWN0ZWQudHh0CmluZGV4IDkwODBmNzkxOTc4NGY3OWE2N2Y0YjY1OGM2OTcxNWU1MDMyNjgx
ZDUuLmYxZTQ1OGEzY2U5YWEwMTFiNDYwNjgwOWFkYWU4YTBlMGM1YTNhMWEgMTAwNjQ0Ci0tLSBh
L0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS1jb250cm9sbGVy
L21lZGlhLWNvbnRyb2xsZXItYXV0by1oaWRlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0
cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250
cm9sbGVyLWF1dG8taGlkZS1leHBlY3RlZC50eHQKQEAgLTMsMTQgKzMsOSBAQCBUZXN0aW5nIHRo
ZSBjb250cm9scyBiYXIgZmFkZXMgb3V0IGFzIGV4cGVjdGVkIGFmdGVyIHRoZSBhdXRvLWhpZGUg
ZGVsYXkgZXhwaXJlcwogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNT
IiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVZpZGVvIHN0YXJ0
ZWQgcGxheWluZywgY29udHJvbHMgYmFyIGlzIHZpc2libGUgYnkgZGVmYXVsdC4KLVBBU1MgY29u
dHJvbHNCYXIuY2xhc3NMaXN0LmNvbnRhaW5zKCdmYWRlZCcpIGlzIGZhbHNlCi0KLUF1dG8taGlk
ZSB0aW1lciBoYXMgYmVlbiBnb2luZyBmb3IgMjAwbXMsIGNvbnRyb2xzIGJhciBzaG91bGQgc3Rp
bGwgYmUgdmlzaWJsZS4KLVBBU1MgY29udHJvbHNCYXIuY2xhc3NMaXN0LmNvbnRhaW5zKCdmYWRl
ZCcpIGlzIGZhbHNlCi0KLUF1dG8taGlkZSB0aW1lciBoYXMgZWxhcHNlZCwgY29udHJvbHMgYmFy
IHNob3VsZCBiZSBmYWRlZC4KLVBBU1MgY29udHJvbHNCYXIuY2xhc3NMaXN0LmNvbnRhaW5zKCdm
YWRlZCcpIGlzIHRydWUKK1BBU1MgISFzaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJy5jb250cm9s
cy1iYXInKSBiZWNhbWUgdHJ1ZQorUEFTUyBzaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJy5jb250
cm9scy1iYXInKS5jbGFzc0xpc3QuY29udGFpbnMoJ2ZhZGVkJykgYmVjYW1lIGZhbHNlCitQQVNT
IHNoYWRvd1Jvb3QucXVlcnlTZWxlY3RvcignLmNvbnRyb2xzLWJhcicpLmNsYXNzTGlzdC5jb250
YWlucygnZmFkZWQnKSBiZWNhbWUgdHJ1ZQogCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0
cnVlCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9s
cy9tZWRpYS1jb250cm9sbGVyL21lZGlhLWNvbnRyb2xsZXItYXV0by1oaWRlLmh0bWwgYi9MYXlv
dXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRp
YS1jb250cm9sbGVyLWF1dG8taGlkZS5odG1sCmluZGV4IGQ0Njc5NGRhZmE4ZDY2OTZmZTk3Yjgw
MDA3M2Y5ODIzZDVlMTkwNTMuLjJjN2IyZGFmYmFhZmY3NGZlMzg1ZWVkM2NlYTYwZWMwOGYxYTcw
YTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9t
ZWRpYS1jb250cm9sbGVyL21lZGlhLWNvbnRyb2xsZXItYXV0by1oaWRlLmh0bWwKKysrIGIvTGF5
b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVk
aWEtY29udHJvbGxlci1hdXRvLWhpZGUuaHRtbApAQCAtMSw0MCArMSwyNiBAQAogPCFET0NUWVBF
IGh0bWw+CiA8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48
L3NjcmlwdD4KIDxib2R5PgotPHZpZGVvIHNyYz0iLi4vLi4vY29udGVudC90ZXN0Lm1wNCIgc3R5
bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogMDsgdG9wOiAwOyB3aWR0aDogMzIwcHg7IGhl
aWdodDogMjQwcHg7IiBjb250cm9scyBhdXRvcGxheSBkYXRhLWF1dG8taGlkZS1kZWxheT0iMjUw
Ij48L3ZpZGVvPgorPHZpZGVvIHNyYz0iLi4vLi4vY29udGVudC90ZXN0Lm1wNCIgc3R5bGU9InBv
c2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogMDsgdG9wOiAwOyB3aWR0aDogMzIwcHg7IGhlaWdodDog
MjQwcHg7IiBjb250cm9scyBhdXRvcGxheT48L3ZpZGVvPgogPHNjcmlwdCB0eXBlPSJ0ZXh0L2ph
dmFzY3JpcHQiPgogCiB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CiAKIGRlc2NyaXB0aW9u
KCJUZXN0aW5nIHRoZSBjb250cm9scyBiYXIgZmFkZXMgb3V0IGFzIGV4cGVjdGVkIGFmdGVyIHRo
ZSBhdXRvLWhpZGUgZGVsYXkgZXhwaXJlcyB1cG9uIGZpcnN0IHBsYXkuIik7CiAKLWxldCBjb250
cm9sc0JhcjsKLQotZG9jdW1lbnQucXVlcnlTZWxlY3RvcigidmlkZW8iKS5hZGRFdmVudExpc3Rl
bmVyKCJwbGF5IiwgKGV2ZW50KSA9PiB7Ci0gICAgY29uc3QgbWVkaWEgPSBldmVudC50YXJnZXQ7
Ci0KLSAgICB3aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKCgpID0+IHsKLSAgICAgICAgY29u
dHJvbHNCYXIgPSB3aW5kb3cuaW50ZXJuYWxzLnNoYWRvd1Jvb3QobWVkaWEpLnF1ZXJ5U2VsZWN0
b3IoIi5jb250cm9scy1iYXIiKTsKLQotICAgICAgICBkZWJ1ZygiVmlkZW8gc3RhcnRlZCBwbGF5
aW5nLCBjb250cm9scyBiYXIgaXMgdmlzaWJsZSBieSBkZWZhdWx0LiIpOwotICAgICAgICBzaG91
bGRCZUZhbHNlKCJjb250cm9sc0Jhci5jbGFzc0xpc3QuY29udGFpbnMoJ2ZhZGVkJykiKTsKK2Nv
bnN0IG1lZGlhID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigidmlkZW8iKTsKK2NvbnN0IHNoYWRv
d1Jvb3QgPSB3aW5kb3cuaW50ZXJuYWxzLnNoYWRvd1Jvb3QobWVkaWEpOworCittZWRpYS5hZGRF
dmVudExpc3RlbmVyKCJwbGF5IiwgKGV2ZW50KSA9PiB7CisgICAgc2hvdWxkQmVjb21lRXF1YWwo
IiEhc2hhZG93Um9vdC5xdWVyeVNlbGVjdG9yKCcuY29udHJvbHMtYmFyJykiLCAidHJ1ZSIsICgp
ID0+IHsKKyAgICAgICAgc2hvdWxkQmVjb21lRXF1YWwoInNoYWRvd1Jvb3QucXVlcnlTZWxlY3Rv
cignLmNvbnRyb2xzLWJhcicpLmNsYXNzTGlzdC5jb250YWlucygnZmFkZWQnKSIsICJmYWxzZSIs
ICgpID0+IHsKKyAgICAgICAgICAgIHNob3VsZEJlY29tZUVxdWFsKCJzaGFkb3dSb290LnF1ZXJ5
U2VsZWN0b3IoJy5jb250cm9scy1iYXInKS5jbGFzc0xpc3QuY29udGFpbnMoJ2ZhZGVkJykiLCAi
dHJ1ZSIsICgpID0+IHsKKyAgICAgICAgICAgICAgICBkZWJ1ZygiIik7CisgICAgICAgICAgICAg
ICAgbWVkaWEucmVtb3ZlKCk7CisgICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAg
ICAgICAgICB9KTsKKyAgICAgICAgfSk7CiAgICAgfSk7Ci0KLSAgICBzZXRUaW1lb3V0KCgpID0+
IHsKLSAgICAgICAgZGVidWcoIiIpOwotICAgICAgICBkZWJ1ZygiQXV0by1oaWRlIHRpbWVyIGhh
cyBiZWVuIGdvaW5nIGZvciAyMDBtcywgY29udHJvbHMgYmFyIHNob3VsZCBzdGlsbCBiZSB2aXNp
YmxlLiIpOwotICAgICAgICBzaG91bGRCZUZhbHNlKCJjb250cm9sc0Jhci5jbGFzc0xpc3QuY29u
dGFpbnMoJ2ZhZGVkJykiKTsKLSAgICB9LCAyMDApOwotCi0gICAgc2V0VGltZW91dCgoKSA9PiB7
Ci0gICAgICAgIGRlYnVnKCIiKTsKLSAgICAgICAgZGVidWcoIkF1dG8taGlkZSB0aW1lciBoYXMg
ZWxhcHNlZCwgY29udHJvbHMgYmFyIHNob3VsZCBiZSBmYWRlZC4iKTsKLSAgICAgICAgc2hvdWxk
QmVUcnVlKCJjb250cm9sc0Jhci5jbGFzc0xpc3QuY29udGFpbnMoJ2ZhZGVkJykiKTsKLQotICAg
ICAgICBkZWJ1ZygiIik7Ci0gICAgICAgIG1lZGlhLnJlbW92ZSgpOwotICAgICAgICBmaW5pc2hK
U1Rlc3QoKTsKLSAgICB9LCAzMDApOwogfSk7CiAKIDwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0
Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBkYzJlNjgxOGEzNTk4NGYzODBlYTgxZDRl
NDM4NDRkOTJlYWQ1N2VkLi5mM2Q3ZGU0ZTg1ZTkzZTgwZWIxOTc2NzEzZjVlYTE1NTE0YTJhZWUy
IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwor
KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ3OSw4
ICsxNDc5LDYgQEAgbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIv
bWVkaWEtY29udHJvbGxlci1pb3Mtb25seS1lbmFibGUtdGEKIG1lZGlhL21vZGVybi1tZWRpYS1j
b250cm9scy9tZWRpYS1jb250cm9sbGVyL21lZGlhLWNvbnRyb2xsZXItaW9zLWRvLW5vdC1oaWRl
LWNvbnRyb2xzLXdoZW4tdGFwcGluZy1idXR0b24uaHRtbCBbIFNraXAgXQogbWVkaWEvbW9kZXJu
LW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxlci10aWdodC1w
YWRkaW5nLmh0bWwgWyBTa2lwIF0KIAotd2Via2l0Lm9yZy9iLzE2NzI2MyBtZWRpYS9tb2Rlcm4t
bWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlk
ZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE2NzI3NSBtZWRpYS9tb2Rl
cm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXN1cHBvcnQvdHJhY2tzLXN1cHBvcnQtc2hvdy1wYW5l
bC1hZnRlci1kcmFnZ2luZy1jb250cm9scy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0
Lm9yZy9iLzE2NzM0NyBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxl
ci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS1tb3VzZS1lbnRlci1hbmQtbW91c2UtbGVhdmUu
aHRtbCBbIFBhc3MgRmFpbHVyZSBdCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>