167253 2017-01-20 13:48:20 -0800 LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is flaky 2017-01-25 10:33:26 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad graouts commit-queue graouts oldest_to_newest 1268551 0 ryanhaddad 2017-01-20 13:48:20 -0800 LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is flaky https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r210975%20(2974)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmacos-fullscreen-media-controls%2Fmacos-fullscreen-media-controls-buttons-containers-styles.html --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-actual.txt @@ -3,14 +3,14 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS centerContainerBounds.left is 311 +FAIL centerContainerBounds.left should be 311. Was 346. PASS centerContainerBounds.top is 500 -PASS centerContainerBounds.width is 178 +FAIL centerContainerBounds.width should be 178. Was 108. PASS centerContainerBounds.height is 44 -PASS rightContainerBounds.left is within 0.5 of 493 +FAIL rightContainerBounds.left should be within 0.5 of 493. Was 562. PASS rightContainerBounds.top is 500 -PASS rightContainerBounds.width is within 0.5 of 141 +FAIL rightContainerBounds.width should be within 0.5 of 141. Was 72. PASS rightContainerBounds.height is 44 PASS successfullyParsed is true 1268561 1 ryanhaddad 2017-01-20 14:09:30 -0800 Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/210984 1269766 2 graouts 2017-01-25 02:00:20 -0800 I can get this test to fail fairly reliably with repeated runs and a dedicated instance: Tools/Scripts/run-webkit-tests --debug -1 -g --no-retry --no-sample-on-timeout --time-out-ms=10000 --run-singly --iterations=100 --exit-after-n-failures=1 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html 1269779 3 graouts 2017-01-25 05:05:19 -0800 The problem is a source issue with IconButton where we don't notify the layout delegate when the image metrics has changed, so we can get in situations where the layout of the buttons container is incorrect, based on 0-width buttons. The test itself is correct. 1269780 4 299692 graouts 2017-01-25 05:11:08 -0800 Created attachment 299692 Patch 1269875 5 299692 commit-queue 2017-01-25 10:33:23 -0800 Comment on attachment 299692 Patch Clearing flags on attachment: 299692 Committed r211154: <http://trac.webkit.org/changeset/211154> 1269876 6 commit-queue 2017-01-25 10:33:26 -0800 All reviewed patches have been landed. Closing bug. 299692 2017-01-25 05:11:08 -0800 2017-01-25 10:33:23 -0800 Patch bug-167253-20170125140907.patch text/plain 4078 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2YyOGNjZjdjMDE3NzE1 ODdiNGU2ZTU3MzMwZjljYTk4ZjE5NzYxMy4uOGVhZTdhMjRjZDc1ODVjMTkxYjc5YTMxOGM4YTM5 NTBmOTQyNzM2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTI1ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBtZWRp YS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWFjb3MtZnVsbHNjcmVlbi1tZWRpYS1jb250cm9scy9t YWNvcy1mdWxsc2NyZWVuLW1lZGlhLWNvbnRyb2xzLWJ1dHRvbnMtY29udGFpbmVycy1zdHlsZXMu aHRtbCBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY3MjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQW4gSWNvbkJ1dHRvbiBsb2FkcyBpdHMgaW1hZ2UgYXN5bmNocm9ub3VzbHkgYW5kIHdh aXRzIGZvciBpdHMgbG9hZCB0byBvYnRhaW4gbWV0cmljcy4gT25jZSB0aGF0IGhhcHBlbnMsCisg ICAgICAgIGl0cyBsYXlvdXQgZGVsZWdhdGUgbmVlZHMgdG8gYmUgbm90aWZpZWQgdGhhdCBpdCBu ZWVkcyBhIG5ldyBsYXlvdXQuIFRoZSB0ZXN0IHdhcyBhIGZsYWt5IGZhaWx1cmUgYmVjYXVzZQor ICAgICAgICB0aGUgaW1hZ2VzIHdvdWxkIHNvbWV0aW1lIGxvYWQgcHJpb3IgdG8gbGF5b3V0LCBh bmQgc29tZXRpbWUgYWZ0ZXIsIHdoaWNoIHdvdWxkIGNhdXNlIGEgZmFpbHVyZS4gVGhlIHRlc3QK KyAgICAgICAgaXMgbm93IHJvYnVzdCB3aXRoIGEgY29udHJvbHMgbGF5b3V0IGhhcHBlbmluZyBh ZnRlciBhbGwgYnV0dG9ucyBoYWQgbG9hZGVkLgorCisgICAgICAgICogTW9kdWxlcy9tb2Rlcm4t bWVkaWEtY29udHJvbHMvY29udHJvbHMvaWNvbi1idXR0b24uanM6CisgICAgICAgIChJY29uQnV0 dG9uLnByb3RvdHlwZS5fdXBkYXRlSW1hZ2UpOgorICAgICAgICAoSWNvbkJ1dHRvbik6CisKIDIw MTctMDEtMjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAg ICBGb2xkIFVTRVJfVElNSU5HIGludG8gV0VCX1RJTUlORyBhbmQgbWFrZSBpdCBhIFJ1bnRpbWVF bmFibGVkRmVhdHVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4t bWVkaWEtY29udHJvbHMvY29udHJvbHMvaWNvbi1idXR0b24uanMgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pY29uLWJ1dHRvbi5qcwppbmRl eCA1NzE3YjA0MzRhNmY1MGIxODkyZDMzN2MwNGQ1YTIxZTZlZDczZWUwLi5hYmVjMjJlNDQwYWZk YWQxZTY0OWNkYjlkMDg3YTAwY2Q5YjhlM2UwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pY29uLWJ1dHRvbi5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9p Y29uLWJ1dHRvbi5qcwpAQCAtMTAzLDEwICsxMDMsMTkgQEAgY2xhc3MgSWNvbkJ1dHRvbiBleHRl bmRzIEJ1dHRvbgogCiAgICAgX3VwZGF0ZUltYWdlKCkKICAgICB7Ci0gICAgICAgIHRoaXMud2lk dGggPSB0aGlzLl9pbWFnZS53aWR0aCAvIHdpbmRvdy5kZXZpY2VQaXhlbFJhdGlvOwotICAgICAg ICB0aGlzLmhlaWdodCA9IHRoaXMuX2ltYWdlLmhlaWdodCAvIHdpbmRvdy5kZXZpY2VQaXhlbFJh dGlvOworICAgICAgICBjb25zdCB3aWR0aCA9IHRoaXMuX2ltYWdlLndpZHRoIC8gd2luZG93LmRl dmljZVBpeGVsUmF0aW87CisgICAgICAgIGNvbnN0IGhlaWdodCA9IHRoaXMuX2ltYWdlLmhlaWdo dCAvIHdpbmRvdy5kZXZpY2VQaXhlbFJhdGlvOworCisgICAgICAgIGlmICh0aGlzLndpZHRoID09 PSB3aWR0aCAmJiB0aGlzLmhlaWdodCA9PT0gaGVpZ2h0KQorICAgICAgICAgICAgcmV0dXJuOwor CisgICAgICAgIHRoaXMud2lkdGggPSB3aWR0aDsKKyAgICAgICAgdGhpcy5oZWlnaHQgPSBoZWln aHQ7CiAKICAgICAgICAgdGhpcy5uZWVkc0xheW91dCA9IHRydWU7CisKKyAgICAgICAgaWYgKHRo aXMubGF5b3V0RGVsZWdhdGUpCisgICAgICAgICAgICB0aGlzLmxheW91dERlbGVnYXRlLm5lZWRz TGF5b3V0ID0gdHJ1ZTsKICAgICB9CiAKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1OGEzNzRkOTg0YTA5ZjMyMjAwZDc4 ZDhiMjExOWVlMDBhNDBmNWZmLi41ODc4ZTM2NjM5NDdhZDA1ZmI2NzI3NWY3MjZhNGZjMGI4OGMy ZDAwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDEtMjUgIEFudG9pbmUgUXVpbnQgIDxn cmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0IG1lZGlhL21vZGVybi1tZWRp YS1jb250cm9scy9tYWNvcy1mdWxsc2NyZWVuLW1lZGlhLWNvbnRyb2xzL21hY29zLWZ1bGxzY3Jl ZW4tbWVkaWEtY29udHJvbHMtYnV0dG9ucy1jb250YWluZXJzLXN0eWxlcy5odG1sIGlzIGZsYWt5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcyNTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRl c3Qgc2hvdWxkIG5vIGxvbmdlciBiZSBmbGFreSwgc28gbGV0J3Mgbm90IG1hcmsgaXQgYXMgc3Vj aCBhbnltb3JlLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDE3LTAxLTI0ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAg ICAgICAgTGF5b3V0VGVzdCBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvYWlycGxheS1zdXBw b3J0L2FpcnBsYXktc3VwcG9ydC5odG1sIGlzIGZhaWxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAyMjIzNDkwNjJlOGFmYTIxMGE2MWU4 ZmY0YTUxYzRkNTc5MmViYTZhLi5kMWU1ZjVkYWQ0YzIyNTE4MmJhMzk0NDE3M2E0NjVlMjgxMDJh ZmZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3Rh dGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25z CkBAIC0yOTksOCArMjk5LDYgQEAgbWVkaWEvYWNjZXNzaWJpbGl0eS1jbG9zZWQtY2FwdGlvbnMt aGFzLWFyaWEtb3ducy5odG1sIFsgUGFzcyBDcmFzaCBdCiBtZWRpYS90cmFjay90cmFjay1jdWVz LWVudGVyLWV4aXQuaHRtbCBbIFBhc3MgQ3Jhc2ggXQogbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRy b2xzL3RyYWNrcy1zdXBwb3J0L3RyYWNrcy1zdXBwb3J0LWNsaWNrLXRyYWNrLWluLXBhbmVsLmh0 bWwgWyBQYXNzIFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvMTY3MjUzIG1lZGlhL21vZGVybi1t ZWRpYS1jb250cm9scy9tYWNvcy1mdWxsc2NyZWVuLW1lZGlhLWNvbnRyb2xzL21hY29zLWZ1bGxz Y3JlZW4tbWVkaWEtY29udHJvbHMtYnV0dG9ucy1jb250YWluZXJzLXN0eWxlcy5odG1sIFsgUGFz cyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE2NzMyMCBbIFNpZXJyYSBSZWxlYXNlIF0gbWVk aWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BsYWNhcmQtc3VwcG9ydC9wbGFjYXJkLXN1cHBvcnQt cGlwLmh0bWwgWyBQYXNzIENyYXNoIF0KIAogd2Via2l0Lm9yZy9iLzE2NzM1MiBbIEVsQ2FwaXRh biBEZWJ1ZyBdIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9yZXdpbmQtYnV0dG9uL3Jld2lu ZC1idXR0b24uaHRtbCBbIFBhc3MgVGltZW91dCBdCg==