167245 2017-01-20 11:03:09 -0800 [WebRTC] libwebrtc H.264 codec is using VTB only for IOS 2017-01-23 19:21:03 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen agouaillard commit-queue oldest_to_newest 1268478 0 youennf 2017-01-20 11:03:09 -0800 It could also be activated for MAC as well. 1268479 1 299358 youennf 2017-01-20 11:04:15 -0800 Created attachment 299358 Patch 1268480 2 299358 achristensen 2017-01-20 11:06:41 -0800 Comment on attachment 299358 Patch I assume since this is in the objc subdirectory this won't be used on linux and windows, right? 1268486 3 youennf 2017-01-20 11:18:40 -0800 (In reply to comment #2) > Comment on attachment 299358 [details] > Patch > > I assume since this is in the objc subdirectory this won't be used on linux > and windows, right? Right, BUILD.gn is including this file and directory only for Mac and iOS targets 1268492 4 299358 commit-queue 2017-01-20 11:43:08 -0800 Comment on attachment 299358 Patch Clearing flags on attachment: 299358 Committed r210974: <http://trac.webkit.org/changeset/210974> 1268493 5 commit-queue 2017-01-20 11:43:13 -0800 All reviewed patches have been landed. Closing bug. 1268803 6 agouaillard 2017-01-21 16:26:10 -0800 Not supposing anything about other reasons one would have not to enable this on Mac, what was the first version of MacOS X to support VTB (so we could guard against earlier version in the GN script)? 1268811 7 youennf 2017-01-21 18:06:22 -0800 (In reply to comment #6) > Not supposing anything about other reasons one would have not to enable this > on Mac, > > what was the first version of MacOS X to support VTB (so we could guard > against earlier version in the GN script)? Good point, I'll check that. 1269323 8 agouaillard 2017-01-23 19:21:03 -0800 I saw info saying it should be iOS 8 and MacOSX 10.8? 299358 2017-01-20 11:04:15 -0800 2017-01-20 11:43:08 -0800 Patch bug-167245-20170120110221.patch text/plain 4284 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAxNGM0NmQ3Y2YzZGM0ZmMxOGQ2OTZlYjdjMzQ3ZmM1MWRiNDUwZWUzLi4xOTM1 ZmQ3MDY4OGMzYWI1M2I2MjkzY2NjNzBiZjgzOWMyN2Y3MWRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNy0wMS0yMCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubmZAZ21haWwuY29tPgogCisgICAgICAgIFtXZWJSVENdIGxpYndlYnJ0YyBI LjI2NCBjb2RlYyBpcyB1c2luZyBWVEIgb25seSBmb3IgSU9TCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcyNDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS93ZWJydGMvc2RrL29iamMvRnJh bWV3b3JrL0NsYXNzZXMvdmlkZW90b29sYm94dmlkZW9jb2RlY2ZhY3RvcnkuY2M6IFJlbW92aW5n IFdFQlJUQ19JT1MgZmxhZy4KKworMjAxNy0wMS0yMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubmZA Z21haWwuY29tPgorCiAgICAgICAgIFtXZWJSVENdIGxpYndlYnJ0YyBOT19SRVRVUk4gaXMgY29u ZmxpY3Rpbmcgd2l0aCBXZWJLaXQgb25lCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjcyNDQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvdmlkZW90 b29sYm94dmlkZW9jb2RlY2ZhY3RvcnkuY2MgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMv U291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy92aWRlb3Rvb2xib3h2aWRl b2NvZGVjZmFjdG9yeS5jYwppbmRleCA0YmY3YTRkNTU5NTUwM2Q4OTY3Y2UyMzAwYjExNjYxMWE5 ODE1YzBjLi44Y2VlNGRmOWVkNDM5ZDEyZmQ3OTk2OWE1OWQ0Mzc2OWQyYTZhMGM3IDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9G cmFtZXdvcmsvQ2xhc3Nlcy92aWRlb3Rvb2xib3h2aWRlb2NvZGVjZmFjdG9yeS5jYworKysgYi9T b3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9GcmFtZXdv cmsvQ2xhc3Nlcy92aWRlb3Rvb2xib3h2aWRlb2NvZGVjZmFjdG9yeS5jYwpAQCAtMTIsMTAgKzEy LDggQEAKICNpbmNsdWRlICJ3ZWJydGMvYmFzZS9sb2dnaW5nLmgiCiAjaW5jbHVkZSAid2VicnRj L2NvbW1vbl92aWRlby9oMjY0L3Byb2ZpbGVfbGV2ZWxfaWQuaCIKICNpbmNsdWRlICJ3ZWJydGMv bWVkaWEvYmFzZS9jb2RlYy5oIgotI2lmIGRlZmluZWQoV0VCUlRDX0lPUykKICNpbmNsdWRlICJ3 ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvaDI2NF92aWRlb190b29sYm94X2VuY29k ZXIuaCIKICNpbmNsdWRlICJ3ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvaDI2NF92 aWRlb190b29sYm94X2RlY29kZXIuaCIKLSNlbmRpZgogCiAvLyBUT0RPKGt0aGVsZ2Fzb24pOiBk ZWxldGUgdGhpcyB3aGVuIENyZWF0ZVZpZGVvRGVjb2RlciB0YWtlcwogLy8gYSBjcmlja2V0OjpW aWRlb0NvZGVjIGluc3RlYWQgb2Ygd2VicnRjOjpWaWRlb0NvZGVjVHlwZS4KQEAgLTM4LDcgKzM2 LDYgQEAgbmFtZXNwYWNlIHdlYnJ0YyB7CiAKIFZpZGVvVG9vbGJveFZpZGVvRW5jb2RlckZhY3Rv cnk6OlZpZGVvVG9vbGJveFZpZGVvRW5jb2RlckZhY3RvcnkoKSB7CiAvLyBIYXJkd2FyZSBIMjY0 IGVuY29kaW5nIG9ubHkgc3VwcG9ydGVkIG9uIGlPUyBmb3Igbm93LgotI2lmIGRlZmluZWQoV0VC UlRDX0lPUykKICAgLy8gVE9ETyhtYWdqZWQpOiBQdXNoIENvbnN0cmFpbmVkIEhpZ2ggcHJvZmls ZSBhcyB3ZWxsIHdoZW4gbmVnb3RpYXRpb24gaXMKICAgLy8gcmVhZHksIGh0dHA6Ly9jcmJ1Zy93 ZWJydGMvNjMzNy4KICAgY3JpY2tldDo6VmlkZW9Db2RlYyBjb25zdHJhaW5lZF9iYXNlbGluZShj cmlja2V0OjprSDI2NENvZGVjTmFtZSk7CkBAIC01MiwyOSArNDksMjQgQEAgVmlkZW9Ub29sYm94 VmlkZW9FbmNvZGVyRmFjdG9yeTo6VmlkZW9Ub29sYm94VmlkZW9FbmNvZGVyRmFjdG9yeSgpIHsK ICAgY29uc3RyYWluZWRfYmFzZWxpbmUuU2V0UGFyYW0oY3JpY2tldDo6a0gyNjRGbXRwTGV2ZWxB c3ltbWV0cnlBbGxvd2VkLCAiMSIpOwogICBjb25zdHJhaW5lZF9iYXNlbGluZS5TZXRQYXJhbShj cmlja2V0OjprSDI2NEZtdHBQYWNrZXRpemF0aW9uTW9kZSwgIjEiKTsKICAgc3VwcG9ydGVkX2Nv ZGVjc18ucHVzaF9iYWNrKGNvbnN0cmFpbmVkX2Jhc2VsaW5lKTsKLSNlbmRpZgogfQogCiBWaWRl b1Rvb2xib3hWaWRlb0VuY29kZXJGYWN0b3J5Ojp+VmlkZW9Ub29sYm94VmlkZW9FbmNvZGVyRmFj dG9yeSgpIHt9CiAKIFZpZGVvRW5jb2RlciogVmlkZW9Ub29sYm94VmlkZW9FbmNvZGVyRmFjdG9y eTo6Q3JlYXRlVmlkZW9FbmNvZGVyKAogICAgIGNvbnN0IGNyaWNrZXQ6OlZpZGVvQ29kZWMmIGNv ZGVjKSB7Ci0jaWYgZGVmaW5lZChXRUJSVENfSU9TKQogICBpZiAoRmluZE1hdGNoaW5nQ29kZWMo c3VwcG9ydGVkX2NvZGVjc18sIGNvZGVjKSkgewogICAgIExPRyhMU19JTkZPKSA8PCAiQ3JlYXRp bmcgSFcgZW5jb2RlciBmb3IgIiA8PCBjb2RlYy5uYW1lOwogICAgIHJldHVybiBuZXcgSDI2NFZp ZGVvVG9vbGJveEVuY29kZXIoY29kZWMpOwogICB9Ci0jZW5kaWYKICAgTE9HKExTX0lORk8pIDw8 ICJObyBIVyBlbmNvZGVyIGZvdW5kIGZvciBjb2RlYyAiIDw8IGNvZGVjLm5hbWU7CiAgIHJldHVy biBudWxscHRyOwogfQogCiB2b2lkIFZpZGVvVG9vbGJveFZpZGVvRW5jb2RlckZhY3Rvcnk6OkRl c3Ryb3lWaWRlb0VuY29kZXIoCiAgICAgVmlkZW9FbmNvZGVyKiBlbmNvZGVyKSB7Ci0jaWYgZGVm aW5lZChXRUJSVENfSU9TKQogICBkZWxldGUgZW5jb2RlcjsKICAgZW5jb2RlciA9IG51bGxwdHI7 Ci0jZW5kaWYKIH0KIAogY29uc3Qgc3RkOjp2ZWN0b3I8Y3JpY2tldDo6VmlkZW9Db2RlYz4mCkBA IC04NSw5ICs3Nyw3IEBAIFZpZGVvVG9vbGJveFZpZGVvRW5jb2RlckZhY3Rvcnk6OnN1cHBvcnRl ZF9jb2RlY3MoKSBjb25zdCB7CiAvLyBWaWRlb1Rvb2xib3hWaWRlb0RlY29kZXJGYWN0b3J5CiAK IFZpZGVvVG9vbGJveFZpZGVvRGVjb2RlckZhY3Rvcnk6OlZpZGVvVG9vbGJveFZpZGVvRGVjb2Rl ckZhY3RvcnkoKSB7Ci0jaWYgZGVmaW5lZChXRUJSVENfSU9TKQogICBzdXBwb3J0ZWRfY29kZWNz Xy5wdXNoX2JhY2soY3JpY2tldDo6VmlkZW9Db2RlYygiSDI2NCIpKTsKLSNlbmRpZgogfQogCiBW aWRlb1Rvb2xib3hWaWRlb0RlY29kZXJGYWN0b3J5Ojp+VmlkZW9Ub29sYm94VmlkZW9EZWNvZGVy RmFjdG9yeSgpIHt9CkBAIC05NSwyMiArODUsMTggQEAgVmlkZW9Ub29sYm94VmlkZW9EZWNvZGVy RmFjdG9yeTo6flZpZGVvVG9vbGJveFZpZGVvRGVjb2RlckZhY3RvcnkoKSB7fQogVmlkZW9EZWNv ZGVyKiBWaWRlb1Rvb2xib3hWaWRlb0RlY29kZXJGYWN0b3J5OjpDcmVhdGVWaWRlb0RlY29kZXIo CiAgICAgVmlkZW9Db2RlY1R5cGUgdHlwZSkgewogICBjb25zdCBhdXRvIGNvZGVjID0gY3JpY2tl dDo6VmlkZW9Db2RlYyhOYW1lRnJvbUNvZGVjVHlwZSh0eXBlKSk7Ci0jaWYgZGVmaW5lZChXRUJS VENfSU9TKQogICBpZiAoRmluZE1hdGNoaW5nQ29kZWMoc3VwcG9ydGVkX2NvZGVjc18sIGNvZGVj KSkgewogICAgIExPRyhMU19JTkZPKSA8PCAiQ3JlYXRpbmcgSFcgZGVjb2RlciBmb3IgIiA8PCBj b2RlYy5uYW1lOwogICAgIHJldHVybiBuZXcgSDI2NFZpZGVvVG9vbGJveERlY29kZXIoKTsKICAg fQotI2VuZGlmCiAgIExPRyhMU19JTkZPKSA8PCAiTm8gSFcgZGVjb2RlciBmb3VuZCBmb3IgY29k ZWMgIiA8PCBjb2RlYy5uYW1lOwogICByZXR1cm4gbnVsbHB0cjsKIH0KIAogdm9pZCBWaWRlb1Rv b2xib3hWaWRlb0RlY29kZXJGYWN0b3J5OjpEZXN0cm95VmlkZW9EZWNvZGVyKAogICAgIFZpZGVv RGVjb2RlciogZGVjb2RlcikgewotI2lmIGRlZmluZWQoV0VCUlRDX0lPUykKICAgZGVsZXRlIGRl Y29kZXI7CiAgIGRlY29kZXIgPSBudWxscHRyOwotI2VuZGlmCiB9CiAKIH0gIC8vIG5hbWVzcGFj ZSB3ZWJydGMK