167244 2017-01-20 10:57:15 -0800 [WebRTC] libwebrtc NO_RETURN is conflicting with WebKit one 2017-01-20 17:22:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen commit-queue oldest_to_newest 1268476 0 youennf 2017-01-20 10:57:15 -0800 [WebRTC] libwebrtc NO_RETURN is conflicting with WebKit one 1268477 1 299357 youennf 2017-01-20 10:58:45 -0800 Created attachment 299357 Patch 1268481 2 299357 achristensen 2017-01-20 11:07:25 -0800 Comment on attachment 299357 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299357&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/typedefs.h:113 > This space seems unbalanced. 1268507 3 299365 youennf 2017-01-20 12:01:35 -0800 Created attachment 299365 Patch for landing 1268508 4 youennf 2017-01-20 12:01:52 -0800 Thanks for the review. (In reply to comment #2) > Comment on attachment 299357 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299357&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/typedefs.h:113 > > > > This space seems unbalanced. Fixed. 1268558 5 299365 commit-queue 2017-01-20 14:04:55 -0800 Comment on attachment 299365 Patch for landing Rejecting attachment 299365 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 299365, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ch file(s). patching file Source/ThirdParty/libwebrtc/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/ThirdParty/libwebrtc/Source/webrtc/api/rtpsender.cc Hunk #1 FAILED at 204. 1 out of 1 hunk FAILED -- saving rejects to file Source/ThirdParty/libwebrtc/Source/webrtc/api/rtpsender.cc.rej patching file Source/ThirdParty/libwebrtc/Source/webrtc/typedefs.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2922039 1268581 6 299385 youennf 2017-01-20 14:31:57 -0800 Created attachment 299385 Patch for landing 1268669 7 commit-queue 2017-01-20 17:21:55 -0800 The commit-queue encountered the following flaky tests while processing attachment 299385: media/audio-concurrent-supported.html bug 167251 The commit-queue is continuing to process your patch. 1268670 8 299385 commit-queue 2017-01-20 17:22:24 -0800 Comment on attachment 299385 Patch for landing Clearing flags on attachment: 299385 Committed r211004: <http://trac.webkit.org/changeset/211004> 1268671 9 commit-queue 2017-01-20 17:22:28 -0800 All reviewed patches have been landed. Closing bug. 299357 2017-01-20 10:58:45 -0800 2017-01-20 12:01:29 -0800 Patch bug-167244-20170120105652.patch text/plain 1423 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBlNWQ2ZmZiYTg1NDQ4NDIwMTA3OGNlMzlmYTViNWZhOTI3MjFhZDcxLi4xNGM0 NmQ3Y2YzZGM0ZmMxOGQ2OTZlYjdjMzQ3ZmM1MWRiNDUwZWUzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNy0wMS0yMCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubmZAZ21haWwuY29tPgogCisgICAgICAgIFtXZWJSVENdIGxpYndlYnJ0YyBO T19SRVRVUk4gaXMgY29uZmxpY3Rpbmcgd2l0aCBXZWJLaXQgb25lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcyNDQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS93ZWJydGMvdHlwZWRlZnMu aDogRGVmaW5pbmcgTk9fUkVUVVJOIG9ubHkgaWYgbm90IGFscmVhZHkgZGVmaW5lZC4KKworMjAx Ny0wMS0yMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubmZAZ21haWwuY29tPgorCiAgICAgICAgIFtX ZWJSVENdIFVwZGF0ZSBsaWJ3ZXJ0YyBBdWRpb1J0cFNlbmRlcjo6U2V0QXVkaW9TZW5kCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcyNDMKIApkaWZm IC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvdHlwZWRl ZnMuaCBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3R5cGVkZWZz LmgKaW5kZXggODBhZjhiYWQ1YzQwMjc3YzcwNzQwOTUyMTE3NTNkMDVlYzhlNjE1Zi4uY2U0ZmQ2 MTgwNWMxZGJiNDZhMjJkZTU1MGMzZmVhOTAzODMxMGM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1Ro aXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvdHlwZWRlZnMuaAorKysgYi9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy90eXBlZGVmcy5oCkBAIC05OSw2ICs5 OSw3IEBACiAjZW5kaWYKICNlbmRpZgogCisjaWZuZGVmIE5PX1JFVFVSTgogLy8gQW5ub3RhdGUg YSBmdW5jdGlvbiB0aGF0IHdpbGwgbm90IHJldHVybiBjb250cm9sIGZsb3cgdG8gdGhlIGNhbGxl ci4KICNpZiBkZWZpbmVkKF9NU0NfVkVSKQogI2RlZmluZSBOT19SRVRVUk4gX19kZWNsc3BlYyhu b3JldHVybikKQEAgLTExMCw0ICsxMTEsNiBAQAogI2RlZmluZSBOT19SRVRVUk4KICNlbmRpZgog CisjZW5kaWYgLy8gTk9fUkVUVVJOCisKICNlbmRpZiAgLy8gV0VCUlRDX1RZUEVERUZTX0hfCg== 299365 2017-01-20 12:01:35 -0800 2017-01-20 14:31:53 -0800 Patch for landing bug-167244-20170120115941.patch text/plain 2589 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwOTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAwM2QxM2RhZTgzZDFhNmYwOGE3YWIwYjZlYTI2N2EzZTZkNDQ0NjVjLi4wYmJj ZDgxOTMzYTRiYThmNmI0ZTE4YmYyMDE4YWZjOWUyZTk4YmE0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxNy0wMS0yMCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubmZAZ21haWwuY29tPgorCisgICAgICAgIFtXZWJSVENdIGxpYndlYnJ0YyBO T19SRVRVUk4gaXMgY29uZmxpY3Rpbmcgd2l0aCBXZWJLaXQgb25lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcyNDQKKworICAgICAgICBSZXZpZXdl ZCBieSBBbGV4IENocmlzdGVuc2VuLgorCisgICAgICAgICogU291cmNlL3dlYnJ0Yy90eXBlZGVm cy5oOiBEZWZpbmluZyBOT19SRVRVUk4gb25seSBpZiBub3QgYWxyZWFkeSBkZWZpbmVkLgorCisy MDE3LTAxLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uZkBnbWFpbC5jb20+CisKKyAgICAgICAg W1dlYlJUQ10gVXBkYXRlIGxpYndlcnRjIEF1ZGlvUnRwU2VuZGVyOjpTZXRBdWRpb1NlbmQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzI0MworCisg ICAgICAgIFJldmlld2VkIGJ5IEFsZXggQ2hyaXN0ZW5zZW4uCisKKyAgICAgICAgSW50cm9kdWNp bmcgIFdFQlJUQ19XRUJLSVRfQlVJTEQgbWFjcm8gdG8gbWF0Y2ggZXhpc3RpbmcgV0VCUlRDX0NI Uk9NSVVNX0JVSUxELgorICAgICAgICBXRUJSVENfV0VCS0lUX0JVSUxEIGlzIGRlZmluZWQgYnkg Y3VycmVudCBXZWJLaXQgbGlid2VicnRjIGJ1aWxkIHN5c3RlbS4KKworICAgICAgICAqIFNvdXJj ZS93ZWJydGMvYXBpL3J0cHNlbmRlci5jYzoKKwogMjAxNy0wMS0xOSAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYlJUQ10gVXBsb2FkIGxpYndlYnJ0YyBj b2RlIGJhc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uv d2VicnRjL2FwaS9ydHBzZW5kZXIuY2MgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291 cmNlL3dlYnJ0Yy9hcGkvcnRwc2VuZGVyLmNjCmluZGV4IDJlMDFkOTYxZDQzNjk2ZWY4NzhjNjMz NmM5NTczZjg0OWNkNGE4ODUuLjBkYzc5MTY5ODQ2NDE1ZTUyMDk0OGU0MDg0ZjM4ZmQ4ZTBkMmI0 YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRj L2FwaS9ydHBzZW5kZXIuY2MKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJj ZS93ZWJydGMvYXBpL3J0cHNlbmRlci5jYwpAQCAtMjA0LDcgKzIwNCw3IEBAIHZvaWQgQXVkaW9S dHBTZW5kZXI6OlNldEF1ZGlvU2VuZCgpIHsKICAgICByZXR1cm47CiAgIH0KICAgY3JpY2tldDo6 QXVkaW9PcHRpb25zIG9wdGlvbnM7Ci0jaWYgIWRlZmluZWQoV0VCUlRDX0NIUk9NSVVNX0JVSUxE KQorI2lmICFkZWZpbmVkKFdFQlJUQ19DSFJPTUlVTV9CVUlMRCkgJiYgIWRlZmluZWQoV0VCUlRD X1dFQktJVF9CVUlMRCkKICAgLy8gVE9ETyh0b21taSk6IFJlbW92ZSB0aGlzIGhhY2sgd2hlbiB3 ZSBtb3ZlIENyZWF0ZUF1ZGlvU291cmNlIG91dCBvZgogICAvLyBQZWVyQ29ubmVjdGlvbi4gIFRo aXMgaXMgYSBiaXQgb2YgYSBzdHJhbmdlIHdheSB0byBhcHBseSBsb2NhbCBhdWRpbwogICAvLyBv cHRpb25zIHNpbmNlIGl0IGlzIGFsc28gYXBwbGllZCB0byBhbGwgc3RyZWFtcy9jaGFubmVscywg bG9jYWwgb3IgcmVtb3RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L1NvdXJjZS93ZWJydGMvdHlwZWRlZnMuaCBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9T b3VyY2Uvd2VicnRjL3R5cGVkZWZzLmgKaW5kZXggODBhZjhiYWQ1YzQwMjc3YzcwNzQwOTUyMTE3 NTNkMDVlYzhlNjE1Zi4uZDVmNGFmYWU4N2E3M2NjYzQ1ZDY0MjQ4MWI2MDdjNTRiZjAwMmVmYiAx MDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvdHlw ZWRlZnMuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy90 eXBlZGVmcy5oCkBAIC05OSw2ICs5OSw3IEBACiAjZW5kaWYKICNlbmRpZgogCisjaWZuZGVmIE5P X1JFVFVSTgogLy8gQW5ub3RhdGUgYSBmdW5jdGlvbiB0aGF0IHdpbGwgbm90IHJldHVybiBjb250 cm9sIGZsb3cgdG8gdGhlIGNhbGxlci4KICNpZiBkZWZpbmVkKF9NU0NfVkVSKQogI2RlZmluZSBO T19SRVRVUk4gX19kZWNsc3BlYyhub3JldHVybikKQEAgLTEwOSw1ICsxMTAsNiBAQAogI2Vsc2UK ICNkZWZpbmUgTk9fUkVUVVJOCiAjZW5kaWYKKyNlbmRpZiAvLyBOT19SRVRVUk4KIAogI2VuZGlm ICAvLyBXRUJSVENfVFlQRURFRlNfSF8K 299385 2017-01-20 14:31:57 -0800 2017-01-20 17:22:24 -0800 Patch for landing bug-167244-20170120143004.patch text/plain 1860 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwOTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBjZTkzMjNmZTc1MjhkNjI0NTU2OTFiYmY3ZWJiNzU5ZmU4YTYyN2JkLi42Zjhm OWIyZDBlZWJjNTM4MzBiODZkNDAzYTUxZjVkZjM1NDI3NGFmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNiBAQAogMjAxNy0wMS0yMCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubmZAZ21haWwuY29tPgogCisgICAgICAgIFtXZWJSVENdIGxpYndlYnJ0YyBO T19SRVRVUk4gaXMgY29uZmxpY3Rpbmcgd2l0aCBXZWJLaXQgb25lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcyNDQKKworICAgICAgICBSZXZpZXdl ZCBieSBBbGV4IENocmlzdGVuc2VuLgorCisgICAgICAgICogU291cmNlL3dlYnJ0Yy90eXBlZGVm cy5oOiBEZWZpbmluZyBOT19SRVRVUk4gb25seSBpZiBub3QgYWxyZWFkeSBkZWZpbmVkLgorCisy MDE3LTAxLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uZkBnbWFpbC5jb20+CisKKyAgICAgICAg W1dlYlJUQ10gVXBkYXRlIGxpYndlcnRjIEF1ZGlvUnRwU2VuZGVyOjpTZXRBdWRpb1NlbmQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzI0MworCisg ICAgICAgIFJldmlld2VkIGJ5IEFsZXggQ2hyaXN0ZW5zZW4uCisKKyAgICAgICAgSW50cm9kdWNp bmcgIFdFQlJUQ19XRUJLSVRfQlVJTEQgbWFjcm8gdG8gbWF0Y2ggZXhpc3RpbmcgV0VCUlRDX0NI Uk9NSVVNX0JVSUxELgorICAgICAgICBXRUJSVENfV0VCS0lUX0JVSUxEIGlzIGRlZmluZWQgYnkg Y3VycmVudCBXZWJLaXQgbGlid2VicnRjIGJ1aWxkIHN5c3RlbS4KKworICAgICAgICAqIFNvdXJj ZS93ZWJydGMvYXBpL3J0cHNlbmRlci5jYzoKKworMjAxNy0wMS0yMCAgWW91ZW5uIEZhYmxldCAg PHlvdWVubmZAZ21haWwuY29tPgorCiAgICAgICAgIFtXZWJSVENdIFVwZGF0ZSBsaWJ3ZXJ0YyBB dWRpb1J0cFNlbmRlcjo6U2V0QXVkaW9TZW5kCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcyNDMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFy dHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvdHlwZWRlZnMuaCBiL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3R5cGVkZWZzLmgKaW5kZXggODBhZjhiYWQ1YzQwMjc3 YzcwNzQwOTUyMTE3NTNkMDVlYzhlNjE1Zi4uZDVmNGFmYWU4N2E3M2NjYzQ1ZDY0MjQ4MWI2MDdj NTRiZjAwMmVmYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJj ZS93ZWJydGMvdHlwZWRlZnMuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291 cmNlL3dlYnJ0Yy90eXBlZGVmcy5oCkBAIC05OSw2ICs5OSw3IEBACiAjZW5kaWYKICNlbmRpZgog CisjaWZuZGVmIE5PX1JFVFVSTgogLy8gQW5ub3RhdGUgYSBmdW5jdGlvbiB0aGF0IHdpbGwgbm90 IHJldHVybiBjb250cm9sIGZsb3cgdG8gdGhlIGNhbGxlci4KICNpZiBkZWZpbmVkKF9NU0NfVkVS KQogI2RlZmluZSBOT19SRVRVUk4gX19kZWNsc3BlYyhub3JldHVybikKQEAgLTEwOSw1ICsxMTAs NiBAQAogI2Vsc2UKICNkZWZpbmUgTk9fUkVUVVJOCiAjZW5kaWYKKyNlbmRpZiAvLyBOT19SRVRV Uk4KIAogI2VuZGlmICAvLyBXRUJSVENfVFlQRURFRlNfSF8K