167197 2017-01-19 04:35:31 -0800 [Win] Test output results should not be written twice. 2017-01-20 10:17:11 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue lforschler oldest_to_newest 1268085 0 pvollan 2017-01-19 04:35:31 -0800 Test results indicate that test output is sometimes written twice for the same test, causing flakiness. 1268087 1 299243 pvollan 2017-01-19 04:42:05 -0800 Created attachment 299243 Patch 1268441 2 299243 bfulgham 2017-01-20 09:26:46 -0800 Comment on attachment 299243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299243&action=review r=me > Tools/DumpRenderTree/win/DumpRenderTree.cpp:685 > + It would be good to understand why this happens. Do we need a similar protection in macOS and other platforms? Or does Windows call dump() in more places? 1268444 3 299243 commit-queue 2017-01-20 09:51:35 -0800 Comment on attachment 299243 Patch Clearing flags on attachment: 299243 Committed r210965: <http://trac.webkit.org/changeset/210965> 1268445 4 commit-queue 2017-01-20 09:51:38 -0800 All reviewed patches have been landed. Closing bug. 1268457 5 pvollan 2017-01-20 10:17:11 -0800 (In reply to comment #2) > Comment on attachment 299243 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299243&action=review > > r=me > > > Tools/DumpRenderTree/win/DumpRenderTree.cpp:685 > > + > > It would be good to understand why this happens. Do we need a similar > protection in macOS and other platforms? Or does Windows call dump() in more > places? macOS will not process messages after dump() is called, while Windows will process a few messages before receiving the WM_QUIT message. This opens up for dump() to be called again on Windows. This might happen if the test performs a reload, and calls notifyDone() a second time. Thanks for reviewing! 299243 2017-01-19 04:42:05 -0800 2017-01-20 09:51:35 -0800 Patch bug-167197-20170119044013.patch text/plain 1957 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMDkyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTAxLTE5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBUZXN0IG91dHB1dCByZXN1bHRzIHNob3VsZCBub3QgYmUgd3Jp dHRlbiB0d2ljZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2NzE5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByZXZlbnQgdGVzdCBvdXRwdXQgZnJvbSBiZWluZyB3cml0dGVuIHR3aWNlIGJ5IHJldHVy bmluZyBlYXJseSBmcm9tCisgICAgICAgIHRoZSBkdW1wKCkgZnVuY3Rpb24sIGlmIGl0IGFscmVh ZHkgaGFzIGJlZW4gY2FsbGVkLgorICAgICAgICBUaGlzIHBhdGNoIGFsc28gYWRkcyBhIG1pc3Np bmcgbmV3bGluZSB0byBhIHRlc3Qgb3V0cHV0IGxpbmUuIAorICAgICAgICAKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoZHVtcCk6CisK IDIwMTctMDEtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeCBHVEsrIHVuaXQgdGVzdHMgZmFpbGluZyBzaW5jZSBy MjEwNTMxLgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUu Y3BwCShyZXZpc2lvbiAyMTA5MjIpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJl bmRlclRyZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NzgsNiArNjc4LDExIEBAIHN0YXRpYyB2 b2lkIGludmFsaWRhdGVBbnlQcmV2aW91c1dhaXRUb0QKIAogdm9pZCBkdW1wKCkKIHsKKyAgICBp ZiAoZG9uZSkgeworICAgICAgICBmcHJpbnRmKHN0ZGVyciwgImR1bXAoKSBoYXMgYWxyZWFkeSBi ZWVuIGNhbGxlZCFcbiIpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgOjpJbnZhbGlk YXRlUmVjdCh3ZWJWaWV3V2luZG93LCAwLCBUUlVFKTsKICAgICA6OlNlbmRNZXNzYWdlKHdlYlZp ZXdXaW5kb3csIFdNX1BBSU5ULCAwLCAwKTsKIApAQCAtNzIyLDcgKzcyNyw3IEBAIHZvaWQgZHVt cCgpCiAgICAgICAgICAgICBpZiAoOjpnVGVzdFJ1bm5lci0+ZHVtcEJhY2tGb3J3YXJkTGlzdCgp KQogICAgICAgICAgICAgICAgIGR1bXBCYWNrRm9yd2FyZExpc3RGb3JBbGxXaW5kb3dzKCk7CiAg ICAgICAgIH0gZWxzZQotICAgICAgICAgICAgZnByaW50Zih0ZXN0UmVzdWx0LCAiRVJST1I6IG5p bCByZXN1bHQgZnJvbSAlcyIsIDo6Z1Rlc3RSdW5uZXItPmR1bXBBc1RleHQoKSA/ICJJRE9NRWxl bWVudDo6aW5uZXJUZXh0IiA6ICJJRnJhbWVWaWV3UHJpdmF0ZTo6cmVuZGVyVHJlZUFzRXh0ZXJu YWxSZXByZXNlbnRhdGlvbiIpOworICAgICAgICAgICAgZnByaW50Zih0ZXN0UmVzdWx0LCAiRVJS T1I6IG5pbCByZXN1bHQgZnJvbSAlc1xuIiwgOjpnVGVzdFJ1bm5lci0+ZHVtcEFzVGV4dCgpID8g IklET01FbGVtZW50Ojppbm5lclRleHQiIDogIklGcmFtZVZpZXdQcml2YXRlOjpyZW5kZXJUcmVl QXNFeHRlcm5hbFJlcHJlc2VudGF0aW9uIik7CiAKICAgICAgICAgaWYgKHByaW50U2VwYXJhdG9y cykKICAgICAgICAgICAgIGZwdXRzKCIjRU9GXG4iLCB0ZXN0UmVzdWx0KTsgLy8gdGVybWluYXRl IHRoZSBjb250ZW50IGJsb2NrCg==