167195 2017-01-19 00:03:05 -0800 [GTK] Do not update the backing store state unnecessarily when page visibility changes 2017-01-19 01:01:03 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply calvaris svillar oldest_to_newest 1268058 0 cgarcia 2017-01-19 00:03:05 -0800 I've noticed that we are receiving UpdateBackingStoreState messages in the web process even when size and scale factor didn't change. That's quite unfortunate because we do a lot of work unnecessarily and we tell the threaded compositor that the size changed. This is not only a problem because it's not rue, but also because changing the size is a sync operation in the threade compositor, so we block the compositing thread for nothing. This is happening because the WebPageProxy notifies the drawing area that the backing store is discardable when the page is not visible, and that always produces a new backing store state. In accelerating compositing mode we don't even have a backing store to discard, so we should check we have something to discard and also make sure we only generate a new backing store state if we really discarded the backing store. 1268059 1 299237 cgarcia 2017-01-19 00:06:10 -0800 Created attachment 299237 Patch 1268062 2 svillar 2017-01-19 00:33:13 -0800 Well, perhaps I was too fast. Are we sure that the call to backingStoreStateDidChange(DoNotRespondImmediately); does not have side effects for other platforms?. It might be the case that they don't perform heavy operations but have to do somethin. 1268068 3 cgarcia 2017-01-19 00:45:37 -0800 (In reply to comment #2) > Well, perhaps I was too fast. Are we sure that the call to > backingStoreStateDidChange(DoNotRespondImmediately); does not have side > effects for other platforms?. It might be the case that they don't perform > heavy operations but have to do somethin. I'm sure, because DrawingAreaProxyImpl is only used by GTK+ port :-) 1268071 4 cgarcia 2017-01-19 01:01:03 -0800 Committed r210920: <http://trac.webkit.org/changeset/210920> 299237 2017-01-19 00:06:10 -0800 2017-01-19 00:30:48 -0800 Patch wk2-backing-store-state.diff text/plain 2678 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0YWM4ZTgwOGY0Yi4uM2MwOWJjNzA0ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNy0wMS0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRG8gbm90IHVwZGF0ZSB0aGUgYmFja2luZyBzdG9y ZSBzdGF0ZSB1bm5lY2Vzc2FyaWx5IHdoZW4gcGFnZSB2aXNpYmlsaXR5IGNoYW5nZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzE5NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkndmUgbm90aWNlZCB0 aGF0IHdlIGFyZSByZWNlaXZpbmcgVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUgbWVzc2FnZXMgaW4g dGhlIHdlYiBwcm9jZXNzIGV2ZW4gd2hlbiBzaXplIGFuZCBzY2FsZQorICAgICAgICBmYWN0b3Ig ZGlkbid0IGNoYW5nZS4gVGhhdCdzIHF1aXRlIHVuZm9ydHVuYXRlIGJlY2F1c2Ugd2UgZG8gYSBs b3Qgb2Ygd29yayB1bm5lY2Vzc2FyaWx5IGFuZCB3ZSB0ZWxsIHRoZQorICAgICAgICB0aHJlYWRl ZCBjb21wb3NpdG9yIHRoYXQgdGhlIHNpemUgY2hhbmdlZC4gVGhpcyBpcyBub3Qgb25seSBhIHBy b2JsZW0gYmVjYXVzZSBpdCdzIG5vdCB0cnVlLCBidXQgYWxzbyBiZWNhdXNlCisgICAgICAgIGNo YW5naW5nIHRoZSBzaXplIGlzIGEgc3luYyBvcGVyYXRpb24gaW4gdGhlIHRocmVhZGVkIGNvbXBv c2l0b3IsIHNvIHdlIGJsb2NrIHRoZSBjb21wb3NpdGluZyB0aHJlYWQgZm9yCisgICAgICAgIG5v dGhpbmcuIFRoaXMgaXMgaGFwcGVuaW5nIGJlY2F1c2UgdGhlIFdlYlBhZ2VQcm94eSBub3RpZmll cyB0aGUgZHJhd2luZyBhcmVhIHRoYXQgdGhlIGJhY2tpbmcgc3RvcmUgaXMKKyAgICAgICAgZGlz Y2FyZGFibGUgd2hlbiB0aGUgcGFnZSBpcyBub3QgdmlzaWJsZSwgYW5kIHRoYXQgYWx3YXlzIHBy b2R1Y2VzIGEgbmV3IGJhY2tpbmcgc3RvcmUgc3RhdGUuIEluIGFjY2VsZXJhdGluZworICAgICAg ICBjb21wb3NpdGluZyBtb2RlIHdlIGRvbid0IGV2ZW4gaGF2ZSBhIGJhY2tpbmcgc3RvcmUgdG8g ZGlzY2FyZCwgc28gd2Ugc2hvdWxkIGNoZWNrIHdlIGhhdmUgc29tZXRoaW5nIHRvIGRpc2NhcmQK KyAgICAgICAgYW5kIGFsc28gbWFrZSBzdXJlIHdlIG9ubHkgZ2VuZXJhdGUgYSBuZXcgYmFja2lu ZyBzdG9yZSBzdGF0ZSBpZiB3ZSByZWFsbHkgZGlzY2FyZGVkIHRoZSBiYWNraW5nIHN0b3JlLgor CisgICAgICAgICogVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmNwcDoKKyAgICAgICAg KFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eUltcGw6OmRpc2NhcmRCYWNraW5nU3RvcmVTb29uKToK KyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eUltcGw6OmRpc2NhcmRCYWNraW5nU3Rv cmUpOgorCiAyMDE3LTAxLTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBSZWR1Y2UgcGxhdGZvcm0gaWZkZWZzIGluIFdlYktpdDIgY3VzdG9t IHByb3RvY29scyBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHAKaW5kZXggNDQwZGY5YTMzZWUuLjE0NDUzNTRkN2Rj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUlt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1w bC5jcHAKQEAgLTE3NSw3ICsxNzUsNyBAQCB2b2lkIERyYXdpbmdBcmVhUHJveHlJbXBsOjplbnRl ckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKGNvbnN0IExheWVyVHJlZUNvbnRleAogCiB2b2lk IERyYXdpbmdBcmVhUHJveHlJbXBsOjpkaXNjYXJkQmFja2luZ1N0b3JlU29vbigpCiB7Ci0gICAg aWYgKCFtX2lzQmFja2luZ1N0b3JlRGlzY2FyZGFibGUgfHwgbV9kaXNjYXJkQmFja2luZ1N0b3Jl VGltZXIuaXNBY3RpdmUoKSkKKyAgICBpZiAoIW1fYmFja2luZ1N0b3JlIHx8ICFtX2lzQmFja2lu Z1N0b3JlRGlzY2FyZGFibGUgfHwgbV9kaXNjYXJkQmFja2luZ1N0b3JlVGltZXIuaXNBY3RpdmUo KSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gV2UnbGwgd2FpdCB0aGlzIG1hbnkgc2Vjb25k cyBhZnRlciB0aGUgbGFzdCBwYWludCBiZWZvcmUgdGhyb3dpbmcgYXdheSBvdXIgYmFja2luZyBz dG9yZSB0byBzYXZlIG1lbW9yeS4KQEAgLTE4Nyw2ICsxODcsOCBAQCB2b2lkIERyYXdpbmdBcmVh UHJveHlJbXBsOjpkaXNjYXJkQmFja2luZ1N0b3JlU29vbigpCiAKIHZvaWQgRHJhd2luZ0FyZWFQ cm94eUltcGw6OmRpc2NhcmRCYWNraW5nU3RvcmUoKQogeworICAgIGlmICghbV9iYWNraW5nU3Rv cmUpCisgICAgICAgIHJldHVybjsKICAgICBtX2JhY2tpbmdTdG9yZSA9IG51bGxwdHI7CiAgICAg YmFja2luZ1N0b3JlU3RhdGVEaWRDaGFuZ2UoRG9Ob3RSZXNwb25kSW1tZWRpYXRlbHkpOwogfQo=