167179 2017-01-18 15:01:32 -0800 Add instrumentation for when we fail to receive a message 2017-01-18 15:24:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1267910 0 andersca 2017-01-18 15:01:32 -0800 Add instrumentation for when we fail to receive a message 1267915 1 299193 andersca 2017-01-18 15:10:02 -0800 Created attachment 299193 Patch 1267916 2 299193 ap 2017-01-18 15:13:27 -0800 Comment on attachment 299193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299193&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:500 > + WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x from mach_msg", kr]); Should this be inside ASSERT_ENABLED, so that the message doesn't pollute output in release builds? 1267921 3 andersca 2017-01-18 15:24:20 -0800 Committed r210892: <http://trac.webkit.org/changeset/210892> 299193 2017-01-18 15:10:02 -0800 2017-01-18 15:13:27 -0800 Patch bug-167179-20170118150812.patch text/plain 1387 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDJjNjlmYjU4MDYwN2Y5 ZWQ3MjI4ZWNiYTc1NmFlM2FjYmEzMDBlMy4uNDVmZWYyMzU3MjhhOTk3YmQyNGIzZGU1NTAwODVl Mjk0ZmEyMDM4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGluc3RydW1l bnRhdGlvbiBmb3Igd2hlbiB3ZSBmYWlsIHRvIHJlY2VpdmUgYSBtZXNzYWdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcxNzkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdpbGwgaGVscCB1cyBk aWFnbm9zZSB3aGF0IHRoZSBlcnJvciBmcm9tIG1hY2hfbXNnIGlzLgorCisgICAgICAgICogUGxh dGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tOgorICAgICAgICAoSVBDOjpyZWFkRnJvbU1h Y2hQb3J0KToKKwogMjAxNy0wMS0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBDTWFrZSBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1hYy5tbSBiL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1hYy5tbQppbmRleCBlM2EzZGU1NjEzMzE4 MWFmN2ZiZjQ0YWUyYzI5MDBhMTRmMjVjY2NlLi5mZDdkOTUxNzZkYjAzNTM5YzNhZGY3N2YwYWMw ZTA1NzgwNzBiMTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvbWFj L0Nvbm5lY3Rpb25NYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL21hYy9D b25uZWN0aW9uTWFjLm1tCkBAIC00OTcsNiArNDk3LDcgQEAgc3RhdGljIG1hY2hfbXNnX2hlYWRl cl90KiByZWFkRnJvbU1hY2hQb3J0KG1hY2hfcG9ydF90IG1hY2hQb3J0LCBSZWNlaXZlQnVmZmVy JgogICAgIH0KIAogICAgIGlmIChrciAhPSBNQUNIX01TR19TVUNDRVNTKSB7CisgICAgICAgIFdL U2V0Q3Jhc2hSZXBvcnRBcHBsaWNhdGlvblNwZWNpZmljSW5mb3JtYXRpb24oKENGU3RyaW5nUmVm KVtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiVW5oYW5kbGVkIGVycm9yIGNvZGUgJXggZnJv bSBtYWNoX21zZyIsIGtyXSk7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAg ICByZXR1cm4gMDsKICAgICB9Cg==