167159 2017-01-18 05:46:22 -0800 Crash when changing video subtitles. 2017-01-18 10:47:15 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified macOS 10.12 RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham calvaris cdumez commit-queue eric.carlson esprehn+autocc gyuyoung.kim jonlee philipj webkit-bug-importer oldest_to_newest 1267723 0 pvollan 2017-01-18 05:46:22 -0800 When changing video captions during playback in MiniBrowser, I get an access violation crash with the stack trace: 0 WebCore::Element::getBoundingClientRect() + 32 1 WebCore::VTTRegion::willRemoveTextTrackCueBox(WebCore::VTTCueBox*) + 44 2 WebCore::VTTRegion::willRemoveTextTrackCueBox(WebCore::VTTCueBox*) + 44 3 WebCore::VTTCue::removeDisplayTree() + 72 4 WebCore::TextTrack::setMode(WTF::AtomicString const&) + 320 5 WebCore::HTMLMediaElement::setSelectedTextTrack(WebCore::TextTrack*) + 308 1267725 1 pvollan 2017-01-18 06:00:26 -0800 <rdar://problem/22574001> 1267726 2 299135 pvollan 2017-01-18 06:15:24 -0800 Created attachment 299135 Patch 1267778 3 299135 pvollan 2017-01-18 10:21:41 -0800 Comment on attachment 299135 Patch Thanks for reviewing! 1267787 4 299135 commit-queue 2017-01-18 10:47:10 -0800 Comment on attachment 299135 Patch Clearing flags on attachment: 299135 Committed r210855: <http://trac.webkit.org/changeset/210855> 1267788 5 commit-queue 2017-01-18 10:47:15 -0800 All reviewed patches have been landed. Closing bug. 299135 2017-01-18 06:15:24 -0800 2017-01-18 10:47:10 -0800 Patch bug-167159-20170118151334.patch text/plain 1305 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDg1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIGNoYW5n aW5nIHZpZGVvIHN1YnRpdGxlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NzE1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCBudWxsIHBvaW50ZXIgY2hlY2suCisKKyAgICAgICAgKiBodG1sL3Ry YWNrL1ZUVEN1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWVFRDdWU6OnJlbW92ZURpc3BsYXlU cmVlKToKKwogMjAxNy0wMS0xOCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgog CiAgICAgICAgIFtNb2Rlcm4gTWVkaWEgQ29udHJvbHNdIFR1cm4gbW9kZXJuIG1lZGlhIGNvbnRy b2xzIG9uIGJ5IGRlZmF1bHQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVlRUQ3Vl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1ZUVEN1ZS5jcHAJ KHJldmlzaW9uIDIxMDYyNCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVlRUQ3VlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODM4LDcgKzgzOCw4IEBAIHZvaWQgVlRUQ3VlOjpyZW1vdmVE aXNwbGF5VHJlZSgpCiAgICAgaWYgKG1fbm90aWZ5UmVnaW9uICYmIHRyYWNrKCkpIHsKICAgICAg ICAgaWYgKFZUVFJlZ2lvbkxpc3QqIHJlZ2lvbnMgPSB0cmFjaygpLT5yZWdpb25zKCkpIHsKICAg ICAgICAgICAgIGlmIChWVFRSZWdpb24qIHJlZ2lvbiA9IHJlZ2lvbnMtPmdldFJlZ2lvbkJ5SWQo bV9yZWdpb25JZCkpCi0gICAgICAgICAgICAgICAgcmVnaW9uLT53aWxsUmVtb3ZlVGV4dFRyYWNr Q3VlQm94KG1fZGlzcGxheVRyZWUuZ2V0KCkpOworICAgICAgICAgICAgICAgIGlmIChoYXNEaXNw bGF5VHJlZSgpKQorICAgICAgICAgICAgICAgICAgICByZWdpb24tPndpbGxSZW1vdmVUZXh0VHJh Y2tDdWVCb3gobV9kaXNwbGF5VHJlZS5nZXQoKSk7CiAgICAgICAgIH0KICAgICB9CiAK