167146 2017-01-17 16:39:52 -0800 Web Inspector: "bouncy highlight" element in TextEditor/DOMTreeOutline should update or dismiss when user scrolls 2017-01-30 23:13:12 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1267561 0 bburg 2017-01-17 16:39:52 -0800 This looks dumb. Should be easy to fix. Relevant code is in TextEditor._revealSearchResult and you could use add/removeScrollHandler to detect this and update position or hide it early. You'd need to make sure the animation cancels. 1267562 1 bburg 2017-01-17 16:40:28 -0800 <rdar://problem/14222375> 1271418 2 hi 2017-01-30 14:51:49 -0800 Not sure if I'm just missing something obvious, but what is the "bouncy highlight" element? Do you mean the light-blue line highlight? 1271421 3 hi 2017-01-30 14:58:44 -0800 (In reply to comment #2) > Not sure if I'm just missing something obvious, but what is the "bouncy > highlight" element? Do you mean the light-blue line highlight? Yeah that was a dumb question. Nevermind -.- 1271423 4 300147 hi 2017-01-30 15:00:21 -0800 Created attachment 300147 Patch 1271557 5 300147 timothy 2017-01-30 19:50:57 -0800 Comment on attachment 300147 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300147&action=review > Source/WebInspectorUI/UserInterface/Views/TextEditor.js:1093 > + }; > + this.addScrollHandler(scrollHandler); Add newline between. 1271583 6 300187 hi 2017-01-30 22:34:51 -0800 Created attachment 300187 Patch 1271584 7 300188 hi 2017-01-30 22:35:41 -0800 Created attachment 300188 Patch 1271590 8 300188 commit-queue 2017-01-30 23:13:09 -0800 Comment on attachment 300188 Patch Clearing flags on attachment: 300188 Committed r211408: <http://trac.webkit.org/changeset/211408> 1271591 9 commit-queue 2017-01-30 23:13:12 -0800 All reviewed patches have been landed. Closing bug. 300147 2017-01-30 15:00:21 -0800 2017-01-30 22:34:51 -0800 Patch bug-167146-20170130145811.patch text/plain 2177 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGEwNTU1ZTYxYjFjMGU4NWU0ZDE5NGFlYmU4ZmZj ZTVkZTZmNzRkMDEuLmIzMTNjYzgyNmNmODBjMDM3NzZiMjQ5M2Y2YWYxZGE5NThlMzYzZjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTMwICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6ICJib3VuY3kgaGlnaGxpZ2h0IiBlbGVtZW50IGluIFRleHRFZGl0b3IvRE9NVHJlZU91 dGxpbmUgc2hvdWxkIHVwZGF0ZSBvciBkaXNtaXNzIHdoZW4gdXNlciBzY3JvbGxzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcxNDYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnBy b3RvdHlwZS5fcmV2ZWFsU2VhcmNoUmVzdWx0LnNjcm9sbEhhbmRsZXIpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLl9yZXZlYWxTZWFyY2hSZXN1bHQuYW5pbWF0 aW9uRW5kZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLl9y ZXZlYWxTZWFyY2hSZXN1bHQpOgorCiAyMDE3LTAxLTI4ICBNYXR0IEJha2VyICA8bWF0dGJha2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZWVkIHNvbWUgbGltaXQgb24g QXN5bmMgQ2FsbCBTdGFja3MgZm9yIGFzeW5jIGxvb3BzIChyQUYgbG9vcHMpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5q cwppbmRleCA1MjNkZjc2NDk1YWFmMGRjYTY4YTJkNjIzNWI5Mzc3NWJlMDdiNzI3Li43ODczZDM5 YmEwZmUxNzRmMjJlMDExYjgzOWZkNDYxZmZjMWE4OWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKQEAgLTEw ODYsNiArMTA4NiwxMiBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0 b3IgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICB0aGlzLl9ib3VuY3lIaWdobGln aHRFbGVtZW50LnN0eWxlLmxlZnQgPSBjb29yZGluYXRlcy5sZWZ0ICsgInB4IjsKICAgICAgICAg dGhpcy5lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuX2JvdW5jeUhpZ2hsaWdodEVsZW1lbnQpOwog CisgICAgICAgIGxldCBzY3JvbGxIYW5kbGVyID0gKCkgPT4geworICAgICAgICAgICAgaWYgKHRo aXMuX2JvdW5jeUhpZ2hsaWdodEVsZW1lbnQpCisgICAgICAgICAgICAgICAgdGhpcy5fYm91bmN5 SGlnaGxpZ2h0RWxlbWVudC5yZW1vdmUoKTsKKyAgICAgICAgfTsKKyAgICAgICAgdGhpcy5hZGRT Y3JvbGxIYW5kbGVyKHNjcm9sbEhhbmRsZXIpOworCiAgICAgICAgIGZ1bmN0aW9uIGFuaW1hdGlv bkVuZGVkKCkKICAgICAgICAgewogICAgICAgICAgICAgaWYgKCF0aGlzLl9ib3VuY3lIaWdobGln aHRFbGVtZW50KQpAQCAtMTA5Myw2ICsxMDk5LDggQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3Ig PSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAogICAgICAgICAg ICAgdGhpcy5fYm91bmN5SGlnaGxpZ2h0RWxlbWVudC5yZW1vdmUoKTsKICAgICAgICAgICAgIGRl bGV0ZSB0aGlzLl9ib3VuY3lIaWdobGlnaHRFbGVtZW50OworCisgICAgICAgICAgICB0aGlzLnJl bW92ZVNjcm9sbEhhbmRsZXIoc2Nyb2xsSGFuZGxlcik7CiAgICAgICAgIH0KIAogICAgICAgICAv LyBMaXN0ZW4gZm9yIHRoZSBlbmQgb2YgdGhlIGFuaW1hdGlvbiBzbyB3ZSBjYW4gcmVtb3ZlIHRo ZSBlbGVtZW50Lgo= 300187 2017-01-30 22:34:51 -0800 2017-01-30 22:35:41 -0800 Patch 167146.diff text/plain 2047 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGEwNTU1ZTYuLmIzMTNjYzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTMwICBEZXZpbiBSb3Vzc28g IDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6ICJi b3VuY3kgaGlnaGxpZ2h0IiBlbGVtZW50IGluIFRleHRFZGl0b3IvRE9NVHJlZU91dGxpbmUgc2hv dWxkIHVwZGF0ZSBvciBkaXNtaXNzIHdoZW4gdXNlciBzY3JvbGxzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcxNDYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGV4 dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5f cmV2ZWFsU2VhcmNoUmVzdWx0LnNjcm9sbEhhbmRsZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlRleHRFZGl0b3IucHJvdG90eXBlLl9yZXZlYWxTZWFyY2hSZXN1bHQuYW5pbWF0aW9uRW5kZWQp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLl9yZXZlYWxTZWFy Y2hSZXN1bHQpOgorCiAyMDE3LTAxLTI4ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZWVkIHNvbWUgbGltaXQgb24gQXN5bmMgQ2Fs bCBTdGFja3MgZm9yIGFzeW5jIGxvb3BzIChyQUYgbG9vcHMpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcwppbmRleCA1 MjNkZjc2Li43NzU0ZjMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKQEAgLTEwODYsNiArMTA4NiwxMyBAQCBX ZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5kcyBXZWJJbnNw ZWN0b3IuVmlldwogICAgICAgICB0aGlzLl9ib3VuY3lIaWdobGlnaHRFbGVtZW50LnN0eWxlLmxl ZnQgPSBjb29yZGluYXRlcy5sZWZ0ICsgInB4IjsKICAgICAgICAgdGhpcy5lbGVtZW50LmFwcGVu ZENoaWxkKHRoaXMuX2JvdW5jeUhpZ2hsaWdodEVsZW1lbnQpOwogCisgICAgICAgIGxldCBzY3Jv bGxIYW5kbGVyID0gKCkgPT4geworICAgICAgICAgICAgaWYgKHRoaXMuX2JvdW5jeUhpZ2hsaWdo dEVsZW1lbnQpCisgICAgICAgICAgICAgICAgdGhpcy5fYm91bmN5SGlnaGxpZ2h0RWxlbWVudC5y ZW1vdmUoKTsKKyAgICAgICAgfTsKKworICAgICAgICB0aGlzLmFkZFNjcm9sbEhhbmRsZXIoc2Ny b2xsSGFuZGxlcik7CisKICAgICAgICAgZnVuY3Rpb24gYW5pbWF0aW9uRW5kZWQoKQogICAgICAg ICB7CiAgICAgICAgICAgICBpZiAoIXRoaXMuX2JvdW5jeUhpZ2hsaWdodEVsZW1lbnQpCkBAIC0x MDkzLDYgKzExMDAsOCBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0 b3IgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogCiAgICAgICAgICAgICB0aGlzLl9ib3VuY3lI aWdobGlnaHRFbGVtZW50LnJlbW92ZSgpOwogICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2JvdW5j eUhpZ2hsaWdodEVsZW1lbnQ7CisKKyAgICAgICAgICAgIHRoaXMucmVtb3ZlU2Nyb2xsSGFuZGxl cihzY3JvbGxIYW5kbGVyKTsKICAgICAgICAgfQogCiAgICAgICAgIC8vIExpc3RlbiBmb3IgdGhl IGVuZCBvZiB0aGUgYW5pbWF0aW9uIHNvIHdlIGNhbiByZW1vdmUgdGhlIGVsZW1lbnQuCg== 300188 2017-01-30 22:35:41 -0800 2017-01-30 23:13:09 -0800 Patch 167146.diff text/plain 2048 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGEwNTU1ZTYuLmQxM2E4OWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTMwICBEZXZpbiBSb3Vzc28g IDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6ICJi b3VuY3kgaGlnaGxpZ2h0IiBlbGVtZW50IGluIFRleHRFZGl0b3IvRE9NVHJlZU91dGxpbmUgc2hv dWxkIHVwZGF0ZSBvciBkaXNtaXNzIHdoZW4gdXNlciBzY3JvbGxzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcxNDYKKworICAgICAgICBSZXZpZXdl ZCBieSBUaW1vdGh5IEhhdGNoZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Rl eHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUu X3JldmVhbFNlYXJjaFJlc3VsdC5zY3JvbGxIYW5kbGVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UZXh0RWRpdG9yLnByb3RvdHlwZS5fcmV2ZWFsU2VhcmNoUmVzdWx0LmFuaW1hdGlvbkVuZGVk KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5fcmV2ZWFsU2Vh cmNoUmVzdWx0KToKKwogMjAxNy0wMS0yOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTmVlZCBzb21lIGxpbWl0IG9uIEFzeW5jIENh bGwgU3RhY2tzIGZvciBhc3luYyBsb29wcyAockFGIGxvb3BzKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5kZXgg NTIzZGY3Ni4uNzc1NGYzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCkBAIC0xMDg2LDYgKzEwODYsMTMgQEAg V2ViSW5zcGVjdG9yLlRleHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5z cGVjdG9yLlZpZXcKICAgICAgICAgdGhpcy5fYm91bmN5SGlnaGxpZ2h0RWxlbWVudC5zdHlsZS5s ZWZ0ID0gY29vcmRpbmF0ZXMubGVmdCArICJweCI7CiAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBl bmRDaGlsZCh0aGlzLl9ib3VuY3lIaWdobGlnaHRFbGVtZW50KTsKIAorICAgICAgICBsZXQgc2Ny b2xsSGFuZGxlciA9ICgpID0+IHsKKyAgICAgICAgICAgIGlmICh0aGlzLl9ib3VuY3lIaWdobGln aHRFbGVtZW50KQorICAgICAgICAgICAgICAgIHRoaXMuX2JvdW5jeUhpZ2hsaWdodEVsZW1lbnQu cmVtb3ZlKCk7CisgICAgICAgIH07CisKKyAgICAgICAgdGhpcy5hZGRTY3JvbGxIYW5kbGVyKHNj cm9sbEhhbmRsZXIpOworCiAgICAgICAgIGZ1bmN0aW9uIGFuaW1hdGlvbkVuZGVkKCkKICAgICAg ICAgewogICAgICAgICAgICAgaWYgKCF0aGlzLl9ib3VuY3lIaWdobGlnaHRFbGVtZW50KQpAQCAt MTA5Myw2ICsxMTAwLDggQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRp dG9yIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAogICAgICAgICAgICAgdGhpcy5fYm91bmN5 SGlnaGxpZ2h0RWxlbWVudC5yZW1vdmUoKTsKICAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9ib3Vu Y3lIaWdobGlnaHRFbGVtZW50OworCisgICAgICAgICAgICB0aGlzLnJlbW92ZVNjcm9sbEhhbmRs ZXIoc2Nyb2xsSGFuZGxlcik7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBMaXN0ZW4gZm9yIHRo ZSBlbmQgb2YgdGhlIGFuaW1hdGlvbiBzbyB3ZSBjYW4gcmVtb3ZlIHRoZSBlbGVtZW50Lgo=