167118 2017-01-17 05:42:59 -0800 [GTK] [TextureMapper] [GLES2] Draw repeated patterns for NPOT textures manually 2017-01-18 00:51:31 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cmarcelo commit-queue kondapallykalyan luiz noam oldest_to_newest 1267345 0 magomez 2017-01-17 05:42:59 -0800 Using GLES2, some drivers have problems drawing repeated patterns when using NPOT textures. To avoid this, it's better to manually draw the patterns using the shader. 1267346 1 magomez 2017-01-17 06:01:19 -0800 (In reply to comment #0) > Using GLES2, some drivers have problems drawing repeated patterns when using > NPOT textures. To avoid this, it's better to manually draw the patterns > using the shader. Forgot to mention that this is only a problem when the GL_OES_texture_npot extension is not available. 1267358 2 299034 magomez 2017-01-17 08:23:21 -0800 Created attachment 299034 Patch 1267685 3 299034 commit-queue 2017-01-18 00:51:26 -0800 Comment on attachment 299034 Patch Clearing flags on attachment: 299034 Committed r210847: <http://trac.webkit.org/changeset/210847> 1267686 4 commit-queue 2017-01-18 00:51:31 -0800 All reviewed patches have been landed. Closing bug. 299034 2017-01-17 08:23:21 -0800 2017-01-18 00:51:26 -0800 Patch bug-167118-20170117172132.patch text/plain 6291 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY2YzE3NTA5YWQwZDIw OTM0MzFlMGVhZWFlZTlkNjBmZTdjMDBjOC4uNjljN2VlMzg1NjkyMzBkNjU5NjY2NmY2OGJjYjA4 MTIxNWEyM2U1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTAxLTE3ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gW1RleHR1cmVN YXBwZXJdIFtHTEVTMl0gRHJhdyByZXBlYXRlZCBwYXR0ZXJucyBmb3IgTlBPVCB0ZXh0dXJlcyBt YW51YWxseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY3MTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiB1c2luZyBHTEVTMiB3aXRob3V0IHRoZSBHTF9PRVNfdGV4dHVyZV9ucG90IGV4dGVuc2lv biwgc29tZSBpbXBsZW1lbnRhdGlvbnMgZmFpbCB0byBwcm9wZXJseQorICAgICAgICBkcmF3IHJl cGVhdGVkIHBhdHRlcnMgZnJvbSBhIHRleHR1cmUgKHVzaW5nIEdMX1JFUEVBVCkuIEZvciB0aG9z ZSBjYXNlcywgcGVyZm9ybSB0aGUgcmVwZXRpdGlvbgorICAgICAgICBtYW51YWxseSB1c2luZyB0 aGUgc2hhZGVyLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RlbnQgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmRyaXZlclN1cHBvcnRzTlBPVFRleHR1cmVzKToKKyAgICAgICAgKFdlYkNv cmU6OlRleHR1cmVNYXBwZXJHTDo6ZHJhd1RleHR1cmUpOgorICAgICAgICAoV2ViQ29yZTo6VGV4 dHVyZU1hcHBlckdMOjpkcmF3VGV4dHVyZWRRdWFkV2l0aFByb2dyYW0pOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbTo6Y3JlYXRlKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dy YW0uaDoKKwogMjAxNy0wMS0xNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSB0aGUgUkVRVUVTVF9BTklNQVRJT05fRlJBTUUgZmxhZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckdMLmNwcAppbmRleCAyMTdiYTVkY2FiNDQxNzA3MGEwNGI3MzA0MGRiZWE1MzFh Y2RkNWYxLi5iMzY5NWU4NTBjMzIwYmFmN2I0ODViZDVkYzBiNzZlY2Q4ZmVhMzZmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckdMLmNwcApAQCAtNDE3LDYgKzQxNywxNiBAQCB2b2lkIFRleHR1cmVNYXBwZXJH TDo6ZHJhd1RleHR1cmUoY29uc3QgQml0bWFwVGV4dHVyZSYgdGV4dHVyZSwgY29uc3QgRmxvYXRS ZWN0JgogICAgIGRyYXdUZXh0dXJlKHRleHR1cmVHTC5pZCgpLCB0ZXh0dXJlR0wuaXNPcGFxdWUo KSA/IDAgOiBTaG91bGRCbGVuZCwgdGV4dHVyZUdMLnNpemUoKSwgdGFyZ2V0UmVjdCwgbWF0cml4 LCBvcGFjaXR5LCBleHBvc2VkRWRnZXMpOwogfQogCitzdGF0aWMgYm9vbCBkcml2ZXJTdXBwb3J0 c05QT1RUZXh0dXJlcyhHcmFwaGljc0NvbnRleHQzRCYgY29udGV4dCkKK3sKKyAgICBpZiAoY29u dGV4dC5pc0dMRVMyQ29tcGxpYW50KCkpIHsKKyAgICAgICAgc3RhdGljIGJvb2wgc3VwcG9ydHNO UE9UVGV4dHVyZXMgPSBjb250ZXh0LmdldEV4dGVuc2lvbnMoKS5zdXBwb3J0cygiR0xfT0VTX3Rl eHR1cmVfbnBvdCIpOworICAgICAgICByZXR1cm4gc3VwcG9ydHNOUE9UVGV4dHVyZXM7CisgICAg fQorCisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZvaWQgVGV4dHVyZU1hcHBlckdMOjpkcmF3VGV4 dHVyZShQbGF0Zm9ybTNET2JqZWN0IHRleHR1cmUsIEZsYWdzIGZsYWdzLCBjb25zdCBJbnRTaXpl JiB0ZXh0dXJlU2l6ZSwgY29uc3QgRmxvYXRSZWN0JiB0YXJnZXRSZWN0LCBjb25zdCBUcmFuc2Zv cm1hdGlvbk1hdHJpeCYgbW9kZWxWaWV3TWF0cml4LCBmbG9hdCBvcGFjaXR5LCB1bnNpZ25lZCBl eHBvc2VkRWRnZXMpCiB7CiAgICAgYm9vbCB1c2VSZWN0ID0gZmxhZ3MgJiBTaG91bGRVc2VBUkJU ZXh0dXJlUmVjdDsKQEAgLTQzMyw2ICs0NDMsOCBAQCB2b2lkIFRleHR1cmVNYXBwZXJHTDo6ZHJh d1RleHR1cmUoUGxhdGZvcm0zRE9iamVjdCB0ZXh0dXJlLCBGbGFncyBmbGFncywgY29uc3QgSQog ICAgICAgICBvcHRpb25zIHw9IFRleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtOjpBbnRpYWxpYXNp bmc7CiAgICAgICAgIGZsYWdzIHw9IFNob3VsZEFudGlhbGlhczsKICAgICB9CisgICAgaWYgKHdy YXBNb2RlKCkgPT0gUmVwZWF0V3JhcCAmJiAhZHJpdmVyU3VwcG9ydHNOUE9UVGV4dHVyZXMoKm1f Y29udGV4dDNEKSkKKyAgICAgICAgb3B0aW9ucyB8PSBUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3Jh bTo6TWFudWFsUmVwZWF0OwogCiAgICAgUmVmUHRyPEZpbHRlck9wZXJhdGlvbj4gZmlsdGVyID0g ZGF0YSgpLmZpbHRlckluZm8gPyBkYXRhKCkuZmlsdGVySW5mby0+ZmlsdGVyOiAwOwogICAgIEdD M0R1aW50IGZpbHRlckNvbnRlbnRUZXh0dXJlSUQgPSAwOwpAQCAtNTU0LDcgKzU2Niw3IEBAIHZv aWQgVGV4dHVyZU1hcHBlckdMOjpkcmF3VGV4dHVyZWRRdWFkV2l0aFByb2dyYW0oVGV4dHVyZU1h cHBlclNoYWRlclByb2dyYW0mIHByCiAgICAgR0MzRGVudW0gdGFyZ2V0ID0gZmxhZ3MgJiBTaG91 bGRVc2VBUkJUZXh0dXJlUmVjdCA/IEdDM0RlbnVtKEV4dGVuc2lvbnMzRDo6VEVYVFVSRV9SRUNU QU5HTEVfQVJCKSA6IEdDM0RlbnVtKEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJEKTsKICAg ICBtX2NvbnRleHQzRC0+YmluZFRleHR1cmUodGFyZ2V0LCB0ZXh0dXJlKTsKICAgICBtX2NvbnRl eHQzRC0+dW5pZm9ybTFpKHByb2dyYW0uc2FtcGxlckxvY2F0aW9uKCksIDApOwotICAgIGlmICh3 cmFwTW9kZSgpID09IFJlcGVhdFdyYXApIHsKKyAgICBpZiAod3JhcE1vZGUoKSA9PSBSZXBlYXRX cmFwICYmIGRyaXZlclN1cHBvcnRzTlBPVFRleHR1cmVzKCptX2NvbnRleHQzRCkpIHsKICAgICAg ICAgbV9jb250ZXh0M0QtPnRleFBhcmFtZXRlcmkoR3JhcGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVf MkQsIEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFX1dSQVBfUywgR3JhcGhpY3NDb250ZXh0M0Q6 OlJFUEVBVCk7CiAgICAgICAgIG1fY29udGV4dDNELT50ZXhQYXJhbWV0ZXJpKEdyYXBoaWNzQ29u dGV4dDNEOjpURVhUVVJFXzJELCBHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV9XUkFQX1QsIEdy YXBoaWNzQ29udGV4dDNEOjpSRVBFQVQpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl clNoYWRlclByb2dyYW0uY3BwCmluZGV4IDJkNjUyODA2YjJhNzU3YjYwZWQ5YThiMzRiYzUyODc1 ODg5YmNhYWQuLmIwYzM3MWI5OTM0ZDVhNmQzNTc5MTJiYjc2NWNjMWFlYzlmNDc4NTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyU2hhZGVyUHJvZ3JhbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcApAQCAtMTU5LDYgKzE1OSw3 IEBAIHN0YXRpYyBjb25zdCBjaGFyKiBmcmFnbWVudFRlbXBsYXRlID0KIAogICAgICAgICB2b2lk IG5vb3AoaW5vdXQgdmVjNCBkdW1teVBhcmFtZXRlcikgeyB9CiAgICAgICAgIHZvaWQgbm9vcChp bm91dCB2ZWM0IGR1bW15UGFyYW1ldGVyLCB2ZWMyIHRleENvb3JkKSB7IH0KKyAgICAgICAgdm9p ZCBub29wKGlub3V0IHZlYzIgZHVtbXlQYXJhbWV0ZXIpIHsgfQogCiAgICAgICAgIGZsb2F0IGFu dGlhbGlhcygpIHsgcmV0dXJuIHNtb290aHN0ZXAoMC4sIDEuLCB2X2FudGlhbGlhcyk7IH0KIApA QCAtMTcwLDYgKzE3MSw4IEBAIHN0YXRpYyBjb25zdCBjaGFyKiBmcmFnbWVudFRlbXBsYXRlID0K IAogICAgICAgICB2ZWMyIHZlcnRleFRyYW5zZm9ybVRleENvb3JkKCkgeyByZXR1cm4gdl90cmFu c2Zvcm1lZFRleENvb3JkOyB9CiAKKyAgICAgICAgdm9pZCBhcHBseU1hbnVhbFJlcGVhdChpbm91 dCB2ZWMyIHBvcykgeyBwb3MgPSBmcmFjdChwb3MpOyB9CisKICAgICAgICAgdm9pZCBhcHBseVRl eHR1cmUoaW5vdXQgdmVjNCBjb2xvciwgdmVjMiB0ZXhDb29yZCkgeyBjb2xvciA9IFNhbXBsZXJG dW5jdGlvbihzX3NhbXBsZXIsIHRleENvb3JkKTsgfQogICAgICAgICB2b2lkIGFwcGx5T3BhY2l0 eShpbm91dCB2ZWM0IGNvbG9yKSB7IGNvbG9yICo9IHVfb3BhY2l0eTsgfQogICAgICAgICB2b2lk IGFwcGx5QW50aWFsaWFzaW5nKGlub3V0IHZlYzQgY29sb3IpIHsgY29sb3IgKj0gYW50aWFsaWFz KCk7IH0KQEAgLTI4MSw2ICsyODQsNyBAQCBzdGF0aWMgY29uc3QgY2hhciogZnJhZ21lbnRUZW1w bGF0ZSA9CiAgICAgICAgIHsKICAgICAgICAgICAgIHZlYzQgY29sb3IgPSB2ZWM0KDEuLCAxLiwg MS4sIDEuKTsKICAgICAgICAgICAgIHZlYzIgdGV4Q29vcmQgPSB0cmFuc2Zvcm1UZXhDb29yZCgp OworICAgICAgICAgICAgYXBwbHlNYW51YWxSZXBlYXRJZk5lZWRlZCh0ZXhDb29yZCk7CiAgICAg ICAgICAgICBhcHBseVRleHR1cmVJZk5lZWRlZChjb2xvciwgdGV4Q29vcmQpOwogICAgICAgICAg ICAgYXBwbHlTb2xpZENvbG9ySWZOZWVkZWQoY29sb3IpOwogICAgICAgICAgICAgYXBwbHlBbnRp YWxpYXNpbmdJZk5lZWRlZChjb2xvcik7CkBAIC0zMjMsNiArMzI3LDcgQEAgUmVmPFRleHR1cmVN YXBwZXJTaGFkZXJQcm9ncmFtPiBUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbTo6Y3JlYXRlKFJl ZjxHcmFwaGljc0MKICAgICBTRVRfQVBQTElFUl9GUk9NX09QVElPTlMoQmx1ckZpbHRlcik7CiAg ICAgU0VUX0FQUExJRVJfRlJPTV9PUFRJT05TKEFscGhhQmx1cik7CiAgICAgU0VUX0FQUExJRVJf RlJPTV9PUFRJT05TKENvbnRlbnRUZXh0dXJlKTsKKyAgICBTRVRfQVBQTElFUl9GUk9NX09QVElP TlMoTWFudWFsUmVwZWF0KTsKIAogICAgIFN0cmluZ0J1aWxkZXIgdmVydGV4U2hhZGVyQnVpbGRl cjsKICAgICB2ZXJ0ZXhTaGFkZXJCdWlsZGVyLmFwcGVuZChvcHRpb25zQXBwbGllckJ1aWxkZXIu dG9TdHJpbmcoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5oCmluZGV4 IDkzMDRlOTZmYjYzZDAxNDU4NzhiN2MwZWY4M2ZmNzNmYTYyYTdhZjAuLjU0MWE0MmIyNzM5YmM0 ZWE0NTA3MGNlYWU5MDVjZTQwODIzYjBkNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hh ZGVyUHJvZ3JhbS5oCkBAIC02MCw3ICs2MCw4IEBAIHB1YmxpYzoKICAgICAgICAgT3BhY2l0eUZp bHRlciAgICA9IDFMIDw8IDEzLAogICAgICAgICBCbHVyRmlsdGVyICAgICAgID0gMUwgPDwgMTQs CiAgICAgICAgIEFscGhhQmx1ciAgICAgICAgPSAxTCA8PCAxNSwKLSAgICAgICAgQ29udGVudFRl eHR1cmUgICA9IDFMIDw8IDE2CisgICAgICAgIENvbnRlbnRUZXh0dXJlICAgPSAxTCA8PCAxNiwK KyAgICAgICAgTWFudWFsUmVwZWF0ICAgICA9IDFMIDw8IDE3CiAgICAgfTsKIAogICAgIHR5cGVk ZWYgdW5zaWduZWQgT3B0aW9uczsK