167073 2017-01-15 14:09:01 -0800 Web Inspector: Search Tab should display search results immediately when closing and reopening Inspector 2020-10-27 14:01:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218260 InRadar P2 Normal --- 1 bburg hi commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1267047 0 bburg 2017-01-15 14:09:01 -0800 STEPS TO REPRODUCE: 1. Inspect a page 2. Search for something 3. Select the third search result => Result is revealed in the resource in main content area 4. Close Inspector 5. Reopen Inspector => Search Tab and search term is restored, but no results and empty content area 6. Click in search field, press enter => Third result is automatically selected and shown in its resource It appears that we don't perform the search again on restoring the tab. We should do this right away. When results appear the existing state restoration machinery should just do the right thing. 1267048 1 webkit-bug-importer 2017-01-15 14:09:18 -0800 <rdar://problem/30033540> 1267094 2 298938 hi 2017-01-15 21:56:38 -0800 Created attachment 298938 Patch 1268715 3 298938 commit-queue 2017-01-20 20:52:53 -0800 Comment on attachment 298938 Patch Clearing flags on attachment: 298938 Committed r211010: <http://trac.webkit.org/changeset/211010> 1268716 4 commit-queue 2017-01-20 20:52:56 -0800 All reviewed patches have been landed. Closing bug. 298938 2017-01-15 21:56:38 -0800 2017-01-20 20:52:53 -0800 Patch bug-167073-20170115225453.patch text/plain 3320 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBlZWI4NWI4OThkMjYwYWVhMDQ1ZmE4NDM5MjU4 MDA4YmRhZTc5OTIuLmM1ZjAzMzJiOGRhNGQ5ZjQxNTZhYWU4ZDA0ZjIzNzkxZDNkODRjYzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTE1ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFNlYXJjaCBUYWIgc2hvdWxkIGRpc3BsYXkgc2VhcmNoIHJlc3VsdHMgaW1tZWRpYXRl bHkgd2hlbiBjbG9zaW5nIGFuZCByZW9wZW5pbmcgSW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcwNzMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2Vh cmNoU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNlYXJjaFNpZGViYXJQ YW5lbC5wcm90b3R5cGUuZm9jdXNTZWFyY2hGaWVsZCk6CisgICAgICAgIEFkZCBwYXJhbWV0ZXIg dGhhdCB3aWxsIHRyaWdnZXIgYSBzZWFyY2ggd2l0aCB0aGUgY3VycmVudCBpbnB1dCB2YWx1ZSB3 aGVuIHRydWUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFRhYkNvbnRl bnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNlYXJjaFRhYkNvbnRlbnRWaWV3KToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5TZWFyY2hUYWJDb250ZW50Vmlldy5wcm90b3R5cGUuZm9j dXNTZWFyY2hGaWVsZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2VhcmNoVGFiQ29udGVudFZp ZXcucHJvdG90eXBlLmluaXRpYWxMYXlvdXQpOgorCiAyMDE3LTAxLTE0ICBEZXZpbiBSb3Vzc28g IDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENt ZC0sIHNob3VsZCBvcGVuIFNldHRpbmdzIHRhYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpz CmluZGV4IDY1ZTNlOTlkNjc3YWExOWIzZTVkYWZlMjVmMzg3YTBkNDc3OWI0YjcuLjhkMjViZDBh MDY5NmMyMjgwY2M2NjI0YTJhZjZhNjM3ODRlMzMyNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFy UGFuZWwuanMKQEAgLTY0LDExICs2NCwxNCBAQCBXZWJJbnNwZWN0b3IuU2VhcmNoU2lkZWJhclBh bmVsID0gY2xhc3MgU2VhcmNoU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjdG9yLgogICAg ICAgICBXZWJJbnNwZWN0b3IuRnJhbWUucmVtb3ZlRXZlbnRMaXN0ZW5lcihudWxsLCBudWxsLCB0 aGlzKTsKICAgICB9CiAKLSAgICBmb2N1c1NlYXJjaEZpZWxkKCkKKyAgICBmb2N1c1NlYXJjaEZp ZWxkKHBlcmZvcm1TZWFyY2gpCiAgICAgewogICAgICAgICB0aGlzLnNob3coKTsKIAogICAgICAg ICB0aGlzLl9pbnB1dEVsZW1lbnQuc2VsZWN0KCk7CisKKyAgICAgICAgaWYgKHBlcmZvcm1TZWFy Y2gpCisgICAgICAgICAgICB0aGlzLnBlcmZvcm1TZWFyY2godGhpcy5faW5wdXRFbGVtZW50LnZh bHVlKTsKICAgICB9CiAKICAgICBwZXJmb3JtU2VhcmNoKHNlYXJjaFF1ZXJ5KQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoVGFiQ29u dGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9T ZWFyY2hUYWJDb250ZW50Vmlldy5qcwppbmRleCBjNGRjODFkMWIwY2QyYWQxMWFmYTNmMjUzOWEy MDI0YjJiZjIyYjYyLi5jZWRhYmQ3ODg4NmIzYWE2MWVlMmQxYTA5YzMzN2NiN2YxNGQwZjE5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFy Y2hUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TZWFyY2hUYWJDb250ZW50Vmlldy5qcwpAQCAtMzYsNiArMzYsOCBAQCBXZWJJ bnNwZWN0b3IuU2VhcmNoVGFiQ29udGVudFZpZXcgPSBjbGFzcyBTZWFyY2hUYWJDb250ZW50Vmll dyBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICAgICAgZGV0YWlsc1NpZGViYXJQYW5lbHMucHVz aChXZWJJbnNwZWN0b3IubGF5ZXJUcmVlRGV0YWlsc1NpZGViYXJQYW5lbCk7CiAKICAgICAgICAg c3VwZXIoaWRlbnRpZmllciB8fCAic2VhcmNoIiwgInNlYXJjaCIsIHRhYkJhckl0ZW0sIFdlYklu c3BlY3Rvci5TZWFyY2hTaWRlYmFyUGFuZWwsIGRldGFpbHNTaWRlYmFyUGFuZWxzKTsKKworICAg ICAgICB0aGlzLl9mb3JjZVBlcmZvcm1TZWFyY2ggPSBmYWxzZTsKICAgICB9CiAKICAgICBzdGF0 aWMgdGFiSW5mbygpCkBAIC03MywxMyArNzUsMjQgQEAgV2ViSW5zcGVjdG9yLlNlYXJjaFRhYkNv bnRlbnRWaWV3ID0gY2xhc3MgU2VhcmNoVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbnNwZWMK IAogICAgIGZvY3VzU2VhcmNoRmllbGQoKQogICAgIHsKLSAgICAgICAgdGhpcy5uYXZpZ2F0aW9u U2lkZWJhclBhbmVsLmZvY3VzU2VhcmNoRmllbGQoKTsKKyAgICAgICAgdGhpcy5uYXZpZ2F0aW9u U2lkZWJhclBhbmVsLmZvY3VzU2VhcmNoRmllbGQodGhpcy5fZm9yY2VQZXJmb3JtU2VhcmNoKTsK KworICAgICAgICB0aGlzLl9mb3JjZVBlcmZvcm1TZWFyY2ggPSBmYWxzZTsKICAgICB9CiAKICAg ICBwZXJmb3JtU2VhcmNoKHNlYXJjaFF1ZXJ5KQogICAgIHsKICAgICAgICAgdGhpcy5uYXZpZ2F0 aW9uU2lkZWJhclBhbmVsLnBlcmZvcm1TZWFyY2goc2VhcmNoUXVlcnkpOwogICAgIH0KKworICAg IC8vIFByb3RlY3RlZAorCisgICAgaW5pdGlhbExheW91dCgpCisgICAgeworICAgICAgICBzdXBl ci5pbml0aWFsTGF5b3V0KCk7CisKKyAgICAgICAgdGhpcy5fZm9yY2VQZXJmb3JtU2VhcmNoID0g dHJ1ZTsKKyAgICB9CiB9OwogCiBXZWJJbnNwZWN0b3IuU2VhcmNoVGFiQ29udGVudFZpZXcuVHlw ZSA9ICJzZWFyY2giOwo=