167049 2017-01-14 10:01:51 -0800 WebAssembly: Suppress warnings & errors in GCC 2017-01-14 14:51:56 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo commit-queue dbates keith_miller mark.lam msaboff saam oldest_to_newest 1266812 0 ysuzuki 2017-01-14 10:01:51 -0800 WebAssembly: Suppress warnings & errors in GCC 1266814 1 298855 ysuzuki 2017-01-14 10:14:24 -0800 Created attachment 298855 Patch 1266826 2 298855 ysuzuki 2017-01-14 11:11:53 -0800 Comment on attachment 298855 Patch Thanks :) 1266828 3 298855 commit-queue 2017-01-14 11:36:30 -0800 Comment on attachment 298855 Patch Clearing flags on attachment: 298855 Committed r210769: <http://trac.webkit.org/changeset/210769> 1266829 4 commit-queue 2017-01-14 11:36:35 -0800 All reviewed patches have been landed. Closing bug. 1266847 5 298855 darin 2017-01-14 13:52:10 -0800 Comment on attachment 298855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298855&action=review > Source/JavaScriptCore/ChangeLog:12 > + Add missing { } after the switch. Ideally, it is not necessary. > + But in GCC, it is required. Since this function is fairly large, > + I think the code generated by this does not cause performance > + regression. This has been coming up a *lot* for me. I suspect this is about older versions of GCC, since we see it on the EFL bot and not the GTK bot, but I suppose we need to support those older versions. 1266848 6 298855 darin 2017-01-14 13:52:55 -0800 Comment on attachment 298855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298855&action=review > Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py:130 > +#if COMPILER(GCC) && ASSERT_DISABLED It bothers me a little that this says COMPILER(GCC) if I am correct and the false positive warning does not occurs with newer versions of GCC. 1266852 7 298855 ysuzuki 2017-01-14 14:51:56 -0800 Comment on attachment 298855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298855&action=review >> Source/JavaScriptCore/ChangeLog:12 >> + regression. > > This has been coming up a *lot* for me. I suspect this is about older versions of GCC, since we see it on the EFL bot and not the GTK bot, but I suppose we need to support those older versions. I'm not 100% confident, but I guess this is due to the GCC version. But it is rather caused in the newer GCC I guess. At least, I tested it on GCC 6.3.1 on Fedora 25. It is quite new: 6.3 is released at December 21, 2016. >> Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py:130 >> +#if COMPILER(GCC) && ASSERT_DISABLED > > It bothers me a little that this says COMPILER(GCC) if I am correct and the false positive warning does not occurs with newer versions of GCC. This warning is caused in the GCC at least version 6.3.1. So I think this macro is not meaningless on the very new GCC. 298855 2017-01-14 10:14:24 -0800 2017-01-14 11:36:30 -0800 Patch bug-167049-20170115031241.patch text/plain 5056 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NTJmNzM2NzAzMWU0Zjc2ZDUzZmQzOTZjYjE2Mjk2ZGY0OWU2NTJkLi43ZTcxNjI3ODBmMThmMWJh MmUzODhkZGY3MjM4MDI2NjM2MTY3MWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNyBAQAogMjAxNy0wMS0xNCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAorICAgICAgICBXZWJBc3NlbWJseTogU3VwcHJlc3Mgd2FybmluZ3MgJiBlcnJvcnMg aW4gR0NDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjcwNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHdhc20vV2FzbUZ1bmN0aW9uUGFyc2VyLmg6CisgICAgICAgIEFkZCBtaXNzaW5nIHsgfSBhZnRl ciB0aGUgc3dpdGNoLiBJZGVhbGx5LCBpdCBpcyBub3QgbmVjZXNzYXJ5LgorICAgICAgICBCdXQg aW4gR0NDLCBpdCBpcyByZXF1aXJlZC4gU2luY2UgdGhpcyBmdW5jdGlvbiBpcyBmYWlybHkgbGFy Z2UsCisgICAgICAgIEkgdGhpbmsgdGhlIGNvZGUgZ2VuZXJhdGVkIGJ5IHRoaXMgZG9lcyBub3Qg Y2F1c2UgcGVyZm9ybWFuY2UKKyAgICAgICAgcmVncmVzc2lvbi4KKworICAgICAgICAqIHdhc20v V2FzbVBhZ2VDb3VudC5oOgorICAgICAgICBVSU5UX01BWCBpcyBkZWZpbmVkIGluIGxpbWl0cy5o LgorCisgICAgICAgICogd2FzbS9nZW5lcmF0ZVdhc21WYWxpZGF0ZUlubGluZXNIZWFkZXIucHk6 CisgICAgICAgIE9uIHRoZSBvdGhlciBoYW5kLCB3ZSB1c2UgdGhpcyBzdXBwcmVzcyBwcmFnbWEg aGVyZSB0byBzb2x2ZSB0aGUKKyAgICAgICAgc2FtZSBwcm9ibGVtIGluIHdhc20vV2FzbUZ1bmN0 aW9uUGFyc2VyLmguIFNpbmNlIHRoZSBsb2FkIGZ1bmN0aW9uCisgICAgICAgIGlzIGZhaXJseSBz bWFsbCwgdGhlIGFkZGl0aW9uYWwgYHJldHVybiB7IH07YCBtYXkgZ2VuZXJhdGUgc29tZQorICAg ICAgICBzdWJvcHRpbWFsIGNvZGUuIFNlZSBidWcgMTUwNzk0IGZvciBtb3JlIGRldGFpbC4KKwor MjAxNy0wMS0xNCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KKwogICAg ICAgICBSZXNlcnZlIGNhcGFjaXR5IGZvciBTdHJpbmdCdWlsZGVyIGluIHVuZXNjYXBlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjcwMDgKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRl eCAzYWRkOGU2ZTBiZDFiMjExZTk0YWViMGJkY2NkNWNkMWVjNmY1ZTg1Li40ZjQ0MTY1M2IxMGM4 NDc3MzlkYTk4ZDhhMzBkOGFlM2I2NTQwY2YwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAx LTE0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFdl YkFzc2VtYmx5OiBTdXBwcmVzcyB3YXJuaW5ncyAmIGVycm9ycyBpbiBHQ0MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzA0OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0xFQkRlY29kZXIuaDoK KyAgICAgICAgKFdURjo6TEVCRGVjb2Rlcjo6ZGVjb2RlSW50KToKKyAgICAgICAgSWYgVCA9IGlu dCwgaXQgcGVyZm9ybXMgYC0xIDw8IHNoaWZ0YC4gSXQgY2F1c2VzCisgICAgICAgIHdhcm5pbmcg aW4gR0NDLiBJbnN0ZWFkLCB3ZSBmaXJzdCBjYXN0IGl0IHRvIHRoZQorICAgICAgICBVbnNpZ25l ZFQsIHBlcmZvcm0gb3BlcmF0aW9uIGFuZCByZS1jYXN0IHRvIHRoZQorICAgICAgICBULgorCiAy MDE3LTAxLTEzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIEVOQUJMRShERVRBSUxTX0VMRU1FTlQpIGd1YXJkcwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZ1bmN0aW9uUGFyc2VyLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd2FzbS9XYXNtRnVuY3Rpb25QYXJzZXIuaAppbmRleCAzMTEwNWQ4ODg1N2Iy NWM0YWE4NjljOWMzZjFjOGQyNWYxZmU0MjVjLi42NGUzYjM2ZDM0MGY1NGFjYzY3YTc2MGEyMTBi N2MyYzcyYmZkMmM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNt RnVuY3Rpb25QYXJzZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtRnVu Y3Rpb25QYXJzZXIuaApAQCAtMzI3LDcgKzMyNyw3IEBAIGF1dG8gRnVuY3Rpb25QYXJzZXI8Q29u dGV4dD46OnBhcnNlRXhwcmVzc2lvbihPcFR5cGUgb3ApIC0+IFBhcnRpYWxSZXN1bHQKICAgICAg ICAgaWYgKHJlc3VsdCAhPSBDb250ZXh0OjplbXB0eUV4cHJlc3Npb24pCiAgICAgICAgICAgICBt X2V4cHJlc3Npb25TdGFjay5hcHBlbmQocmVzdWx0KTsKIAotICAgICAgICAgICAgcmV0dXJuIHsg fTsKKyAgICAgICAgcmV0dXJuIHsgfTsKICAgICB9CiAKICAgICBjYXNlIENhbGxJbmRpcmVjdDog ewpAQCAtNTExLDYgKzUxMSw3IEBAIGF1dG8gRnVuY3Rpb25QYXJzZXI8Q29udGV4dD46OnBhcnNl RXhwcmVzc2lvbihPcFR5cGUgb3ApIC0+IFBhcnRpYWxSZXN1bHQKICAgICB9CiAKICAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4geyB9OwogfQogCiAvLyBGSVhNRTogV2Ugc2hv dWxkIHRyeSB0byB1c2UgdGhlIHNhbWUgZGVjb2RlciBmdW5jdGlvbiBmb3IgYm90aCB1bnJlYWNo YWJsZSBhbmQgcmVhY2hhYmxlIGNvZGUuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjU5NjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dh c21QYWdlQ291bnQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21QYWdlQ291bnQu aAppbmRleCA2N2RiYjU1NGM4ZWY1ZTZiYTQxNDExNmRiMWJhYzlhNDA5ZDcwNzU1Li5lNDM4NDdj MDFhOGQyODJhNDQzYmM0Mzg4MWNmMGRiNTBjNWRkNGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd2FzbS9XYXNtUGFnZUNvdW50LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbVBhZ2VDb3VudC5oCkBAIC0yNyw2ICsyNyw4IEBACiAKICNpZiBFTkFCTEUo V0VCQVNTRU1CTFkpCiAKKyNpbmNsdWRlIDxsaW1pdHMuaD4KKwogbmFtZXNwYWNlIFdURiB7CiBj bGFzcyBQcmludFN0cmVhbTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 YXNtL2dlbmVyYXRlV2FzbVZhbGlkYXRlSW5saW5lc0hlYWRlci5weSBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL2dlbmVyYXRlV2FzbVZhbGlkYXRlSW5saW5lc0hlYWRlci5weQppbmRleCA1 MmI2NmIxZTZjNjQyZDVjMzFhYWU5MWY0MmE0OTBjMzhmNzAxYjIwLi5jM2QzNzEyNTFhZjNiZDM4 ODMxNTk4Y2NjZDVhN2E3ZTIxYzZiN2NjIDEwMDc1NQotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd2FzbS9nZW5lcmF0ZVdhc21WYWxpZGF0ZUlubGluZXNIZWFkZXIucHkKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3dhc20vZ2VuZXJhdGVXYXNtVmFsaWRhdGVJbmxpbmVzSGVhZGVyLnB5 CkBAIC0xMjUsNiArMTI1LDEzIEBAIGRlZiBzdG9yZU1hY3JvKG5hbWUpOgogCiAjaWYgRU5BQkxF KFdFQkFTU0VNQkxZKQogCisjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgorCisjaWYgQ09N UElMRVIoR0NDKSAmJiBBU1NFUlRfRElTQUJMRUQKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcHVz aAorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBpZ25vcmVkICItV3JldHVybi10eXBlIgorI2VuZGlm IC8vIENPTVBJTEVSKEdDQykgJiYgQVNTRVJUX0RJU0FCTEVECisKIG5hbWVzcGFjZSBKU0MgeyBu YW1lc3BhY2UgV2FzbSB7CiAKICIiIiArIHVuYXJ5U3BlY2lhbGl6YXRpb25zICsgYmluYXJ5U3Bl Y2lhbGl6YXRpb25zICsgIiIiCkBAIC0xNTEsNiArMTU4LDEwIEBAIGRlZiBzdG9yZU1hY3JvKG5h bWUpOgogCiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6V2FzbQogCisjaWYgQ09NUElMRVIoR0NDKSAm JiBBU1NFUlRfRElTQUJMRUQKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcG9wCisjZW5kaWYgLy8g Q09NUElMRVIoR0NDKSAmJiBBU1NFUlRfRElTQUJMRUQKKwogI2VuZGlmIC8vIEVOQUJMRShXRUJB U1NFTUJMWSkKIAogIiIiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9MRUJEZWNvZGVyLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9MRUJEZWNvZGVyLmgKaW5kZXggMWQ0ODE3NjljNmRjYjViZmNiYzhl ZjUwMmE4YTdlODM4MDFmODhjNC4uZTE0YTUyNzk2MjVkNWI2NDliMjgwNzQ3MzcwZWZkNDQ5N2Fi ZGU0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTEVCRGVjb2Rlci5oCisrKyBiL1NvdXJj ZS9XVEYvd3RmL0xFQkRlY29kZXIuaApAQCAtNzgsOCArNzgsOSBAQCBpbmxpbmUgYm9vbCBXQVJO X1VOVVNFRF9SRVRVUk4gZGVjb2RlSW50KGNvbnN0IHVpbnQ4X3QqIGJ5dGVzLCBzaXplX3QgbGVu Z3RoLCBzaQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAgIHVzaW5nIFVu c2lnbmVkVCA9IHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZDxUPjo6dHlwZTsKICAgICBpZiAo c2hpZnQgPCBudW1CaXRzICYmIChieXRlICYgMHg0MCkpCi0gICAgICAgIHJlc3VsdCB8PSBzdGF0 aWNfY2FzdDxUPigtMSkgPDwgc2hpZnQ7CisgICAgICAgIHJlc3VsdCA9IHN0YXRpY19jYXN0PFQ+ KHN0YXRpY19jYXN0PFVuc2lnbmVkVD4ocmVzdWx0KSB8IChzdGF0aWNfY2FzdDxVbnNpZ25lZFQ+ KC0xKSA8PCBzaGlmdCkpOwogICAgIHJldHVybiB0cnVlOwogfQogCg==