167046 2017-01-13 23:31:01 -0800 Remove unused WKView initializer parameter 2017-01-14 01:02:21 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca beidson commit-queue mitz oldest_to_newest 1266786 0 thorton 2017-01-13 23:31:01 -0800 Remove unused WKView initializer parameter 1266787 1 298850 thorton 2017-01-13 23:31:18 -0800 Created attachment 298850 Patch 1266788 2 thorton 2017-01-13 23:31:56 -0800 There is some further cleanup to be done in WebViewImpl and PageClientImpl, but that will be more hairy. 1266793 3 298850 commit-queue 2017-01-14 01:02:18 -0800 Comment on attachment 298850 Patch Clearing flags on attachment: 298850 Committed r210765: <http://trac.webkit.org/changeset/210765> 1266794 4 commit-queue 2017-01-14 01:02:21 -0800 All reviewed patches have been landed. Closing bug. 298850 2017-01-13 23:31:18 -0800 2017-01-14 01:02:18 -0800 Patch bug-167046-20170113232935.patch text/plain 4316 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWIzN2UxODgzMGQ2NTZj N2I5YTRkYjUyN2QzZDgzMzhlNjljODViZS4uNmFkNDU1ZWE3Y2E3ZWZmYTcxMjFjNjliODBlYTU3 YTNjOGM0OWEzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTEzICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVz ZWQgV0tWaWV3IGluaXRpYWxpemVyIHBhcmFtZXRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06Cisg ICAgICAgICgtW1dLVmlldyBpbml0V2l0aEZyYW1lOnByb2Nlc3NQb29sOmNvbmZpZ3VyYXRpb246 XSk6CisgICAgICAgICgtW1dLVmlldyBpbml0V2l0aEZyYW1lOmNvbnRleHRSZWY6cGFnZUdyb3Vw UmVmOnJlbGF0ZWRUb1BhZ2U6XSk6CisgICAgICAgICgtW1dLVmlldyBpbml0V2l0aEZyYW1lOmNv bmZpZ3VyYXRpb25SZWY6XSk6CisgICAgICAgICgtW1dLVmlldyBpbml0V2l0aEZyYW1lOnByb2Nl c3NQb29sOmNvbmZpZ3VyYXRpb246d2ViVmlldzpdKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oOgorICAgICAgICBFdmVyIHNpbmNlIFdLV2Vi VmlldyBzdG9wcGVkIGhhdmluZyBXS1ZpZXcgaW5zaWRlIGl0LCB0aGlzIHBhcmFtZXRlcgorICAg ICAgICBoYXMgbmV2ZXIgYmVlbiB1c2VkLiBOb3csIGl0IG9ubHkgbGVhZHMgdG8gY29uZnVzaW9u LgorCiAyMDE3LTAxLTEzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIEVOQUJMRShERVRBSUxTX0VMRU1FTlQpIGd1YXJkcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmluZGV4IDU4MGM4NzA3NDFkMDY0ZGIy ZjU1N2I0MmQ0ZjM0YjE1Y2RkMGFlOGQuLjMyNDFjNDM5YWFiMmNkYTM0MjZlZTFkZWM1ZmY5M2Uw ZWE3YjM5YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dL Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0K QEAgLTg5NSw3ICs4OTUsNyBAQCBTb21lIG90aGVyIGVkaXRpbmctcmVsYXRlZCBtZXRob2RzIHN0 aWxsIHVuaW1wbGVtZW50ZWQ6CiAjZW5kaWYgLy8gV0tfQVBJX0VOQUJMRUQKIH0KIAotLSAoaW5z dGFuY2V0eXBlKWluaXRXaXRoRnJhbWU6KE5TUmVjdClmcmFtZSBwcm9jZXNzUG9vbDooV2ViUHJv Y2Vzc1Bvb2wmKXByb2Nlc3NQb29sIGNvbmZpZ3VyYXRpb246KFJlZjxBUEk6OlBhZ2VDb25maWd1 cmF0aW9uPiYmKWNvbmZpZ3VyYXRpb24gd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldworLSAo aW5zdGFuY2V0eXBlKWluaXRXaXRoRnJhbWU6KE5TUmVjdClmcmFtZSBwcm9jZXNzUG9vbDooV2Vi UHJvY2Vzc1Bvb2wmKXByb2Nlc3NQb29sIGNvbmZpZ3VyYXRpb246KFJlZjxBUEk6OlBhZ2VDb25m aWd1cmF0aW9uPiYmKWNvbmZpZ3VyYXRpb24KIHsKICAgICBzZWxmID0gW3N1cGVyIGluaXRXaXRo RnJhbWU6ZnJhbWVdOwogICAgIGlmICghc2VsZikKQEAgLTkwNCw3ICs5MDQsNyBAQCBTb21lIG90 aGVyIGVkaXRpbmctcmVsYXRlZCBtZXRob2RzIHN0aWxsIHVuaW1wbGVtZW50ZWQ6CiAgICAgSW5p dGlhbGl6ZVdlYktpdDIoKTsKIAogICAgIF9kYXRhID0gW1tXS1ZpZXdEYXRhIGFsbG9jXSBpbml0 XTsKLSAgICBfZGF0YS0+X2ltcGwgPSBzdGQ6Om1ha2VfdW5pcXVlPFdlYlZpZXdJbXBsPihzZWxm LCB3ZWJWaWV3LCBwcm9jZXNzUG9vbCwgV1RGTW92ZShjb25maWd1cmF0aW9uKSk7CisgICAgX2Rh dGEtPl9pbXBsID0gc3RkOjptYWtlX3VuaXF1ZTxXZWJWaWV3SW1wbD4oc2VsZiwgbnVsbHB0ciwg cHJvY2Vzc1Bvb2wsIFdURk1vdmUoY29uZmlndXJhdGlvbikpOwogCiAgICAgW3NlbGYgbWF5YmVJ bnN0YWxsSWNvbkxvYWRpbmdDbGllbnRdOwogCkBAIC0xMDk5LDcgKzEwOTksNyBAQCBzdGF0aWMg V2ViQ29yZTo6VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbiB0b1VzZXJJbnRlcmZhY2VMYXlv dXREaXJlY3Rpb24oTlNVcwogICAgIGNvbmZpZ3VyYXRpb24tPnByZWZlcmVuY2VWYWx1ZXMoKS5z ZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNlc0tleTo6c3lzdGVtTGF5b3V0RGlyZWN0aW9uS2V5KCks IFdlYktpdDo6V2ViUHJlZmVyZW5jZXNTdG9yZTo6VmFsdWUoc3RhdGljX2Nhc3Q8dWludDMyX3Q+ KHRvVXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbihzZWxmLnVzZXJJbnRlcmZhY2VMYXlvdXRE aXJlY3Rpb24pKSkpOwogI2VuZGlmCiAKLSAgICByZXR1cm4gW3NlbGYgaW5pdFdpdGhGcmFtZTpm cmFtZSBwcm9jZXNzUG9vbDoqdG9JbXBsKGNvbnRleHRSZWYpIGNvbmZpZ3VyYXRpb246V1RGTW92 ZShjb25maWd1cmF0aW9uKSB3ZWJWaWV3Om5pbF07CisgICAgcmV0dXJuIFtzZWxmIGluaXRXaXRo RnJhbWU6ZnJhbWUgcHJvY2Vzc1Bvb2w6KnRvSW1wbChjb250ZXh0UmVmKSBjb25maWd1cmF0aW9u OldURk1vdmUoY29uZmlndXJhdGlvbildOwogfQogCiAtIChpZClpbml0V2l0aEZyYW1lOihOU1Jl Y3QpZnJhbWUgY29uZmlndXJhdGlvblJlZjooV0tQYWdlQ29uZmlndXJhdGlvblJlZiljb25maWd1 cmF0aW9uUmVmCkBAIC0xMTA3LDcgKzExMDcsNyBAQCBzdGF0aWMgV2ViQ29yZTo6VXNlckludGVy ZmFjZUxheW91dERpcmVjdGlvbiB0b1VzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb24oTlNVcwog ICAgIFJlZjxBUEk6OlBhZ2VDb25maWd1cmF0aW9uPiBjb25maWd1cmF0aW9uID0gdG9JbXBsKGNv bmZpZ3VyYXRpb25SZWYpLT5jb3B5KCk7CiAgICAgYXV0byYgcHJvY2Vzc1Bvb2wgPSAqY29uZmln dXJhdGlvbi0+cHJvY2Vzc1Bvb2woKTsKIAotICAgIHJldHVybiBbc2VsZiBpbml0V2l0aEZyYW1l OmZyYW1lIHByb2Nlc3NQb29sOnByb2Nlc3NQb29sIGNvbmZpZ3VyYXRpb246V1RGTW92ZShjb25m aWd1cmF0aW9uKSB3ZWJWaWV3Om5pbF07CisgICAgcmV0dXJuIFtzZWxmIGluaXRXaXRoRnJhbWU6 ZnJhbWUgcHJvY2Vzc1Bvb2w6cHJvY2Vzc1Bvb2wgY29uZmlndXJhdGlvbjpXVEZNb3ZlKGNvbmZp Z3VyYXRpb24pXTsKIH0KIAogLSAoQk9PTCl3YW50c1VwZGF0ZUxheWVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJuYWwuaAppbmRleCA3NmM2YzBj MWU5YjRhMTBlNGMwMmRlMDI2ZTFkZWZkN2M1ZjkxMDJhLi5lMWVmMWVlZTNmMDM5YTllMDE4MTMy NWIxMTExNjY2NDJkYzQ4ZDQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlld0ludGVybmFsLmgKQEAgLTMxLDI1ICszMSwxMiBAQAogI2ltcG9ydCA8d3Rm L1JldGFpblB0ci5oPgogI2ltcG9ydCA8d3RmL1ZlY3Rvci5oPgogCi1uYW1lc3BhY2UgQVBJIHsK LWNsYXNzIFBhZ2VDb25maWd1cmF0aW9uOwotfQotCi1uYW1lc3BhY2UgV2ViS2l0IHsKLWNsYXNz IFdlYlByb2Nlc3NQb29sOwotfQotCi1AY2xhc3MgV0tXZWJWaWV3OwogI2lmIFdLX0FQSV9FTkFC TEVECiBAY2xhc3MgX1dLVGh1bWJuYWlsVmlldzsKLSNlbmRpZgogCiBAaW50ZXJmYWNlIFdLVmll dyAoKQotI2lmIFdLX0FQSV9FTkFCTEVECi0tIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhGcmFtZToo TlNSZWN0KWZyYW1lIHByb2Nlc3NQb29sOihXZWJLaXQ6OldlYlByb2Nlc3NQb29sJilwcm9jZXNz UG9vbCBjb25maWd1cmF0aW9uOihSZWY8QVBJOjpQYWdlQ29uZmlndXJhdGlvbj4mJiljb25maWd1 cmF0aW9uIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXc7CiBAcHJvcGVydHkgKG5vbmF0b21p Yywgc2V0dGVyPV9zZXRUaHVtYm5haWxWaWV3OikgX1dLVGh1bWJuYWlsVmlldyAqX3RodW1ibmFp bFZpZXc7Ci0jZW5kaWYKLQogQGVuZAorI2VuZGlmCiAKICNlbmRpZgo=