16704 2008-01-01 22:17:31 -0800 input with type="hidden" matches :enabled/:disabled (Acid3 bug) 2008-01-04 22:42:06 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED NeedsReduction P2 Normal --- 1 eric bdakin bdakin oldest_to_newest 65990 0 eric 2008-01-01 22:17:31 -0800 input with type="hidden" matches :enabled/:disabled (Acid3 bug) function () { // test 42: :enabled, :disabled, :checked, etc selectorTest(function (doc, add, expect) { var input = doc.createElement('input'); input.type = 'checkbox'; doc.body.appendChild(input); var neither = 0; var both = add(":checked:enabled"); var checked = add(":checked"); var enabled = add(":enabled"); expect(doc.body, neither, "control failure"); expect(input, enabled, "input element didn't match :enabled"); input.click(); expect(input, both, "input element didn't match :checked"); input.disabled = true; expect(input, checked, "failure 3"); input.checked = false; expect(input, neither, "failure 4"); expect(doc.body, neither, "failure 5"); }); selectorTest(function (doc, add, expect) { var input1 = doc.createElement('input'); input1.type = 'radio'; input1.name = 'radio'; doc.body.appendChild(input1); var input2 = doc.createElement('input'); input2.type = 'radio'; input2.name = 'radio'; doc.body.appendChild(input2); var checked = add(":checked"); expect(input1, 0, "failure 6"); expect(input2, 0, "failure 7"); input2.checked = true; expect(input1, 0, "failure 6"); expect(input2, checked, "failure 7"); input1.checked = true; expect(input1, checked, "failure 8"); expect(input2, 0, "failure 9"); input2.setAttribute("checked", "checked"); // sets defaultChecked, doesn't change actual state expect(input1, checked, "failure 9"); expect(input2, 0, "failure 10"); }); selectorTest(function (doc, add, expect) { var input = doc.createElement('input'); input.type = 'button'; doc.body.appendChild(input); var neither = 0; var enabled = add(":enabled"); var disabled = add(":disabled"); add(":enabled:disabled"); expect(input, enabled, "failure 11"); input.disabled = true; expect(input, disabled, "failure 12"); input.removeAttribute("disabled"); expect(input, enabled, "failure 13"); input.setAttribute("type", "hidden"); expect(input, neither, "an input with type=hidden is matching one of :enabled or :disabled"); }); return 3; }, We'll need to make a nicer stand-alone test case. 66245 1 18282 bdakin 2008-01-04 20:56:09 -0800 Created attachment 18282 Patch: Prevent :enabled and :disabled from applying to input type="hidden" I verified that this fixes the test in Acid3. 66246 2 18282 oliver 2008-01-04 21:00:17 -0800 Comment on attachment 18282 Patch: Prevent :enabled and :disabled from applying to input type="hidden" r=me, my only requirement is that you do layoutController.dumpAsText() (or whatever the controller is called) There's n o need for this to be a render tree comparison 66249 3 oliver 2008-01-04 21:19:22 -0800 Fixed with r29191. 66255 4 adele 2008-01-04 22:40:36 -0800 would it be better to check that a renderer exists instead of special casing the hidden input? 66256 5 adele 2008-01-04 22:42:06 -0800 that would cause enabled controls that have display:none set to no longer match those rules...which might not be desirable. 18282 2008-01-04 20:56:09 -0800 2008-01-04 21:00:17 -0800 Patch: Prevent :enabled and :disabled from applying to input type="hidden" posting.txt text/plain 7128 bdakin SW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaAkocmV2aXNpb24gMjkxODcpCisrKyBXZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC03OSw2ICs3OSw3IEBA CiAgICAgdmlydHVhbCBib29sIGlzUmFkaW9CdXR0b24oKSBjb25zdCB7IHJldHVybiBtX3R5cGUg PT0gUkFESU87IH0KICAgICBib29sIGlzVGV4dEZpZWxkKCkgY29uc3QgeyByZXR1cm4gbV90eXBl ID09IFRFWFQgfHwgbV90eXBlID09IFBBU1NXT1JEIHx8IG1fdHlwZSA9PSBTRUFSQ0ggfHwgbV90 eXBlID09IElTSU5ERVg7IH0KICAgICBib29sIGlzU2VhcmNoRmllbGQoKSBjb25zdCB7IHJldHVy biBtX3R5cGUgPT0gU0VBUkNIOyB9CisgICAgdmlydHVhbCBib29sIGlzSW5wdXRUeXBlSGlkZGVu KCkgY29uc3QgeyByZXR1cm4gbV90eXBlID09IEhJRERFTjsgfQogCiAgICAgYm9vbCBjaGVja2Vk KCkgY29uc3QgeyByZXR1cm4gbV9jaGVja2VkOyB9CiAgICAgdm9pZCBzZXRDaGVja2VkKGJvb2ws IGJvb2wgc2VuZENoYW5nZUV2ZW50ID0gZmFsc2UpOwpJbmRleDogV2ViQ29yZS9kb20vRWxlbWVu dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL0VsZW1lbnQuaAkocmV2aXNpb24gMjkxODcp CisrKyBXZWJDb3JlL2RvbS9FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTExOSw2ICsxMTks OCBAQAogICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRlZEludG9Eb2N1bWVudCgpOwogICAgIHZpcnR1 YWwgdm9pZCByZW1vdmVkRnJvbURvY3VtZW50KCk7CiAKKyAgICB2aXJ0dWFsIGJvb2wgaXNJbnB1 dFR5cGVIaWRkZW4oKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorCiAgICAgU3RyaW5nIG5vZGVO YW1lUHJlc2VydmluZ0Nhc2UoKSBjb25zdDsKIAogICAgIC8vIGNvbnZlbmllbmNlIG1ldGhvZHMg d2hpY2ggaWdub3JlIGV4Y2VwdGlvbnMKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyOTE5MCkKKysrIFdlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMDEtMDQgIEJldGgg RGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY3MDQgaW5wdXQgd2l0aCAKKyAgICAgICAgdHlwZT0iaGlkZGVuIiBtYXRjaGVz IDplbmFibGVkLzpkaXNhYmxlZCAoQWNpZDMgYnVnKQorCisgICAgICAgIFByZXZlbnQgOmVuYWJs ZWQgYW5kIDpkaXNhYmxlZCBmcm9tIGFwcGx5aW5nIHRvIGlucHV0IHR5cGU9ImhpZGRlbiIgCisK KyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD U1NTdHlsZVNlbGVjdG9yOjpjaGVja09uZVNlbGVjdG9yKTogUmF0aGVyIHRoYW4gCisgICAgICAg IGFsbG93aW5nIDplbmFibGVkIGFuZCA6ZGlzYWJsZWQgdG8gYXBwbHkgdG8gYWxsIGNvbnRyb2xz LCBvbmx5IAorICAgICAgICBhbGxvdyBpdCB0byBhcHBseSB0byBub24tImhpZGRlbiIgY29udHJv bHMKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6 aXNJbnB1dFR5cGVIaWRkZW4pOiAKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuaDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmlzSW5wdXRUeXBlSGlkZGVuKToK KwogMjAwOC0wMS0wNCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rv ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJl dmlzaW9uIDI5MTg3KQorKysgV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1OTksMTcgKzE1OTksMTcgQEAKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9F bmFibGVkOgotICAgICAgICAgICAgICAgIGlmIChlICYmIGUtPmlzQ29udHJvbCgpKQorICAgICAg ICAgICAgICAgIGlmIChlICYmIGUtPmlzQ29udHJvbCgpICYmICFlLT5pc0lucHV0VHlwZUhpZGRl bigpKQogICAgICAgICAgICAgICAgICAgICAvLyBUaGUgVUkgc3BlYyBzdGF0ZXMgdGhhdCB5b3Ug Y2FuJ3QgbWF0Y2ggOmVuYWJsZWQgdW5sZXNzIHlvdSBhcmUgYW4gb2JqZWN0IHRoYXQgY2FuCiAg ICAgICAgICAgICAgICAgICAgIC8vICJyZWNlaXZlIGZvY3VzIGFuZCBiZSBhY3RpdmF0ZWQuIiAg V2Ugd2lsbCBsaW1pdCBtYXRjaGluZyBvZiB0aGlzIHBzZXVkby1jbGFzcyB0byBlbGVtZW50cwot ICAgICAgICAgICAgICAgICAgICAvLyB0aGF0IGFyZSBjb250cm9scy4KKyAgICAgICAgICAgICAg ICAgICAgLy8gdGhhdCBhcmUgbm9uLSJoaWRkZW4iIGNvbnRyb2xzLgogICAgICAgICAgICAgICAg ICAgICByZXR1cm4gZS0+aXNFbmFibGVkKCk7ICAgICAgICAgICAgICAgICAgICAKICAgICAgICAg ICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0Rpc2Fi bGVkOgotICAgICAgICAgICAgICAgIGlmIChlICYmIGUtPmlzQ29udHJvbCgpKQorICAgICAgICAg ICAgICAgIGlmIChlICYmIGUtPmlzQ29udHJvbCgpICYmICFlLT5pc0lucHV0VHlwZUhpZGRlbigp KQogICAgICAgICAgICAgICAgICAgICAvLyBUaGUgVUkgc3BlYyBzdGF0ZXMgdGhhdCB5b3UgY2Fu J3QgbWF0Y2ggOmVuYWJsZWQgdW5sZXNzIHlvdSBhcmUgYW4gb2JqZWN0IHRoYXQgY2FuCiAgICAg ICAgICAgICAgICAgICAgIC8vICJyZWNlaXZlIGZvY3VzIGFuZCBiZSBhY3RpdmF0ZWQuIiAgV2Ug d2lsbCBsaW1pdCBtYXRjaGluZyBvZiB0aGlzIHBzZXVkby1jbGFzcyB0byBlbGVtZW50cwotICAg ICAgICAgICAgICAgICAgICAvLyB0aGF0IGFyZSBjb250cm9scy4KKyAgICAgICAgICAgICAgICAg ICAgLy8gdGhhdCBhcmUgbm9uLSJoaWRkZW4iIGNvbnRyb2xzLgogICAgICAgICAgICAgICAgICAg ICByZXR1cm4gIWUtPmlzRW5hYmxlZCgpOyAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9DaGVja2Vk OgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvaGlkZGVuLWlucHV0 LW5vdC1lbmFibGVkLWV4cGVjdGVkLnBuZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxl IG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWltZS10eXBlID0gYXBwbGljYXRpb24vb2N0 ZXQtc3RyZWFtCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv ZmFzdC9mb3Jtcy9oaWRkZW4taW5wdXQtbm90LWVuYWJsZWQtZXhwZWN0ZWQucG5nCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIGFwcGxpY2F0aW9uL29jdGV0LXN0cmVhbQoKSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL2hpZGRlbi1pbnB1dC1ub3Qt ZW5hYmxlZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2Zhc3QvZm9ybXMvaGlkZGVuLWlucHV0LW5vdC1lbmFibGVkLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL2hpZGRlbi1p bnB1dC1ub3QtZW5hYmxlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOCBA QAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6 ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hU TUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgp IHNpemUgNzg0eDU4NAorICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6ZSA3ODR4 MTgKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgNDY0eDE4CisgICAg ICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNDY0OiAiUEFTU0VEISBIaWRkZW4gaW5wdXQg dHlwZXMgc2hvdWxkIG5vdCByZXNwb25kIHRvIDplbmFibGVkIG9yIDpkaXNhYmxlZCIKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL2hpZGRlbi1pbnB1dC1ub3QtZW5h YmxlZC1leHBlY3RlZC5jaGVja3N1bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC9mb3Jtcy9oaWRkZW4taW5wdXQtbm90LWVuYWJsZWQtZXhwZWN0ZWQuY2hlY2tz dW0JKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9mb3Jtcy9o aWRkZW4taW5wdXQtbm90LWVuYWJsZWQtZXhwZWN0ZWQuY2hlY2tzdW0JKHJldmlzaW9uIDApCkBA IC0wLDAgKzEgQEAKK2ZlNzRiODg4MDgxYmJkMjY4ODMxNWIwMjVjOGI3ODM5ClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjkxOTApCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOC0wMS0wNCAg QmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY3MDQgaW5wdXQgd2l0aCAKKyAgICAgICAgdHlwZT0iaGlkZGVuIiBt YXRjaGVzIDplbmFibGVkLzpkaXNhYmxlZCAoQWNpZDMgYnVnKQorCisgICAgICAgICogZmFzdC9m b3Jtcy9oaWRkZW4taW5wdXQtbm90LWVuYWJsZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxh dGZvcm0vbWFjL2Zhc3QvZm9ybXMvaGlkZGVuLWlucHV0LW5vdC1lbmFibGVkLWV4cGVjdGVkLmNo ZWNrc3VtOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9mb3Jtcy9oaWRkZW4t aW5wdXQtbm90LWVuYWJsZWQtZXhwZWN0ZWQucG5nOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9y bS9tYWMvZmFzdC9mb3Jtcy9oaWRkZW4taW5wdXQtbm90LWVuYWJsZWQtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKwogMjAwOC0wMS0wNCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIEFkZCBtaXNzaW5nIGV4cGVjdGVkIHJlc3VsdC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvaGlkZGVuLWlucHV0LW5vdC1lbmFibGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9oaWRkZW4taW5wdXQtbm90LWVuYWJsZWQuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaGlkZGVuLWlucHV0LW5vdC1lbmFibGVkLmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzMgQEAKKzxoZWFkPgorPHN0eWxlPgorICAgICNp bnB1dCB7CisgICAgICAgIGNvbG9yOnB1cnBsZTsKKyAgICB9CisgICAgCisgICAgI2lucHV0OmVu YWJsZWQgeworICAgICAgICBjb2xvcjpyZWQ7CisgICAgfQorICAgIAorICAgICNpbnB1dDpkaXNh YmxlZCB7CisgICAgICAgIGNvbG9yOmdyZWVuOworICAgIH0KKzwvc3R5bGU+Cis8L2hlYWQ+CisK Kzxib2R5PiAgICAKKyAgICA8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorICAgIDxpbnB1dCBpZD0i aW5wdXQiIHR5cGU9ImhpZGRlbiI+PC9pbnB1dD4KKyAgICAKKyAgICA8c2NyaXB0PgorICAgICAg ICB2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5wdXQiKTsKKyAgICAgICAg dmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKTsKKyAgICAgICAg aWYgKGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoaW5wdXQsIG51bGwpLmNv bG9yID09ICJyZ2IoMjU1LCAwLCAwKSIpCisgICAgICAgICAgICAvLyA6ZW5hYmxlZAorICAgICAg ICAgICAgcmVzdWx0LmlubmVySFRNTCA9ICJGQUlMRUQhIjsKKyAgICAgICAgZWxzZSBpZiAoZG9j dW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShpbnB1dCwgbnVsbCkuY29sb3IgPT0g InJnYigwLCAyNTUsIDApIikKKyAgICAgICAgICAgIC8vIDpkaXNhYmxlZAorICAgICAgICAgICAg cmVzdWx0LmlubmVySFRNTCA9ICJGQUlMRUQhIjsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAg cmVzdWx0LmlubmVySFRNTCA9ICJQQVNTRUQhIEhpZGRlbiBpbnB1dCB0eXBlcyBzaG91bGQgbm90 IHJlc3BvbmQgdG8gOmVuYWJsZWQgb3IgOmRpc2FibGVkIjsKKyAgICA8L3NjcmlwdD4KKzwvYm9k eT4K