167036 2017-01-13 17:00:58 -0800 Correct potential nullptr dereference in RenderLayer::updateLayerPosition() 2017-01-13 19:43:41 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser zalan oldest_to_newest 1266672 0 bfulgham 2017-01-13 17:00:58 -0800 Crash logs indicate an infrequent crash in RenderLayer::updateLayerPosition(). Code inspection reveals that we might dereference a nullptr for elements with enclosing parents with a layer. The search for this parent might end without finding anything, resulting in the ancestor being set to nullptr. This patch adds the missing nullptr check to avoid this possibility. 1266674 1 bfulgham 2017-01-13 17:01:18 -0800 <rdar://problem/30023019> 1266677 2 298810 bfulgham 2017-01-13 17:04:16 -0800 Created attachment 298810 Patch 1266725 3 298810 dino 2017-01-13 18:45:27 -0800 Comment on attachment 298810 Patch Test case? 1266754 4 298810 commit-queue 2017-01-13 19:43:38 -0800 Comment on attachment 298810 Patch Clearing flags on attachment: 298810 Committed r210760: <http://trac.webkit.org/changeset/210760> 1266755 5 commit-queue 2017-01-13 19:43:41 -0800 All reviewed patches have been landed. Closing bug. 298810 2017-01-13 17:04:16 -0800 2017-01-13 19:43:38 -0800 Patch bug-167036-20170113170235.patch text/plain 1548 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDc1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAxLTEzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFBvdGVudGlhbCBudWxscHRy IGRlcmVmZXJlbmNlIGluIFJlbmRlckxheWVyOjp1cGRhdGVMYXllclBvc2l0aW9uKCkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzAzNgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzAwMjMwMTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQSB2YWx1ZSB3YXMgYmVpbmcgdXNlZCB3aXRob3V0IG51bGxw dHIgY2hlY2tpbmcsIGV2ZW4gdGhvdWdoIGl0IGhhZCBiZWVuIGNoZWNrZWQgZm9yIG51bGwgYQor ICAgICAgICBmZXcgbGluZXMgcHJpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnVwZGF0ZUxheWVyUG9zaXRp b24pOiBBZGQgbWlzc2luZyBudWxscHRyIGNoZWNrLgorCiAyMDE3LTAxLTEzICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIG51bGxwdHIgZnJhbWUg ZGVyZWZlcmVuY2Ugd2hlbiBzY3JvbGxUbyBpcyBjYWxsZWQgb24gYSBkaXNjb25uZWN0ZWQgRE9N V2luZG93CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJl dmlzaW9uIDIxMDczOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNjAsNyArMTM2MCw3IEBAIGJvb2wgUmVuZGVyTGF5ZXI6 OnVwZGF0ZUxheWVyUG9zaXRpb24oKQogICAgICAgICAgICAgfQogICAgICAgICAgICAgYW5jZXN0 b3IgPSBhbmNlc3Rvci0+cGFyZW50KCk7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKGlzPFJlbmRl ckJveD4oKmFuY2VzdG9yKSAmJiBpczxSZW5kZXJUYWJsZVJvdz4oKmFuY2VzdG9yKSkgeworICAg ICAgICBpZiAoYW5jZXN0b3IgJiYgaXM8UmVuZGVyQm94PigqYW5jZXN0b3IpICYmIGlzPFJlbmRl clRhYmxlUm93PigqYW5jZXN0b3IpKSB7CiAgICAgICAgICAgICAvLyBQdXQgb3Vyc2VsdmVzIGlu dG8gdGhlIHJvdyBjb29yZGluYXRlIHNwYWNlLgogICAgICAgICAgICAgbG9jYWxQb2ludCAtPSBk b3duY2FzdDxSZW5kZXJCb3g+KCphbmNlc3RvcikudG9wTGVmdExvY2F0aW9uT2Zmc2V0KCk7CiAg ICAgICAgIH0K