167028 2017-01-13 15:59:02 -0800 Web Inspector: Cmd-, should open Settings tab 2017-01-15 21:10:48 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1266634 0 bburg 2017-01-13 15:59:02 -0800 This matches the system-wide shortcut in all macOS apps. 1266636 1 webkit-bug-importer 2017-01-13 15:59:23 -0800 <rdar://problem/30022283> 1266772 2 298843 hi 2017-01-13 20:29:49 -0800 Created attachment 298843 Patch So this works with "Fn⌘," but not with regular "⌘,". Any ideas? 1266927 3 298843 commit-queue 2017-01-14 22:28:48 -0800 Comment on attachment 298843 Patch Clearing flags on attachment: 298843 Committed r210772: <http://trac.webkit.org/changeset/210772> 1266928 4 commit-queue 2017-01-14 22:28:52 -0800 All reviewed patches have been landed. Closing bug. 1267087 5 joepeck 2017-01-15 21:10:48 -0800 Is this a good idea? Does any application allow sub-windows to override the "⌘,"? Does any application have multiple preferences windows? I have found it very disturbing to my workflow when Web Inspector overrides some of Safari's keyboard shortcuts (notably ⌘W, ⇧⌘W). Perhaps "⌘," is so rare that it won't be a problem here. 298843 2017-01-13 20:29:49 -0800 2017-01-14 22:28:48 -0800 Patch 167028.diff text/plain 1829 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIxYmIzZmUuLjllZTgwZTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAxLTEzICBEZXZpbiBSb3Vzc28g IDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENt ZC0sIHNob3VsZCBvcGVuIFNldHRpbmdzIHRhYgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3MDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5f c2hvd1NldHRpbmdzVGFiKTogQWRkZWQuCisKIDIwMTctMDEtMTMgIE5pa2l0YSBWYXNpbHlldiAg PG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVzb3VyY2Vz IGRpc2FwcGVhciBmcm9tIHRoZSBuZXR3b3JrIHRhYiB3aGVuIGlmcmFtZSBnZXRzIHJlbW92ZWQg ZnJvbSBET00KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv TWFpbi5qcwppbmRleCA0ZTRmMDRiLi45ZjE2ODJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0yNTgsNiArMjU4LDggQEAgV2Vi SW5zcGVjdG9yLmNvbnRlbnRMb2FkZWQgPSBmdW5jdGlvbigpCiAKICAgICB0aGlzLnNldHRpbmdz VGFiQ29udGVudFZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlNldHRpbmdzVGFiQ29udGVudFZpZXc7 CiAKKyAgICB0aGlzLl9zZXR0aW5nc0tleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIu Q29tbWFuZE9yQ29udHJvbCwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5LkNvbW1h LCB0aGlzLl9zaG93U2V0dGluZ3NUYWIuYmluZCh0aGlzKSk7CisKICAgICAvLyBDcmVhdGUgdGhl IHVzZXIgaW50ZXJmYWNlIGVsZW1lbnRzLgogICAgIHRoaXMudG9vbGJhciA9IG5ldyBXZWJJbnNw ZWN0b3IuVG9vbGJhcihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidG9vbGJhciIpLCBudWxsLCB0 cnVlKTsKICAgICB0aGlzLnRvb2xiYXIuZGlzcGxheU1vZGUgPSBXZWJJbnNwZWN0b3IuVG9vbGJh ci5EaXNwbGF5TW9kZS5JY29uT25seTsKQEAgLTU2OCw2ICs1NzAsMTEgQEAgV2ViSW5zcGVjdG9y Ll9vcGVuRGVmYXVsdFRhYiA9IGZ1bmN0aW9uKGV2ZW50KQogICAgIHRoaXMuc2hvd05ld1RhYlRh YigpOwogfTsKIAorV2ViSW5zcGVjdG9yLl9zaG93U2V0dGluZ3NUYWIgPSBmdW5jdGlvbihldmVu dCkKK3sKKyAgICB0aGlzLnRhYkJyb3dzZXIuc2hvd1RhYkZvckNvbnRlbnRWaWV3KHRoaXMuc2V0 dGluZ3NUYWJDb250ZW50Vmlldyk7Cit9OworCiBXZWJJbnNwZWN0b3IuX3RyeVRvUmVzdG9yZVBl bmRpbmdUYWJzID0gZnVuY3Rpb24oKQogewogICAgIGxldCBzdGlsbFBlbmRpbmdPcGVuVGFicyA9 IFtdOwo=