167025 2017-01-13 15:42:37 -0800 Web Inspector: Settings tab is restored when reopening inspector 2017-01-13 23:11:01 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1266618 0 hi 2017-01-13 15:42:37 -0800 * Steps to reproduce 1. Open WebInspector 2. Select Settings tab (gear icon on far right of tab bar) 3. Close WebInspector 4. Open WebInspector * Expected Tab previously selected before Settings tab is shown. * Actual The Settings tab is shown. 1266629 1 bburg 2017-01-13 15:52:07 -0800 Unsure why one way is better than the other. Can you elaborate? 1266631 2 webkit-bug-importer 2017-01-13 15:52:57 -0800 <rdar://problem/30022133> 1266766 3 hi 2017-01-13 20:04:24 -0800 (In reply to comment #1) > Unsure why one way is better than the other. Can you elaborate? I think that since settings are something that usually won't be changed often, to have the inspector window reopen to the settings view seems weird. I'd rather the settings view be sorta "transient" in that it acts as if it is never shown. What I mean by that is that clicking the gear icon will open the settings view, but it won't trigger the saving of the newly active tab, so reopening the inspector will go back to the previous view. 1266771 4 298842 hi 2017-01-13 20:10:41 -0800 Created attachment 298842 Patch 1266781 5 mattbaker 2017-01-13 22:24:28 -0800 (In reply to comment #3) > (In reply to comment #1) > > Unsure why one way is better than the other. Can you elaborate? > > I think that since settings are something that usually won't be changed > often, to have the inspector window reopen to the settings view seems weird. > I'd rather the settings view be sorta "transient" in that it acts as if it > is never shown. What I mean by that is that clicking the gear icon will > open the settings view, but it won't trigger the saving of the newly active > tab, so reopening the inspector will go back to the previous view. I agree, "transient" is a good way to think about it. 1266784 6 298842 commit-queue 2017-01-13 23:10:56 -0800 Comment on attachment 298842 Patch Clearing flags on attachment: 298842 Committed r210764: <http://trac.webkit.org/changeset/210764> 1266785 7 commit-queue 2017-01-13 23:11:01 -0800 All reviewed patches have been landed. Closing bug. 298842 2017-01-13 20:10:41 -0800 2017-01-13 23:10:56 -0800 Patch bug-167025-20170113210859.patch text/plain 1761 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY1YjUyZjI4MDZiYTg5MzI2MjdjYWJlMGY0NzU5 MWI2ZjllNDQ3ZWYuLjNmODMwNjYzNGExYTIwYmM1YjlmZjAxOTI2ZWYyNTJiMWI4OGE4NzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTEzICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFNldHRpbmdzIHRhYiBpcyByZXN0b3JlZCB3aGVuIHJlb3BlbmluZyBpbnNwZWN0b3IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzAyNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuX3RhYkJyb3dzZXJT ZWxlY3RlZFRhYkNvbnRlbnRWaWV3RGlkQ2hhbmdlKToKKyAgICAgICAgT25seSBzYXZlIHRoZSBz ZWxlY3RlZFRhYkluZGV4IGlmIHRoZSBjdXJyZW50IHRhYiBzaG91bGQgYmUgc2F2ZWQgYW5kIHJl bG9hZGVkIHVwb24gb3BlbmluZworICAgICAgICB0aGUgV2ViSW5zcGVjdG9yIHdpbmRvdy4KKwog MjAxNy0wMS0xMiAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMjA5NzExKTogV2ViIEluc3BlY3RvcjogaW4gRWxlbWVudHMgVGFi LCBzZWxlY3RpbmcgYSBkZWVwbHkgbmVzdGVkIERPTSBlbGVtZW50IGNhdXNlcyBuYXZpZ2F0aW9u IGJhciBidXR0b25zIHRvIGJlIHB1c2hlZCBvZmYgdGhlIGxlYWRpbmcgZWRnZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDRlNGYw NGJiNDdkZDYzODg1YzNjNWViM2YxYzJlZmZkMmM1NDg0ZDguLmFlMTUwOTFkZTQ2YzQ0NTNiYzA5 MTZmMWI3MjczMGYzMzA0YjdhOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTE1OTAsNyArMTU5MCw3IEBAIFdlYkluc3BlY3Rv ci5fc2V0dXBWaWV3SGllcmFyY2h5ID0gZnVuY3Rpb24oKQogCiBXZWJJbnNwZWN0b3IuX3RhYkJy b3dzZXJTZWxlY3RlZFRhYkNvbnRlbnRWaWV3RGlkQ2hhbmdlID0gZnVuY3Rpb24oZXZlbnQpCiB7 Ci0gICAgaWYgKHRoaXMudGFiQmFyLnNlbGVjdGVkVGFiQmFySXRlbSkKKyAgICBpZiAodGhpcy50 YWJCYXIuc2VsZWN0ZWRUYWJCYXJJdGVtICYmIHRoaXMudGFiQmFyLnNlbGVjdGVkVGFiQmFySXRl bS5yZXByZXNlbnRlZE9iamVjdC5jb25zdHJ1Y3Rvci5zaG91bGRTYXZlVGFiKCkpCiAgICAgICAg IHRoaXMuX3NlbGVjdGVkVGFiSW5kZXhTZXR0aW5nLnZhbHVlID0gdGhpcy50YWJCYXIudGFiQmFy SXRlbXMuaW5kZXhPZih0aGlzLnRhYkJhci5zZWxlY3RlZFRhYkJhckl0ZW0pOwogCiAgICAgaWYg KCF0aGlzLmRvZXNDdXJyZW50VGFiU3VwcG9ydFNwbGl0Q29udGVudEJyb3dzZXIoKSkK