167005 2017-01-13 07:52:09 -0800 Added preprocessor guard for iOS-specific piece of code in GraphicsContext3DOpenGL 2017-01-13 09:32:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen commit-queue dbates dino graouts kondapallykalyan noam oldest_to_newest 1266458 0 annulen 2017-01-13 07:52:09 -0800 Variable boundFrameBuffer is used only in IOS-specific code 1266459 1 298759 annulen 2017-01-13 07:53:46 -0800 Created attachment 298759 Patch 1266466 2 298759 annulen 2017-01-13 09:03:08 -0800 Comment on attachment 298759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review > Source/WebCore/ChangeLog:8 > + Variable "boundFrameBuffer" is used only in IOS-specific code Oops, will change to iOS before commiting 1266472 3 annulen 2017-01-13 09:24:37 -0800 Committed r210731: <http://trac.webkit.org/changeset/210731> 1266475 4 298759 dbates 2017-01-13 09:26:42 -0800 Comment on attachment 298759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:232 > GLint boundFrameBuffer; > ::glGetIntegerv(GL_FRAMEBUFFER_BINDING, &boundFrameBuffer); Can we move this code into the existing PLATFORM(IOS)-guarded section below or do we need to execute this statement before the glBindFramebufferEXT() calls? Obviously, the benefit of moving this code under the existing PLATFORM(IOS)-guarded code section in this functions is that we can avoid adding another guard. 1266477 5 achristensen 2017-01-13 09:29:39 -0800 We definitely need to check which frame buffer is bound before binding another one. 1266480 6 dbates 2017-01-13 09:32:27 -0800 (In reply to comment #5) > We definitely need to check which frame buffer is bound before binding > another one. I'm blind. 298759 2017-01-13 07:53:46 -0800 2017-01-13 09:15:43 -0800 Patch bug-167005-20170113185204.patch text/plain 1843 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJjYWZmYmU0MzEzYTAw NjIxOWY2MmFiNmYwNjZlMDU4NmYwMzY3ZC4uYTI5OTBmZTcyYTMzMTIzOGVhMjVjN2RlZjc3OWE2 YjY4OTE5ZGJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAxLTEzICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBBZGRlZCBwcmVw cm9jZXNzb3IgZ3VhcmQgZm9yIGlPUy1zcGVjaWZpYyBwaWVjZSBvZiBjb2RlIGluIEdyYXBoaWNz Q29udGV4dDNET3BlbkdMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjcwMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBWYXJpYWJsZSAiYm91bmRGcmFtZUJ1ZmZlciIgaXMgdXNlZCBvbmx5IGluIElPUy1z cGVjaWZpYyBjb2RlCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6cmVzb2x2ZU11bHRpc2FtcGxpbmdJ Zk5lY2Vzc2FyeSk6CisKIDIwMTctMDEtMTMgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIxMDYyMSk6IFttYWMtd2syXSBMYXlv dXRUZXN0IGZhc3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0tdmlkZW8tZWxlbWVudC12aWRlby10 cmFja3MtZGlzYWJsZWQtdGhlbi1lbmFibGVkLmh0bWwgdGltaW5nIG91dApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNE T3BlbkdMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFw aGljc0NvbnRleHQzRE9wZW5HTC5jcHAKaW5kZXggMzFjMjg3YzgzN2Y1MzUyZGNhMmZiZTZlODgy YzMxZDM4MWM5Yjg4ZC4uNDFiNmUyMDI5ZjYzYTc4YjhkM2IxZDhiYTdhZmVjMzM2NmYwZmQ5OCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBo aWNzQ29udGV4dDNET3BlbkdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wuY3BwCkBAIC0yMjcsOCArMjI3LDEw IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnJlc29sdmVNdWx0aXNhbXBsaW5nSWZOZWNlc3Nh cnkoY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBUZW1wb3JhcnlPcGVuR0xTZXR0aW5nIHNjb3Bl ZERlcHRoKEdMX0RFUFRIX1RFU1QsIEdMX0ZBTFNFKTsKICAgICBUZW1wb3JhcnlPcGVuR0xTZXR0 aW5nIHNjb3BlZFN0ZW5jaWwoR0xfU1RFTkNJTF9URVNULCBHTF9GQUxTRSk7CiAKKyNpZiBQTEFU Rk9STShJT1MpCiAgICAgR0xpbnQgYm91bmRGcmFtZUJ1ZmZlcjsKICAgICA6OmdsR2V0SW50ZWdl cnYoR0xfRlJBTUVCVUZGRVJfQklORElORywgJmJvdW5kRnJhbWVCdWZmZXIpOworI2VuZGlmCiAK ICAgICA6OmdsQmluZEZyYW1lYnVmZmVyRVhUKEdMX1JFQURfRlJBTUVCVUZGRVJfRVhULCBtX211 bHRpc2FtcGxlRkJPKTsKICAgICA6OmdsQmluZEZyYW1lYnVmZmVyRVhUKEdMX0RSQVdfRlJBTUVC VUZGRVJfRVhULCBtX2Zibyk7Cg==