<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>167004</bug_id>
          
          <creation_ts>2017-01-13 06:43:37 -0800</creation_ts>
          <short_desc>[CMake] Clean up SHARED_CORE option</short_desc>
          <delta_ts>2017-01-13 10:10:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1266448</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-01-13 06:43:37 -0800</bug_when>
    <thetext>Somebody changed JSC to always be a shared library, but failed to update the option description a couple lines above. JSC doesn&apos;t belong in this conditional anymore anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266450</commentid>
    <comment_count>1</comment_count>
      <attachid>298756</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-01-13 06:44:54 -0800</bug_when>
    <thetext>Created attachment 298756
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266500</commentid>
    <comment_count>2</comment_count>
      <attachid>298756</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-01-13 10:10:40 -0800</bug_when>
    <thetext>Comment on attachment 298756
Patch

Clearing flags on attachment: 298756

Committed r210734: &lt;http://trac.webkit.org/changeset/210734&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266501</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-01-13 10:10:44 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>298756</attachid>
            <date>2017-01-13 06:44:54 -0800</date>
            <delta_ts>2017-01-13 10:10:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-167004-20170113084313.patch</filename>
            <type>text/plain</type>
            <size>1469</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNzI5CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi
L0NNYWtlTGlzdHMudHh0CmluZGV4IDc5YTE3YmFjYTBkZjUzMjhlN2IzZDExOTcyYmI2YjdiNDdl
MmU2ZmEuLmJmM2M0ZWZhYjBlYWYyY2FjMjZhZTc2NmM3NjdjMWE2Njk5YjdiNDQgMTAwNjQ0Ci0t
LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0xMDUsMTYgKzEwNSwx
NSBAQCBlbmRpZiAoKQogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIyBEZWZhdWx0IGxpYnJhcnkg
dHlwZXMKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLW9wdGlvbihTSEFSRURfQ09SRSAiYnVpbGQg
SmF2YVNjcmlwdENvcmUgYW5kIFdlYkNvcmUgYXMgc2hhcmVkIGxpYnJhcmllcyIpCitvcHRpb24o
U0hBUkVEX0NPUkUgImJ1aWxkIFdlYkNvcmUgYXMgYSBzaGFyZWQgbGlicmFyeSIpCiAKIGlmIChT
SEFSRURfQ09SRSkKLSAgICBzZXQoSmF2YVNjcmlwdENvcmVfTElCUkFSWV9UWVBFIFNIQVJFRCkK
ICAgICBzZXQoV2ViQ29yZV9MSUJSQVJZX1RZUEUgU0hBUkVEKQogZWxzZSAoKQotICAgIHNldChK
YXZhU2NyaXB0Q29yZV9MSUJSQVJZX1RZUEUgU0hBUkVEKQogICAgIHNldChXZWJDb3JlX0xJQlJB
UllfVFlQRSBTVEFUSUMpCiBlbmRpZiAoKQogCitzZXQoSmF2YVNjcmlwdENvcmVfTElCUkFSWV9U
WVBFIFNIQVJFRCkKIHNldChXZWJLaXRfTElCUkFSWV9UWVBFIFNIQVJFRCkKIHNldChXZWJLaXQy
X0xJQlJBUllfVFlQRSBTSEFSRUQpCiBzZXQoV2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUllfVFlQ
RSBTVEFUSUMpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMTRmNjQ3
MTYwOGU5NGVhOTRlN2QyZGJmZmFiZDZmNGI4ZTVjZDczZS4uNTc5YTEwODRiZGIzNzAxY2UwMDJl
MTA4Zjc5MjdjNDZhYmNlNjczMiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAxLTEzICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh
bnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2VdIENsZWFuIHVwIFNIQVJFRF9DT1JF
IG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTY3MDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNi0xMi0yMSAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5u
dWxlbkB5YW5kZXgucnU+CiAKICAgICAgICAgc2V0IFBZVEhPTlBBVEggaW4gc2VwYXJhdGUgQ09N
TUFORCBkb2Vzbid0IHdvcmsgd2l0aCBhbGwgQ01ha2UgZ2VuZXJhdG9ycwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>