16700 2008-01-01 15:36:00 -0800 Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:] 2008-01-01 16:38:32 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 12111 1 ddkilzer webkit-unassigned opendarwin oldest_to_newest 65951 0 ddkilzer 2008-01-01 15:36:00 -0800 The fix for Bug 12111 was not fully correct. The return value of -[NSFileManager fileExistsAtPath:isDirectory:] should be checked. See Bug 12111 Comment #8. 65953 1 18228 ddkilzer 2008-01-01 15:55:06 -0800 Created attachment 18228 Patch v1 Use the return value of -[NSFileManager fileExistsAtPath:isDirectory:] and clean up code for WebKit style (remove extraneous curly braces in if/else statements). 65955 2 18228 mitz 2008-01-01 16:09:44 -0800 Comment on attachment 18228 Patch v1 r=me 65961 3 ddkilzer 2008-01-01 16:38:32 -0800 Committed revision 29072. 18228 2008-01-01 15:55:06 -0800 2008-01-01 16:09:44 -0800 Patch v1 bug-16700-v1.diff text/plain 1949 ddkilzer SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiAyOTA3MSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDEtMDEgIERhdmlkIEQuIEtpbHplciAgPGRk a2lsemVyQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY3MDAKKyAgICAgICAgICBGaXggLVtXZWJEZWZhdWx0UG9saWN5RGVsZWdhdGUgd2ViVmlldzpk ZWNpZGVQb2xpY3lGb3JNSU1FVHlwZTpyZXF1ZXN0OmZyYW1lOmRlY2lzaW9uTGlzdGVuZXI6XQor CisgICAgICAgICogRGVmYXVsdERlbGVnYXRlcy9XZWJEZWZhdWx0UG9saWN5RGVsZWdhdGUubTog Q2hlY2sgcmV0dXJuIHZhbHVlIG9mCisgICAgICAgIC1bTlNGaWxlTWFuYWdlciBmaWxlRXhpc3Rz QXRQYXRoOmlzRGlyZWN0b3J5Ol0gYmVmb3JlIHVzaW5nIHRoZSB2YWx1ZQorICAgICAgICBvZiBp c0RpcmVjdG9yeS4KKwogMjAwNy0xMi0yOSAgTmlrb2xhcyBaaW1tZXJtYW5uICA8emltbWVybWFu bkBrZGUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMuCkluZGV4OiBXZWJLaXQvbWFj L0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFBvbGljeURlbGVnYXRlLm0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L21hYy9EZWZhdWx0RGVsZWdhdGVzL1dlYkRlZmF1bHRQb2xpY3lEZWxlZ2F0ZS5t CShyZXZpc2lvbiAyOTA3MSkKKysrIFdlYktpdC9tYWMvRGVmYXVsdERlbGVnYXRlcy9XZWJEZWZh dWx0UG9saWN5RGVsZWdhdGUubQkod29ya2luZyBjb3B5KQpAQCAtNjYsMjAgKzY2LDE2IEBAIHN0 YXRpYyBXZWJEZWZhdWx0UG9saWN5RGVsZWdhdGUgKnNoYXJlZEQKIHsKICAgICBpZiAoW1tyZXF1 ZXN0IFVSTF0gaXNGaWxlVVJMXSkgewogICAgICAgICBCT09MIGlzRGlyZWN0b3J5ID0gTk87Ci0g ICAgICAgIFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gZmlsZUV4aXN0c0F0UGF0aDpb W3JlcXVlc3QgVVJMXSBwYXRoXSBpc0RpcmVjdG9yeTomaXNEaXJlY3RvcnldOwotICAgICAgICAK LSAgICAgICAgaWYgKGlzRGlyZWN0b3J5KSB7Ci0gICAgICAgICAgICBbbGlzdGVuZXIgaWdub3Jl XTsKLSAgICAgICAgfSBlbHNlIGlmKFtXZWJWaWV3IGNhblNob3dNSU1FVHlwZTp0eXBlXSkgewor ICAgICAgICBCT09MIGV4aXN0cyA9IFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gZmls ZUV4aXN0c0F0UGF0aDpbW3JlcXVlc3QgVVJMXSBwYXRoXSBpc0RpcmVjdG9yeTomaXNEaXJlY3Rv cnldOworCisgICAgICAgIGlmIChleGlzdHMgJiYgIWlzRGlyZWN0b3J5ICYmIFtXZWJWaWV3IGNh blNob3dNSU1FVHlwZTp0eXBlXSkKICAgICAgICAgICAgIFtsaXN0ZW5lciB1c2VdOwotICAgICAg ICB9IGVsc2V7CisgICAgICAgIGVsc2UKICAgICAgICAgICAgIFtsaXN0ZW5lciBpZ25vcmVdOwot ICAgICAgICB9Ci0gICAgfSBlbHNlIGlmIChbV2ViVmlldyBjYW5TaG93TUlNRVR5cGU6dHlwZV0p IHsKKyAgICB9IGVsc2UgaWYgKFtXZWJWaWV3IGNhblNob3dNSU1FVHlwZTp0eXBlXSkKICAgICAg ICAgW2xpc3RlbmVyIHVzZV07Ci0gICAgfSBlbHNlIHsKKyAgICBlbHNlCiAgICAgICAgIFtsaXN0 ZW5lciBpZ25vcmVdOwotICAgIH0KIH0KIAogLSAodm9pZCl3ZWJWaWV3OiAoV2ViVmlldyAqKXd2 IGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246KE5TRGljdGlvbmFyeSAqKWFjdGlvbklu Zm9ybWF0aW9uIAo=