166975 2017-01-12 09:38:20 -0800 OneDrive application crashes upon launch 2017-01-14 22:40:30 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson commit-queue webkit-bug-importer oldest_to_newest 1266175 0 youennf 2017-01-12 09:38:20 -0800 See radar 29910273. SubresourceLoader::willSendRequestInternal is calling ResourceLoader::willSendRequestInternal. App delegate code may cancel the load which will make m_resource null. 1266176 1 298692 youennf 2017-01-12 09:44:24 -0800 Created attachment 298692 Patch 1266252 2 youennf 2017-01-12 12:50:42 -0800 Any idea how to add a test for it? Ideally, we would need to have some delegate code cancelling the redirect load. Maybe we can simulate this code path using content extension blockers? 1266255 3 298692 beidson 2017-01-12 13:01:45 -0800 Comment on attachment 298692 Patch Code change looks fine. I do think it's worth following up all leads on trying to get a test for this. 1266259 4 298692 commit-queue 2017-01-12 13:27:53 -0800 Comment on attachment 298692 Patch Clearing flags on attachment: 298692 Committed r210679: <http://trac.webkit.org/changeset/210679> 1266261 5 commit-queue 2017-01-12 13:27:57 -0800 All reviewed patches have been landed. Closing bug. 1266935 6 298692 darin 2017-01-14 22:40:30 -0800 Comment on attachment 298692 Patch Can we make a test that covers this? 298692 2017-01-12 09:44:24 -0800 2017-01-12 13:27:53 -0800 Patch bug-166975-20170112094245.patch text/plain 1490 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBjNGY5Yzg4NWI2Zjgw YWJiNDc4OTUyMDE3MzliYTkzNTc5YWQ0Yi4uMjlmMDU4ZWJiMzJlNDlhZmJjZGU4ZWViZmQ4NjY0 YTgyMjkyZTNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAxLTEyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBPbmVEcml2ZSBhcHBsaWNh dGlvbiBjcmFzaGVzIHVwb24gbGF1bmNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjY5NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDaGVja2luZyB3aGV0aGVyIGxvYWQgaXMgdGVybWluYXRlZCBqdXN0 IGFmdGVyIGNhbGxpbmcgUmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdEludGVybmFsLgor ICAgICAgICBUaGUgcmVhc29uIGlzIHRoYXQgZGVsZWdhdGUgY2FsbCBtYXkgYWN0dWFsbHkgY2Fu Y2VsIHRoZSBsb2FkIGF0IHRoYXQgcG9pbnQuCisKKyAgICAgICAgKiBsb2FkZXIvU3VicmVzb3Vy Y2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3VicmVzb3VyY2VMb2FkZXI6OndpbGxT ZW5kUmVxdWVzdEludGVybmFsKToKKwogMjAxNy0wMS0xMSAgQW5kcmVhcyBLbGluZyAgPGFrbGlu Z0BhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggd2hlbiBXZWJDb3JlJ3MgR0MgaGVhcCBncm93 cyB3YXkgdG9vIGxhcmdlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJl c291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRl ci5jcHAKaW5kZXggNzY4OWQ3ODRiNDJmNzE2NjI2ZWU1NzMxMDMwMTMxMmUwNTYwZTllYi4uYjZh NjM0MTBkM2VjNjZmOTVlNjYxMDVhYWRmN2MzMzJmOWI0NDFhNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0yMzUsNiArMjM1LDEwIEBAIHZvaWQg U3VicmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdEludGVybmFsKFJlc291cmNlUmVxdWVz dCYgbmV3UmVxdWVzdCwgY29uCiAgICAgICAgIHJldHVybjsKIAogICAgIFJlc291cmNlTG9hZGVy Ojp3aWxsU2VuZFJlcXVlc3RJbnRlcm5hbChuZXdSZXF1ZXN0LCByZWRpcmVjdFJlc3BvbnNlKTsK KworICAgIGlmIChyZWFjaGVkVGVybWluYWxTdGF0ZSgpKQorICAgICAgICByZXR1cm47CisKICAg ICBpZiAobmV3UmVxdWVzdC5pc051bGwoKSkgewogICAgICAgICBjYW5jZWwoKTsKICAgICAgICAg cmV0dXJuOwo=