166904 2017-01-10 14:01:01 -0800 Missing logging in IconLoader::startLoading 2017-01-10 15:10:53 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 krollin krollin achristensen beidson cdumez commit-queue dbates japhet oldest_to_newest 1265528 0 krollin 2017-01-10 14:01:01 -0800 The LOG_ERROR in startLoading references 'resourceRequest', which has been WTF::Moved as part of a preceding function call. As such, the logging statement doesn't print out a possibly useful URL. 1265529 1 298511 krollin 2017-01-10 14:03:53 -0800 Created attachment 298511 Patch 1265550 2 298511 commit-queue 2017-01-10 15:10:47 -0800 Comment on attachment 298511 Patch Clearing flags on attachment: 298511 Committed r210562: <http://trac.webkit.org/changeset/210562> 1265552 3 commit-queue 2017-01-10 15:10:53 -0800 All reviewed patches have been landed. Closing bug. 298511 2017-01-10 14:03:53 -0800 2017-01-10 15:10:47 -0800 Patch bug-166904-20170110140222.patch text/plain 2807 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVmMDdiMzUyZWExYjg1 MTEwNTA4ZWNmYmU1OTc3OGNkMDM1MTJlZC4uODI3YzU3ZjdkYzdjMzkxYTM2ZDBkMzMwMDY4OTU0 NDg1YzJmMzU3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAxLTEwICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBNaXNzaW5nIGxvZ2dpbmcg aW4gSWNvbkxvYWRlcjo6c3RhcnRMb2FkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY5MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgTE9HX0VSUk9SIGluIHN0YXJ0TG9hZGluZyByZWZlcmVu Y2VzICdyZXNvdXJjZVJlcXVlc3QnLCB3aGljaCBoYXMKKyAgICAgICAgYmVlbiBXVEY6Ok1vdmVk IGFzIHBhcnQgb2YgYSBwcmVjZWRpbmcgZnVuY3Rpb24gY2FsbC4gQXMgc3VjaCwgdGhlCisgICAg ICAgIGxvZ2dpbmcgc3RhdGVtZW50IGRvZXNuJ3QgcHJpbnQgb3V0IGEgcG9zc2libHkgdXNlZnVs IFVSTC4gRml4IHRoaXMgYnkKKyAgICAgICAgbWFraW5nIGEgY29weSBvZiB0aGUgVVJMIGJlZm9y ZSBpdCdzIGFmZmVjdGVkIGJ5IHRoZSBNb3ZlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtLSBj aGFuZ2Ugb25seSBhZmZlY3RzIGxvZ2dpbmcgY29kZS4KKworICAgICAgICAqIGxvYWRlci9pY29u L0ljb25Mb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SWNvbkxvYWRlcjo6c3RhcnRMb2Fk aW5nKToKKwogMjAxNy0wMS0wNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFN0YXJ0IGhpdHRlc3RpbmcgYSBjbGVhbiB0cmVlIGluIFJlbmRlckVtYmVkZGVkT2Jq ZWN0Ojppc1JlcGxhY2VtZW50T2JzY3VyZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9pY29uL0ljb25Mb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNv bkxvYWRlci5jcHAKaW5kZXggYmE1OWE4NGI2ZTczMGE3NzU5MGY1ZmNmMTkzYWNiNjEwZWU0NGE3 ZS4uZGI1NzEzNTE2OTQ5ZDI0MjE2ZTZkZjYyYTA1MjQyYWRiMzYzMTE0ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAKQEAgLTc2LDYgKzc2LDEyIEBAIHZvaWQg SWNvbkxvYWRlcjo6c3RhcnRMb2FkaW5nKCkKIAogICAgIFJlc291cmNlUmVxdWVzdCByZXNvdXJj ZVJlcXVlc3QgPSBtX2RvY3VtZW50TG9hZGVyID8gbV91cmwgOiAgbV9mcmFtZS0+bG9hZGVyKCku aWNvbigpLnVybCgpOwogICAgIHJlc291cmNlUmVxdWVzdC5zZXRQcmlvcml0eShSZXNvdXJjZUxv YWRQcmlvcml0eTo6TG93KTsKKyNpZiAhRVJST1JfRElTQUJMRUQKKyAgICAvLyBDb3B5IHRoaXMg YmVjYXVzZSB3ZSBtYXkgd2FudCB0byBhY2Nlc3MgaXQgYWZ0ZXIgdHJhbnNmZXJyaW5nIHRoZQor ICAgIC8vIGByZXNvdXJjZVJlcXVlc3RgIHRvIHRoZSBgcmVxdWVzdGAuIElmIHdlIGRvbid0LCB0 aGVuIHRoZSBMT0dfRVJST1IKKyAgICAvLyBiZWxvdyB3b24ndCBwcmludCBhIFVSTC4KKyAgICBh dXRvIHJlc291cmNlUmVxdWVzdFVSTCA9IHJlc291cmNlUmVxdWVzdC51cmwoKTsKKyNlbmRpZgog CiAgICAgLy8gQ29udGVudFNlY3VyaXR5UG9saWN5SW1wb3NpdGlvbjo6RG9Qb2xpY3lDaGVjayBp cyBhIHBsYWNlaG9sZGVyIHZhbHVlLiBJdCBkb2VzIG5vdCBhZmZlY3QgdGhlIHJlcXVlc3Qgc2lu Y2UgQ29udGVudCBTZWN1cml0eSBQb2xpY3kgZG9lcyBub3QgYXBwbHkgdG8gcmF3IHJlc291cmNl cy4KICAgICBDYWNoZWRSZXNvdXJjZVJlcXVlc3QgcmVxdWVzdChXVEZNb3ZlKHJlc291cmNlUmVx dWVzdCksIFJlc291cmNlTG9hZGVyT3B0aW9ucyhTZW5kQ2FsbGJhY2tzLCBTbmlmZkNvbnRlbnQs IEJ1ZmZlckRhdGEsIERvTm90QWxsb3dTdG9yZWRDcmVkZW50aWFscywgQ2xpZW50Q3JlZGVudGlh bFBvbGljeTo6Q2Fubm90QXNrQ2xpZW50Rm9yQ3JlZGVudGlhbHMsIEZldGNoT3B0aW9uczo6Q3Jl ZGVudGlhbHM6Ok9taXQsIERvU2VjdXJpdHlDaGVjaywgRmV0Y2hPcHRpb25zOjpNb2RlOjpOb0Nv cnMsIERvTm90SW5jbHVkZUNlcnRpZmljYXRlSW5mbywgQ29udGVudFNlY3VyaXR5UG9saWN5SW1w b3NpdGlvbjo6RG9Qb2xpY3lDaGVjaywgRGVmZXJzTG9hZGluZ1BvbGljeTo6QWxsb3dEZWZlcnNM b2FkaW5nLCBDYWNoaW5nUG9saWN5OjpBbGxvd0NhY2hpbmcpKTsKQEAgLTg3LDcgKzkzLDcgQEAg dm9pZCBJY29uTG9hZGVyOjpzdGFydExvYWRpbmcoKQogICAgIGlmIChtX3Jlc291cmNlKQogICAg ICAgICBtX3Jlc291cmNlLT5hZGRDbGllbnQoKnRoaXMpOwogICAgIGVsc2UKLSAgICAgICAgTE9H X0VSUk9SKCJGYWlsZWQgdG8gc3RhcnQgbG9hZCBmb3IgaWNvbiBhdCB1cmwgJXMiLCByZXNvdXJj ZVJlcXVlc3QudXJsKCkuc3RyaW5nKCkuYXNjaWkoKS5kYXRhKCkpOworICAgICAgICBMT0dfRVJS T1IoIkZhaWxlZCB0byBzdGFydCBsb2FkIGZvciBpY29uIGF0IHVybCAlcyIsIHJlc291cmNlUmVx dWVzdFVSTC5zdHJpbmcoKS5hc2NpaSgpLmRhdGEoKSk7CiB9CiAKIHZvaWQgSWNvbkxvYWRlcjo6 c3RvcExvYWRpbmcoKQo=