166902 2017-01-10 12:38:00 -0800 Keyboard accessory bar can appear on top of full-screen video 2017-01-12 23:38:05 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin commit-queue eric.carlson jeremyj-wk jer.noble jonlee sam simon.fraser oldest_to_newest 1265495 0 thorton 2017-01-10 12:38:00 -0800 Keyboard accessory bar can appear on top of full-screen video 1265496 1 298500 thorton 2017-01-10 12:38:08 -0800 Created attachment 298500 Patch 1265516 2 sam 2017-01-10 13:20:04 -0800 Test? 1265519 3 thorton 2017-01-10 13:31:04 -0800 Of full-screen window level? Maybe with Jer's new test app? 1265530 4 thorton 2017-01-10 14:08:20 -0800 (In reply to comment #3) > Of full-screen window level? Maybe with Jer's new test app? Not sure it's super valuable, though, I will just end up testing that an integer that I set is still the value that I set it to :| Also, the UI test app doesn't seem super fleshed out yet, so it should probably be a layout test (it does seem like we can go full-screen in a layout test) with some UISC glue to check the window level? 1265656 5 thorton 2017-01-10 19:05:10 -0800 (In reply to comment #2) > Test? I think not, for now. WebKitTestRunner still doesn't seem to have enough UIKit infrastructure (it's still not a UIApplication) set up to make full-screen actually work (though I just spent far too long trying). I will try again with MobileMiniBrowser, but it's not very scalable (currently have to add new UI for each test). 1265677 6 simon.fraser 2017-01-10 21:06:10 -0800 (In reply to comment #5) > (In reply to comment #2) > > Test? > > I think not, for now. WebKitTestRunner still doesn't seem to have enough > UIKit infrastructure (it's still not a UIApplication) iOS uses WebKitTestRunnerApp.app, which is a UIApplication with a root view controller. 1265680 7 thorton 2017-01-10 21:27:10 -0800 Hmm, odd. I was getting all manner of bizarre logging to the contrary from UIWindow, but maybe I was doing something wrong. 1266430 8 298500 commit-queue 2017-01-12 23:38:00 -0800 Comment on attachment 298500 Patch Clearing flags on attachment: 298500 Committed r210727: <http://trac.webkit.org/changeset/210727> 1266431 9 commit-queue 2017-01-12 23:38:05 -0800 All reviewed patches have been landed. Closing bug. 298500 2017-01-10 12:38:08 -0800 2017-01-12 23:38:00 -0800 Patch bug-166902-20170110123632.patch text/plain 2007 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ0ZjU2ZDhkMGMyNjFj MmRhNTc4MDUyZTUwZDQ3OWJkNTJhOWI0MC4uNTE5NmRlODM5NzYyNDY0MmY2OWE1ODdkMmU0MTgy NTEwZjkwMTkxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAxLTEwICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEtleWJvYXJkIGFj Y2Vzc29yeSBiYXIgY2FuIGFwcGVhciBvbiB0b3Agb2YgZnVsbC1zY3JlZW4gdmlkZW8KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NjkwMgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjk2NjgyMjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlQVZLaXQubW06CisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktp dDo6c2V0dXBGdWxsc2NyZWVuKToKKyAgICAgICAgSW5jcmVhc2UgdGhlIGZ1bGwtc2NyZWVuIHZp ZGVvIHdpbmRvdyBsZXZlbCB0byBvbmUgYWJvdmUgdGhlIGtleWJvYXJkLAorICAgICAgICB0byBl bnN1cmUgdGhhdCB0aGUgdmlkZW8gaXMgbmV2ZXIgb2JzY3VyZWQgYnkgdGhlIGtleWJvYXJkIG9y IGl0cworICAgICAgICBhY2Nlc3Nvcnkgdmlld3MuCisKIDIwMTctMDEtMTAgIEplciBOb2JsZSAg PGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIE1lZGlhS2V5 cy5jcmVhdGVTZXNzaW9uKCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0gYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KaW5kZXggN2Q5 M2E4MTBmMjliYjYyZTIwNWJmZTRmNzFjNTRiODc2MjBmNDU4MS4uZWI0NTUzOWM5ZDgzZjAxZWIz NTE0MWUxNGExM2Q5MWExMzg3OWEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQpA QCAtNzMsNiArNzMsNyBAQCBTT0ZUX0xJTktfQ0xBU1MoVUlLaXQsIFVJV2luZG93KQogU09GVF9M SU5LX0NMQVNTKFVJS2l0LCBVSVZpZXcpCiBTT0ZUX0xJTktfQ0xBU1MoVUlLaXQsIFVJVmlld0Nv bnRyb2xsZXIpCiBTT0ZUX0xJTktfQ0xBU1MoVUlLaXQsIFVJQ29sb3IpCitTT0ZUX0xJTktfQ09O U1RBTlQoVUlLaXQsIFVJUmVtb3RlS2V5Ym9hcmRMZXZlbCwgVUlXaW5kb3dMZXZlbCkKIAogI2lm ICFMT0dfRElTQUJMRUQKIHN0YXRpYyBjb25zdCBjaGFyKiBib29sU3RyaW5nKGJvb2wgdmFsKQpA QCAtNjA2LDYgKzYwNyw3IEBAIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OnNldHVwRnVsbHNjcmVlbihVSVZpZXcmIHZpZGVvVmlldywgY29uc3QKICAgICAgICAgW1ttX3Zp ZXdDb250cm9sbGVyIHZpZXddIHNldEZyYW1lOlttX3dpbmRvdyBib3VuZHNdXTsKICAgICAgICAg W21fdmlld0NvbnRyb2xsZXIgX3NldElnbm9yZUFwcFN1cHBvcnRlZE9yaWVudGF0aW9uczpZRVNd OwogICAgICAgICBbbV93aW5kb3cgc2V0Um9vdFZpZXdDb250cm9sbGVyOm1fdmlld0NvbnRyb2xs ZXIuZ2V0KCldOworICAgICAgICBbbV93aW5kb3cgc2V0V2luZG93TGV2ZWw6Z2V0VUlSZW1vdGVL ZXlib2FyZExldmVsKCkgKyAxXTsKICAgICAgICAgW21fd2luZG93IG1ha2VLZXlBbmRWaXNpYmxl XTsKICAgICB9CiAK