<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>166897</bug_id>
          
          <creation_ts>2017-01-10 11:17:41 -0800</creation_ts>
          <short_desc>Do dot allow selection of editable content when not editing</short_desc>
          <delta_ts>2017-01-12 16:38:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>iOS 10</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Enrica Casucci">enrica</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1265445</commentid>
    <comment_count>0</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2017-01-10 11:17:41 -0800</bug_when>
    <thetext>Long press/force press should not create a selection in editable content if we are not already editing.
We want to allow the selection in editable content (input elements, text areas or content editable) only after the user has focused the field and keyboard is on screen.

rdar://problem/29388806</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1265457</commentid>
    <comment_count>1</comment_count>
      <attachid>298491</attachid>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2017-01-10 11:27:55 -0800</bug_when>
    <thetext>Created attachment 298491
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1265531</commentid>
    <comment_count>2</comment_count>
      <attachid>298491</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-01-10 14:13:34 -0800</bug_when>
    <thetext>Comment on attachment 298491
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298491&amp;action=review

&gt; Source/WebKit2/ChangeLog:3
&gt; +        Do dot allow selection of editable content when not editing.

s/dot/not/?

&gt; Source/WebKit2/ChangeLog:11
&gt; +        When retrieving the position information, we should not consider
&gt; +        as candidates for selection editable elements, since this is only
&gt; +        used for non editable selections.

Seems like this should be quite easy to test with some of the stuff that Megan has been hooking up, no?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1265535</commentid>
    <comment_count>3</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2017-01-10 14:17:57 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; Comment on attachment 298491 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=298491&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:3
&gt; &gt; +        Do dot allow selection of editable content when not editing.
&gt; 
&gt; s/dot/not/?
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:11
&gt; &gt; +        When retrieving the position information, we should not consider
&gt; &gt; +        as candidates for selection editable elements, since this is only
&gt; &gt; +        used for non editable selections.
&gt; 
&gt; Seems like this should be quite easy to test with some of the stuff that
&gt; Megan has been hooking up, no?

Yes, I&apos;ll write a test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266364</commentid>
    <comment_count>4</comment_count>
      <attachid>298731</attachid>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2017-01-12 16:27:47 -0800</bug_when>
    <thetext>Created attachment 298731
Patch2

Patch with test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266365</commentid>
    <comment_count>5</comment_count>
      <attachid>298731</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-01-12 16:31:15 -0800</bug_when>
    <thetext>Comment on attachment 298731
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=298731&amp;action=review

&gt; LayoutTests/fast/events/touch/ios/long-press-on-editable.html:21
&gt; +        function getTapScript()

Nothing ever calls this function?

&gt; LayoutTests/fast/events/touch/ios/long-press-on-editable.html:28
&gt; +             })();`

This line is indented wrong, I think. One space too many?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266366</commentid>
    <comment_count>6</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2017-01-12 16:33:20 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; Comment on attachment 298731 [details]
&gt; Patch2
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=298731&amp;action=review
&gt; 
&gt; &gt; LayoutTests/fast/events/touch/ios/long-press-on-editable.html:21
&gt; &gt; +        function getTapScript()
&gt; 
&gt; Nothing ever calls this function?
&gt; 
&gt; &gt; LayoutTests/fast/events/touch/ios/long-press-on-editable.html:28
&gt; &gt; +             })();`
&gt; 
&gt; This line is indented wrong, I think. One space too many?

Copy paste :-( Will fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266369</commentid>
    <comment_count>7</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2017-01-12 16:38:18 -0800</bug_when>
    <thetext>Committed revision 210687.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>298491</attachid>
            <date>2017-01-10 11:27:55 -0800</date>
            <delta_ts>2017-01-12 16:27:47 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>dontselecteditable.txt</filename>
            <type>text/plain</type>
            <size>3530</size>
            <attacher name="Enrica Casucci">enrica</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDU1NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTEwICBFbnJpY2Eg
Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgRG8gZG90IGFsbG93IHNlbGVj
dGlvbiBvZiBlZGl0YWJsZSBjb250ZW50IHdoZW4gbm90IGVkaXRpbmcuCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY4OTcKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzI5Mzg4ODA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFdoZW4gcmV0cmlldmluZyB0aGUgcG9zaXRpb24gaW5mb3JtYXRpb24sIHdl
IHNob3VsZCBub3QgY29uc2lkZXIKKyAgICAgICAgYXMgY2FuZGlkYXRlcyBmb3Igc2VsZWN0aW9u
IGVkaXRhYmxlIGVsZW1lbnRzLCBzaW5jZSB0aGlzIGlzIG9ubHkKKyAgICAgICAgdXNlZCBmb3Ig
bm9uIGVkaXRhYmxlIHNlbGVjdGlvbnMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv
aW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OmlzQXNzaXN0YWJsZUVsZW1lbnQp
OiBKdXN0IG1vdmVkIGluIHRoZSBmaWxlLgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpnZXRQ
b3NpdGlvbkluZm9ybWF0aW9uKToKKwogMjAxNy0wMS0xMCAgWmFuIERvYmVyc2VrICA8emRvYmVy
c2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVGhyZWFkZWRDb29yZGluYXRlZExheWVyVHJlZUhv
c3Q6OnJlbmRlck5leHRGcmFtZSgpIHNob3VsZCBzaG9ydC1jdXQgdG8gbGF5ZXIgZmx1c2hpbmcK
SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t
bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl
YlBhZ2VJT1MubW0JKHJldmlzaW9uIDIxMDUxMykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl
c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjI4Miw2ICsy
MjgyLDIwIEBAIHN0YXRpYyBFbGVtZW50KiBjb250YWluaW5nTGlua0VsZW1lbnQoRWwKICAgICBy
ZXR1cm4gbnVsbHB0cjsKIH0KIAorc3RhdGljIGlubGluZSBib29sIGlzQXNzaXN0YWJsZUVsZW1l
bnQoRWxlbWVudCYgbm9kZSkKK3sKKyAgICBpZiAoaXM8SFRNTFNlbGVjdEVsZW1lbnQ+KG5vZGUp
KQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBpZiAoaXM8SFRNTFRleHRBcmVhRWxlbWVudD4o
bm9kZSkpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmIChpczxIVE1MSW5wdXRFbGVtZW50
Pihub2RlKSkgeworICAgICAgICBIVE1MSW5wdXRFbGVtZW50JiBpbnB1dEVsZW1lbnQgPSBkb3du
Y2FzdDxIVE1MSW5wdXRFbGVtZW50Pihub2RlKTsKKyAgICAgICAgLy8gRklYTUU6IFRoaXMgbGF1
bmRyeSBsaXN0IG9mIHR5cGVzIGlzIG5vdCBhIGdvb2Qgd2F5IHRvIGZhY3RvciB0aGlzLiBOZWVk
IGEgc3VpdGFibGUgZnVuY3Rpb24gb24gSFRNTElucHV0RWxlbWVudCBpdHNlbGYuCisgICAgICAg
IHJldHVybiBpbnB1dEVsZW1lbnQuaXNUZXh0RmllbGQoKSB8fCBpbnB1dEVsZW1lbnQuaXNEYXRl
RmllbGQoKSB8fCBpbnB1dEVsZW1lbnQuaXNEYXRlVGltZUxvY2FsRmllbGQoKSB8fCBpbnB1dEVs
ZW1lbnQuaXNNb250aEZpZWxkKCkgfHwgaW5wdXRFbGVtZW50LmlzVGltZUZpZWxkKCk7CisgICAg
fQorICAgIHJldHVybiBub2RlLmlzQ29udGVudEVkaXRhYmxlKCk7Cit9CisKIHZvaWQgV2ViUGFn
ZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbihjb25zdCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVx
dWVzdCYgcmVxdWVzdCwgSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24mIGluZm8pCiB7
CiAgICAgaW5mby5yZXF1ZXN0ID0gcmVxdWVzdDsKQEAgLTI0MzUsNyArMjQ0OSw3IEBAIHZvaWQg
V2ViUGFnZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbihjb24KICAgICAgICAgICAgIH0gZWxzZSB7
CiAgICAgICAgICAgICAgICAgaW5mby5pc1NlbGVjdGFibGUgPSByZW5kZXJlci0+c3R5bGUoKS51
c2VyU2VsZWN0KCkgIT0gU0VMRUNUX05PTkU7CiAgICAgICAgICAgICAgICAgaWYgKGluZm8uaXNT
ZWxlY3RhYmxlICYmICFoaXROb2RlLT5pc1RleHROb2RlKCkpCi0gICAgICAgICAgICAgICAgICAg
IGluZm8uaXNTZWxlY3RhYmxlID0gIXJlY3RJc1Rvb0JpZ0ZvclNlbGVjdGlvbihpbmZvLmJvdW5k
cywgKnJlc3VsdC5pbm5lck5vZGVGcmFtZSgpKTsKKyAgICAgICAgICAgICAgICAgICAgaW5mby5p
c1NlbGVjdGFibGUgPSAhaXNBc3Npc3RhYmxlRWxlbWVudCgqZG93bmNhc3Q8RWxlbWVudD4oaGl0
Tm9kZSkpICYmICFyZWN0SXNUb29CaWdGb3JTZWxlY3Rpb24oaW5mby5ib3VuZHMsICpyZXN1bHQu
aW5uZXJOb2RlRnJhbWUoKSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CkBAIC0y
NDk3LDIwICsyNTExLDYgQEAgdm9pZCBXZWJQYWdlOjpwZXJmb3JtQWN0aW9uT25FbGVtZW50KHVp
bgogICAgIH0KIH0KIAotc3RhdGljIGlubGluZSBib29sIGlzQXNzaXN0YWJsZUVsZW1lbnQoRWxl
bWVudCYgbm9kZSkKLXsKLSAgICBpZiAoaXM8SFRNTFNlbGVjdEVsZW1lbnQ+KG5vZGUpKQotICAg
ICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAoaXM8SFRNTFRleHRBcmVhRWxlbWVudD4obm9kZSkp
Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIGlmIChpczxIVE1MSW5wdXRFbGVtZW50Pihub2Rl
KSkgewotICAgICAgICBIVE1MSW5wdXRFbGVtZW50JiBpbnB1dEVsZW1lbnQgPSBkb3duY2FzdDxI
VE1MSW5wdXRFbGVtZW50Pihub2RlKTsKLSAgICAgICAgLy8gRklYTUU6IFRoaXMgbGF1bmRyeSBs
aXN0IG9mIHR5cGVzIGlzIG5vdCBhIGdvb2Qgd2F5IHRvIGZhY3RvciB0aGlzLiBOZWVkIGEgc3Vp
dGFibGUgZnVuY3Rpb24gb24gSFRNTElucHV0RWxlbWVudCBpdHNlbGYuCi0gICAgICAgIHJldHVy
biBpbnB1dEVsZW1lbnQuaXNUZXh0RmllbGQoKSB8fCBpbnB1dEVsZW1lbnQuaXNEYXRlRmllbGQo
KSB8fCBpbnB1dEVsZW1lbnQuaXNEYXRlVGltZUxvY2FsRmllbGQoKSB8fCBpbnB1dEVsZW1lbnQu
aXNNb250aEZpZWxkKCkgfHwgaW5wdXRFbGVtZW50LmlzVGltZUZpZWxkKCk7Ci0gICAgfQotICAg
IHJldHVybiBub2RlLmlzQ29udGVudEVkaXRhYmxlKCk7Ci19Ci0KIHN0YXRpYyBpbmxpbmUgRWxl
bWVudCogbmV4dEFzc2lzdGFibGVFbGVtZW50KE5vZGUqIHN0YXJ0Tm9kZSwgUGFnZSYgcGFnZSwg
Ym9vbCBpc0ZvcndhcmQpCiB7CiAgICAgaWYgKCFpczxFbGVtZW50PihzdGFydE5vZGUpKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>298731</attachid>
            <date>2017-01-12 16:27:47 -0800</date>
            <delta_ts>2017-01-12 16:31:15 -0800</delta_ts>
            <desc>Patch2</desc>
            <filename>dontselecteditable.txt</filename>
            <type>text/plain</type>
            <size>6910</size>
            <attacher name="Enrica Casucci">enrica</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDY4NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAxLTEyICBFbnJpY2Eg
Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgRG8gbm90IGFsbG93IHNlbGVj
dGlvbiBvZiBlZGl0YWJsZSBjb250ZW50IHdoZW4gbm90IGVkaXRpbmcuCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY4OTcKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzI5Mzg4ODA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL3RvdWNoL2lvcy9sb25nLXByZXNzLW9uLWVk
aXRhYmxlLmh0bWwKKworICAgICAgICBXaGVuIHJldHJpZXZpbmcgdGhlIHBvc2l0aW9uIGluZm9y
bWF0aW9uLCB3ZSBzaG91bGQgbm90IGNvbnNpZGVyCisgICAgICAgIGFzIGNhbmRpZGF0ZXMgZm9y
IHNlbGVjdGlvbiBlZGl0YWJsZSBlbGVtZW50cywgc2luY2UgdGhpcyBpcyBvbmx5CisgICAgICAg
IHVzZWQgZm9yIG5vbiBlZGl0YWJsZSBzZWxlY3Rpb25zLgorCisgICAgICAgICogV2ViUHJvY2Vz
cy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0Ojppc0Fzc2lzdGFi
bGVFbGVtZW50KTogTW92ZWQgd2l0aGluIHRoZSBmaWxlLgorICAgICAgICAoV2ViS2l0OjpXZWJQ
YWdlOjpnZXRQb3NpdGlvbkluZm9ybWF0aW9uKToKKwogMjAxNy0wMS0xMiAgTWVnYW4gR2FyZG5l
ciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAgIERvdWJsZSBDaGVjayBVUkxz
IG9uIFVJIHNpZGUgYmVmb3JlIHB1dHRpbmcgaW4gcGFzdGVib2FyZApJbmRleDogU291cmNlL1dl
YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2
aXNpb24gMjEwNTYzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9X
ZWJQYWdlSU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMjgyLDYgKzIyODIsMjAgQEAgc3RhdGlj
IEVsZW1lbnQqIGNvbnRhaW5pbmdMaW5rRWxlbWVudChFbAogICAgIHJldHVybiBudWxscHRyOwog
fQogCitzdGF0aWMgaW5saW5lIGJvb2wgaXNBc3Npc3RhYmxlRWxlbWVudChFbGVtZW50JiBub2Rl
KQoreworICAgIGlmIChpczxIVE1MU2VsZWN0RWxlbWVudD4obm9kZSkpCisgICAgICAgIHJldHVy
biB0cnVlOworICAgIGlmIChpczxIVE1MVGV4dEFyZWFFbGVtZW50Pihub2RlKSkKKyAgICAgICAg
cmV0dXJuIHRydWU7CisgICAgaWYgKGlzPEhUTUxJbnB1dEVsZW1lbnQ+KG5vZGUpKSB7CisgICAg
ICAgIEhUTUxJbnB1dEVsZW1lbnQmIGlucHV0RWxlbWVudCA9IGRvd25jYXN0PEhUTUxJbnB1dEVs
ZW1lbnQ+KG5vZGUpOworICAgICAgICAvLyBGSVhNRTogVGhpcyBsYXVuZHJ5IGxpc3Qgb2YgdHlw
ZXMgaXMgbm90IGEgZ29vZCB3YXkgdG8gZmFjdG9yIHRoaXMuIE5lZWQgYSBzdWl0YWJsZSBmdW5j
dGlvbiBvbiBIVE1MSW5wdXRFbGVtZW50IGl0c2VsZi4KKyAgICAgICAgcmV0dXJuIGlucHV0RWxl
bWVudC5pc1RleHRGaWVsZCgpIHx8IGlucHV0RWxlbWVudC5pc0RhdGVGaWVsZCgpIHx8IGlucHV0
RWxlbWVudC5pc0RhdGVUaW1lTG9jYWxGaWVsZCgpIHx8IGlucHV0RWxlbWVudC5pc01vbnRoRmll
bGQoKSB8fCBpbnB1dEVsZW1lbnQuaXNUaW1lRmllbGQoKTsKKyAgICB9CisgICAgcmV0dXJuIG5v
ZGUuaXNDb250ZW50RWRpdGFibGUoKTsKK30KKwogdm9pZCBXZWJQYWdlOjpnZXRQb3NpdGlvbklu
Zm9ybWF0aW9uKGNvbnN0IEludGVyYWN0aW9uSW5mb3JtYXRpb25SZXF1ZXN0JiByZXF1ZXN0LCBJ
bnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbiYgaW5mbykKIHsKICAgICBpbmZvLnJlcXVl
c3QgPSByZXF1ZXN0OwpAQCAtMjQzNSw3ICsyNDQ5LDcgQEAgdm9pZCBXZWJQYWdlOjpnZXRQb3Np
dGlvbkluZm9ybWF0aW9uKGNvbgogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAg
ICBpbmZvLmlzU2VsZWN0YWJsZSA9IHJlbmRlcmVyLT5zdHlsZSgpLnVzZXJTZWxlY3QoKSAhPSBT
RUxFQ1RfTk9ORTsKICAgICAgICAgICAgICAgICBpZiAoaW5mby5pc1NlbGVjdGFibGUgJiYgIWhp
dE5vZGUtPmlzVGV4dE5vZGUoKSkKLSAgICAgICAgICAgICAgICAgICAgaW5mby5pc1NlbGVjdGFi
bGUgPSAhcmVjdElzVG9vQmlnRm9yU2VsZWN0aW9uKGluZm8uYm91bmRzLCAqcmVzdWx0LmlubmVy
Tm9kZUZyYW1lKCkpOworICAgICAgICAgICAgICAgICAgICBpbmZvLmlzU2VsZWN0YWJsZSA9ICFp
c0Fzc2lzdGFibGVFbGVtZW50KCpkb3duY2FzdDxFbGVtZW50PihoaXROb2RlKSkgJiYgIXJlY3RJ
c1Rvb0JpZ0ZvclNlbGVjdGlvbihpbmZvLmJvdW5kcywgKnJlc3VsdC5pbm5lck5vZGVGcmFtZSgp
KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KQEAgLTI0OTcsMjAgKzI1MTEsNiBA
QCB2b2lkIFdlYlBhZ2U6OnBlcmZvcm1BY3Rpb25PbkVsZW1lbnQodWluCiAgICAgfQogfQogCi1z
dGF0aWMgaW5saW5lIGJvb2wgaXNBc3Npc3RhYmxlRWxlbWVudChFbGVtZW50JiBub2RlKQotewot
ICAgIGlmIChpczxIVE1MU2VsZWN0RWxlbWVudD4obm9kZSkpCi0gICAgICAgIHJldHVybiB0cnVl
OwotICAgIGlmIChpczxIVE1MVGV4dEFyZWFFbGVtZW50Pihub2RlKSkKLSAgICAgICAgcmV0dXJu
IHRydWU7Ci0gICAgaWYgKGlzPEhUTUxJbnB1dEVsZW1lbnQ+KG5vZGUpKSB7Ci0gICAgICAgIEhU
TUxJbnB1dEVsZW1lbnQmIGlucHV0RWxlbWVudCA9IGRvd25jYXN0PEhUTUxJbnB1dEVsZW1lbnQ+
KG5vZGUpOwotICAgICAgICAvLyBGSVhNRTogVGhpcyBsYXVuZHJ5IGxpc3Qgb2YgdHlwZXMgaXMg
bm90IGEgZ29vZCB3YXkgdG8gZmFjdG9yIHRoaXMuIE5lZWQgYSBzdWl0YWJsZSBmdW5jdGlvbiBv
biBIVE1MSW5wdXRFbGVtZW50IGl0c2VsZi4KLSAgICAgICAgcmV0dXJuIGlucHV0RWxlbWVudC5p
c1RleHRGaWVsZCgpIHx8IGlucHV0RWxlbWVudC5pc0RhdGVGaWVsZCgpIHx8IGlucHV0RWxlbWVu
dC5pc0RhdGVUaW1lTG9jYWxGaWVsZCgpIHx8IGlucHV0RWxlbWVudC5pc01vbnRoRmllbGQoKSB8
fCBpbnB1dEVsZW1lbnQuaXNUaW1lRmllbGQoKTsKLSAgICB9Ci0gICAgcmV0dXJuIG5vZGUuaXND
b250ZW50RWRpdGFibGUoKTsKLX0KLQogc3RhdGljIGlubGluZSBFbGVtZW50KiBuZXh0QXNzaXN0
YWJsZUVsZW1lbnQoTm9kZSogc3RhcnROb2RlLCBQYWdlJiBwYWdlLCBib29sIGlzRm9yd2FyZCkK
IHsKICAgICBpZiAoIWlzPEVsZW1lbnQ+KHN0YXJ0Tm9kZSkpCkluZGV4OiBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAy
MTA1NjMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr
MSwxNCBAQAorMjAxNy0wMS0xMiAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgor
CisgICAgICAgIERvIG5vdCBhbGxvdyBzZWxlY3Rpb24gb2YgZWRpdGFibGUgY29udGVudCB3aGVu
IG5vdCBlZGl0aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTY2ODk3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTM4ODgwNj4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL3Rv
dWNoL2lvcy9sb25nLXByZXNzLW9uLWVkaXRhYmxlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg
ICAgICogZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJlc3Mtb24tZWRpdGFibGUuaHRtbDog
QWRkZWQuCisKIDIwMTctMDEtMTAgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j
b20+CiAKICAgICAgICAgSW1wbGVtZW50ICJwcm94aW1pdHkiIHNjcm9sbCBzbmFwcGluZwpJbmRl
eDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJlc3Mtb24tZWRpdGFi
bGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Rv
dWNoL2lvcy9sb25nLXByZXNzLW9uLWVkaXRhYmxlLWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQp
CisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy1vbi1lZGl0
YWJsZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyIEBACitQQVNTOiBu
byBzZWxlY3Rpb24gbWFkZQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9p
b3MvbG9uZy1wcmVzcy1vbi1lZGl0YWJsZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz
L2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9sb25nLXByZXNzLW9uLWVkaXRhYmxlLmh0bWwJKG5vbmV4
aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJlc3Mt
b24tZWRpdGFibGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDY5IEBACis8IURPQ1RZ
UEUgaHRtbD4KKworPGh0bWw+Cis8aGVhZD4KKyAgICA8c2NyaXB0PgorICAgICAgICBpZiAod2lu
ZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwor
ICAgICAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIH0KKworICAg
ICAgICBmdW5jdGlvbiBnZXRQcmVzc1NjcmlwdCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHJl
dHVybiBgCisgICAgICAgICAgICAoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgdWlDb250
cm9sbGVyLmxvbmdQcmVzc0F0UG9pbnQoMzAsIDIwLCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAg
ICAgICAgICAgdWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUoKTsKKyAgICAgICAgICAgICAg
ICB9KTsKKyAgICAgICAgICAgIH0pKCk7YAorICAgICAgICB9CisgICAgCisgICAgICAgIGZ1bmN0
aW9uIGdldFRhcFNjcmlwdCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiBgCisgICAg
ICAgICAgICAoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgdWlDb250cm9sbGVyLnNpbmdsZVRh
cEF0UG9pbnQoMzAsIDIwLCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICAgdWlDb250cm9s
bGVyLnVpU2NyaXB0Q29tcGxldGUoKTsKKyAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAg
ICB9KSgpO2AKKyAgICAgICAgfQorICAgIAorICAgICAgICBmdW5jdGlvbiBydW5UZXN0KCkKKyAg
ICAgICAgeworICAgICAgICAgICAgaWYgKCF0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KQorICAgICAg
ICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgdmFyIG91dHB1dCA9ICcnOworICAgICAg
ICAgICAgdmFyIHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0YXJnZXQnKTsKKyAg
ICAgICAgICAgIGlmICh0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KSB7CisgICAgICAgICAgICAgICAg
dGVzdFJ1bm5lci5ydW5VSVNjcmlwdChnZXRQcmVzc1NjcmlwdCgpLCBmdW5jdGlvbihyZXN1bHQp
IHsKKyAgICAgICAgICAgICAgICAgICAgdmFyIHNlbGVjdGlvblRleHQgPSBkb2N1bWVudC5nZXRT
ZWxlY3Rpb24oKS50b1N0cmluZygpOworICAgICAgICAgICAgICAgICAgICBpZiAoc2VsZWN0aW9u
VGV4dCA9PSAiUHJlc3NNZSIpCisgICAgICAgICAgICAgICAgICAgICAgICBvdXRwdXQgKz0gJ0ZB
SUxFRDogU2VsZWN0ZWQ6ICcgKyBzZWxlY3Rpb25UZXh0OworICAgICAgICAgICAgICAgICAgICBl
bHNlCisgICAgICAgICAgICAgICAgICAgICAgICBvdXRwdXQgKz0gJ1BBU1M6IG5vIHNlbGVjdGlv
biBtYWRlJzsKKyAgICAgICAgICAgICAgICAgICAgb3V0cHV0ICs9ICc8YnI+JzsKKyAgICAgICAg
ICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RhcmdldCcpLmlubmVySFRNTCA9
IG91dHB1dDsKKyAgICAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cisg
ICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgICAgICB3
aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIHJ1blRlc3QsIGZhbHNlKTsKKyAgICA8L3Nj
cmlwdD4KKyAgICA8c3R5bGU+CisgICAgICAgICN0YXJnZXQgeworICAgICAgICAgICAgaGVpZ2h0
OiAxMDBweDsKKyAgICAgICAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgICAgIGJhY2tncm91
bmQtY29sb3I6IHNpbHZlcjsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPG1ldGEgbmFt
ZT0idmlld3BvcnQiIGNvbnRlbnQ9ImluaXRpYWwtc2NhbGU9MSI+Cis8L2hlYWQ+Cis8Ym9keT4K
KzxkaXYgaWQ9InRhcmdldCI+CisJPHRleHRhcmVhPlByZXNzTWU8L3RleHRhcmVhPgorICAgIFRo
aXMgdGVzdCByZXF1aXJlcyBVSVNjcmlwdENvbnRyb2xsZXIgdG8gcnVuLgorPC9kaXY+Cis8L2Jv
ZHk+Cis8L2h0bWw+Cg==
</data>
<flag name="review"
          id="320837"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
      

    </bug>

</bugzilla>