166892 2017-01-10 10:18:14 -0800 Web Inspector: fix UIString for Print Styles button 2017-01-11 12:31:56 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi bburg commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1265410 0 bburg 2017-01-10 10:18:14 -0800 Per ASG, this should say 'turn on/off' instead of enable/disable. 1265411 1 webkit-bug-importer 2017-01-10 10:18:30 -0800 <rdar://problem/29950216> 1265435 2 bburg 2017-01-10 10:59:36 -0800 Or even better, it could say "Force Print Media Styles" / "Use Default Media Styles". In the documentation we would have a better explanation that @media is being overridden to 'print' when this is on. 1265439 3 joepeck 2017-01-10 11:11:39 -0800 (In reply to comment #2) > Or even better, it could say "Force Print Media Styles" / "Use Default Media Styles". I like that! 1265621 4 298536 hi 2017-01-10 17:35:44 -0800 Created attachment 298536 Patch 1265794 5 298536 bburg 2017-01-11 09:59:51 -0800 Comment on attachment 298536 Patch rs=me, Thanks Devin! 1265838 6 298536 joepeck 2017-01-11 11:10:04 -0800 Comment on attachment 298536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298536&action=review > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814 > +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles"; Should the "s" in "Styles" be capitalized for these? 1265847 7 bburg 2017-01-11 11:31:02 -0800 (In reply to comment #6) > Comment on attachment 298536 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298536&action=review > > > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814 > > +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles"; > > Should the "s" in "Styles" be capitalized for these? It's unclear whether this string should be title case. This seems more like a button label than a description. We are inconsistent about this in many places. 1265849 8 bburg 2017-01-11 11:35:24 -0800 (In reply to comment #7) > (In reply to comment #6) > > Comment on attachment 298536 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=298536&action=review > > > > > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814 > > > +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles"; > > > > Should the "s" in "Styles" be capitalized for these? > > It's unclear whether this string should be title case. This seems more like > a button label than a description. We are inconsistent about this in many > places. More context: https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/20000957-CH15-SW4 This seems to be a help tag for button. Since the AX title would be categorized like Push Button, I think this is still the correct capitalization. 1265872 9 298536 commit-queue 2017-01-11 12:31:52 -0800 Comment on attachment 298536 Patch Clearing flags on attachment: 298536 Committed r210594: <http://trac.webkit.org/changeset/210594> 1265873 10 commit-queue 2017-01-11 12:31:56 -0800 All reviewed patches have been landed. Closing bug. 298536 2017-01-10 17:35:44 -0800 2017-01-11 12:31:52 -0800 Patch bug-166892-20170110173407.patch text/plain 4518 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU2NmJjODEwNWRhZjEzMTVlMmVhY2QwOWEyNzE0 ODcwNGQ1MmZmZDguLjhlMzczMThlMTBhOWIzMjU5YTcxOGI1NDZmZjYxMjI1YWZhZjBmMGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTEwICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGZpeCBVSVN0cmluZyBmb3IgUHJpbnQgU3R5bGVzIGJ1dHRvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2ODkyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9E T01UcmVlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUNvbnRl bnRWaWV3KToKKyAgICAgICAgQ2hhbmdlZCBVSVN0cmluZyB0byBiZXR0ZXIgbWF0Y2ggZG9jdW1l bnRhdGlvbi4KKwogMjAxNy0wMS0wOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMDI2MC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5s cHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDUwYjY2M2Q5Y2E3ZjA2MTI0ZjhmNmE0ZTlh ZTg4YjA0NjBjNjBmMTEuLjc5Y2E4MDA4ZTE5NGJmMzc4ZmU2MTVjYTcxOTM2NWRhMzRmYmU1YTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9q L2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXph dGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtMjU1LDcgKzI1NSw2IEBAIGxv Y2FsaXplZFN0cmluZ3NbIkRpc2FibGUgQnJlYWtwb2ludCJdID0gIkRpc2FibGUgQnJlYWtwb2lu dCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJEaXNhYmxlIEJyZWFrcG9pbnRzIl0gPSAiRGlzYWJsZSBC cmVha3BvaW50cyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJEaXNhYmxlIGFsbCBicmVha3BvaW50cyAo JXMpIl0gPSAiRGlzYWJsZSBhbGwgYnJlYWtwb2ludHMgKCVzKSI7CiBsb2NhbGl6ZWRTdHJpbmdz WyJEaXNhYmxlIHBhaW50IGZsYXNoaW5nIl0gPSAiRGlzYWJsZSBwYWludCBmbGFzaGluZyI7Ci1s b2NhbGl6ZWRTdHJpbmdzWyJEaXNhYmxlIHByaW50IHN0eWxlcyJdID0gIkRpc2FibGUgcHJpbnQg c3R5bGVzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkRpc2FibGVkIl0gPSAiRGlzYWJsZWQiOwogbG9j YWxpemVkU3RyaW5nc1siRGlzcGxheSJdID0gIkRpc3BsYXkiOwogbG9jYWxpemVkU3RyaW5nc1si RG8gbm90IGZhZGUgdW5leGVjdXRlZCBjb2RlIl0gPSAiRG8gbm90IGZhZGUgdW5leGVjdXRlZCBj b2RlIjsKQEAgLTMxNiw3ICszMTUsNiBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJFbmFibGUgQnJlYWtw b2ludHMiXSA9ICJFbmFibGUgQnJlYWtwb2ludHMiOwogbG9jYWxpemVkU3RyaW5nc1siRW5hYmxl IGFsbCBicmVha3BvaW50cyAoJXMpIl0gPSAiRW5hYmxlIGFsbCBicmVha3BvaW50cyAoJXMpIjsK IGxvY2FsaXplZFN0cmluZ3NbIkVuYWJsZSBicmVha3BvaW50cy4iXSA9ICJFbmFibGUgYnJlYWtw b2ludHMuIjsKIGxvY2FsaXplZFN0cmluZ3NbIkVuYWJsZSBwYWludCBmbGFzaGluZyJdID0gIkVu YWJsZSBwYWludCBmbGFzaGluZyI7Ci1sb2NhbGl6ZWRTdHJpbmdzWyJFbmFibGUgcHJpbnQgc3R5 bGVzIl0gPSAiRW5hYmxlIHByaW50IHN0eWxlcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFbmNvZGVk Il0gPSAiRW5jb2RlZCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFbmNvZGluZyJdID0gIkVuY29kaW5n IjsKIGxvY2FsaXplZFN0cmluZ3NbIkVudGVyIENsYXNzIE5hbWUiXSA9ICJFbnRlciBDbGFzcyBO YW1lIjsKQEAgLTM2OSw2ICszNjcsNyBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJGb2N1cyBvbiBTdWJ0 cmVlIl0gPSAiRm9jdXMgb24gU3VidHJlZSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJGb2N1c2VkIl0g PSAiRm9jdXNlZCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJGb250Il0gPSAiRm9udCI7CiBsb2NhbGl6 ZWRTdHJpbmdzWyJGb250cyJdID0gIkZvbnRzIjsKK2xvY2FsaXplZFN0cmluZ3NbIkZvcmNlIFBy aW50IE1lZGlhIFN0eWxlcyJdID0gIkZvcmNlIFByaW50IE1lZGlhIFN0eWxlcyI7CiBsb2NhbGl6 ZWRTdHJpbmdzWyJGb3JjZWQgTGF5b3V0Il0gPSAiRm9yY2VkIExheW91dCI7CiBsb2NhbGl6ZWRT dHJpbmdzWyJGb3JjZWQgUHNldWRvLUNsYXNzZXMiXSA9ICJGb3JjZWQgUHNldWRvLUNsYXNzZXMi OwogbG9jYWxpemVkU3RyaW5nc1siRm9ybWF0OiBIU0wiXSA9ICJGb3JtYXQ6IEhTTCI7CkBAIC04 MTIsNiArODExLDcgQEAgbG9jYWxpemVkU3RyaW5nc1siVW5jb21tZW50IEFsbCBQcm9wZXJ0aWVz Il0gPSAiVW5jb21tZW50IEFsbCBQcm9wZXJ0aWVzIjsKIGxvY2FsaXplZFN0cmluZ3NbIlVuaXF1 ZSJdID0gIlVuaXF1ZSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJVbmtub3duIG5vZGUiXSA9ICJVbmtu b3duIG5vZGUiOwogbG9jYWxpemVkU3RyaW5nc1siVW50aXRsZWQiXSA9ICJVbnRpdGxlZCI7Cits b2NhbGl6ZWRTdHJpbmdzWyJVc2UgRGVmYXVsdCBNZWRpYSBTdHlsZXMiXSA9ICJVc2UgRGVmYXVs dCBNZWRpYSBTdHlsZXMiOwogbG9jYWxpemVkU3RyaW5nc1siVXNlciBBZ2VudCJdID0gIlVzZXIg QWdlbnQiOwogbG9jYWxpemVkU3RyaW5nc1siVXNlciBBZ2VudCBTdHlsZXNoZWV0Il0gPSAiVXNl ciBBZ2VudCBTdHlsZXNoZWV0IjsKIGxvY2FsaXplZFN0cmluZ3NbIlVzZXIgU3R5bGVzaGVldCJd ID0gIlVzZXIgU3R5bGVzaGVldCI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMKaW5kZXgg MzIzNzI5NjFiMDk4YjA5NzhhZGEzNTZlNzFiM2FlYzZjYzEzMzZlOS4uMzdkOWRhZTBkMjU1ZWZi YjBkMmU2MGU2MGYwZGY3MjE2NmNhYjE1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5q cwpAQCAtNDcsNyArNDcsNyBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZUNvbnRlbnRWaWV3ID0gY2xh c3MgRE9NVHJlZUNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLgogICAgICAgICB0aGlz Ll9zaG93U2hhZG93RE9NU2V0dGluZ0NoYW5nZWQoKTsKIAogICAgICAgICBXZWJJbnNwZWN0b3Iu c2hvd1ByaW50U3R5bGVzU2V0dGluZy5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5TZXR0 aW5nLkV2ZW50LkNoYW5nZWQsIHRoaXMuX3Nob3dQcmludFN0eWxlc1NldHRpbmdDaGFuZ2VkLCB0 aGlzKTsKLSAgICAgICAgdGhpcy5fc2hvd1ByaW50U3R5bGVzQnV0dG9uTmF2aWdhdGlvbkl0ZW0g PSBuZXcgV2ViSW5zcGVjdG9yLkFjdGl2YXRlQnV0dG9uTmF2aWdhdGlvbkl0ZW0oInByaW50LXN0 eWxlcyIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiRW5hYmxlIHByaW50IHN0eWxlcyIpLCBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIkRpc2FibGUgcHJpbnQgc3R5bGVzIiksICJJbWFnZXMvUHJpbnRl ci5zdmciLCAxNiwgMTYpOworICAgICAgICB0aGlzLl9zaG93UHJpbnRTdHlsZXNCdXR0b25OYXZp Z2F0aW9uSXRlbSA9IG5ldyBXZWJJbnNwZWN0b3IuQWN0aXZhdGVCdXR0b25OYXZpZ2F0aW9uSXRl bSgicHJpbnQtc3R5bGVzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJGb3JjZSBQcmludCBNZWRp YSBTdHlsZXMiKSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJVc2UgRGVmYXVsdCBNZWRpYSBTdHls ZXMiKSwgIkltYWdlcy9QcmludGVyLnN2ZyIsIDE2LCAxNik7CiAgICAgICAgIHRoaXMuX3Nob3dQ cmludFN0eWxlc0J1dHRvbk5hdmlnYXRpb25JdGVtLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVj dG9yLkJ1dHRvbk5hdmlnYXRpb25JdGVtLkV2ZW50LkNsaWNrZWQsIHRoaXMuX3RvZ2dsZVByaW50 U3R5bGVzU2V0dGluZywgdGhpcyk7CiAgICAgICAgIHRoaXMuX3Nob3dQcmludFN0eWxlc1NldHRp bmdDaGFuZ2VkKCk7CiAK