166875 2017-01-09 19:49:52 -0800 Crash when WebCore's GC heap grows way too large. 2017-01-11 16:56:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 166896 1 kling kling barraclough benjamin cdumez cmarcelo commit-queue dbates fpizlo ggaren keith_miller kling mark.lam msaboff saam oldest_to_newest 1265266 0 kling 2017-01-09 19:49:52 -0800 <rdar://problem/27896585> Let's put a hard limit on the GC and crash instead of descending into swap hell. 1265283 1 298442 kling 2017-01-09 20:38:03 -0800 Created attachment 298442 Proposed patch 1265284 2 298442 mark.lam 2017-01-09 20:41:57 -0800 Comment on attachment 298442 Proposed patch r=me 1265332 3 298442 commit-queue 2017-01-10 04:17:37 -0800 Comment on attachment 298442 Proposed patch Clearing flags on attachment: 298442 Committed r210540: <http://trac.webkit.org/changeset/210540> 1265333 4 commit-queue 2017-01-10 04:17:42 -0800 All reviewed patches have been landed. Closing bug. 1265418 5 298442 fpizlo 2017-01-10 10:41:18 -0800 Comment on attachment 298442 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=298442&action=review > Source/JavaScriptCore/ChangeLog:10 > + Hard cap the JavaScript heap at 4GB of live objects (determined post-GC.) > + If we go past this limit, crash with a recognizable signature. Why? This is a regression. If I have 20GB of RAM, why I can't I write a JavaScript program that uses all of it? Previously, I could. Now, I can't. 1265423 6 fpizlo 2017-01-10 10:43:54 -0800 If the point is to give a quota to WebProcesses, then the max heap size should be a parameter that WebCore passes to JSC. When JSC is used as a framework, embedded in who-knows-what, I don't think we should have any such limit. 1265428 7 mark.lam 2017-01-10 10:47:15 -0800 (In reply to comment #6) > If the point is to give a quota to WebProcesses, then the max heap size > should be a parameter that WebCore passes to JSC. > > When JSC is used as a framework, embedded in who-knows-what, I don't think > we should have any such limit. That's a very good point. 1265438 8 kling 2017-01-10 11:09:35 -0800 Yeah, fair point Phil. I will roll this out and give it a do-over. 1265441 9 commit-queue 2017-01-10 11:12:16 -0800 Re-opened since this is blocked by bug 166896 1265810 10 298597 kling 2017-01-11 10:24:30 -0800 Created attachment 298597 Proposed patch Only the common WebCore VM this time. 1265818 11 298597 mark.lam 2017-01-11 10:34:56 -0800 Comment on attachment 298597 Proposed patch r=me 1265860 12 298605 kling 2017-01-11 12:09:59 -0800 Created attachment 298605 Patch for landing (Windows build fixed) 1265863 13 ggaren 2017-01-11 12:13:37 -0800 Why not apply to the limit to the WebContent process instead? 1265896 14 kling 2017-01-11 13:32:46 -0800 (In reply to comment #13) > Why not apply to the limit to the WebContent process instead? The long-term plan is to integrate with OS facilities to do that (and more.) This patch is just a stopgap mitigation for a specific pathology. 1265970 15 298605 commit-queue 2017-01-11 16:56:36 -0800 Comment on attachment 298605 Patch for landing (Windows build fixed) Clearing flags on attachment: 298605 Committed r210609: <http://trac.webkit.org/changeset/210609> 1265971 16 commit-queue 2017-01-11 16:56:42 -0800 All reviewed patches have been landed. Closing bug. 298442 2017-01-09 20:38:03 -0800 2017-01-11 10:24:30 -0800 Proposed patch bug-166875.diff text/plain 2221 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRmMTE0NTEuLjAzOWE4NTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTA5ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIEdDIGhlYXAgZ3Jvd3Mg d2F5IHRvbyBsYXJnZS4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE2Njg3NT4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3ODk2NTg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhcmQgY2FwIHRoZSBKYXZhU2NyaXB0IGhlYXAgYXQg NEdCIG9mIGxpdmUgb2JqZWN0cyAoZGV0ZXJtaW5lZCBwb3N0LUdDLikKKyAgICAgICAgSWYgd2Ug Z28gcGFzdCB0aGlzIGxpbWl0LCBjcmFzaCB3aXRoIGEgcmVjb2duaXphYmxlIHNpZ25hdHVyZS4K KworICAgICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6OmRpZEV4Y2Vl ZEhlYXBTaXplTGltaXQpOgorICAgICAgICAoSlNDOjpIZWFwOjp1cGRhdGVBbGxvY2F0aW9uTGlt aXRzKToKKwogMjAxNy0wMS0wOCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgSW5qZWN0IE1hcmtlZFNwYWNlIHNpemUgY2xhc3NlcyBmb3IgYSBmZXcgbW9yZSBo aWdoLXZvbHVtZSBvYmplY3RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAppbmRleCAy NjU4M2M0Li5iNjY1ZDBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcApAQCAtMTY5 Nyw2ICsxNjk3LDExIEBAIHZvaWQgSGVhcDo6bm90aWZ5SW5jcmVtZW50YWxTd2VlcGVyKCkKICAg ICBtX3N3ZWVwZXItPnN0YXJ0U3dlZXBpbmcoKTsKIH0KIAorTkVWRVJfSU5MSU5FIHZvaWQgSGVh cDo6ZGlkRXhjZWVkSGVhcFNpemVMaW1pdCgpCit7CisgICAgQ1JBU0goKTsKK30KKwogdm9pZCBI ZWFwOjp1cGRhdGVBbGxvY2F0aW9uTGltaXRzKCkKIHsKICAgICBzdGF0aWMgY29uc3QgYm9vbCB2 ZXJib3NlID0gZmFsc2U7CkBAIC0xNzI4LDYgKzE3MzMsMTIgQEAgdm9pZCBIZWFwOjp1cGRhdGVB bGxvY2F0aW9uTGltaXRzKCkKIAogICAgIGlmICh2ZXJib3NlKQogICAgICAgICBkYXRhTG9nKCJl eHRyYU1lbW9yeVNpemUoKSA9ICIsIGV4dHJhTWVtb3J5U2l6ZSgpLCAiLCBjdXJyZW50SGVhcFNp emUgPSAiLCBjdXJyZW50SGVhcFNpemUsICJcbiIpOworCisjaWYgVVNFKEpTVkFMVUU2NCkKKyAg ICAvLyBJZiB0aGUgaGVhcCBoYXMgZ3Jvd24gbGFyZ2VyIHRoYW4gNEdCLCBqdXN0IGNyYXNoIGJl Zm9yZSB0aGluZ3MgZ2V0IG91dCBvZiBjb250cm9sLgorICAgIGlmIChjdXJyZW50SGVhcFNpemUg PiA0MDk2ICogTUIpCisgICAgICAgIGRpZEV4Y2VlZEhlYXBTaXplTGltaXQoKTsKKyNlbmRpZgog ICAgIAogICAgIGlmIChPcHRpb25zOjpnY01heEhlYXBTaXplKCkgJiYgY3VycmVudEhlYXBTaXpl ID4gT3B0aW9uczo6Z2NNYXhIZWFwU2l6ZSgpKQogICAgICAgICBIZWFwU3RhdGlzdGljczo6ZXhp dFdpdGhGYWlsdXJlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgKaW5kZXggMzE1YWFiOS4u NWMxYjgyNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaApAQCAtNDk5LDYgKzQ5OSw4IEBA IHByaXZhdGU6CiAgICAgCiAgICAgdm9pZCBzZXRNdXRhdG9yU2hvdWxkQmVGZW5jZWQoYm9vbCB2 YWx1ZSk7CiAKKyAgICBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgZGlkRXhjZWVkSGVhcFNp emVMaW1pdCgpOworCiAgICAgY29uc3QgSGVhcFR5cGUgbV9oZWFwVHlwZTsKICAgICBjb25zdCBz aXplX3QgbV9yYW1TaXplOwogICAgIGNvbnN0IHNpemVfdCBtX21pbkJ5dGVzUGVyQ3ljbGU7Cg== 298597 2017-01-11 10:24:30 -0800 2017-01-11 12:09:59 -0800 Proposed patch bug-166875-2.diff text/plain 5145 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhhYzJlOWIuLjIzOGViYzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAxLTExICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIFdlYkNvcmUncyBHQyBo ZWFwIGdyb3dzIHdheSB0b28gbGFyZ2UuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8x NjY4NzU+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzg5NjU4NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBzaW1wbGUgQVBJIHRvIEpT Qzo6SGVhcCB0aGF0IGFsbG93cyBzZXR0aW5nIGEgaGFyZCBsaW1pdCBvbiB0aGUgYW1vdW50Cisg ICAgICAgIG9mIGxpdmUgYnl0ZXMuIElmIHRoaXMgaXMgZXhjZWVkZWQsIHdlIGNyYXNoIHdpdGgg YSByZWNvZ25pemFibGUgc2lnbmF0dXJlLgorICAgICAgICBCeSBkZWZhdWx0IHRoZXJlIGlzIG5v IGxpbWl0LgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6 ZGlkRXhjZWVkTWF4TGl2ZVNpemUpOgorICAgICAgICAoSlNDOjpIZWFwOjp1cGRhdGVBbGxvY2F0 aW9uTGltaXRzKToKKyAgICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAgICAgKEpTQzo6SGVhcDo6 c2V0TWF4TGl2ZVNpemUpOgorCiAyMDE3LTAxLTExICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50 ZWFAZ21haWwuY29tPgogCiAgICAgICAgIERlY291cGxlIG1vZHVsZSBsb2FkaW5nIGluaXRpYXRv ciBmcm9tIFNjcmlwdEVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKaW5kZXgg MDQwMzRkZi4uYmNmZjMyMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKQEAgLTE2 NzYsNiArMTY3NiwxMSBAQCB2b2lkIEhlYXA6Om5vdGlmeUluY3JlbWVudGFsU3dlZXBlcigpCiAg ICAgbV9zd2VlcGVyLT5zdGFydFN3ZWVwaW5nKCk7CiB9CiAKK05FVkVSX0lOTElORSB2b2lkIEhl YXA6OmRpZEV4Y2VlZE1heExpdmVTaXplKCkKK3sKKyAgICBDUkFTSCgpOworfQorCiB2b2lkIEhl YXA6OnVwZGF0ZUFsbG9jYXRpb25MaW1pdHMoKQogewogICAgIHN0YXRpYyBjb25zdCBib29sIHZl cmJvc2UgPSBmYWxzZTsKQEAgLTE3MDcsNiArMTcxMiw5IEBAIHZvaWQgSGVhcDo6dXBkYXRlQWxs b2NhdGlvbkxpbWl0cygpCiAKICAgICBpZiAodmVyYm9zZSkKICAgICAgICAgZGF0YUxvZygiZXh0 cmFNZW1vcnlTaXplKCkgPSAiLCBleHRyYU1lbW9yeVNpemUoKSwgIiwgY3VycmVudEhlYXBTaXpl ID0gIiwgY3VycmVudEhlYXBTaXplLCAiXG4iKTsKKworICAgIGlmIChtX21heExpdmVTaXplICYm IGN1cnJlbnRIZWFwU2l6ZSA+IG1fbWF4TGl2ZVNpemUpCisgICAgICAgIGRpZEV4Y2VlZE1heExp dmVTaXplKCk7CiAgICAgCiAgICAgaWYgKE9wdGlvbnM6OmdjTWF4SGVhcFNpemUoKSAmJiBjdXJy ZW50SGVhcFNpemUgPiBPcHRpb25zOjpnY01heEhlYXBTaXplKCkpCiAgICAgICAgIEhlYXBTdGF0 aXN0aWNzOjpleGl0V2l0aEZhaWx1cmUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL0hlYXAuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAppbmRl eCBiNWZkN2NjLi5hNmE5Nzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9IZWFwLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCkBAIC0xMzEs NiArMTMxLDkgQEAgcHVibGljOgogICAgIHZvaWQgbGFzdENoYW5jZVRvRmluYWxpemUoKTsKICAg ICB2b2lkIHJlbGVhc2VEZWxheWVkUmVsZWFzZWRPYmplY3RzKCk7CiAKKyAgICAvLyBTZXQgYSBo YXJkIGxpbWl0IHdoZXJlIEpTQyB3aWxsIGNyYXNoIGlmIGxpdmUgaGVhcCBzaXplIGV4Y2VlZHMg aXQuCisgICAgdm9pZCBzZXRNYXhMaXZlU2l6ZShzaXplX3Qgc2l6ZSkgeyBtX21heExpdmVTaXpl ID0gc2l6ZTsgfQorCiAgICAgVk0qIHZtKCkgY29uc3QgeyByZXR1cm4gbV92bTsgfQogICAgIE1h cmtlZFNwYWNlJiBvYmplY3RTcGFjZSgpIHsgcmV0dXJuIG1fb2JqZWN0U3BhY2U7IH0KICAgICBN YWNoaW5lVGhyZWFkcyYgbWFjaGluZVRocmVhZHMoKSB7IHJldHVybiBtX21hY2hpbmVUaHJlYWRz OyB9CkBAIC02MTksNiArNjIyLDkgQEAgcHJpdmF0ZToKICAgICBzaXplX3QgbV9ibG9ja0J5dGVz QWxsb2NhdGVkIHsgMCB9OwogICAgIHNpemVfdCBtX2V4dGVybmFsTWVtb3J5U2l6ZSB7IDAgfTsK ICNlbmRpZgorCisgICAgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIGRpZEV4Y2VlZE1heExp dmVTaXplKCk7CisgICAgc2l6ZV90IG1fbWF4TGl2ZVNpemUgeyAwIH07CiAgICAgCiAgICAgc3Rk Ojp1bmlxdWVfcHRyPE11dGF0b3JTY2hlZHVsZXI+IG1fc2NoZWR1bGVyOwogICAgIApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAw MjY1NmNkLi40ZWM1NmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTExICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIFdlYkNvcmUn cyBHQyBoZWFwIGdyb3dzIHdheSB0b28gbGFyZ2UuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xNjY4NzU+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzg5NjU4NT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQdWJsaXNoIHRoZSBXVEY6 OkdCIGNvbnN0YW50LgorCisgICAgICAgICogd3RmL1N0ZExpYkV4dHJhcy5oOgorCiAyMDE3LTAx LTA2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNv LnVrPgogCiAgICAgICAgIFtHVEtdIFNob3VsZCBzdXBwb3J0IGtleSBhbmQgY29kZSBwcm9wZXJ0 aWVzIG9uIGtleWJvYXJkIGV2ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvU3RkTGli RXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAppbmRleCBiMjZiNDYxLi43 NzljMzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaApAQCAtNDc3LDYgKzQ3Nyw3IEBAIEFMV0FZU19J TkxJTkUgY29uc3RleHByIHR5cGVuYW1lIHJlbW92ZV9yZWZlcmVuY2U8VD46OnR5cGUmJiBtb3Zl KFQmJiB2YWx1ZSkKIAogdXNpbmcgV1RGOjpLQjsKIHVzaW5nIFdURjo6TUI7Cit1c2luZyBXVEY6 OkdCOwogdXNpbmcgV1RGOjphcHByb3hpbWF0ZUJpbmFyeVNlYXJjaDsKIHVzaW5nIFdURjo6Ymlu YXJ5U2VhcmNoOwogdXNpbmcgV1RGOjpiaXR3aXNlX2Nhc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI2Nzg0 Yy4uYzc0MzIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAxLTExICBBbmRy ZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIFdlYkNv cmUncyBHQyBoZWFwIGdyb3dzIHdheSB0b28gbGFyZ2UuCisgICAgICAgIDxodHRwczovL3dlYmtp dC5vcmcvYi8xNjY4NzU+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzg5NjU4NT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYXAgdGhlIGNvbW1v biBXZWJDb3JlIFZNIGF0IDQgR0Igb2YgbGl2ZSBKYXZhU2NyaXB0IGhlYXAgb2JqZWN0cy4KKwor ICAgICAgICAqIGJpbmRpbmdzL2pzL0NvbW1vblZNLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNv bW1vblZNU2xvdyk6CisKIDIwMTctMDEtMTEgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMDU3MS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0NvbW1vblZNLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0NvbW1vblZNLmNwcAppbmRleCA4NmY3MDYwLi4xMzgzNjM1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9Db21tb25WTS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvQ29tbW9uVk0uY3BwCkBAIC00MCw2ICs0MCw4IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIFZNKiBnX2NvbW1vblZNT3JOdWxsOwogYm9vbCBnX29wYXF1 ZVJvb3RXcml0ZUJhcnJpZXJFbmFibGVkOwogCitzdGF0aWMgY29uc3Qgc2l6ZV90IG1heEdDSGVh cFNpemUgPSA0ICogR0I7CisKIFZNJiBjb21tb25WTVNsb3coKQogewogICAgIEFTU0VSVChpc01h aW5UaHJlYWQoKSk7CkBAIC00Nyw2ICs0OSw3IEBAIFZNJiBjb21tb25WTVNsb3coKQogICAgIAog ICAgIFNjcmlwdENvbnRyb2xsZXI6OmluaXRpYWxpemVUaHJlYWRpbmcoKTsKICAgICBnX2NvbW1v blZNT3JOdWxsID0gJlZNOjpjcmVhdGVMZWFrZWQoTGFyZ2VIZWFwKS5sZWFrUmVmKCk7CisgICAg Z19jb21tb25WTU9yTnVsbC0+aGVhcC5zZXRNYXhMaXZlU2l6ZShtYXhHQ0hlYXBTaXplKTsKICAg ICBnX2NvbW1vblZNT3JOdWxsLT5oZWFwLmFjcXVpcmVBY2Nlc3MoKTsgLy8gQXQgYW55IHRpbWUs IHdlIG1heSBkbyB0aGluZ3MgdGhhdCBhZmZlY3QgdGhlIEdDLgogI2lmICFQTEFURk9STShJT1Mp CiAgICAgZ19jb21tb25WTU9yTnVsbC0+c2V0RXhjbHVzaXZlVGhyZWFkKHN0ZDo6dGhpc190aHJl YWQ6OmdldF9pZCgpKTsK 298605 2017-01-11 12:09:59 -0800 2017-01-11 16:56:36 -0800 Patch for landing (Windows build fixed) land-166875.diff text/plain 5015 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhhYzJlOWIuLjljNGNiMzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAxLTExICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIFdlYkNvcmUncyBHQyBo ZWFwIGdyb3dzIHdheSB0b28gbGFyZ2UuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8x NjY4NzU+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzg5NjU4NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBBZGQgYSBzaW1wbGUgQVBJIHRvIEpTQzo6SGVh cCB0aGF0IGFsbG93cyBzZXR0aW5nIGEgaGFyZCBsaW1pdCBvbiB0aGUgYW1vdW50CisgICAgICAg IG9mIGxpdmUgYnl0ZXMuIElmIHRoaXMgaXMgZXhjZWVkZWQsIHdlIGNyYXNoIHdpdGggYSByZWNv Z25pemFibGUgc2lnbmF0dXJlLgorICAgICAgICBCeSBkZWZhdWx0IHRoZXJlIGlzIG5vIGxpbWl0 LgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6ZGlkRXhj ZWVkTWF4TGl2ZVNpemUpOgorICAgICAgICAoSlNDOjpIZWFwOjp1cGRhdGVBbGxvY2F0aW9uTGlt aXRzKToKKyAgICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAgICAgKEpTQzo6SGVhcDo6c2V0TWF4 TGl2ZVNpemUpOgorCiAyMDE3LTAxLTExICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21h aWwuY29tPgogCiAgICAgICAgIERlY291cGxlIG1vZHVsZSBsb2FkaW5nIGluaXRpYXRvciBmcm9t IFNjcmlwdEVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hl YXAuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKaW5kZXggMDQwMzRk Zi4uYmNmZjMyMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKQEAgLTE2NzYsNiAr MTY3NiwxMSBAQCB2b2lkIEhlYXA6Om5vdGlmeUluY3JlbWVudGFsU3dlZXBlcigpCiAgICAgbV9z d2VlcGVyLT5zdGFydFN3ZWVwaW5nKCk7CiB9CiAKK05FVkVSX0lOTElORSB2b2lkIEhlYXA6OmRp ZEV4Y2VlZE1heExpdmVTaXplKCkKK3sKKyAgICBDUkFTSCgpOworfQorCiB2b2lkIEhlYXA6OnVw ZGF0ZUFsbG9jYXRpb25MaW1pdHMoKQogewogICAgIHN0YXRpYyBjb25zdCBib29sIHZlcmJvc2Ug PSBmYWxzZTsKQEAgLTE3MDcsNiArMTcxMiw5IEBAIHZvaWQgSGVhcDo6dXBkYXRlQWxsb2NhdGlv bkxpbWl0cygpCiAKICAgICBpZiAodmVyYm9zZSkKICAgICAgICAgZGF0YUxvZygiZXh0cmFNZW1v cnlTaXplKCkgPSAiLCBleHRyYU1lbW9yeVNpemUoKSwgIiwgY3VycmVudEhlYXBTaXplID0gIiwg Y3VycmVudEhlYXBTaXplLCAiXG4iKTsKKworICAgIGlmIChtX21heExpdmVTaXplICYmIGN1cnJl bnRIZWFwU2l6ZSA+IG1fbWF4TGl2ZVNpemUpCisgICAgICAgIGRpZEV4Y2VlZE1heExpdmVTaXpl KCk7CiAgICAgCiAgICAgaWYgKE9wdGlvbnM6OmdjTWF4SGVhcFNpemUoKSAmJiBjdXJyZW50SGVh cFNpemUgPiBPcHRpb25zOjpnY01heEhlYXBTaXplKCkpCiAgICAgICAgIEhlYXBTdGF0aXN0aWNz OjpleGl0V2l0aEZhaWx1cmUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAppbmRleCBiNWZk N2NjLi5hNmE5Nzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCkBAIC0xMzEsNiArMTMx LDkgQEAgcHVibGljOgogICAgIHZvaWQgbGFzdENoYW5jZVRvRmluYWxpemUoKTsKICAgICB2b2lk IHJlbGVhc2VEZWxheWVkUmVsZWFzZWRPYmplY3RzKCk7CiAKKyAgICAvLyBTZXQgYSBoYXJkIGxp bWl0IHdoZXJlIEpTQyB3aWxsIGNyYXNoIGlmIGxpdmUgaGVhcCBzaXplIGV4Y2VlZHMgaXQuCisg ICAgdm9pZCBzZXRNYXhMaXZlU2l6ZShzaXplX3Qgc2l6ZSkgeyBtX21heExpdmVTaXplID0gc2l6 ZTsgfQorCiAgICAgVk0qIHZtKCkgY29uc3QgeyByZXR1cm4gbV92bTsgfQogICAgIE1hcmtlZFNw YWNlJiBvYmplY3RTcGFjZSgpIHsgcmV0dXJuIG1fb2JqZWN0U3BhY2U7IH0KICAgICBNYWNoaW5l VGhyZWFkcyYgbWFjaGluZVRocmVhZHMoKSB7IHJldHVybiBtX21hY2hpbmVUaHJlYWRzOyB9CkBA IC02MTksNiArNjIyLDkgQEAgcHJpdmF0ZToKICAgICBzaXplX3QgbV9ibG9ja0J5dGVzQWxsb2Nh dGVkIHsgMCB9OwogICAgIHNpemVfdCBtX2V4dGVybmFsTWVtb3J5U2l6ZSB7IDAgfTsKICNlbmRp ZgorCisgICAgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIGRpZEV4Y2VlZE1heExpdmVTaXpl KCk7CisgICAgc2l6ZV90IG1fbWF4TGl2ZVNpemUgeyAwIH07CiAgICAgCiAgICAgc3RkOjp1bmlx dWVfcHRyPE11dGF0b3JTY2hlZHVsZXI+IG1fc2NoZWR1bGVyOwogICAgIApkaWZmIC0tZ2l0IGEv U291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAwMjY1NmNk Li4yMzM1NGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTExICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIFdlYkNvcmUncyBHQyBo ZWFwIGdyb3dzIHdheSB0b28gbGFyZ2UuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8x NjY4NzU+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzg5NjU4NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBQdWJsaXNoIHRoZSBXVEY6OkdCIGNvbnN0YW50 LgorCisgICAgICAgICogd3RmL1N0ZExpYkV4dHJhcy5oOgorCiAyMDE3LTAxLTA2ICBHdXN0YXZv IE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAg ICAgIFtHVEtdIFNob3VsZCBzdXBwb3J0IGtleSBhbmQgY29kZSBwcm9wZXJ0aWVzIG9uIGtleWJv YXJkIGV2ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmggYi9T b3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAppbmRleCBiMjZiNDYxLi43NzljMzkyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9TdGRMaWJFeHRyYXMuaApAQCAtNDc3LDYgKzQ3Nyw3IEBAIEFMV0FZU19JTkxJTkUgY29uc3Rl eHByIHR5cGVuYW1lIHJlbW92ZV9yZWZlcmVuY2U8VD46OnR5cGUmJiBtb3ZlKFQmJiB2YWx1ZSkK IAogdXNpbmcgV1RGOjpLQjsKIHVzaW5nIFdURjo6TUI7Cit1c2luZyBXVEY6OkdCOwogdXNpbmcg V1RGOjphcHByb3hpbWF0ZUJpbmFyeVNlYXJjaDsKIHVzaW5nIFdURjo6YmluYXJ5U2VhcmNoOwog dXNpbmcgV1RGOjpiaXR3aXNlX2Nhc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI2Nzg0Yy4uYjQ1MTkxMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAxLTExICBBbmRyZWFzIEtsaW5nICA8 YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIFdlYkNvcmUncyBHQyBoZWFw IGdyb3dzIHdheSB0b28gbGFyZ2UuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNjY4 NzU+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzg5NjU4NT4KKworICAgICAgICBSZXZpZXdl ZCBieSBNYXJrIExhbS4KKworICAgICAgICBDYXAgdGhlIGNvbW1vbiBXZWJDb3JlIFZNIGF0IDQg R0Igb2YgbGl2ZSBKYXZhU2NyaXB0IGhlYXAgb2JqZWN0cy4KKworICAgICAgICAqIGJpbmRpbmdz L2pzL0NvbW1vblZNLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbW1vblZNU2xvdyk6CisKIDIw MTctMDEtMTEgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMDU3MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0NvbW1vblZNLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0NvbW1vblZNLmNwcAppbmRleCA4NmY3MDYwLi4yMTE2ODYyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9Db21tb25WTS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvQ29tbW9uVk0uY3BwCkBAIC00Nyw2ICs0NywxMCBAQCBWTSYgY29tbW9uVk1TbG93 KCkKICAgICAKICAgICBTY3JpcHRDb250cm9sbGVyOjppbml0aWFsaXplVGhyZWFkaW5nKCk7CiAg ICAgZ19jb21tb25WTU9yTnVsbCA9ICZWTTo6Y3JlYXRlTGVha2VkKExhcmdlSGVhcCkubGVha1Jl ZigpOworI2lmIENQVShYODZfNjQpIHx8IENQVShBUk02NCkKKyAgICBzdGF0aWMgY29uc3Qgc2l6 ZV90IG1heEdDSGVhcFNpemUgPSA0ICogR0I7CisgICAgZ19jb21tb25WTU9yTnVsbC0+aGVhcC5z ZXRNYXhMaXZlU2l6ZShtYXhHQ0hlYXBTaXplKTsKKyNlbmRpZgogICAgIGdfY29tbW9uVk1Pck51 bGwtPmhlYXAuYWNxdWlyZUFjY2VzcygpOyAvLyBBdCBhbnkgdGltZSwgd2UgbWF5IGRvIHRoaW5n cyB0aGF0IGFmZmVjdCB0aGUgR0MuCiAjaWYgIVBMQVRGT1JNKElPUykKICAgICBnX2NvbW1vblZN T3JOdWxsLT5zZXRFeGNsdXNpdmVUaHJlYWQoc3RkOjp0aGlzX3RocmVhZDo6Z2V0X2lkKCkpOwo=