166837 2017-01-09 04:17:20 -0800 Support webkit-test-runner key-value pairs in http tests in DumpRenderTree 2017-01-10 14:19:11 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 165668 1 graouts graouts ap commit-queue graouts lforschler mmaxfield webkit-bug-importer oldest_to_newest 1264935 0 graouts 2017-01-09 04:17:20 -0800 With https://bugs.webkit.org/show_bug.cgi?id=149812, we added support for webkit-test-runner key-value pairs in http tests in WebKitTestRunner. We also need this to work with DumpRenderTree / WebKit1 so that we can get legacy media controls tests to work when modern media controls are on by default (see https://bugs.webkit.org/show_bug.cgi?id=165668). 1264936 1 webkit-bug-importer 2017-01-09 04:17:52 -0800 <rdar://problem/29925855> 1264946 2 298343 graouts 2017-01-09 05:18:17 -0800 Created attachment 298343 Patch 1265033 3 ap 2017-01-09 09:42:40 -0800 The purpose of WKTR key value pairs is to add settings that require restarting WebContent process, and so it's by definition impossible to implement for DumpRenderTree. The fact that it's implementable tells me that this was the wrong mechanism to enable modern media controls in tests. Why didn't a JS call work? 1265077 4 298343 commit-queue 2017-01-09 11:35:49 -0800 Comment on attachment 298343 Patch Clearing flags on attachment: 298343 Committed r210517: <http://trac.webkit.org/changeset/210517> 1265078 5 commit-queue 2017-01-09 11:35:54 -0800 All reviewed patches have been landed. Closing bug. 1265360 6 graouts 2017-01-10 07:30:26 -0800 (In reply to comment #3) > The fact that it's implementable tells me that this was the wrong mechanism > to enable modern media controls in tests. Why didn't a JS call work? The value of using a WKTR key-value pair is that the setting can be set prior to any media element being created inside the test. Using a JS call would have required for all media tests that wish to set a different value than the default to dynamically create the media element after calling JS to change it. 1265536 7 ap 2017-01-10 14:19:11 -0800 My understanding is that the markup for the media element won't be parsed until preceding JS executes. In other words, this should work due to the way HTML parser works, (and it works that way because of document.write()): <script> internals.enableModernMediaControls(); </script> <video>...</video> 298343 2017-01-09 05:18:17 -0800 2017-01-09 11:35:49 -0800 Patch bug-166837-20170109141642.patch text/plain 4855 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNDk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjYxOGNkYTdhNzhkODRmNDk4NzEyZDY2NjExOThjY2Nl MWE0YWY5Mi4uNGMwNzAyYjQ4N2UzZmVkYzEwNzk5NTRlOGNjZTAzMjA2OWE1MmUwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDE3LTAxLTA5ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAg ICAgICAgU3VwcG9ydCB3ZWJraXQtdGVzdC1ydW5uZXIga2V5LXZhbHVlIHBhaXJzIGluIGh0dHAg dGVzdHMgaW4gRHVtcFJlbmRlclRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NjgzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIG5vdyBjb3JyZWN0bHkgaGFuZGxlIHRoZSAtLWFic29sdXRlUGF0 aCBhcmd1bWVudCBpbiBEdW1wUmVuZGVyVHJlZSBhbmQgdXNlCisgICAgICAgIHRoZSBwcm92aWRl ZCB2YWx1ZSB3aGVuIHRyeWluZyB0byBkZXRlcm1pbmUgdGhlIHBhdGggdG8gdGhlIHRlc3QgZmls ZS4gRmFpbGluZworICAgICAgICB0aGF0LCB3ZSB1c2UgdGhlIGNvbXB1dGVkIFVSTCBvciB0aGUg cmF3IHBhdGggcHJvdmlkZWQgdG8gY292ZXIgYWxsIGNhc2VzLgorICAgICAgICAKKyAgICAgICAg VGhpcyB3YXMgdGVzdGVkIGluIHRoZSBjb250ZXh0IG9mIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjU2NjgKKyAgICAgICAgYnkgYXBwbHlpbmcgdGhpcyBwYXRjaCBh bmQgc2VlaW5nIHRoZSBudW1iZXIgdGVzdCBmYWlsdXJlcyBkcmFtYXRpY2FsbHkgcmVkdWNlZAor ICAgICAgICB3aXRoIFdLMSBkdWUgdG8gdGhlIG9wdGlvbiB0byB0dXJuIG1vZGVybiBtZWRpYSBj b250cm9scyBvZmYgZm9yIG9sZGVyIG1lZGlhIGNvbnRyb2xzCisgICAgICAgIHRlc3RzLgorCisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuaDoKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZUNvbW1vbi5jcHA6CisgICAgICAgIChwYXJzZUlucHV0 TGluZSk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE9wdGlvbnMuaDoKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9UZXN0T3B0aW9ucy5tbToKKyAgICAgICAgKFRlc3RPcHRpb25zOjpU ZXN0T3B0aW9ucyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVl Lm1tOgorICAgICAgICAocnVuVGVzdCk6CisKIDIwMTctMDEtMDcgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgc2V0dGluZyB0byBjcmVhdGUg ZWRpdGFibGUgTWluaUJyb3dzZXIgd2luZG93cyBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv RHVtcFJlbmRlclRyZWUuaAppbmRleCA0NGFhMmJmYTViYzVlNDM3YzgzNGE2NWY4ZTczZmFjMWI2 ZDJmMWQ4Li43NDNlNjgyNTUyNGRlZjY5Yzc0MDg1NDYzNWY3ZjFlZTM0N2FmYTBjIDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5oCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmgKQEAgLTU4LDYgKzU4LDcgQEAgdm9pZCBkaXNw bGF5V2ViVmlldygpOwogCiBzdHJ1Y3QgVGVzdENvbW1hbmQgewogICAgIHN0ZDo6c3RyaW5nIHBh dGhPclVSTDsKKyAgICBzdGQ6OnN0cmluZyBhYnNvbHV0ZVBhdGg7CiAgICAgYm9vbCBzaG91bGRE dW1wUGl4ZWxzIHsgZmFsc2UgfTsKICAgICBzdGQ6OnN0cmluZyBleHBlY3RlZFBpeGVsSGFzaDsK ICAgICBpbnQgdGltZW91dCB7IDMwMDAwIH07IC8vIGluIG1zCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZUNvbW1vbi5jcHAgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9EdW1wUmVuZGVyVHJlZUNvbW1vbi5jcHAKaW5kZXggODIxYjEzYjMzZTkzNzI0OTQxYTNj MjdhNzU1MWZkYWQ4NzhlNjBhNy4uM2M3YWE2MWU4MzlmNzI2NjJmMzg3OWExOGE1NzE0YjM3NjZj ZmU4OCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWVDb21t b24uY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlQ29tbW9uLmNw cApAQCAtMTA1LDcgKzEwNSw3IEBAIFRlc3RDb21tYW5kIHBhcnNlSW5wdXRMaW5lKGNvbnN0IHN0 ZDo6c3RyaW5nJiBpbnB1dExpbmUpCiAgICAgICAgIH0gZWxzZSBpZiAoYXJnID09ICItLWR1bXAt anNjb25zb2xlbG9nLWluLXN0ZGVyciIpCiAgICAgICAgICAgICByZXN1bHQuZHVtcEpTQ29uc29s ZUxvZ0luU3RkRXJyID0gdHJ1ZTsKICAgICAgICAgZWxzZSBpZiAoYXJnID09IHN0ZDo6c3RyaW5n KCItLWFic29sdXRlUGF0aCIpKQotICAgICAgICAgICAgdG9rZW5pemVyLm5leHQoKTsKKyAgICAg ICAgICAgIHJlc3VsdC5hYnNvbHV0ZVBhdGggPSB0b2tlbml6ZXIubmV4dCgpOwogICAgICAgICBl bHNlCiAgICAgICAgICAgICBkaWUoaW5wdXRMaW5lKTsKICAgICB9CmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9UZXN0T3B0aW9ucy5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVz dE9wdGlvbnMuaAppbmRleCBlNjU3NGJiOGFiOTA3NmExNWUyZWU4Zjk4ZGZkYzExZmUwMzM2NTY5 Li5mY2I1YmMyY2RlZGFmNGFmYTVkYzNlYWY0YjlhMDg3MTQ0MmJkNjU5IDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9UZXN0T3B0aW9ucy5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL1Rlc3RPcHRpb25zLmgKQEAgLTI0LDYgKzI0LDcgQEAKICAqLwogCiAjcHJhZ21hIG9uY2UK KyNpbmNsdWRlICJEdW1wUmVuZGVyVHJlZS5oIgogCiBAY2xhc3MgTlNVUkw7CiAKQEAgLTMyLDUg KzMzLDUgQEAgc3RydWN0IFRlc3RPcHRpb25zIHsKICAgICBib29sIGVuYWJsZU1vZGVybk1lZGlh Q29udHJvbHMgeyBmYWxzZSB9OwogICAgIGJvb2wgZW5hYmxlUG9pbnRlckxvY2sgeyBmYWxzZSB9 OwogCi0gICAgVGVzdE9wdGlvbnMoTlNVUkwgKnRlc3RVUkwpOworICAgIFRlc3RPcHRpb25zKE5T VVJMKiwgY29uc3QgVGVzdENvbW1hbmQmKTsKIH07CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9UZXN0T3B0aW9ucy5tbSBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3RPcHRpb25z Lm1tCmluZGV4IGM1YWNhY2IzZmNhN2I1OWIzYTc2NmIwNjk5ZTJjMzY1ZWMzYmZkNzMuLjU2OGY2 MmJhYjQ3MjZlZWI4NDJkMmNmYTc1YjQ3NDZhNDhlYTVmYTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL1Rlc3RPcHRpb25zLm1tCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rl c3RPcHRpb25zLm1tCkBAIC00MSwxMiArNDEsMTYgQEAgc3RhdGljIGJvb2wgcGFyc2VCb29sZWFu VGVzdEhlYWRlclZhbHVlKGNvbnN0IHN0ZDo6c3RyaW5nJiB2YWx1ZSkKICAgICByZXR1cm4gZmFs c2U7CiB9CiAKLVRlc3RPcHRpb25zOjpUZXN0T3B0aW9ucyhOU1VSTCAqdGVzdFVSTCkKK1Rlc3RP cHRpb25zOjpUZXN0T3B0aW9ucyhOU1VSTCAqdGVzdFVSTCwgY29uc3QgVGVzdENvbW1hbmQmIGNv bW1hbmQpCiB7Ci0gICAgaWYgKCFbdGVzdFVSTCBpc0ZpbGVVUkxdKQotICAgICAgICByZXR1cm47 CisgICAgc3RkOjpzdHJpbmcgcGF0aCA9IGNvbW1hbmQuYWJzb2x1dGVQYXRoOworICAgIGlmIChw YXRoLmVtcHR5KCkgJiYgW3Rlc3RVUkwgaXNGaWxlVVJMXSkKKyAgICAgICAgcGF0aCA9IFt0ZXN0 VVJMIGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbl07CisgICAgZWxzZQorICAgICAgICBwYXRoID0g Y29tbWFuZC5wYXRoT3JVUkw7CiAKLSAgICBzdGQ6OnN0cmluZyBwYXRoID0gW3Rlc3RVUkwgZmls ZVN5c3RlbVJlcHJlc2VudGF0aW9uXTsKKyAgICBpZiAocGF0aC5lbXB0eSgpKQorICAgICAgICBy ZXR1cm47CiAKICAgICBzdGQ6OnN0cmluZyBvcHRpb25zOwogICAgIHN0ZDo6aWZzdHJlYW0gdGVz dEZpbGUocGF0aC5kYXRhKCkpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFj L0R1bXBSZW5kZXJUcmVlLm1tIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJU cmVlLm1tCmluZGV4IDcxODEzNzcwYjg3NzM0MzljYzYwZjM4NzJmODU1YjQyZmYyYzM2ZjAuLjE4 YmM3ODQ4Yzg0YTdkMzA2ZTZhNTg3ZDg5OTgyOWQ5ZWVhNjE3Y2MgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KQEAgLTE5OTAsNyArMTk5MCw3IEBAIHN0YXRp YyB2b2lkIHJ1blRlc3QoY29uc3Qgc3RyaW5nJiBpbnB1dExpbmUpCiAgICAgTlNTdHJpbmcgKmlu Zm9ybWF0aW9uU3RyaW5nID0gW0AiQ1JBU0hJTkcgVEVTVDogIiBzdHJpbmdCeUFwcGVuZGluZ1N0 cmluZzp0ZXN0UGF0aF07CiAgICAgV0tTZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3BlY2lmaWNJ bmZvcm1hdGlvbigoQ0ZTdHJpbmdSZWYpaW5mb3JtYXRpb25TdHJpbmcpOwogCi0gICAgVGVzdE9w dGlvbnMgb3B0aW9ucyh1cmwpOworICAgIFRlc3RPcHRpb25zIG9wdGlvbnModXJsLCBjb21tYW5k KTsKICAgICByZXNldFdlYlZpZXdUb0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3Rpbmcob3B0aW9u cyk7CiAKICAgICBjb25zdCBjaGFyKiB0ZXN0VVJMKFtbdXJsIGFic29sdXRlU3RyaW5nXSBVVEY4 U3RyaW5nXSk7Cg==