166836 2017-01-09 03:16:48 -0800 [GTK] Replace WebKitWebSettings with WebKitSettings in documentation 2017-01-09 03:27:05 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela tpopela berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1264924 0 tpopela 2017-01-09 03:16:48 -0800 We are using WebKitWebSettings on some places in documentation, but WebKitWebSettings is originally a WK1 thing and was replaced with WebKitSettings 1264925 1 298339 tpopela 2017-01-09 03:20:54 -0800 Created attachment 298339 Patch 1264926 2 commit-queue 2017-01-09 03:22:24 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1264927 3 298339 cgarcia 2017-01-09 03:22:57 -0800 Comment on attachment 298339 Patch Good catch! 1264928 4 298339 tpopela 2017-01-09 03:26:56 -0800 Comment on attachment 298339 Patch Clearing flags on attachment: 298339 Committed r210500: <http://trac.webkit.org/changeset/210500> 1264929 5 tpopela 2017-01-09 03:27:05 -0800 All reviewed patches have been landed. Closing bug. 298339 2017-01-09 03:20:54 -0800 2017-01-09 03:26:56 -0800 Patch bug-166836-20170109121919.patch text/plain 5998 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQwNWI1ZWRiZjUxOTJl Y2U1Nzg3NmViOTY4NWEzZTMzMTEyMmUwYi4uNDQ2YmU0MzU0ZDg1YmMxZjEyZWY4NDQ2MDEwYzIy ODJmY2UzMGRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAxLTA5ICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gUmVwbGFjZSBX ZWJLaXRXZWJTZXR0aW5ncyB3aXRoIFdlYktpdFNldHRpbmdzIGluIGRvY3VtZW50YXRpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NjgzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHVzZSBX ZWJLaXRXZWJTZXR0aW5ncyAoaXQgd2FzIGEgV2ViS2l0MSB0aGluZykgaW4gZG9jdW1lbnRhdGlv biwKKyAgICAgICAgYnV0IHJlcGxhY2UgaXQgd2l0aCBXZWJLaXRTZXR0aW5ncy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtp dF9zZXR0aW5nc19jbGFzc19pbml0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJWaWV3LmNwcDoKKwogMjAxNy0wMS0wNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIFBhc3NSZWZQdHIgdXNlIGZyb20gImluc3BlY3RvciIsICJw bGF0Zm9ybS9zcWwiLCBhbmQgInBsYXRmb3JtL3RleHQiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKaW5kZXggZTIzM2M5MTcxMWY1 OWQxYzI3MDVlNWQzZjNkNGJiN2VlYWMzMzdhYy4uODMzOTIxYjhiMTMzNTU1ZjFmMjIwNGVjODI3 ZTk1NmRkZWExM2Y5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0U2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFNldHRpbmdzLmNwcApAQCAtNjc5LDcgKzY3OSw3IEBAIHN0YXRpYyB2b2lkIHdl YmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVh ZFdyaXRlQ29uc3RydWN0UGFyYW1GbGFncykpOwogCiAgICAgLyoqCi0gICAgICogV2ViS2l0V2Vi U2V0dGluZ3M6ZGVmYXVsdC1mb250LWZhbWlseToKKyAgICAgKiBXZWJLaXRTZXR0aW5nczpkZWZh dWx0LWZvbnQtZmFtaWx5OgogICAgICAqCiAgICAgICogVGhlIGZvbnQgZmFtaWx5IHRvIHVzZSBh cyB0aGUgZGVmYXVsdCBmb3IgY29udGVudCB0aGF0IGRvZXMgbm90IHNwZWNpZnkgYSBmb250Lgog ICAgICAqLwpAQCAtNjkyLDcgKzY5Miw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19j bGFzc19pbml0KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWFkV3JpdGVDb25zdHJ1Y3RQ YXJhbUZsYWdzKSk7CiAKICAgICAvKioKLSAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczptb25vc3Bh Y2UtZm9udC1mYW1pbHk6CisgICAgICogV2ViS2l0U2V0dGluZ3M6bW9ub3NwYWNlLWZvbnQtZmFt aWx5OgogICAgICAqCiAgICAgICogVGhlIGZvbnQgZmFtaWx5IHVzZWQgYXMgdGhlIGRlZmF1bHQg Zm9yIGNvbnRlbnQgdXNpbmcgYSBtb25vc3BhY2UgZm9udC4KICAgICAgKgpAQCAtNzA2LDcgKzcw Niw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFNldHRp bmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdzKSk7CiAKICAgICAv KioKLSAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczpzZXJpZi1mb250LWZhbWlseToKKyAgICAgKiBX ZWJLaXRTZXR0aW5nczpzZXJpZi1mb250LWZhbWlseToKICAgICAgKgogICAgICAqIFRoZSBmb250 IGZhbWlseSB1c2VkIGFzIHRoZSBkZWZhdWx0IGZvciBjb250ZW50IHVzaW5nIGEgc2VyaWYgZm9u dC4KICAgICAgKi8KQEAgLTcxOSw3ICs3MTksNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfc2V0dGlu Z3NfY2xhc3NfaW5pdChXZWJLaXRTZXR0aW5nc0NsYXNzKiBrbGFzcykKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3Ry dWN0UGFyYW1GbGFncykpOwogCiAgICAgLyoqCi0gICAgICogV2ViS2l0V2ViU2V0dGluZ3M6c2Fu cy1zZXJpZi1mb250LWZhbWlseToKKyAgICAgKiBXZWJLaXRTZXR0aW5nczpzYW5zLXNlcmlmLWZv bnQtZmFtaWx5OgogICAgICAqCiAgICAgICogVGhlIGZvbnQgZmFtaWx5IHVzZWQgYXMgdGhlIGRl ZmF1bHQgZm9yIGNvbnRlbnQgdXNpbmcgYSBzYW5zLXNlcmlmIGZvbnQuCiAgICAgICovCkBAIC03 MzIsNyArNzMyLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQoV2Vi S2l0U2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJlYWRXcml0ZUNvbnN0cnVjdFBhcmFtRmxhZ3MpKTsK IAogICAgIC8qKgotICAgICAqIFdlYktpdFdlYlNldHRpbmdzOmN1cnNpdmUtZm9udC1mYW1pbHk6 CisgICAgICogV2ViS2l0U2V0dGluZ3M6Y3Vyc2l2ZS1mb250LWZhbWlseToKICAgICAgKgogICAg ICAqIFRoZSBmb250IGZhbWlseSB1c2VkIGFzIHRoZSBkZWZhdWx0IGZvciBjb250ZW50IHVzaW5n IGEgY3Vyc2l2ZSBmb250LgogICAgICAqLwpAQCAtNzQ1LDcgKzc0NSw3IEBAIHN0YXRpYyB2b2lk IHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdzKSk7CiAKICAgICAvKioKLSAgICAgKiBXZWJLaXRX ZWJTZXR0aW5nczpmYW50YXN5LWZvbnQtZmFtaWx5OgorICAgICAqIFdlYktpdFNldHRpbmdzOmZh bnRhc3ktZm9udC1mYW1pbHk6CiAgICAgICoKICAgICAgKiBUaGUgZm9udCBmYW1pbHkgdXNlZCBh cyB0aGUgZGVmYXVsdCBmb3IgY29udGVudCB1c2luZyBhIGZhbnRhc3kgZm9udC4KICAgICAgKi8K QEAgLTc1OCw3ICs3NTgsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfc2V0dGluZ3NfY2xhc3NfaW5p dChXZWJLaXRTZXR0aW5nc0NsYXNzKiBrbGFzcykKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3RydWN0UGFyYW1GbGFn cykpOwogCiAgICAgLyoqCi0gICAgICogV2ViS2l0V2ViU2V0dGluZ3M6cGljdG9ncmFwaC1mb250 LWZhbWlseToKKyAgICAgKiBXZWJLaXRTZXR0aW5nczpwaWN0b2dyYXBoLWZvbnQtZmFtaWx5Ogog ICAgICAqCiAgICAgICogVGhlIGZvbnQgZmFtaWx5IHVzZWQgYXMgdGhlIGRlZmF1bHQgZm9yIGNv bnRlbnQgdXNpbmcgYSBwaWN0b2dyYXBoIGZvbnQuCiAgICAgICovCkBAIC03NzEsNyArNzcxLDcg QEAgc3RhdGljIHZvaWQgd2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQoV2ViS2l0U2V0dGluZ3ND bGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHJlYWRXcml0ZUNvbnN0cnVjdFBhcmFtRmxhZ3MpKTsKIAogICAgIC8qKgot ICAgICAqIFdlYktpdFdlYlNldHRpbmdzOmRlZmF1bHQtZm9udC1zaXplOgorICAgICAqIFdlYktp dFNldHRpbmdzOmRlZmF1bHQtZm9udC1zaXplOgogICAgICAqCiAgICAgICogVGhlIGRlZmF1bHQg Zm9udCBzaXplIGluIHBpeGVscyB0byB1c2UgZm9yIGNvbnRlbnQgZGlzcGxheWVkIGlmCiAgICAg ICogbm8gZm9udCBzaXplIGlzIHNwZWNpZmllZC4KQEAgLTc4NSw3ICs3ODUsNyBAQCBzdGF0aWMg dm9pZCB3ZWJraXRfc2V0dGluZ3NfY2xhc3NfaW5pdChXZWJLaXRTZXR0aW5nc0NsYXNzKiBrbGFz cykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJlYWRXcml0ZUNvbnN0cnVjdFBhcmFtRmxhZ3MpKTsKIAogICAgIC8qKgotICAgICAqIFdlYktp dFdlYlNldHRpbmdzOmRlZmF1bHQtbW9ub3NwYWNlLWZvbnQtc2l6ZToKKyAgICAgKiBXZWJLaXRT ZXR0aW5nczpkZWZhdWx0LW1vbm9zcGFjZS1mb250LXNpemU6CiAgICAgICoKICAgICAgKiBUaGUg ZGVmYXVsdCBmb250IHNpemUgaW4gcGl4ZWxzIHRvIHVzZSBmb3IgY29udGVudCBkaXNwbGF5ZWQg aW4KICAgICAgKiBtb25vc3BhY2UgZm9udCBpZiBubyBmb250IHNpemUgaXMgc3BlY2lmaWVkLgpA QCAtNzk5LDcgKzc5OSw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0 KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3RydWN0UGFyYW1GbGFncykp OwogCiAgICAgLyoqCi0gICAgICogV2ViS2l0V2ViU2V0dGluZ3M6bWluaW11bS1mb250LXNpemU6 CisgICAgICogV2ViS2l0U2V0dGluZ3M6bWluaW11bS1mb250LXNpemU6CiAgICAgICoKICAgICAg KiBUaGUgbWluaW11bSBmb250IHNpemUgaW4gcG9pbnRzIHVzZWQgdG8gZGlzcGxheSB0ZXh0LiBU aGlzIHNldHRpbmcKICAgICAgKiBjb250cm9scyB0aGUgYWJzb2x1dGUgc21hbGxlc3Qgc2l6ZS4g VmFsdWVzIG90aGVyIHRoYW4gMCBjYW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggMmY2NjFjYTFjODEyOGRkOWI2MTBiMDJj MTJjODg4Nzk0MmIyZTBlYy4uNzAwNjM5OTQ2ZjQyMDVlNTBmN2ZkYzYzMzk3ZWVhYzI3NDlmYWIw OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlldy5jcHAKQEAgLTI5NzEsNyArMjk3MSw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdS dW5KYXZhU2NyaXB0Q2FsbGJhY2soQVBJOjpTZXJpYWxpemVkU2NyaXB0VmFsdWUqIHdrU2VyCiAg KiBAdXNlcl9kYXRhOiAoY2xvc3VyZSk6IHRoZSBkYXRhIHRvIHBhc3MgdG8gY2FsbGJhY2sgZnVu Y3Rpb24KICAqCiAgKiBBc3luY2hyb25vdXNseSBydW4gQHNjcmlwdCBpbiB0aGUgY29udGV4dCBv ZiB0aGUgY3VycmVudCBwYWdlIGluIEB3ZWJfdmlldy4gSWYKLSAqIFdlYktpdFdlYlNldHRpbmdz OmVuYWJsZS1qYXZhc2NyaXB0IGlzIEZBTFNFLCB0aGlzIG1ldGhvZCB3aWxsIGRvIG5vdGhpbmcu CisgKiBXZWJLaXRTZXR0aW5nczplbmFibGUtamF2YXNjcmlwdCBpcyBGQUxTRSwgdGhpcyBtZXRo b2Qgd2lsbCBkbyBub3RoaW5nLgogICoKICAqIFdoZW4gdGhlIG9wZXJhdGlvbiBpcyBmaW5pc2hl ZCwgQGNhbGxiYWNrIHdpbGwgYmUgY2FsbGVkLiBZb3UgY2FuIHRoZW4gY2FsbAogICogd2Via2l0 X3dlYl92aWV3X3J1bl9qYXZhc2NyaXB0X2ZpbmlzaCgpIHRvIGdldCB0aGUgcmVzdWx0IG9mIHRo ZSBvcGVyYXRpb24uCg==